On Tue, Mar 31, 2015 at 05:31:25PM -0700, Alex Wang wrote: > When ovsdb happens to get blocked for few seconds, the 'stats_timer' > will not be updated due to incompletion of previous transaction. > When the current time passes the 'stats_timer', the call to > poll_timer_wait_until(stats_timer) will keep waking up ovs-vswitchd, > causing 100% cpu utilization. > > This commit fixes this issue by making ovs-vswitchd wait on the > previous idl transaction when it is incomplete rather than the > 'stats_timer'. > > Signed-off-by: Alex Wang <al...@nicira.com>
I'd add a blank line after the declaration: > +/* Statistics update to database. */ > +static struct ovsdb_idl_txn *stats_txn; > /* Each time this timer expires, the bridge fetches interface and mirror > * statistics and pushes them into the database. */ > static int stats_timer_interval; Missing ' at end of comment: > + /* If the 'stats_txn' is non-null (transaction incomplete), waits for the > + * transaction to complete. Otherwise, waits for the 'stats_timer. */ Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
