On Mon, Apr 06, 2015 at 09:46:43PM -0300, Flavio Leitner wrote: > On Mon, 6 Apr 2015 13:56:04 -0700 > Ben Pfaff <b...@nicira.com> wrote: > > > Since %install puts every .ko file into /lib/modules, %files should > > make sure that all of them are packaged. > > The RPM fails to build the package when there is an unpackaged file and > that is useful because it tells you are missing something. Consider > that the ovs-testcontroller is now back but the packager didn't follow > the change in upstream, so when he updates the tarball, RPM will warn > about unpackaged "/usr/bin/ovs-testcontroller" and he can decide if > that should go in a separate package, remove previous obsoletes, > enforce the correct permissions, check selinux or initscripts, or even > if it should be package/shipped or not. > > So, having a more detailed %files list can result in a bit more > maintenance but it's less error prone.
Thanks. Over the years I had guessed this much, but it's good to see it confirmed. > Anyway, since this is a "*.ko" and I doubt we want to split them apart > or not include one, or include unintentional files, I am fine with this > patch. > > Acked-by: Flavio Leitner <f...@redhat.com> Thanks, I applied this to master, with your ack. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
