I get a warning in gso.c after this patch:
datapath/linux/gso.c: In function ‘rpl_ip_local_out’:
datapath/linux/gso.c:134:174: warning: ‘id’ may be used uninitialized in
this function [-Wuninitialized]
Could you take a look at this?
On Fri, Jun 21, 2013 at 3:14 PM, Pravin Shelar wrote:
> On T
Hi OpenvSwitch Devs
Ubuntu Saucy is about to bump kernel version from 3.9 to 3.10; I started
looking at the impact of this on ovs but swiftly went down the rabbit
hole of not really understanding how the introduction of 802.1ad support
in this kernel version would impact on the compat layer of
On 20 June 2013 20:10, Ben Pfaff wrote:
> Can you confirm that the autoconf test needs #include but
> the actual program doesn't? It looks funny.
Yes. It looks like it should be added in the actual program; right
wow we end up with the definition leaking from another header.
__
In clang's attempt to be GCC compatible it ignores, but does not fail
on, unknown -W options. Configure then ends up added the option to
WARNING_FLAGS, and the warning is then emitted for every file
compiled.
>From config.log:
configure:7388: checking whether clang accepts -Wno-override-init
con
On 06/21/13 01:17, Stephen Rothwell wrote:
> Hi all,
>
> Happy solstice!
>
> Changes since 20130620:
>
when CONFIG_INET is not enabled:
CC net/openvswitch/flow.o
In file included from net/openvswitch/flow.c:43:0:
include/net/ip_tunnels.h: In function 'tunnel_ip_select_ident':
include/ne
Thanks, applied.
On Thu, Jun 20, 2013 at 10:37:36PM -0700, Alex Wang wrote:
> Looks good to me.,
>
>
> On Wed, Jun 12, 2013 at 11:35 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/ofp-errors.h |6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > di
On Fri, Jun 21, 2013 at 10:03:21AM -0400, Ed Maste wrote:
> In clang's attempt to be GCC compatible it ignores, but does not fail
> on, unknown -W options. Configure then ends up added the option to
> WARNING_FLAGS, and the warning is then emitted for every file
> compiled.
>
> From config.log:
>
When flow table is copied, the mask list from the old table
is not properly copied into the new table. The corrupted mask
list in the new table will lead to kernel crash. This patch
fixes this bug.
Bug #18110
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/flow.c |2 +-
1 f
On Thu, Jun 20, 2013 at 11:38 PM, Andy Zhou wrote:
> Fix a bug where some mask attributes are missing in the netlink packets
> from kernel to the user space.
>
> Reported-by: Justin Pettit
> Signed-off-by: Andy Zhou
Can you describe this some more? Presumably, this is because some of
the prereq
Yes, you are right about the root cause.
A fully wildcarded ip proto in the key would prevent the mask of ICMP (may
not be fully wildcarded) to be generated.
This patch fixes it.
Andy
On Fri, Jun 21, 2013 at 9:27 AM, Jesse Gross wrote:
> On Thu, Jun 20, 2013 at 11:38 PM, Andy Zhou wrote:
>
Correction.
The ICMP mask will have to be fully masked in this example. But they still
need to be present in the netlink. A missing ICMP mask attribute will be
interpreted by the user space programs as exact match.
On Fri, Jun 21, 2013 at 9:38 AM, Andy Zhou wrote:
> Yes, you are right abou
It doesn't really make sense that userspace would interpret a missing
attribute as exact match because when the flow is installed a missing
attribute means that it is wildcarded. Therefore, if you echoed back
the exact same flow it would have a different meaning.
On Fri, Jun 21, 2013 at 9:43 AM, A
You are right.
The user space code needs to distinguish between two cases:
1) The entire mask attribute is missing, then the entire key is exact
match.
2) The mask attribute is there, then the missing key attributes should be
treated as wildcarded fields.
It seems we don't need this patch, but ma
On 21 June 2013 12:05, Ben Pfaff wrote:
> By default, clang warns about but does not fail on unknown -W options.
> This made configure add the option to WARNING_FLAGS, which caused the
> warning about not-understood warnings to be emitted for every file
> compiled.
>
> In combination with -Werror,
That sounds right to me.
On Fri, Jun 21, 2013 at 10:06 AM, Andy Zhou wrote:
> You are right.
>
> The user space code needs to distinguish between two cases:
> 1) The entire mask attribute is missing, then the entire key is exact match.
> 2) The mask attribute is there, then the missing key attrib
Thank you for pointing this out. Please disregard the patch.
On Fri, Jun 21, 2013 at 10:12 AM, Jesse Gross wrote:
> That sounds right to me.
>
> On Fri, Jun 21, 2013 at 10:06 AM, Andy Zhou wrote:
> > You are right.
> >
> > The user space code needs to distinguish between two cases:
> > 1) The
Looks good to me, thanks
On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> configure.ac |1 +
> lib/util.c | 48 +---
> lib/util.h |3 ++-
> 3 files changed, 40 insertions(+), 12 deletions(-)
>
> diff
The #include_next in sparse/pthread.h is a bit exotic. Would you
please include a short comment explaining why it's necessary?
sparse/pthread.h has some trailing newlines at the end of the file.
In ovs-thread.c any reason not to macro-ize the trylock functions as well?
Acked-by: Ethan Jackson
On Wed, Jun 19, 2013 at 1:27 PM, Ben Pfaff wrote:
> On Wed, Jun 19, 2013 at 02:03:15AM -0700, Gurucharan Shetty wrote:
> > Specifically for the case, where we know that a bridge record
> > should exist in xapi, if we don't get any bridge records, log
> > the failure and retry again later.
> >
> >
If a packet is neither GSO nor CHECKSUM_PARTIAL then the
GRE GSO compatibility code can use an uninitialized IP ID.
CC: Pravin Shelar
Reported-by: Joe Stringer
Signed-off-by: Jesse Gross
---
datapath/linux/compat/gso.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/datap
Thanks, it looks like a real issue to me. I sent out a patch that should fix it.
On Fri, Jun 21, 2013 at 1:19 AM, Joe Stringer wrote:
> I get a warning in gso.c after this patch:
>
> datapath/linux/gso.c: In function ‘rpl_ip_local_out’:
> datapath/linux/gso.c:134:174: warning: ‘id’ may be used un
Tunnel constants can be used in generic code but in these cases
the inline functions in ip_tunnels.h cause compilation problems
if CONFIG_INET is not set.
CC: Pravin Shelar
Reported-by: Randy Dunlap
Signed-off-by: Jesse Gross
---
include/net/ip_tunnels.h | 5 +
1 file changed, 5 insertions
Open vSwitch GRE tunnels are currently only enabled if the GRE
datapath code is statically compiled in but it should be possible
to use it as a module as well.
CC: Pravin Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/vport-gre.c | 2 +-
net/openvswitch/vport.c | 2 +-
2 files change
On Fri, Jun 21, 2013 at 8:22 AM, Randy Dunlap wrote:
> On 06/21/13 01:17, Stephen Rothwell wrote:
>> Hi all,
>>
>> Happy solstice!
>>
>> Changes since 20130620:
>>
>
> when CONFIG_INET is not enabled:
>
> CC net/openvswitch/flow.o
> In file included from net/openvswitch/flow.c:43:0:
> inclu
When flow table is copied, the mask list from the old table
is not properly copied into the new table. The corrupted mask
list in the new table will lead to kernel crash. This patch
fixes this bug.
Bug #18110
Reported-by: Justin Pettit
---
v1 -> v2:
Jesse pointed out the race conditi
On Fri, Jun 21, 2013 at 4:18 PM, Andy Zhou wrote:
> When flow table is copied, the mask list from the old table
> is not properly copied into the new table. The corrupted mask
> list in the new table will lead to kernel crash. This patch
> fixes this bug.
>
> Bug #18110
> Reported-by: Justin Petti
Right, looks good to me.
On 22 Jun 2013 08:12, "Jesse Gross" wrote:
> If a packet is neither GSO nor CHECKSUM_PARTIAL then the
> GRE GSO compatibility code can use an uninitialized IP ID.
>
> CC: Pravin Shelar
> Reported-by: Joe Stringer
> Signed-off-by: Jesse Gross
> ---
> datapath/linux/com
On Thu, 20 Jun 2013 13:47:11 -0700
Pravin Shelar wrote:
> On Thu, Jun 20, 2013 at 10:13 AM, Stephen Hemminger
> wrote:
> > On Thu, 20 Jun 2013 08:58:42 -0700
> > Stephen Hemminger wrote:
> >
> >> On Thu, 20 Jun 2013 00:26:15 -0700
> >> Pravin B Shelar wrote:
> >>
> >> > First two patches fixes
Thanks, I applied it.
On Fri, Jun 21, 2013 at 4:57 PM, Joe Stringer wrote:
> Right, looks good to me.
>
> On 22 Jun 2013 08:12, "Jesse Gross" wrote:
>>
>> If a packet is neither GSO nor CHECKSUM_PARTIAL then the
>> GRE GSO compatibility code can use an uninitialized IP ID.
>>
>> CC: Pravin Shela
O.K. How about the attached incremental patch?
On Fri, Jun 21, 2013 at 4:37 PM, Jesse Gross wrote:
> On Fri, Jun 21, 2013 at 4:18 PM, Andy Zhou wrote:
> > When flow table is copied, the mask list from the old table
> > is not properly copied into the new table. The corrupted mask
> > list in
Do we need any of the tests for tbl->mask_list at this point if we
always allocate a list head?
On Fri, Jun 21, 2013 at 5:52 PM, Andy Zhou wrote:
> O.K. How about the attached incremental patch?
>
>
> On Fri, Jun 21, 2013 at 4:37 PM, Jesse Gross wrote:
>>
>> On Fri, Jun 21, 2013 at 4:18 PM, And
On 06/21/13 16:17, Jesse Gross wrote:
> Tunnel constants can be used in generic code but in these cases
> the inline functions in ip_tunnels.h cause compilation problems
> if CONFIG_INET is not set.
>
> CC: Pravin Shelar
> Reported-by: Randy Dunlap
> Signed-off-by: Jesse Gross
Acked-by: Randy
No. there is no need any more. An incremental patch is attached that
removes all the tbl->mask_list checks. I have also rolled the last 3
patches in to a single one in case it is useful.
On Fri, Jun 21, 2013 at 6:10 PM, Jesse Gross wrote:
> Do we need any of the tests for tbl->mask_list at thi
Applied, thanks.
On Fri, Jun 21, 2013 at 9:07 PM, Andy Zhou wrote:
> No. there is no need any more. An incremental patch is attached that
> removes all the tbl->mask_list checks. I have also rolled the last 3 patches
> in to a single one in case it is useful.
>
>
> On Fri, Jun 21, 2013 at 6:10 P
34 matches
Mail list logo
