Correction. The ICMP mask will have to be fully masked in this example. But they still need to be present in the netlink. A missing ICMP mask attribute will be interpreted by the user space programs as exact match.
On Fri, Jun 21, 2013 at 9:38 AM, Andy Zhou <[email protected]> wrote: > Yes, you are right about the root cause. > > A fully wildcarded ip proto in the key would prevent the mask of ICMP (may > not be fully wildcarded) to be generated. > This patch fixes it. > > Andy > > > On Fri, Jun 21, 2013 at 9:27 AM, Jesse Gross <[email protected]> wrote: > >> On Thu, Jun 20, 2013 at 11:38 PM, Andy Zhou <[email protected]> wrote: >> > Fix a bug where some mask attributes are missing in the netlink packets >> > from kernel to the user space. >> > >> > Reported-by: Justin Pettit <[email protected]> >> > Signed-off-by: Andy Zhou <[email protected]> >> >> Can you describe this some more? Presumably, this is because some of >> the prerequisite values are either fully or partially masked out and >> this is preventing latter masks from being emitted. However, since we >> force prerequisites to be exact match, doesn't that mean the omitted >> masks are fully wildcarded? >> > >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
