On Thu, May 02, 2013 at 06:06:35PM +0900, Simon Horman wrote:
> Do not perform validation of learn actions during parsing.
> I believe this is consistent with the handling of all other actions.
>
> Verification of all actions, including learn actions, occurs separately
> in ofpact_check__().
>
>
Now I've tried with the latest 1.4 code, but it still produces these
message intermittently. Here are some examples:
May 3 16:32:27 localhost ovs-vswitchd:
00093|ofproto_dpif|WARN|unexpected flow from datapath
in_port(1),eth(src=00:21:1b:f3:63:45,dst=00:e0:ed:26:a9:bc),eth_type(0x0800),ipv4(s
On Thu, May 2, 2013 at 9:34 PM, Ben Pfaff wrote:
> On Thu, May 02, 2013 at 08:20:52PM -0700, Jesse Gross wrote:
>> On Thu, May 2, 2013 at 1:30 PM, Andy Zhou wrote:
>> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>> > index e890fd8..6048e9b 100644
>> > --- a/include/lin
VPORT_F_TUN_ID is last remaining flag, once we remove it, flags
field from vport-ops can be removed. Since it does not complicate
much code, we decided to remove this flag.
Signed-off-by: Pravin B Shelar
---
v3-v4:
- Pass tun_key as param to ovs_vport_receive().
v1-v3:
New patch.
---
datapath
On Fri, May 3, 2013 at 10:35 AM, Pravin B Shelar wrote:
> VPORT_F_TUN_ID is last remaining flag, once we remove it, flags
> field from vport-ops can be removed. Since it does not complicate
> much code, we decided to remove this flag.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
T
Until now, the OVSDB data journaling implementation has made write errors
"sticky", so that a single write error persists as long as ovsdb-server is
alive. However, some kinds of write errors (such as ENOSPC) can be
transient in practice. I don't know of a good reason to make such errors
sticky,
Looks good.
On Wed, May 1, 2013 at 11:32 AM, Ben Pfaff wrote:
> getmntent_r() is a GNU extension so we test for its existence and just
> disable this feature of system stats if it is not present, because this
> feature is not very important.
>
> Signed-off-by: Ben Pfaff
> ---
> configure.ac
On Fri, May 03, 2013 at 06:53:28PM +0100, Zoltan Kiss wrote:
> Until now, the OVSDB data journaling implementation has made write errors
> "sticky", so that a single write error persists as long as ovsdb-server is
> alive. However, some kinds of write errors (such as ENOSPC) can be
> transient in
Thanks. Do these messages appear in the log just as you show them, or
are they interspersed with other messages?
On Fri, May 03, 2013 at 05:40:57PM +0100, Zoltan Kiss wrote:
> Now I've tried with the latest 1.4 code, but it still produces these
> message intermittently. Here are some examples:
>
Thanks, I applied this to master.
On Fri, May 03, 2013 at 11:24:46AM -0700, Andy Zhou wrote:
> Looks good.
>
>
> On Wed, May 1, 2013 at 11:32 AM, Ben Pfaff wrote:
>
> > getmntent_r() is a GNU extension so we test for its existence and just
> > disable this feature of system stats if it is not
I have reviewed all 9 patches. They look fine. Thanks.
On Wed, May 1, 2013 at 11:20 AM, Ben Pfaff wrote:
> In preparation for multithreading OVS, it makes sense to mark any
> static data that we can "const", because read-only access to data
> is obviously thread-safe.
>
> Ben Pfaff (9):
> dpi
Thanks, I did want your opinion. I applied this to branch-1.10.
On Thu, May 02, 2013 at 05:19:42PM -0700, Neil Mckee wrote:
> Thanks!
>
> If that was a question to me, then yes, I think it would be good to
> fix this on branch 1.10 too. The old code resulted in ifIndex==-95
> being offered to t
FreeBSD does not have EAI_ADDRFAMILY or EAI_NODATA and thus failed to build
after commit 3cbb5dc7e89df2b40bb6f715873cf2b6b25a7054 "socket-util: Use
getaddrinfo() instead of gethostbyname() for thread safety."
Signed-off-by: Ed Maste
---
lib/socket-util.c | 4
1 file changed, 4 insertions(+)
On Fri, May 03, 2013 at 04:31:02PM -0400, Ed Maste wrote:
> FreeBSD does not have EAI_ADDRFAMILY or EAI_NODATA and thus failed to build
> after commit 3cbb5dc7e89df2b40bb6f715873cf2b6b25a7054 "socket-util: Use
> getaddrinfo() instead of gethostbyname() for thread safety."
>
> Signed-off-by: Ed Mas
I applied them to master. Thanks a lot for the reviews.
On Fri, May 03, 2013 at 01:13:09PM -0700, Andy Zhou wrote:
> I have reviewed all 9 patches. They look fine. Thanks.
>
>
> On Wed, May 1, 2013 at 11:20 AM, Ben Pfaff wrote:
>
> > In preparation for multithreading OVS, it makes sense to ma
> +case OFPTYPE_ECHO_REQUEST:
> +if (reply_to_echo_requests) {
> +struct ofpbuf *reply;
> +
> +reply = make_echo_reply(b->data);
> +retval = vconn_send(vconn, reply);
> +if (retval && retval
On Fri, May 03, 2013 at 01:36:28PM -0700, Ethan Jackson wrote:
> > +case OFPTYPE_ECHO_REQUEST:
> > +if (reply_to_echo_requests) {
> > +struct ofpbuf *reply;
> > +
> > +reply = make_echo_reply(b->data);
> > +retv
> +#define IFACE_STAT(MEMBER, NAME) +1
You need a space after the + here.
Otherwise looks good, thanks.
Acked-by: Ethan Jackson
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Acked-by: Ethan Jackson
On Wed, Feb 13, 2013 at 11:06 PM, Ben Pfaff wrote:
> We always use unsigned types for port numbers elsewhere, so use one here
> too.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-util.c |2 +-
> lib/ofp-util.h |2 +-
> 2 files changed, 2 insertions(+), 2 deletion
Fine with me.
Acked-by: Ethan Jackson
On Fri, May 3, 2013 at 1:45 PM, Ben Pfaff wrote:
> On Fri, May 03, 2013 at 01:36:28PM -0700, Ethan Jackson wrote:
>> > +case OFPTYPE_ECHO_REQUEST:
>> > +if (reply_to_echo_requests) {
>> > +struct ofpbuf *reply
As documented in netdev-provider.h for the get_stats method.
Signed-off-by: Ed Maste
---
lib/netdev-bsd.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index e3461b8..7ab9d3e 100644
--- a/lib/netdev-bsd.c
+++
Thanks. I made that change, and removed "&& retval != EAGAIN" from
the "if" condition (since vconn_send_block() does not return EAGAIN),
and applied this series to master.
On Fri, May 03, 2013 at 01:49:03PM -0700, Ethan Jackson wrote:
> Fine with me.
>
> Acked-by: Ethan Jackson
>
> On Fri, May
Thanks, I applied this to master.
On Fri, May 03, 2013 at 01:48:10PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> On Wed, Feb 13, 2013 at 11:06 PM, Ben Pfaff wrote:
> > We always use unsigned types for port numbers elsewhere, so use one here
> > too.
> >
> > Signed-off-by: Ben Pfaf
On Fri, May 03, 2013 at 04:57:38PM -0400, Ed Maste wrote:
> As documented in netdev-provider.h for the get_stats method.
>
> Signed-off-by: Ed Maste
Thanks, applied to master, branch-1.11, and branch-1.10.
___
dev mailing list
dev@openvswitch.org
http:
OpenFlow 1.0 can match on flows that have the IPv6 Ethertype, but
ofputil_usable_protocols() incorrectly reported that such a match required
NXM or OXM. This commit fixes the problem.
Also, add some related tests.
Reported-by: Nagi Reddy Jonnala
Signed-off-by: Ben Pfaff
---
AUTHORS
Signed-off-by: Ben Pfaff
---
DESIGN |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/DESIGN b/DESIGN
index f3e9309..0037eea 100644
--- a/DESIGN
+++ b/DESIGN
@@ -185,7 +185,7 @@ Each column is interpreted as follows.
- OF1.0 and OF1.1: /x,yy/z means dl_vlan
Otherwise, input with invalid trailing data was accepted, such as input
that had 7 colon-separated segments instead of 6.
Signed-off-by: Ben Pfaff
---
lib/meta-flow.c | 21 +
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
i
On Fri, May 03, 2013 at 01:47:05PM -0700, Ethan Jackson wrote:
> > +#define IFACE_STAT(MEMBER, NAME) +1
>
> You need a space after the + here.
>
> Otherwise looks good, thanks.
>
> Acked-by: Ethan Jackson
Thanks, I fixed that and applied this to master.
The get_config vport op is left over from old compatibility code,
it is neither used nor implemented any more.
Signed-off-by: Jesse Gross
---
datapath/vport-netdev.h |1 -
datapath/vport.h|3 ---
2 files changed, 4 deletions(-)
diff --git a/datapath/vport-netdev.h b/datapath/vpo
29 matches
Mail list logo
