> +            case OFPTYPE_ECHO_REQUEST:
> +                if (reply_to_echo_requests) {
> +                    struct ofpbuf *reply;
> +
> +                    reply = make_echo_reply(b->data);
> +                    retval = vconn_send(vconn, reply);
> +                    if (retval && retval != EAGAIN) {
> +                        ovs_fatal(retval, "failed to send echo reply");
> +                    }
> +                }

I think we need to destroy 'reply' when vconn_send() returns EAGAIN.
Otherwise I think we leak it.

Ethan
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to