On Fri, May 03, 2013 at 01:36:28PM -0700, Ethan Jackson wrote:
> > + case OFPTYPE_ECHO_REQUEST:
> > + if (reply_to_echo_requests) {
> > + struct ofpbuf *reply;
> > +
> > + reply = make_echo_reply(b->data);
> > + retval = vconn_send(vconn, reply);
> > + if (retval && retval != EAGAIN) {
> > + ovs_fatal(retval, "failed to send echo reply");
> > + }
> > + }
>
> I think we need to destroy 'reply' when vconn_send() returns EAGAIN.
> Otherwise I think we leak it.
How about if I change "vconn_send()" to "vconn_send_block()" here?
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
