[ovs-dev] [PATCH 02/18] deal with platforms where backtrace() is in a different library than libc.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi execinfo for NetBSD and ubacktrace for uClibc. i don't know if the latter is relevant to Open vSwitch, though. Signed-off-by: YAMAMOTO Takashi --- m4/openvswitch.m4 | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitc

[ovs-dev] [PATCH 15/18] implement set_etheraddr for NetBSD

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 76 ++-- 1 file changed, 69 insertions(+), 7 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 76782ec..615a26f 100644 --- a/lib/netdev-bsd.c +++

[ovs-dev] [PATCH 09/18] be compilable even when _SC_PHYS_PAGES is not available.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- vswitchd/system-stats.c | 4 1 file changed, 4 insertions(+) diff --git a/vswitchd/system-stats.c b/vswitchd/system-stats.c index f679516..2e18b1b 100644 --- a/vswitchd/system-stats.c +++ b/vswitchd/system-stats.c @@ -97,7 +97,11

[ovs-dev] [PATCH 01/18] fix an obvious mistake in a test of IFM_ETHER

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi a bug fix in FreeBSD code. Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index f46eee8..24facbb 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -1037,7

[ovs-dev] [PATCH 11/18] include some headers to satisfy header file dependencies on NetBSD-6.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi while this change don't seem to be necessary on NetBSD-current, NetBSD-6 is the latest release at this point. Signed-off-by: YAMAMOTO Takashi --- lib/route-table.h | 1 + lib/socket-util.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/route-table.h b/lib/rout

[ovs-dev] [PATCH 03/18] add ax_check_openssl.m4

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi this file is obtained from: http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_check_openssl.m4;hb=5a7260331c7d13263126e35c5743fdc35cbc2894 Signed-off-by: YAMAMOTO Takashi --- m4/ax_check_openssl.m4 | 124 +

[ovs-dev] [PATCH 04/18] use ax_check_openssl.m4 instead of a direct use of pkg-config.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi on some platforms, including NetBSD-6, openssl is available but its pkg-config files (*.pc) are not. Signed-off-by: YAMAMOTO Takashi --- m4/ax_check_openssl.m4 | 38 +++--- m4/openvswitch.m4 | 3 +-- 2 files changed, 20 insertions(+)

[ovs-dev] [PATCH 10/18] some ctype related casts to suppress gcc warnings on NetBSD.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi where it can't be EOF, cast a value to unsigned char before passing it to ctype functions to avoid unintended sign extension. Signed-off-by: YAMAMOTO Takashi --- lib/json.c | 14 +++--- lib/ofp-util.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-)

[ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 53 + 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 615a26f..1cb1d8b 100644 --- a/lib/netdev-bsd.c +++ b/l

[ovs-dev] [PATCH 17/18] some NetBSD related documentation changes

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- INSTALL.userspace | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/INSTALL.userspace b/INSTALL.userspace index 296f077..65ad499 100644 --- a/INSTALL.userspace +++ b/INSTALL.userspace @@ -31,9 +31

[ovs-dev] [PATCH 08/18] change the type of popcount unsigned.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi it's a natural choice and compatible with a version found in NetBSD libc. Signed-off-by: YAMAMOTO Takashi --- lib/util.c | 2 +- lib/util.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/util.c b/lib/util.c index 83d3ff8..8a0b3ab 100644 --- a/

[ovs-dev] [PATCH 06/18] add NetBSD case for test.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- utilities/ovs-pki.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in index 1f15410..8da8aa7 100755 --- a/utilities/ovs-pki.in +++ b/utilities/ovs-pki.in @@ -27,7 +27,7 @@ b

[ovs-dev] [PATCH 13/18] add minimal NetBSD support

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi mostly ride on the existing FreeBSD support. Signed-off-by: YAMAMOTO Takashi --- lib/command-line.c| 4 ++-- lib/command-line.h| 2 +- lib/netdev-bsd.c | 37 - lib/netdev-dummy.c| 8 lib/netdev-provider.h |

[ovs-dev] [PATCH 00/18] NetBSD support

2013-01-31 Thread YAMAMOTO Takashi
NetBSD support YAMAMOTO Takashi (18): fix an obvious mistake in a test of IFM_ETHER deal with platforms where backtrace() is in a different library than libc. add ax_check_openssl.m4 use ax_check_openssl.m4 instead of a direct use of pkg-config. include strings.h for strcasecmp. ad

[ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi where interface renaming is not supported (NetBSD), remember both of our netdev name and the correspoinding kernel name separately. the latter is necessary to talk with kernel using interface names. eg. ifioctls, bpf XXX there should be a proper way to query kernel name.

[ovs-dev] [PATCH 12/18] use RT_ROUNDUP on NetBSD

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c index eb4a168..38cd2c9 100644 --- a/lib/route-table-bsd.c +++ b/lib/route-table-bsd.c @@ -97,7 +97,13 @@ route

[ovs-dev] [PATCH 18/18] implement get_next_hop for NetBSD

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- INSTALL.userspace | 6 +-- lib/netdev-bsd.c | 151 +- 2 files changed, 152 insertions(+), 5 deletions(-) diff --git a/INSTALL.userspace b/INSTALL.userspace index 65ad499..5f9a9d8 1

[ovs-dev] [PATCH 07/18] explicitly invoke perl for uuidfilt.pl (rather than via shebang)

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi depending on a platform, perl might not be /usr/bin/perl. eg. on NetBSD it's usually /usr/pkg/bin/perl. Signed-off-by: YAMAMOTO Takashi --- tests/ovs-vsctl.at | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl

[ovs-dev] [PATCH 05/18] include strings.h for strcasecmp.

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- lib/smap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/smap.c b/lib/smap.c index 54b339f..d993d84 100644 --- a/lib/smap.c +++ b/lib/smap.c @@ -15,6 +15,8 @@ #include #include "smap.h" +#include/* strcasecmp */ +

Re: [ovs-dev] [PATCH 01/18] fix an obvious mistake in a test of IFM_ETHER

2013-01-31 Thread Ed Maste
On 31 January 2013 05:49, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > -if (!IFM_TYPE(ifmr.ifm_current) & IFM_ETHER) { > +if (!(IFM_TYPE(ifmr.ifm_current) & IFM_ETHER)) { > VLOG_DBG_RL(&rl, "%s: doesn't appear to be ethernet", > netdev_get_name(netdev

Re: [ovs-dev] [PATCH 02/18] deal with platforms where backtrace() is in a different library than libc.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:36PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > execinfo for NetBSD and ubacktrace for uClibc. > i don't know if the latter is relevant to Open vSwitch, though. > > Signed-off-by: YAMAMOTO Takashi I didn't know that backtrace() was more widely ava

Re: [ovs-dev] [PATCH 05/18] include strings.h for strcasecmp.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:39PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi I see many uses of strcasecmp() in the tree: blp@blp:~/nicira/ovs(0)$ git --no-pager grep -l strcasecmp lib/bundle.c lib/cfm.c lib/meta-flow.c lib/

Re: [ovs-dev] [PATCH 07/18] explicitly invoke perl for uuidfilt.pl (rather than via shebang)

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:41PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > depending on a platform, perl might not be /usr/bin/perl. > eg. on NetBSD it's usually /usr/pkg/bin/perl. > > Signed-off-by: YAMAMOTO Takashi That's a good point but we have $PERL (set via "configure

Re: [ovs-dev] [PATCH 06/18] add NetBSD case for test.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:40PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi This looks good to me, thanks. I'd update the subject to: ovs-pki: Add NetBSD case for test. to match our usual style.

Re: [ovs-dev] [PATCH 08/18] change the type of popcount unsigned.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:42PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > it's a natural choice and compatible with a version found in NetBSD libc. > > Signed-off-by: YAMAMOTO Takashi This looks good, thank you. ___ dev mailing l

Re: [ovs-dev] [PATCH 09/18] be compilable even when _SC_PHYS_PAGES is not available.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:43PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi Looks good to me, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 10/18] some ctype related casts to suppress gcc warnings on NetBSD.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:44PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > where it can't be EOF, cast a value to unsigned char before passing it > to ctype functions to avoid unintended sign extension. > > Signed-off-by: YAMAMOTO Takashi Thanks, these look good except that

Re: [ovs-dev] [PATCH 11/18] include some headers to satisfy header file dependencies on NetBSD-6.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:45PM +0900, YAMAMOTO Takashi wrote: > @@ -23,6 +23,7 @@ > #include > #include > #include "openvswitch/types.h" > +#include > #include This is the first I've ever heard of in_systm.h. Is it a portable header file? It is not in SUSv4, although I do see it on m

Re: [ovs-dev] [PATCH 12/18] use RT_ROUNDUP on NetBSD

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:46PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi This looks reasonable, thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 13/18] add minimal NetBSD support

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:47PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > mostly ride on the existing FreeBSD support. > > Signed-off-by: YAMAMOTO Takashi ... > @@ -1458,6 +1485,13 @@ static int > set_etheraddr(const char *netdev_name, int hwaddr_family, >

Re: [ovs-dev] [PATCH 03/18] add ax_check_openssl.m4

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:37PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > this file is obtained from: > http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_check_openssl.m4;hb=5a7260331c7d13263126e35c5743fdc35cbc2894 > > Signed-off-by: YAMAMOTO Ta

Re: [ovs-dev] [PATCH 04/18] use ax_check_openssl.m4 instead of a direct use of pkg-config.

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:38PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > on some platforms, including NetBSD-6, openssl is available but > its pkg-config files (*.pc) are not. > > Signed-off-by: YAMAMOTO Takashi Thanks. I like getting rid of a pkgconfig.m4 dependency. T

Re: [ovs-dev] [PATCH 04/18] use ax_check_openssl.m4 instead of a direct use of pkg-config.

2013-01-31 Thread Ed Maste
On 31 January 2013 05:49, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > on some platforms, including NetBSD-6, openssl is available but > its pkg-config files (*.pc) are not. FreeBSD as well (this is a common issue in the FreeBSD ports tree). Thanks. _

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:48PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > where interface renaming is not supported (NetBSD), remember both of > our netdev name and the correspoinding kernel name separately. > the latter is necessary to talk with kernel using interface names.

Re: [ovs-dev] [PATCH 15/18] implement set_etheraddr for NetBSD

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:49PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi I see a number of repeated blocks here of the form: > +int saved_errno = errno; > + > +close(s); > +return saved_errno; We would usually put thi

Re: [ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:50PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi Did you consider opening an AF_LINK socket only once instead of once per call? The netdev_get_stats() function can sometimes be called often, so it may be best to avoi

Re: [ovs-dev] [PATCH 17/18] some NetBSD related documentation changes

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:51PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi Thanks, this seems reasonable. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 00/18] NetBSD support

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:34PM +0900, YAMAMOTO Takashi wrote: > NetBSD support Thanks a lot! Ed Maste and I made some comments. I hope that you will consider them and then repost a revised series. ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread Jesse Gross
On Thu, Jan 31, 2013 at 9:40 AM, Ben Pfaff wrote: > I am not sure that OVS-created tap devices are that useful anyway. I've > thought for some time of removing them from OVS entirely. But it seems > that they are likely to be even less useful on netbsd. Should we simply > not support them there

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 09:59:40AM -0800, Jesse Gross wrote: > On Thu, Jan 31, 2013 at 9:40 AM, Ben Pfaff wrote: > > I am not sure that OVS-created tap devices are that useful anyway. I've > > thought for some time of removing them from OVS entirely. But it seems > > that they are likely to be e

Re: [ovs-dev] [BUG] broad-/multicast & SLB bonding -> FAIL

2013-01-31 Thread Ethan Jackson
Are you absolutely sure the traffic isn't egressing the first switch, and then ingressing the other switch into the bond? It's often hard to tell with tcpdump which direction traffic is travelling. Could you please send problematic traffic through the switch, and while that's going either run ovs

Re: [ovs-dev] [BUG] broad-/multicast & SLB bonding -> FAIL

2013-01-31 Thread Jesse Gross
On Thu, Jan 31, 2013 at 11:30 AM, Ethan Jackson wrote: > Are you absolutely sure the traffic isn't egressing the first switch, > and then ingressing the other switch into the bond? It's often hard > to tell with tcpdump which direction traffic is travelling. He did sent the output ovs-dpctl dump

Re: [ovs-dev] [PATCH 18/18] implement get_next_hop for NetBSD

2013-01-31 Thread Reid Price
> +the in-band support as the following. Perhaps change 'as the following' to 'with the following command' -Reid On Thu, Jan 31, 2013 at 2:49 AM, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi > --- > INSTALL.userspace | 6 +-- > lib/netdev-bsd.c |

Re: [ovs-dev] [coverity 04/12] ovsdb-tool: Fix memory leak on error path in "show-log" implementation.

2013-01-31 Thread Ben Pfaff
Thanks. I pushed these four patches to master and I'm in the process of doing backports. On Wed, Jan 30, 2013 at 04:44:06PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > On Thu, Jan 24, 2013 at 2:44 PM, Ben Pfaff wrote: > > Found by Coverity. > > > > Signed-off-by: Ben Pfaff > > -

Re: [ovs-dev] [PATCH] ofproto-dpif: Clear revalidation flags only once, not per-ofproto.

2013-01-31 Thread Ben Pfaff
Thanks, applied to master. On Mon, Jan 28, 2013 at 12:30:10PM -0800, Ethan Jackson wrote: > Thanks for fixing this. > > Acked-by: Ethan Jackson > > On Mon, Jan 28, 2013 at 10:45 AM, Ben Pfaff wrote: > > Found by inspection. > > > > CC: Ethan Jackson > > Signed-off-by: Ben Pfaff > > --- > > I

Re: [ovs-dev] [PATCH] ovs-ctl: Update comment.

2013-01-31 Thread Ben Pfaff
On Mon, Jan 28, 2013 at 08:20:25PM +, Kyle Mestery (kmestery) wrote: > On Jan 28, 2013, at 1:00 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > > Acked-by: Kyle Mestery Thanks, applied to master. ___ dev mailing list dev@openvswitch.org ht

Re: [ovs-dev] [leaks 1/3] ofproto-dpif: Fix memory leak in port_dump_next().

2013-01-31 Thread Ben Pfaff
Thanks, applied to master. On Fri, Jan 25, 2013 at 03:11:22PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > On Thu, Jan 24, 2013 at 3:20 PM, Ben Pfaff wrote: > > The caller of port_query_by_name() is responsible for freeing the > > ofproto_port that it returns on success, but ofprot

[ovs-dev] [monitor 0/3] "ovs-ofctl monitor" improvements

2013-01-31 Thread Ben Pfaff
This is a repost of a series that I originally sent out on Oct. 24, 2012: http://openvswitch.org/pipermail/dev/2012-October/022213.html http://openvswitch.org/pipermail/dev/2012-October/022215.html http://openvswitch.org/pipermail/dev/2012-October/022214.html Ben Pfaff (3): rconn: Factor code ou

[ovs-dev] [monitor 2/3] rconn: Discard messages received on monitor connections.

2013-01-31 Thread Ben Pfaff
Otherwise, if a monitor connection happens to be talking to a (misguided?) peer that sends it messages, such as replies to what the peer perceives as echo requests meant for it, then the peer will eventually hang trying to send data because the monitor connection never sinks it. Signed-off-by: Ben

[ovs-dev] [monitor 1/3] rconn: Factor code out from copy_to_monitor().

2013-01-31 Thread Ben Pfaff
This prepares for the introduction of a second user in the following commit. Signed-off-by: Ben Pfaff --- lib/rconn.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/rconn.c b/lib/rconn.c index 9b6cd86..d7bb0be 100644 --- a/lib/rconn.c +++ b/lib/rconn.

[ovs-dev] [monitor 3/3] ovs-ofctl: Make "ovs-ofctl monitor" respond to echo requests.

2013-01-31 Thread Ben Pfaff
Otherwise the command will time out after a while when there's no traffic, which probably isn't what we want. Reported-by: Henry Mai Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c | 34 +++--- 1 files changed, 27 insertions(+), 7 deletions(-) diff --git a/util

Re: [ovs-dev] [PATCH 0/16 v2.17] Basic MPLS actions and matches

2013-01-31 Thread Simon Horman
On Fri, Jan 25, 2013 at 04:22:06PM +0900, Simon Horman wrote: > Hi, > > This series implements basic MPLS actions and matches based on work by > Ravi K, Leo Alterman and Yamahata-san. > > The main limitation of this implementation is that it only > supports manipulating the outer-most MPLS label.

Re: [ovs-dev] [PATCH 0/16 v2.17] Basic MPLS actions and matches

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 09:23:52AM +0900, Simon Horman wrote: > On Fri, Jan 25, 2013 at 04:22:06PM +0900, Simon Horman wrote: > > Hi, > > > > This series implements basic MPLS actions and matches based on work by > > Ravi K, Leo Alterman and Yamahata-san. > > > > The main limitation of this imple

[ovs-dev] [PATCH v2 1/2] netdev-dummy: Correctly maintain port statistics.

2013-01-31 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index f81b68e..234d7bc 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -205,6 +205,19 @@ netdev_dummy_drai

[ovs-dev] [PATCH v2 0/2] add test for self-modifying learn action

2013-01-31 Thread Ben Pfaff
This is a repost of a series originally posted on Sep. 18, 2012: http://openvswitch.org/pipermail/dev/2012-September/021272.html http://openvswitch.org/pipermail/dev/2012-September/021273.html Ben Pfaff (2): netdev-dummy: Correctly maintain port statistics. tests: Add test for self-modifying l

[ovs-dev] [PATCH v2 2/2] tests: Add test for self-modifying learn action.

2013-01-31 Thread Ben Pfaff
CC: Paul Ingram Signed-off-by: Ben Pfaff --- tests/learn.at | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/tests/learn.at b/tests/learn.at index 800dc14..8f59b63 100644 --- a/tests/learn.at +++ b/tests/learn.at @@ -252,6 +252,41 @@ NXS

Re: [ovs-dev] [PATCH 0/16 v2.17] Basic MPLS actions and matches

2013-01-31 Thread Simon Horman
On Thu, Jan 31, 2013 at 04:27:01PM -0800, Ben Pfaff wrote: > On Fri, Feb 01, 2013 at 09:23:52AM +0900, Simon Horman wrote: > > On Fri, Jan 25, 2013 at 04:22:06PM +0900, Simon Horman wrote: > > > Hi, > > > > > > This series implements basic MPLS actions and matches based on work by > > > Ravi K, Le

Re: [ovs-dev] [PATCH 00/18] NetBSD support

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:34PM +0900, YAMAMOTO Takashi wrote: >> NetBSD support > > Thanks a lot! Ed Maste and I made some comments. I hope that you will > consider them and then repost a revised series. thanks for reviewing! YAMAMOTO Takashi

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:48PM +0900, YAMAMOTO Takashi wrote: >> From: YAMAMOTO Takashi >> >> where interface renaming is not supported (NetBSD), remember both of >> our netdev name and the correspoinding kernel name separately. >> the latter is necessary to talk with kernel using inte

Re: [ovs-dev] [PATCH 11/18] include some headers to satisfy header file dependencies on NetBSD-6.

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:45PM +0900, YAMAMOTO Takashi wrote: >> @@ -23,6 +23,7 @@ >> #include >> #include >> #include "openvswitch/types.h" >> +#include >> #include > > This is the first I've ever heard of in_systm.h. Is it a portable > header file? It is not in SUSv4, althou

Re: [ovs-dev] [PATCH 05/18] include strings.h for strcasecmp.

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:39PM +0900, YAMAMOTO Takashi wrote: >> From: YAMAMOTO Takashi >> >> Signed-off-by: YAMAMOTO Takashi > > I see many uses of strcasecmp() in the tree: > > blp@blp:~/nicira/ovs(0)$ git --no-pager grep -l strcasecmp > lib/bundle.c > lib/cfm.c >

Re: [ovs-dev] [PATCH 02/18] deal with platforms where backtrace() is in a different library than libc.

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:36PM +0900, YAMAMOTO Takashi wrote: >> From: YAMAMOTO Takashi >> >> execinfo for NetBSD and ubacktrace for uClibc. >> i don't know if the latter is relevant to Open vSwitch, though. >> >> Signed-off-by: YAMAMOTO Takashi > > I didn't know that backtrace() wa

Re: [ovs-dev] [PATCH 13/18] add minimal NetBSD support

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:47PM +0900, YAMAMOTO Takashi wrote: >> From: YAMAMOTO Takashi >> >> mostly ride on the existing FreeBSD support. >> >> Signed-off-by: YAMAMOTO Takashi > > ... > >> @@ -1458,6 +1485,13 @@ static int >> set_etheraddr(const char *netdev_name, int hwaddr_fami

Re: [ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

2013-01-31 Thread YAMAMOTO Takashi
hi, > On Thu, Jan 31, 2013 at 07:49:50PM +0900, YAMAMOTO Takashi wrote: >> From: YAMAMOTO Takashi >> >> Signed-off-by: YAMAMOTO Takashi > > Did you consider opening an AF_LINK socket only once instead of once per > call? The netdev_get_stats() function can sometimes be called often, so > it m

Re: [ovs-dev] [PATCH 11/18] include some headers to satisfy header file dependencies on NetBSD-6.

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 10:56:34AM +0900, YAMAMOTO Takashi wrote: > hi, > > > On Thu, Jan 31, 2013 at 07:49:45PM +0900, YAMAMOTO Takashi wrote: > >> @@ -23,6 +23,7 @@ > >> #include > >> #include > >> #include "openvswitch/types.h" > >> +#include > >> #include > > > > This is the first I'v

Re: [ovs-dev] [PATCH 05/18] include strings.h for strcasecmp.

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 10:59:51AM +0900, YAMAMOTO Takashi wrote: > hi, > > > On Thu, Jan 31, 2013 at 07:49:39PM +0900, YAMAMOTO Takashi wrote: > >> From: YAMAMOTO Takashi > >> > >> Signed-off-by: YAMAMOTO Takashi > > > > I see many uses of strcasecmp() in the tree: > > > > blp@blp:~/nici

Re: [ovs-dev] [PATCH 02/18] deal with platforms where backtrace() is in a different library than libc.

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 11:25:35AM +0900, YAMAMOTO Takashi wrote: > > On Thu, Jan 31, 2013 at 07:49:36PM +0900, YAMAMOTO Takashi wrote: > >> From: YAMAMOTO Takashi > >> > >> execinfo for NetBSD and ubacktrace for uClibc. > >> i don't know if the latter is relevant to Open vSwitch, though. > >> >

Re: [ovs-dev] [PATCH 13/18] add minimal NetBSD support

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 11:35:26AM +0900, YAMAMOTO Takashi wrote: > >> -#ifdef __FreeBSD__ > >> -#define FREE_BSD 1 > >> +#if defined(__FreeBSD__) || defined(__NetBSD__) > >> +#define FREEBSD_OR_NETBSD 1 > >> #else > >> -#define FREE_BSD 0 > >> +#define FREEBSD_OR_NETBSD 0 > >> #endif > > > > It

Re: [ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 11:38:50AM +0900, YAMAMOTO Takashi wrote: > > On Thu, Jan 31, 2013 at 07:49:50PM +0900, YAMAMOTO Takashi wrote: > > Is there a reason not to squash this patch (and the previous one) into > > the earlier patch that modified netdev-bsd? I do not see anything that > > keeps it

Re: [ovs-dev] [PATCH 00/18] NetBSD support

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 10:46:52AM +0900, YAMAMOTO Takashi wrote: > > On Thu, Jan 31, 2013 at 07:49:34PM +0900, YAMAMOTO Takashi wrote: > >> NetBSD support > > > > Thanks a lot! Ed Maste and I made some comments. I hope that you will > > consider them and then repost a revised series. > > thank

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 10:53:10AM +0900, YAMAMOTO Takashi wrote: > > On Thu, Jan 31, 2013 at 07:49:48PM +0900, YAMAMOTO Takashi wrote: > >> From: YAMAMOTO Takashi > >> > >> where interface renaming is not supported (NetBSD), remember both of > >> our netdev name and the correspoinding kernel nam

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread YAMAMOTO Takashi
hi, >> > * ovs-vswitchd starts up and creates some tap devices. It knows >> > the mapping between the user-requested name and the kernel >> > name. >> > >> > * Admin restarts ovs-vswitchd. >> > >> > * New instance of ovs-vswitchd creates new tap devic

Re: [ovs-dev] [PATCH 14/18] keep "kernel name" for each netdev

2013-01-31 Thread Ben Pfaff
On Fri, Feb 01, 2013 at 12:23:00PM +0900, YAMAMOTO Takashi wrote: > hi, > > >> > * ovs-vswitchd starts up and creates some tap devices. It knows > >> > the mapping between the user-requested name and the kernel > >> > name. > >> > > >> > * Admin restarts ovs-v