On Thu, Jan 31, 2013 at 07:49:39PM +0900, YAMAMOTO Takashi wrote:
> From: YAMAMOTO Takashi <[email protected]>
>
> Signed-off-by: YAMAMOTO Takashi <[email protected]>
I see many uses of strcasecmp() in the tree:
blp@blp:~/nicira/ovs(0)$ git --no-pager grep -l strcasecmp
lib/bundle.c
lib/cfm.c
lib/meta-flow.c
lib/multipath.c
lib/odp-util.c
lib/ofp-parse.c
lib/ofp-util.c
lib/vlog.c
utilities/ovs-ofctl.c
utilities/ovs-vsctl.c
vswitchd/bridge.c
but only one use of strings.h:
lib/dpif-linux.c
I am surprised that your patch only adds one #include. Why is that?
> +#include <strings.h> /* strcasecmp */
The comment isn't necessary here.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
