On Thu, Jan 31, 2013 at 07:49:47PM +0900, YAMAMOTO Takashi wrote:
> From: YAMAMOTO Takashi <[email protected]>
>
> mostly ride on the existing FreeBSD support.
>
> Signed-off-by: YAMAMOTO Takashi <[email protected]>
...
> @@ -1458,6 +1485,13 @@ static int
> set_etheraddr(const char *netdev_name, int hwaddr_family,
> int hwaddr_len, const uint8_t mac[ETH_ADDR_LEN])
> {
> +#if defined(__NetBSD__)
> + (void)netdev_name;
> + (void)hwaddr_family;
> + (void)hwaddr_len;
> + (void)mac;
> + return ENOTSUP; /* XXX */
OVS generally uses EOPNOTSUPP (not ENOTSUP, which I hadn't known about)
internally to indicate that an operation isn't supported. Will you
change this instance to EOPNOTSUPP? Thanks.
> -#ifdef __FreeBSD__
> -#define FREE_BSD 1
> +#if defined(__FreeBSD__) || defined(__NetBSD__)
> +#define FREEBSD_OR_NETBSD 1
> #else
> -#define FREE_BSD 0
> +#define FREEBSD_OR_NETBSD 0
> #endif
It might be more readable to just use "BSD" in place of
FREEBSD_OR_NETBSD, which is a bit long.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
