[ovs-dev] [PATCH 2/2] Add experimental support for TUNNEL SRC/DST

2012-12-11 Thread Jarno Rajahalme
Add wildcarding support for tun_src/tun_dst to allow matching. Signed-off-by: Jarno Rajahalme --- lib/meta-flow.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 909e434..711dd2e 100644 --- a/lib/meta-flow.c +++ b/lib/meta-

Re: [ovs-dev] [PATCH] support NXAST_SET_TUNNEL_DST action

2012-12-11 Thread Jarno Rajahalme
On Dec 11, 2012, at 6:53 , ext Ben Pfaff wrote: > On Mon, Dec 10, 2012 at 05:16:39PM -0800, Rich Lane wrote: >> I would have liked to put this in under the BSN vendor ID but there isn't any >> existing support for actions from other vendors. Let me know if you'd like me >> to add that. > > Jesse m

[ovs-dev] [PATCH] Add experimental support for TUNNEL SRC/DST.

2012-12-11 Thread Jarno Rajahalme
Add NXM definitions for tun_src and tun_dst, allowing them to be used in matching and setting them via SetField action. Signed-off-by: Jarno Rajahalme --- include/openflow/nicira-ext.h |3 +++ lib/meta-flow.c | 26 -- lib/nx-match.c|

Re: [ovs-dev] [PATCH] docs: Add INSTALL.OpenNebula

2012-12-11 Thread Jaime Melis
Hi, here you go. Thanks, Jaime On Wed, Dec 5, 2012 at 4:33 PM, Ben Pfaff wrote: > On Wed, Dec 05, 2012 at 12:51:08PM +0100, Jaime Melis wrote: > > From: Jaime Melis > > Date: Wed, 5 Dec 2012 12:33:40 +0100 > > Subject: [PATCH] INSTALL.OpenNebula: New instructions for using with > > OpenNebu

[ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE vendor action

2012-12-11 Thread Romain Lenglet
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding OFPACT_SAMPLE OVS action. Signed-off-by: Romain Lenglet --- NEWS | 1 + include/openflow/nicira-ext.h | 16 +++ lib/ofp-actions.c | 45 +++ l

[ovs-dev] [PATCH 2/2] ofproto: Translate NXAST_SAMPLE actions into SAMPLE datapath actions

2012-12-11 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- lib/odp-util.c | 14 lib/odp-util.h | 9 +- ofproto/ofproto-dpif.c | 88 +- tests/odp.at | 1 + 4 files changed, 95 insertions(+), 17 deletions(-) diff --git a/lib/odp-util.

Re: [ovs-dev] [PATCH] docs: Add INSTALL.OpenNebula

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 04:10:02PM +0100, Jaime Melis wrote: > here you go. Thanks. While proofreading, I noticed what might be a problem, though. The documentation says: It is also necessary to install the Open vSwitch compatibility layer for Linux bridging. Please refer to the INSTAL

Re: [ovs-dev] [PATCH] docs: Add INSTALL.OpenNebula

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 10:03:22AM -0800, Ben Pfaff wrote: > On Tue, Dec 11, 2012 at 04:10:02PM +0100, Jaime Melis wrote: > > here you go. > > Thanks. > > While proofreading, I noticed what might be a problem, though. The > documentation says: Here's what I came up with while proofreading, by t

Re: [ovs-dev] [PATCH] Add experimental support for TUNNEL SRC/DST.

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 02:35:37PM +0200, Jarno Rajahalme wrote: > Add NXM definitions for tun_src and tun_dst, allowing them to be used in > matching and setting them via SetField action. > > Signed-off-by: Jarno Rajahalme I'm OK with this but it needs Jesse's approval since he's mentioned that

Re: [ovs-dev] [PATCH] support NXAST_SET_TUNNEL_DST action

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 10:17:31AM +0200, Jarno Rajahalme wrote: > To allow them to be applied the OXMs I defined should probably be changed to > NXMs instead. Either way they would be usable on both OF 1.2+ and OF 1.0 (via > NXT_FLOW_MOD). At first I was going to suggest that they should use a No

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-12-11 Thread Ben Pfaff
On Wed, Dec 05, 2012 at 06:01:17PM +0100, Thomas Graf wrote: > On 12/04/2012 08:25 PM, Ben Pfaff wrote: > >It tells a human user that the operation failed. It could also notify > >a script that the operation failed, e.g. if we decided to return a > >nonzero exit status. (ovs-vsctl is intended for

Re: [ovs-dev] [PATCH] Add experimental support for TUNNEL SRC/DST.

2012-12-11 Thread Jesse Gross
On Tue, Dec 11, 2012 at 10:14 AM, Ben Pfaff wrote: > On Tue, Dec 11, 2012 at 02:35:37PM +0200, Jarno Rajahalme wrote: >> Add NXM definitions for tun_src and tun_dst, allowing them to be used in >> matching and setting them via SetField action. >> >> Signed-off-by: Jarno Rajahalme > > I'm OK with

Re: [ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE vendor action

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE OpenFlow vendor action and the corresponding > OFPACT_SAMPLE OVS action. > > Signed-off-by: Romain Lenglet I think that this new action is intended to send the packet to a controller when sampling happens, and

Re: [ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE vendor action

2012-12-11 Thread Romain Lenglet
On Dec 11, 2012, at 10:47 AM, Ben Pfaff wrote: > On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote: >> Define NXAST_SAMPLE OpenFlow vendor action and the corresponding >> OFPACT_SAMPLE OVS action. >> >> Signed-off-by: Romain Lenglet > > I think that this new action is intended to

Re: [ovs-dev] [PATCH] Add experimental support for TUNNEL SRC/DST.

2012-12-11 Thread Rich Lane
Tue, Dec 11, 2012 at 10:22 AM, Jesse Gross wrote: > On Tue, Dec 11, 2012 at 10:14 AM, Ben Pfaff wrote: > > On Tue, Dec 11, 2012 at 02:35:37PM +0200, Jarno Rajahalme wrote: > >> Add NXM definitions for tun_src and tun_dst, allowing them to be used in > >> matching and setting them via SetField a

Re: [ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-11 Thread Kyle Mestery (kmestery)
On Dec 10, 2012, at 11:27 AM, Jesse Gross wrote: > On Sat, Dec 8, 2012 at 5:35 AM, Kyle Mestery (kmestery) > wrote: >> On Dec 7, 2012, at 10:15 PM, Jesse Gross wrote: >>> On Fri, Dec 7, 2012 at 1:47 PM, Kyle Mestery wrote: Some tunneling protocols require manipulation of the packet before

Re: [ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE vendor action

2012-12-11 Thread Ben Pfaff
On Tue, Dec 11, 2012 at 11:17:33AM -0800, Romain Lenglet wrote: > On Dec 11, 2012, at 10:47 AM, Ben Pfaff wrote: > > > On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote: > >> Define NXAST_SAMPLE OpenFlow vendor action and the corresponding > >> OFPACT_SAMPLE OVS action. > >> > >> Si

Re: [ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE vendor action

2012-12-11 Thread Romain Lenglet
On Dec 11, 2012, at 1:19 PM, Ben Pfaff wrote: > On Tue, Dec 11, 2012 at 11:17:33AM -0800, Romain Lenglet wrote: >> On Dec 11, 2012, at 10:47 AM, Ben Pfaff wrote: >> >>> On Tue, Dec 11, 2012 at 09:54:50AM -0800, Romain Lenglet wrote: Define NXAST_SAMPLE OpenFlow vendor action and the corres

[ovs-dev] [PATCH 2/2] ofproto: Translate NXAST_SAMPLE_IPFIX actions into SAMPLE dp actions

2012-12-11 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- lib/odp-util.c | 14 ++ lib/odp-util.h | 9 +- ofproto/ofproto-dpif.c | 76 -- tests/odp.at | 1 + 4 files changed, 85 insertions(+), 15 deletions(-) diff --git a/lib/odp-uti

[ovs-dev] [PATCH 1/2] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2012-12-11 Thread Romain Lenglet
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding OFPACT_SAMPLE_IPFIX OVS action. Signed-off-by: Romain Lenglet --- NEWS | 1 + include/openflow/nicira-ext.h | 23 ++ lib/ofp-actions.c | 45 +++

[ovs-dev] [PATCH] ovs-vsctl: Check "ofport" column after adding a new port

2012-12-11 Thread Thomas Graf
When adding a new port or bond, save the port name and check the "ofport" column of that port after the database has been reloaded. It will contain OFPP_NONE (-1) if the addition process failed inside the bridge. Print an error message and exit ovs-vsctl with -EFAULT in that case. Note that this i

Re: [ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-11 Thread Jesse Gross
On Tue, Dec 11, 2012 at 12:45 PM, Kyle Mestery (kmestery) wrote: > On Dec 10, 2012, at 11:27 AM, Jesse Gross wrote: >> On Sat, Dec 8, 2012 at 5:35 AM, Kyle Mestery (kmestery) >> wrote: >>> On Dec 7, 2012, at 10:15 PM, Jesse Gross wrote: On Fri, Dec 7, 2012 at 1:47 PM, Kyle Mestery wrote:

Re: [ovs-dev] [PATCH 02/13] Upstream GRE : Refactor code GRE code.

2012-12-11 Thread Jesse Gross
Thanks and sorry that I took so long to get back to you. I thought about the layering a fair amount and am still somewhat bothered by the flow of things. I think if we make a couple small modifications then it will fit more cleanly: * I don't think that we really need ip_tunnel_xmit(). It's pri

Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-11 Thread Tom Herbert
> This patch adds ipv6 set action functionality. It allows to change > traffic class, flow label, hop-limit, ipv6 source and destination > address fields. > I have to wonder about these patches and the underlying design direction. Aren't these sort of things and more already implemented by IPtable