On Dec 11, 2012, at 6:53 , ext Ben Pfaff wrote: > On Mon, Dec 10, 2012 at 05:16:39PM -0800, Rich Lane wrote: >> I would have liked to put this in under the BSN vendor ID but there isn't any >> existing support for actions from other vendors. Let me know if you'd like me >> to add that. > > Jesse made some comments on the rest, here's some on this bit. > > I'm open to generalizing the actions code to support other vendor IDs. > > It might make sense, though, to instead expose the tunnel destination > as an NXM/OXM field, and then we could just use NXAST_REG_LOAD or > OFPAT_SET_FIELD to change it.
I just sent two patches demonstrating the above. What is nice about this strategy, in addition to the implementation simplicity, is the fact that matching support requires the addition of NXM/OXM definitions anyway, and the SetField action support comes as a free bonus. To allow them to be applied the OXMs I defined should probably be changed to NXMs instead. Either way they would be usable on both OF 1.2+ and OF 1.0 (via NXT_FLOW_MOD). Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
