Re: [ovs-dev] Spurious test failure?

2012-12-08 Thread Jarno Rajahalme
On Dec 7, 2012, at 17:40 , ext Ben Pfaff wrote: > On Fri, Dec 07, 2012 at 01:57:14PM +0200, Jarno Rajahalme wrote: >> On Dec 4, 2012, at 21:06 , ext Ben Pfaff wrote: >> >>> On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Rajahalme wrote: It seems to me that depending on test machine load or o

Re: [ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-08 Thread Kyle Mestery (kmestery)
On Dec 7, 2012, at 10:15 PM, Jesse Gross wrote: > On Fri, Dec 7, 2012 at 1:47 PM, Kyle Mestery wrote: >> Some tunneling protocols require manipulation of the packet before the outer >> IP header is placed on the packet. An example of a tunneling protocol with >> this attribute is LISP. For these

Re: [ovs-dev] Spurious test failure?

2012-12-08 Thread Ben Pfaff
On Sat, Dec 08, 2012 at 11:16:33AM +0200, Jarno Rajahalme wrote: > On Dec 7, 2012, at 17:40 , ext Ben Pfaff wrote: > > On Fri, Dec 07, 2012 at 01:57:14PM +0200, Jarno Rajahalme wrote: > >> On Dec 4, 2012, at 21:06 , ext Ben Pfaff wrote: > >> > >>> On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Ra

Re: [ovs-dev] [PATCH] netdev-bsd: Use underlying tap device on netdev_bsd_listen().

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 11:28:26AM -0500, Ed Maste wrote: > This is a trivial port to netdev-bsd of Justin Pettit's netdev-linux fix. > > Signed-off-by: Ed Maste > --- > This fixes the userspace datapath on FreeBSD. > > Justin's change: > > Commit acf608 (ofproto-dpif: Use a single underlying

Re: [ovs-dev] [PATCH] vswitchd: Avoid writing to const struct

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 05:41:16PM -0500, Ed Maste wrote: > When built with Clang, vswitchd segfaulted in ovsrec_open_vswitch_init, > from calling memset() on a const struct. > > Signed-off-by: Ed Maste > --- > This could be addressed instead by just dropping the const in the > null_cfg definitio

Re: [ovs-dev] [PATCH] nx-match: Log a warning when a wildcarded bit is set to 1.

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 09:57:30PM +, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:47 PM, Ben Pfaff wrote: > > On Wed, Oct 03, 2012 at 09:48:57AM -0700, Ben Pfaff wrote: > >> This was prompted by a conversation on the openflow-discuss mailing list > >> where developers of some OpenFlo

Re: [ovs-dev] Adding STP option support for RHEL ovs-ifup

2012-12-08 Thread Ben Pfaff
Thanks, I applied this to master. On Fri, Dec 07, 2012 at 11:12:54PM +0200, Andres Toomsalu wrote: > Added sign-off line... > > > On Tue, Dec 4, 2012 at 7:24 AM, Ben Pfaff wrote: > > > On Wed, Nov 28, 2012 at 02:57:35PM +0200, Andres Toomsalu wrote: > > > Here is a small patch for adding STP o

Re: [ovs-dev] Adding STP option support for RHEL ovs-ifup

2012-12-08 Thread Ben Pfaff
But I had to change the Signed-off-by email address to match the authorship (From) address. Thanks, Ben. On Sat, Dec 08, 2012 at 10:47:44AM -0800, Ben Pfaff wrote: > Thanks, I applied this to master. > > On Fri, Dec 07, 2012 at 11:12:54PM +0200, Andres Toomsalu wrote: > > Added sign-off line...

Re: [ovs-dev] [PATCH] nx-match: Log a warning when a wildcarded bit is set to 1.

2012-12-08 Thread Kyle Mestery (kmestery)
On Dec 8, 2012, at 12:45 PM, Ben Pfaff wrote: > On Fri, Dec 07, 2012 at 09:57:30PM +, Kyle Mestery (kmestery) wrote: >> On Dec 4, 2012, at 2:47 PM, Ben Pfaff wrote: >>> On Wed, Oct 03, 2012 at 09:48:57AM -0700, Ben Pfaff wrote: This was prompted by a conversation on the openflow-discuss

Re: [ovs-dev] [PATCH] vlog: New vlog/enable-rate-limit and vlog/disable-rate-limit commands.

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 10:00:08PM +, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:48 PM, Ben Pfaff wrote: > > > On Tue, Oct 16, 2012 at 10:15:48AM -0700, Ben Pfaff wrote: > >> A few times while troubleshooting it would have been useful to get > >> complete logs, rather than post-rat

Re: [ovs-dev] [PATCH] vswitchd: Make the maximum size of MAC learning tables user-configurable.

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 10:11:55PM +, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:50 PM, Ben Pfaff wrote: > > On Wed, Oct 24, 2012 at 05:01:29PM -0700, Ben Pfaff wrote: > >> We've had a couple of requests for this over the years. It's easy to do, > >> so let's implement it. > >> >

Re: [ovs-dev] [PATCH] ofproto: Report correct error for emergency flow with timeout.

2012-12-08 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 10:02:16PM +, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:52 PM, Ben Pfaff wrote: > > On Thu, Nov 01, 2012 at 12:22:41AM -0700, Ben Pfaff wrote: > >> The OpenFlow 1.0 specification says: > >> > >>Emergency flow mod messages must have timeout values set to

[ovs-dev] [PATCH] vswitchd: Avoid writing to const struct

2012-12-08 Thread Ed Maste
When built with Clang, vswitchd segfaulted in ovsrec_open_vswitch_init, from calling memset() on a const struct. Signed-off-by: Ed Maste --- vswitchd/bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index b1d2feb..cb94fa0 1006

Re: [ovs-dev] [PATCH] vswitchd: Avoid writing to const struct

2012-12-08 Thread Ben Pfaff
On Sat, Dec 08, 2012 at 06:23:12PM -0500, Ed Maste wrote: > When built with Clang, vswitchd segfaulted in ovsrec_open_vswitch_init, > from calling memset() on a const struct. > > Signed-off-by: Ed Maste Applied to master, thanks. ___ dev mailing list d