On Fri, Dec 07, 2012 at 10:11:55PM +0000, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:50 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Wed, Oct 24, 2012 at 05:01:29PM -0700, Ben Pfaff wrote: > >> We've had a couple of requests for this over the years. It's easy to do, > >> so let's implement it. > >> > >> Signed-off-by: Ben Pfaff <b...@nicira.com> > > > > I know that some users would find this handy, so it would be nice to > > get it reviewed. > > Just a few minor comments (and apologies, I deleted this from my mail > client, so reviewing by cutting and pasting from the archives):
That's fine with me. Thanks. > For mac_learning_set_max_entries(), set_mac_table_config(), and > ofproto_set_mac_table_config(), maybe make "max_entries" const in the > parameter list. max_entries is an integer. It isn't common OVS style to mark plain integer parameters as const. We usually reserve that for the referents of pointers. > Acked-by: Kyle Mestery <kmest...@cisco.com> Thanks, I pushed this. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
