On Fri, Dec 07, 2012 at 09:57:30PM +0000, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:47 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Wed, Oct 03, 2012 at 09:48:57AM -0700, Ben Pfaff wrote: > >> This was prompted by a conversation on the openflow-discuss mailing list > >> where developers of some OpenFlow switches mentioned that they save an > >> entire copy of raw flows passed in by controllers because of the > >> possibility that there might be wildcarded 1-bits, e.g. something like > >> 192.168.1.1/255.255.0.0 instead of 192.168.0.0/255.255.0.0. I've always > >> intended that this not be necessary, but it was never explicitly written > >> down. This commit starts the process of updating OVS to make this a > >> requirement, by logging a warning whenever such a NXM or OXM entry is seen, > >> and by updating the spec in nicira-ext.h to describe my intent. > >> > >> I intend to also file a bug report in the ONF tracker for OpenFlow to get > >> a similar clarification into OpenFlow 1.4. (I don't intend to make this > >> an error in Open vSwitch unless ONF actually accepts this change.) > >> > >> Thanks to Zolt?n Lajos Kis, Dan Talayco, Rob Sherwood, and HIDEyuki > >> Shimonishi for participating in the discussion on openflow-discuss. > >> > >> Signed-off-by: Ben Pfaff <b...@nicira.com> > > > > It would be really good to get this in soon, so that we can report a > > warning when controllers have unusual behavior here. > > Looked this one over, looks good to me. > > Signed-off-by: Kyle Mestery <kmest...@cisco.com>
I changed that to an Acked-by (since you're a reviewer, not along the delivery path) and pushed this. Thank you! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
