On Dec 7, 2012, at 17:40 , ext Ben Pfaff wrote: > On Fri, Dec 07, 2012 at 01:57:14PM +0200, Jarno Rajahalme wrote: >> On Dec 4, 2012, at 21:06 , ext Ben Pfaff wrote: >> >>> On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Rajahalme wrote: >>>> It seems to me that depending on test machine load or other >>>> scheduling reasons, it is possible that some tests fail sometimes, >>>> even if there is no real failure. One such case below, where it >>>> seems that the middle reply comes in a bit later than >>>> anticipated. On repeat this failure did not occur again. >>> >>> From time to time we this kind of problem does get introduced into the >>> testsuite. Sorry about that. Fixes are welcome; I often fix them if >>> I start seeing them in my own testsuite runs. >>> >> >> OK. Would a proper fix be to suppress the "sent" line(s) and just >> check that the responses match? > > At first glance what I've appended is a proper fix. Will you review it? >
Runs fine, even though I still was not able to repeat the failure I reported. However, I don't know if that is a definitive fix. Isn't it still possible, that the flow monitor reply for the 2nd add-flow will *arrive* after both the ofctl/barrier request and ofctl/send are *sent*? That is, "ovs-appctl -t ovs-ofctl ofctl/barrier" will not wait for the barrier response to come back before returning, of does it? The real problem seems to be that messages for sent messages and received messages are mixed in the same stream, and sometimes, depending on scheduling etc. the interleaving of the two might be different. >> Haven't seen the failure I reported since, though. > > Sometimes you can reproduce failures just by running a particular test > in a loop. You can make the test run faster with a technique like this: > > amfilt make -j4 check TESTSUITEFLAGS='-d 541' > while tests/testsuite.dir/0541/run -d; do : ; done > What is the function of "amfilt" above, and where should I go to get it? Regards, Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
