On Tue, Feb 05, 2013 at 09:19:06AM -0800, Ben Pfaff wrote:
> On Tue, Feb 05, 2013 at 10:13:18AM +0900, Simon Horman wrote:
> > On Tue, Feb 05, 2013 at 09:00:35AM +0900, Simon Horman wrote:
> > > On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote:
> > > > On Fri, Jan 25, 2013 at 04:22:07PM +0
On Tue, Feb 05, 2013 at 10:13:18AM +0900, Simon Horman wrote:
> On Tue, Feb 05, 2013 at 09:00:35AM +0900, Simon Horman wrote:
> > On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote:
> > > On Fri, Jan 25, 2013 at 04:22:07PM +0900, Simon Horman wrote:
> > > > This patch implements use-space da
On Tue, Feb 05, 2013 at 09:00:35AM +0900, Simon Horman wrote:
> On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote:
> > On Fri, Jan 25, 2013 at 04:22:07PM +0900, Simon Horman wrote:
> > > This patch implements use-space datapath and non-datapath code
> > > to match and use the datapath API s
On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote:
> On Fri, Jan 25, 2013 at 04:22:07PM +0900, Simon Horman wrote:
> > This patch implements use-space datapath and non-datapath code
> > to match and use the datapath API set out in Leo Alterman's patch
> > "user-space datapath: Add basic MPL
On Fri, Jan 25, 2013 at 01:44:39PM +0900, Simon Horman wrote:
> On Tue, Jan 22, 2013 at 03:49:42PM -0800, Ben Pfaff wrote:
> > On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> > > > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> > > > > parse_l3_onward() could use flow_
On Tue, Jan 22, 2013 at 03:49:42PM -0800, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> > > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> > > > parse_l3_onward() could use flow_innermost_dl_type() since that's what
> > > > it's effectively calcula
Great! Thanks for clearing that up for me.
-Andre
- Original Message -
From: "Simon Horman"
To: "Andre Khan"
Cc: dev@openvswitch.org, "Isaku Yamahata" , "Ravi K"
, "Ben Pfaff"
Sent: Wednesday, January 23, 2013 11:00:11 PM
Subject: R
On Wed, Jan 23, 2013 at 10:31:52PM -0800, Andre Khan wrote:
>
> Hi Simon,
>
> Regarding this part in your mail:
>
>>> push_mpls_lse() isn't documented as putting the new MPLS label before or
>>> after the existing labels, but it appears to me that it puts the new
>>> label after the
On Tue, Jan 22, 2013 at 03:41:37PM -0800, Ben Pfaff wrote:
> On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> > On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> > > This patch implements use-space datapath and non-datapath code
> > > to match and use the datapath API set
t;
To: "Ben Pfaff"
Cc: dev@openvswitch.org, "Isaku Yamahata" , "Ravi K"
Sent: Wednesday, January 23, 2013 9:43:58 PM
Subject: Re: [ovs-dev] [PATCH 01/16] User-Space MPLS actions and matches
On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> On Fri, Jan 18, 2
On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> > This patch implements use-space datapath and non-datapath code
> > to match and use the datapath API set out in Leo Alterman's patch
> > "user-space datapath: Add basic MPL
On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> > > parse_l3_onward() could use flow_innermost_dl_type() since that's what
> > > it's effectively calculating as 'dl_type' (maybe it should be
> > > 'inner_dl_type' or 'inn
On Tue, Jan 22, 2013 at 10:47:17AM -0800, Ben Pfaff wrote:
> On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> > This patch implements use-space datapath and non-datapath code
> > to match and use the datapath API set out in Leo Alterman's patch
> > "user-space datapath: Add basic MPL
On Tue, Jan 22, 2013 at 09:27:14AM +0900, Simon Horman wrote:
> On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> > On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote:
> > > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
>
> [snip]
>
> > > > parse_l3_onward() c
On Fri, Jan 18, 2013 at 09:27:55AM +0900, Simon Horman wrote:
> This patch implements use-space datapath and non-datapath code
> to match and use the datapath API set out in Leo Alterman's patch
> "user-space datapath: Add basic MPLS support to kernel".
I'm resuming my review starting from packets
On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote:
> > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
[snip]
> > > parse_l3_onward() could use flow_innermost_dl_type() since that's what
> > > it's effectively c
On Thu, Jan 17, 2013 at 11:22:56AM -0800, Jesse Gross wrote:
> On Thu, Jan 17, 2013 at 10:18 AM, Ben Pfaff wrote:
> > On Thu, Jan 17, 2013 at 09:16:36AM -0800, Jesse Gross wrote:
> >> On Wed, Jan 16, 2013 at 8:54 PM, Simon Horman wrote:
> >> It is. However, my understanding is that you were plan
On Thu, Jan 17, 2013 at 10:18 AM, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 09:16:36AM -0800, Jesse Gross wrote:
>> On Wed, Jan 16, 2013 at 8:54 PM, Simon Horman wrote:
>> It is. However, my understanding is that you were planning on
>> following Ben's suggestion to try to get the userspace por
On Thu, Jan 17, 2013 at 09:16:36AM -0800, Jesse Gross wrote:
> On Wed, Jan 16, 2013 at 8:54 PM, Simon Horman wrote:
> It is. However, my understanding is that you were planning on
> following Ben's suggestion to try to get the userspace portions in
> first. In that case, there is no userspace/ke
On Wed, Jan 16, 2013 at 8:54 PM, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 07:04:06PM -0800, Jesse Gross wrote:
>> On Wed, Jan 16, 2013 at 4:27 PM, Simon Horman wrote:
>> > On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
>> >> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
>
On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote:
> On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > > index 5e32965..b421753 1006
On Wed, Jan 16, 2013 at 07:04:06PM -0800, Jesse Gross wrote:
> On Wed, Jan 16, 2013 at 4:27 PM, Simon Horman wrote:
> > On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> >> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> >> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horma
On Wed, Jan 16, 2013 at 4:31 PM, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
>> > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
>> > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
>> >
>> > For the PUSH/POP actions I think we also have the sa
On Wed, Jan 16, 2013 at 4:27 PM, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
>> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
>> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
>> >> diff --git a/include/linux/openvswitch.h b/include/lin
On Wed, Jan 16, 2013 at 04:31:31PM -0800, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
> > > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
> > > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
> > >
> > > For the PUSH/POP actions I think we als
On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
> > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
> > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
> >
> > For the PUSH/POP actions I think we also have the same issue with
> > inserting in the middle of the list an
On Wed, Jan 16, 2013 at 03:49:00PM -0800, Ben Pfaff wrote:
> On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> > On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > >> diff --git a/include/linux/openvswitch.h b/inc
On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> >> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> >> index 5e32965..b421753 100644
> >> --
On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> >> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> >> index 5e32965..b421753 100644
> >> --
On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>> index 5e32965..b421753 100644
>> --- a/include/linux/openvswitch.h
>> +++ b/include/linux/openvswitch.h
>>
On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > index 5e32965..b421753 100644
> > --- a/include/linux/openvswitch.h
> > +++ b/include/linux/openv
On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 5e32965..b421753 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -282,6 +282,7 @@ enum ovs_key_attr {
> OVS_KEY_AT
32 matches
Mail list logo
