On Tue, Jan 22, 2013 at 09:27:14AM +0900, Simon Horman wrote: > On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote: > > On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote: > > > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote: > > [snip] > > > > > parse_l3_onward() could use flow_innermost_dl_type() since that's what > > > > it's effectively calculating as 'dl_type' (maybe it should be > > > > 'inner_dl_type' or 'innermost_dl_type'). > > > > I'm not so sure about this. > > > > flow_innermost_dl_type(), in its current incantation, is used to > > obtain the innermost dl_type of a struct flow. In other words, > > it reads flow->encap_dl_type. > > > > On the other hand, parse_l3_onward() may write flow->encap_dl_type > > and never reads it.
OK, I'll have another look at this. > > > > It's getting late here so I'll resume looking at this patch starting at > > > > lib/packets.c next chance I get. > > Hi Ben, > > With the exception of your above suggestion regarding parse_l3_onward() > I believe that v2.16 of the MPLS series addresses all of the concerns > raised by you and Jesse in relation to v2.14. I'm wondering if you > could find some time to look at lib/packets.c and beyond. I'm continuing to review it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
