On Wed, Jan 16, 2013 at 04:31:31PM -0800, Ben Pfaff wrote: > On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote: > > > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using > > > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS. > > > > > > For the PUSH/POP actions I think we also have the same issue with > > > inserting in the middle of the list and can use the same solution. > > > > I'm unsure what "inserting in the middle of the list" refers to. > > I think Jesse just means that you shouldn't add a new enum value in > a way that changes existing enum values. (Took me a minute too.)
Oh yes, of course. I'll move the PUSH/POP values to the end. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
