On 3 November 2016 at 03:33, Stephen Finucane wrote:
> On 2016-11-02 17:57, Joe Stringer wrote:
>>
>> On 30 October 2016 at 06:29, Stephen Finucane wrote:
>>>
>>> This is the third conversion series. This one is larger yet again,
>>> though many of th
series needs a rebase against latest master. Is
this series also available via git somewhere? That would make it a
little easier for me to base my change on top.
Thanks again for your heroic efforts on this rST/sphinx work!
Joe
___
dev mailing list
de
On 1 November 2016 at 11:35, Pravin B Shelar wrote:
> The compat vlan code ignores vlan tag for inner packet
> on egress path. Following patch fixes this by inserting the
> tag for inner packet before tunnel encapsulation.
>
> Signed-off-by: Pravin B Shelar
Acked-b
On 1 November 2016 at 10:48, Pravin Shelar wrote:
> On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote:
>> On 31 October 2016 at 22:00, Pravin B Shelar wrote:
>>> The compat vlan code ignores vlan tag for inner packet
>>> on egress path. Following patch fixes this b
On 31 October 2016 at 22:00, Pravin B Shelar wrote:
> The compat vlan code ignores vlan tag for inner packet
> on egress path. Following patch fixes this by inserting the
> tag for inner packet before tunnel encapsulation.
>
> Signed-off-by: Pravin B Shelar
Is this a problem upstream and for oth
s closed vxlan socket is freed. This
> operation can race with vxlan-xmit function which
> dereferences vxlan socket. Following patch uses RCU
> mechanism to avoid this situation.
>
> Signed-off-by: Pravin B Shelar
> Signed-off-by: David S. Miller
>
>
On 31 October 2016 at 14:33, Ben Pfaff wrote:
> On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote:
>> On 31 October 2016 at 13:23, Ben Pfaff wrote:
>> > Some datapaths do not support the ct action, and others support only a
>> > subset of its featur
t it's more clear than just OpenFlow hexdumps
telling you "OFPBAC". Maybe it should either say this, or this should
be mentioned in the FAQ.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
this situation.
>
> Signed-off-by: Pravin B Shelar
Thanks, one style comment below. Otherwise:
Acked-by: Joe Stringer
> @@ -442,11 +449,13 @@ static int lisp_open(struct net_device *dev)
> struct lisp_dev *lisp = netdev_priv(dev);
> struct udp_tunnel_sock_cfg tunnel_
B Shelar
> Acked-by: John W. Linville
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 29 October 2016 at 21:33, Pravin B Shelar wrote:
> Upstream commit:
> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca
> Author: pravin shelar
> Date: Fri Oct 28 09:59:15 2016 -0700
>
> vxlan: avoid using stale vxlan socket.
>
> When vxlan device is closed vxlan socket is
On 21 October 2016 at 11:37, Joe Stringer wrote:
> On 21 October 2016 at 10:55, Pravin B Shelar wrote:
>> On upstream kernel datapath OVS make use of networking devices
>> where networking stack does check if device is UP. following
>> patch adds same check in cas
until output and
proceeds past this check before the reconfiguration thread clears it.
Probably the type of test to check this would be running heavy traffic
through a vxlan port, then toggle the port up and down.
Will you also check upstream?
Anyway, this LGTM so:
Acked-by: Joe Stringer
On 19 October 2016 at 11:27, Pravin B Shelar wrote:
> On upstream kernel datapath OVS make use of networking devices
> where networking stack does check if device is UP. following
> patch adds same check in case of compat tunneling implementation.
> This check also fixes kernel crash in case vxlan
On 14 October 2016 at 07:37, Bhanuprakash Bodireddy
wrote:
> Aligning the 'keys' array seems to have positive performance impact.
>
> Signed-off-by: Bhanuprakash Bodireddy
> Co-authored-by: Antonio Fischetti
> Signed-off-by: Antonio Fischetti
> Acked-by: Daniele Di Proietto
It looks like the
On 18 October 2016 at 05:31, Eric Garver wrote:
> On Mon, Oct 17, 2016 at 05:17:44PM -0700, Joe Stringer wrote:
>> On 23 September 2016 at 12:16, Eric Garver wrote:
>> > This series adds 802.1ad test cases for the check-* make targets. It is
>> > meant as a coun
On 23 September 2016 at 12:16, Eric Garver wrote:
> Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
>
> Signed-off-by: Eric Garver
> # ADD_OVS_TUNNEL([type], [bridge], [port], [remote-addr], [overlay-addr])
> #
> # Add an ovs-based tunnel device in the root namespace, with name
On 23 September 2016 at 12:16, Eric Garver wrote:
> This series adds 802.1ad test cases for the check-* make targets. It is
> meant as a counterpart to the 802.1ad work currently going on and being
> discussed on the dev list.
>
> User space support for 802.1ad is being worked on by Xiao Liang (ba
On 6 October 2016 at 11:51, Ben Pfaff wrote:
> On Thu, Oct 06, 2016 at 11:33:39AM +0900, Joe Stringer wrote:
>> This warning breaks the build on travis:
>> lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared.
>> Should it be static?
>>
a lookup table")
Signed-off-by: Joe Stringer
---
lib/json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/json.c b/lib/json.c
index e052a6a0af0d..40c8f718db72 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -1624,7 +1624,7 @@ json_serialize_array(const struct json_a
viously discussed
* Testing - we may want a mode where tc flower is used in software
mode, to test the tc netlink interface. It would be good to see
extension of kernel module testsuite to at least test some basics of
the interface, perhaps also the flower behaviour (though that may be
out of sco
On 2 October 2016 at 04:01, Stephen Finucane wrote:
> This is essentially the output of 'sphinx-quickstart' but with parts of
> the Makefile merged into the existing Makefile.am and a license added
> to the index.rst file.
>
> Signed-off-by: Stephen Finucane
> ---
> I need to know who to assign c
On 28 September 2016 at 16:21, Joe Stringer wrote:
> On 28 September 2016 at 14:22, Daniele Di Proietto
> wrote:
>> Thanks for doing this cleanup, my instant revalidation series should be much
>> simpler after this.
>>
>> It looks like this needs rebasing, but i
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
> Thanks for doing this cleanup, my instant revalidation series should be much
> simpler after this.
>
> It looks like this needs rebasing, but it is pretty trivial
>
> I've gone through the code, I only have a couple minor of comments abou
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
>
>
> 2016-09-20 18:47 GMT-07:00 Joe Stringer :
>>
>> To make more of the core revalidate() functions do just one thing and
>> not modify state on the way, refactor them to prepare the xcache then
>> defe
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
> Is there any reason not to squash this with the previous patch?
It was an attempt at separating functional changes from cosmetic.
> If you want to keep two commits for clarity I would split it like:
>
> commit1) move the block above odp
On 27 September 2016 at 14:40, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks, applied to master. It doesn't apply cleanly to branch-2.6, so
I don't plan to backport it unless you feel strongly about that.
___
dev mailing list
dev@openvswitc
On 8 June 2016 at 13:49, Daniele Di Proietto wrote:
>
>
>
>
>
> On 08/06/2016 13:30, "Ben Pfaff" wrote:
>
>>On Wed, Jun 08, 2016 at 01:07:32PM -0700, Ben Pfaff wrote:
>>> On Wed, Jun 01, 2016 at 07:23:29PM -0700, Daniele Di Proietto wrote:
>>> > linux/in.h (from linux uapi headers) carries many o
ahalme
LGTM, minor spelling below. Thanks.
Acked-by: Joe Stringer
> ---
> lib/ofp-actions.c | 7 +--
> tests/ofproto-dpif.at | 40
> tests/ovs-ofctl.at| 46 +++---
> 3 files chan
On 27 September 2016 at 14:32, Jarno Rajahalme wrote:
> Datapath flow setup fails when setting the FTP helper on an
> unsupported IP protocol. It is better to fail at the OpenFlow rule
> set-up time instead.
>
> Signed-off-by: Jarno Rajahalme
Acked-b
On 27 September 2016 at 14:32, Jarno Rajahalme wrote:
> Replace a tab by a space and remove an unnecessary variable.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On 21 September 2016 at 14:01, Joe Stringer wrote:
> On 21 September 2016 at 11:44, Lance Richardson wrote:
>>> From: "Joe Stringer"
>>> To: dev@openvswitch.org
>>> Sent: Wednesday, September 21, 2016 2:36:42 PM
>>> Subject: [ovs-d
Hi David,
Thanks for the submission. Since this is a bugfix for a long-running
behaviour, I reduced the patch to just the functional changes and
applied it to master, branch-2.6 and branch-2.5.
Here's the final change, please let me know if it is still missing something:
https://github.com/openvs
On 26 September 2016 at 18:46, Jarno Rajahalme wrote:
> Setting up a datapath flow that has a conntrack action with 'alg=ftp',
> but does not match on 'nw_proto=tcp' fails with 'WARN' in
> ovs-vswitchd.log. It is better to flag such inconsistencies during
> OpenFlow rule set-up time. Also, connt
On 26 September 2016 at 07:13, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
> INSTALL.md | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/INSTALL.md b/INSTALL.md
> index bb40e4a..a9b70db 100644
> --- a/INSTALL.md
> +++ b/INSTALL
On 26 September 2016 at 13:24, Pravin B Shelar wrote:
> Fixes test failure seen due to the IPsec tunnel deprecation
> messages in test logs.
>
> Fixes: 9e9d0384910e ("openvswitch: deprecates support for IPsec tunnel
> port.").
> Reported-by: Joe Stringer
> Signed-
On 23 September 2016 at 12:13, Justin Pettit wrote:
>
>> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote:
>>
>> On 23 September 2016 at 01:53, Justin Pettit wrote:
>>>
>>> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
>
On 23 September 2016 at 06:25, Ansis Atteka wrote:
>
>
> On 23 September 2016 at 03:25, Joe Stringer wrote:
>>
>> ovs-lib creates several directories directly from the script, but
>> doesn't make any attempt to ensure that the correct SELinux context is
>&
On 23 September 2016 at 01:53, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> NEWS | 1 +
> debian/changelog | 10 ++
> include/openflow/nicira-ext.h | 9 +
> include/openvswitch/ofp-msgs.h | 4
> lib/dpif.c
On 23 September 2016 at 05:51, Eric Garver wrote:
> On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote:
>> On 14 September 2016 at 17:26, Eric Garver wrote:
>> > Signed-off-by: Eric Garver
>>
>> Hi Eric,
>>
>> I tried this series again on a va
On 14 September 2016 at 17:26, Eric Garver wrote:
> Signed-off-by: Eric Garver
Hi Eric,
I tried this series again on a variety of kernels and these initial
ping over cvlan tests are failing for check-system-userspace on older
kernels (3.10,3.13) due to reasons we had discussed a bit on the
prev
On 22 September 2016 at 12:55, Ansis Atteka wrote:
> On Thu, Sep 22, 2016 at 3:54 AM, Joe Stringer wrote:
>> ovs-lib creates several directories directly from the script, but
>> doesn't make any attempt to ensure that the correct SELinux context is
>> applied to thes
actice, many of these should otherwise be
handled by packaging scripts but if they exist then we should ensure the
correct SELinux context is set.
On systems where 'restorecon' is unavailable, this should be a no-op.
VMware-BZ: #1732672
Signed-off-by: Joe Stringer
Acked-by: Ansis Att
actice, many of these should otherwise be
handled by packaging scripts but if they exist then we should ensure the
correct SELinux context is set.
On systems where 'restorecon' is unavailable, this should be a no-op.
VMware-BZ: #1732672
Signed-off-by: Joe Stringer
---
Fortunately, th
On 19 September 2016 at 11:18, Ben Pfaff wrote:
> On Thu, Sep 15, 2016 at 04:26:05PM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>
> ...
>
>> + * When using the openvswitch module distributed with OVS against kernel
>> + versions 4.4-4.6, th
On 21 September 2016 at 11:44, Lance Richardson wrote:
>> From: "Joe Stringer"
>> To: dev@openvswitch.org
>> Sent: Wednesday, September 21, 2016 2:36:42 PM
>> Subject: [ovs-dev] [PATCH] travis: Work around glibtoolize error.
>>
>> Signed-off-by: J
Signed-off-by: Joe Stringer
---
.travis/osx-prepare.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.travis/osx-prepare.sh b/.travis/osx-prepare.sh
index cf46d872edfa..611c0709d760 100755
--- a/.travis/osx-prepare.sh
+++ b/.travis/osx-prepare.sh
@@ -1,3 +1,5 @@
#!/bin/bash
set -ev
On 30 August 2016 at 18:47, Daniele Di Proietto wrote:
> Sometimes the ofproto layer creates a flow which is not liked by the
> revalidation for various reasons. This behavior, while not critical
> might impact the performance. This commit adds a facility to detect
> this issue early and log a w
Simplify the remaining bits of the original revalidation codepath to
only handle the "full-revalidation" case. Make the 'ukey' parameter
purely const by pushing the only piece that gets changed into a separate
argument.
Signed-off-by: Joe Stringer
---
ofproto/ofprot
prepared and
attached to the ukey, but the actual execution will be skipped since it
will be executed on flow_delete very soon anyway with final stats.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 56 ---
1 file changed, 42 insertions
Shift the early-exit conditions for revalidation into a separate
function.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 136 --
1 file changed, 78 insertions(+), 58 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto
This code was already very similar to the actual revalidation code, but
previously it wasn't structured quite closely enough to share it. Do so.
xlate_actions_for_side_effects() is now unused, so remove it.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c
Refactor the newly introduced xlate_ukey() function to just perform the
translation, not modify the ukey.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/ofproto/ofproto-dpif
de from the delete path is now shared with the dump path. The
code is longer overall, but hopefully it's a bit easier to follow.
Joe Stringer (6):
revalidator: Refactor ukey->xout translation.
revalidator: Don't modify ukey from xlate_ukey().
revalidator: Refactor revalidation
This patch shifts the code that directly calls xlate into a separate
function, xlate_ukey().
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 110 --
1 file changed, 73 insertions(+), 37 deletions(-)
diff --git a/ofproto/ofproto-dpif
0,
> is_backup=0xffefff2de) at ovsdb/ovsdb-server.c:198
> #12 0x000000406edb in main (argc=1, argv=0xffefff550)
> at ovsdb/ovsdb-server.c:429
>
> Reported-by: Joe Stringer
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079315.
On 16 September 2016 at 07:41, David Hill wrote:
> Hello guys,
>
>Our preliminary tests seems to indicate this solves the issue with the
> ixgbe driver. My fear is now that other drivers might show the same
> behavior. Patching ovs to fallback to ethtool is a good way to avoid this
> imho.
Signed-off-by: Joe Stringer
---
Pravin, does the GRE note look correct?
---
NEWS | 19 +++
1 file changed, 19 insertions(+)
diff --git a/NEWS b/NEWS
index 8c78b3676cf3..19570b96816f 100644
--- a/NEWS
+++ b/NEWS
@@ -124,6 +124,25 @@ v2.6.0 - xx xxx
- Add 'mtu_re
ting bits of using sparse, but on the whole I
> think it saves us pretty often.
>
> CC: Jarno Rajahalme
> Fixes: 6dd3c787f591 ("ofproto: Support packet_outs in bundles.")
> Signed-off-by: Ben Pfaff
Acked-by: Joe Stringer
__
On 14 September 2016 at 20:39, Ben Pfaff wrote:
> If the socket length does not include any of the bytes of the path, then
> the code should not read even the first byte of the path.
>
> Found by valgrind.
>
> CC: Thadeu Lima de Souza Cascardo
> Reported-by: Joe Stringer
On 13 September 2016 at 08:46, Thadeu Lima de Souza Cascardo
wrote:
> Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses
> Linux 3.16.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Thanks. It was also missing uuid-runtime which stopped the install_deb
target from wor
On 12 September 2016 at 14:55, Jesse Gross wrote:
> On Mon, Sep 12, 2016 at 2:48 PM, Pravin B Shelar wrote:
>> This allows openvswitch and geneve module co-exist kernel on newer
>> kernels.
>>
>> Reported-by: Joe Stringer
>> Signed-off-by: Pravin B Shelar
&
On 10 September 2016 at 21:26, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:48:53PM -0700, Joe Stringer wrote:
>> Valgrind reports:
>>
>> ==18725== 32 bytes in 1 blocks are definitely lost in loss record 339 of 497
>> ==18725==at 0x4C29BBE: malloc (in
>> /us
On 10 September 2016 at 21:24, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:48:52PM -0700, Joe Stringer wrote:
>> By placing these nodes at the start of their respective structures,
>> several "possibly lost" warnings from valgrind are silenced.
>>
>> Fix
0x418185: process_notification (replication.c:576)
> ==18725==by 0x417705: replication_run (replication.c:185)
> ==18725==by 0x408240: main_loop (ovsdb-server.c:198)
> ==18725==by 0x406432: main (ovsdb-server.c:429)
>
> I don't know the exact cause of the problem, b
On 12 September 2016 at 03:57, Thadeu Lima de Souza Cascardo
wrote:
> On Fri, Sep 09, 2016 at 06:44:21PM -0700, Joe Stringer wrote:
>> On 9 September 2016 at 14:09, Thadeu Lima de Souza Cascardo
>> wrote:
>> > Now, vagrant up will test both Fedora 23 and Debian Jessie
On 9 September 2016 at 14:09, Thadeu Lima de Souza Cascardo
wrote:
> Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses
> Linux 3.16.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
> ---
> Vagrantfile | 44 ++--
> 1 file changed
On 8 September 2016 at 08:49, Jesse Gross wrote:
> On Wed, Sep 7, 2016 at 5:18 PM, Joe Stringer wrote:
>> On 1 September 2016 at 18:08, Jesse Gross wrote:
>>> On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer wrote:
>>>> The upstream code uses NF_INET_PRE_ROUTIN
On 9 September 2016 at 14:05, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote:
>> On 19 July 2016 at 20:08, Ben Pfaff wrote:
>> > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo
>> > wrote:
>>
On 8 September 2016 at 21:23, Ben Pfaff wrote:
> On Tue, Sep 06, 2016 at 10:59:19AM -0700, Joe Stringer wrote:
>> In the new test I'm seeing OVSDB segfault:
>>
>> #0 0x004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
>>type=0x10c29e8) at
ain (ovsdb-server.c:429)
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
This addresses the crash, but I don't understand the deeper reasoning
why we get into this state in the first place so I welcome any counter
proposals.
Th
0x44FFB6: unixctl_server_run (unixctl.c:400)
==18725==by 0x4081AC: main_loop (ovsdb-server.c:182)
==18725==by 0x406432: main (ovsdb-server.c:429)
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
This also affects branch-2.6.
By placing these nodes at the start of their respective structures,
several "possibly lost" warnings from valgrind are silenced.
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
Also affects branch-2.6.
---
ovsdb/jsonrpc-se
ighted a segfault, a memory
leak and some other warnings about "possibly lost" memory. This series
addresses these particular issues.
There's a couple of "possible loss" warnings for this test that I didn't
address here, because they look less likely to cause problems in
On 19 July 2016 at 20:08, Ben Pfaff wrote:
> On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote:
>> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix
>> STREAM socket. The current code will assume it means a sun_path larger than
>> 0.
>>
>> T
On 9 September 2016 at 08:55, Ben Pfaff wrote:
> Our previously announced plan for OVS 2.6 is to release on Sept. 15, in
> less than a week. In the OVN meeting in IRC yesterday, we already
> discussed a few OVN bugs that should be fixed before the release. All
> of them seem like they can be fix
On 8 September 2016 at 12:34, Guru Shetty wrote:
> On 29 August 2016 at 12:11, Paul Boca wrote:
>
>> In user mode the flags are interpreted as little endian.
>> This fix makes the kernel mode compatible with user mode.
>>
>> Signed-off-by: Paul-Daniel Boca
>>
> Applied, thank you.
Does this nee
On 1 September 2016 at 18:08, Jesse Gross wrote:
> On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer wrote:
>> The upstream code uses NF_INET_PRE_ROUTING hook for the nf_conntrack_in()
>> call, which does deeper (eg l4proto) validation. It was previously
>> thought that using the
of the code may be
reused and shared rather than copying/pasting. As a result, the
differences between tests are easier to identify.
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 218 ++--
1 file changed, 81 insertions(+), 137 deletions
ed to master.
I plan to follow up shortly to reduce copy/paste in these tests and
clarify what "FTP with NAT 2" means.
>> On Sep 7, 2016, at 2:07 PM, Joe Stringer wrote:
>>
>> The existing FTP with NAT tests all perform NATing from an IP like
>> 10.1.1.1 -> 10.1.1
een IPs that do not change the message length
in FTP control messages (eg, 10.1.1.1 -> 10.1.1.9) to more clearly
identify failures in this area.
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 83 +++--
1 file changed, 81 insertions(+), 2 del
On 2 September 2016 at 17:43, Jarno Rajahalme wrote:
> Bridges might get deleted while revalidation is going through the
> xlate cache entries. Thus we need to do the xbridge lookup before we
> use the xlate cache, and use uuid's instead of pointers on xlate cache
> entries that might refer to ot
In the new test I'm seeing OVSDB segfault:
#0 0x004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
type=0x10c29e8) at ../lib/ovsdb-data.c:1626
1626if (a->n != b->n) {
(gdb) bt
#0 0x004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
type=0x10c29e8) at .
> or `ifconfig`), but this seems the best way to remain compatible with
>> old users while providing a more powerful interface.
>>
>> Suggested-by: Darrell Ball
>> Signed-off-by: Daniele Di Proietto
>
> Thanks for taking care of all of this.
>
> For bot
her workarounds.
Reported-by: Jesse Gross
Signed-off-by: Joe Stringer
---
datapath/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/conntrack.c b/datapath/conntrack.c
index ddfb0c42b379..a2fc450edc05 100644
--- a/datapath/conntrack.c
+++ b/datapath/conntrac
On 31 August 2016 at 09:58, Ben Pfaff wrote:
> On Wed, Aug 31, 2016 at 09:33:24AM -0700, Amitabha Biswas wrote:
>> Fixes: 19cd0a87
>>
>> Signed-off-by: Amitabha Biswas
>> Acked-by: Numan Siddique
>
> Thanks, applied to master.
I think this was affecting branch-2.6 as well:
https://travis-ci.or
On 1 September 2016 at 13:14, Lance Richardson wrote:
> Support "make check-kernel RECHECK=yes", similar to existing support
> for "make check RECHECK=yes".
>
> Signed-off-by: Lance Richardson
Thanks a lot, applied to master and branch-2.6 .
___
dev ma
On 1 September 2016 at 13:14, Lance Richardson wrote:
> Add ability to execute kernel datapath tests when building rpms.
> These tests are disabled by default, and can optionally be run
> by providing "--with check_datapath_kernel" on the rpmbuild command
> line. This is intended to facilitate au
On 31 August 2016 at 11:06, Joe Stringer wrote:
> Recent bugs[1] have highlighted a particular situation where we may handle
> significant traffic in userspace via the upcall mechanism either due to flow
> table changes, or when bugs in translation logic result in unexpected dele
On 31 August 2016 at 14:52, Daniele Di Proietto wrote:
> Open vSwitch controls the MTU of internal ports and sets it to the
> minimum of physical ports MTU on the same bridge.
>
> Commit 47bf118665a3("ofproto: Always set MTU for new internal ports.")
> made this more consistent. Now the MTU is al
On 31 August 2016 at 13:18, Jarno Rajahalme wrote:
> With a minor question below,
>
> Acked-by: Jarno Rajahalme
>
>> On Aug 31, 2016, at 11:06 AM, Joe Stringer wrote:
>>
>> If a revalidator dumps/revalidates a flow during the 'dump' phase,
>> re
On 31 August 2016 at 13:17, Jarno Rajahalme wrote:
> With small nits below,
>
> Acked-by: Jarno Rajahalme
Thanks, I also noticed a couple of VLOGs missing their ratelimiters.
>> @@ -334,9 +345,9 @@ static int ukey_create_from_dpif_flow(const struct udpif
>> *,
>>
On 31 August 2016 at 13:16, Jarno Rajahalme wrote:
> With one question below,
>
> Acked-by: Jarno Rajahalme
Thanks for the review,
>> On Aug 31, 2016, at 11:06 AM, Joe Stringer wrote:
>>
>> Currently when processing a batch of upcalls, all datapath operations
>
On 30 August 2016 at 13:45, Lance Richardson wrote:
> Add a test case to check connectivity over an OVS bond, using a
> Linux bond over veth interfaces.
>
> Also added a new macro "ADD_VETH_BOND", modeled after "ADD_VETH",
> in anticipation of future additional bonding test cases.
>
> Signed-off-b
tp://openvswitch.org/pipermail/dev/2016-August/078855.html
Joe Stringer (4):
upcall: Reuse flow_put initializer.
upcall: Only init flow_put if ukey is installed.
upcall: Track ukey states.
upcall: Replace ukeys for deleted flows.
ofproto/ofproto-dpif-upcall.c | 208 +++---
x27;s a little simpler to only initialize the datapath operation if the
ukey could actually be installed. The locks are held longer, but these
locks aren't heavily contended and the extended holding of the lock will
be removed in a subsequent patch anyway.
Signed-off-by: Joe Stringer
---
v2:
raffic flow to return
to the fastpath.
Signed-off-by: Joe Stringer
---
v2: Rebase against ukey lifecycle patch.
---
ofproto/ofproto-dpif-upcall.c | 32
1 file changed, 32 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
Signed-off-by: Joe Stringer
---
v2: First post
---
ofproto/ofproto-dpif-upcall.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index e4473080ad65..e7fcdd28c9ff 100644
--- a/ofproto
of the current code, and also make
the following patch easier to reason about.
Signed-off-by: Joe Stringer
---
v2: First post.
---
ofproto/ofproto-dpif-upcall.c | 140 --
1 file changed, 94 insertions(+), 46 deletions(-)
diff --git a/ofproto/ofproto-
On 26 August 2016 at 02:13, Simon Horman wrote:
> On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote:
>> On 25 August 2016 at 03:08, Simon Horman wrote:
>> > Please find my working patch below.
>> >
>> > From: Simon Horman
>> >
1 - 100 of 2046 matches
Mail list logo
