In the new test I'm seeing OVSDB segfault:
#0 0x00000000004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
type=0x10c29e8) at ../lib/ovsdb-data.c:1626
1626 if (a->n != b->n) {
(gdb) bt
#0 0x00000000004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
type=0x10c29e8) at ../lib/ovsdb-data.c:1626
#1 0x0000000000431388 in ovsdb_datum_equals (a=0x10ebaa0, b=0x0,
type=0x10c29e8)
at ../lib/ovsdb-data.c:1616
#2 0x00000000004117cd in update_monitor_row_data (mt=0x10eab60,
row=0x10eba40,
data=0x0) at ../ovsdb/monitor.c:310
#3 0x0000000000413796 in ovsdb_monitor_changes_update (old=0x0,
new=0x10eba40,
mt=0x10eab60, changes=0x10ec630) at ../ovsdb/monitor.c:1255
#4 0x00000000004139ec in ovsdb_monitor_change_cb (old=0x0, new=0x10eba40,
changed=0x10eb908, aux_=0x7ffe4c7803c0) at ../ovsdb/monitor.c:1339
#5 0x000000000041c2c1 in ovsdb_txn_for_each_change (txn=0x10ebdd0,
cb=0x4138be <ovsdb_monitor_change_cb>, aux=0x7ffe4c7803c0)
at ../ovsdb/transaction.c:906
#6 0x000000000041431f in ovsdb_monitor_commit (replica=0x10ec060,
txn=0x10ebdd0,
durable=false) at ../ovsdb/monitor.c:1553
#7 0x000000000041c124 in ovsdb_txn_commit_ (txn=0x10ebdd0, durable=false)
at ../ovsdb/transaction.c:868
#8 0x000000000041c219 in ovsdb_txn_commit (txn=0x10ebdd0, durable=false)
at ../ovsdb/transaction.c:893
#9 0x0000000000415b3f in process_notification (table_updates=0x10c3380,
db=0x10c3220) at ../ovsdb/replication.c:576
#10 0x0000000000414b5e in replication_run () at ../ovsdb/replication.c:185
#11 0x00000000004058a1 in main_loop (jsonrpc=0x10be2b0,
all_dbs=0x7ffe4c7806a0,
unixctl=0x10e9b60, remotes=0x7ffe4c780740, run_process=0x0,
exiting=0x7ffe4c7806ff, is_backup=0x7ffe4c78070f)
at ../ovsdb/ovsdb-server.c:198
#12 0x00000000004062d8 in main (argc=1, argv=0x7ffe4c7808f8)
at ../ovsdb/ovsdb-server.c:429
On 3 September 2016 at 21:39, Andy Zhou <az...@ovn.org> wrote:
> On Fri, Sep 2, 2016 at 1:55 PM, Ben Pfaff <b...@ovn.org> wrote:
>
>> On Wed, Aug 31, 2016 at 07:32:41PM -0700, Andy Zhou wrote:
>> > Added the '--no-sync' option base on feedbacks of current
>> > implementation.
>> >
>> > Added appctl command "ovsdb-server/sync-status" based on feedbacks
>> > of current implementation.
>> >
>> > Added the RPL_S_INIT state in the state machine. This state is
>> > not strictly necessary for the replication state machine, but is
>> > introduced to make sure the state is update immediately when
>> > the state machine is reset, via replication_init(). Without it
>> > ovsdb/sync-status may display "replicating" or crash, if the command
>> > is issued between after replication_init() is called, but before
>> > the state variable is updated from replication_run().
>> >
>> > Added a test to simulate the integration of HA manager with OVSDB
>> > server using replication.
>> >
>> > Other documentation and API improvements.
>> >
>> > Tested-by: Numan Siddique <nusid...@redhat.com>
>> > Signed-off-by: Andy Zhou <az...@ovn.org>
>>
>> Thanks for working on this.
>>
>> Until I read the documentation fairly carefully, I was a bit mystified
>> by --no-sync. I don't like negative forms very much to start out with,
>> but it also wasn't clear why I'd want to specify where to sync from but
>> not to sync. Then I figured out that it's really just saying to start
>> in active mode.
>>
>> So I'd suggest renaming --no-sync to --active.
>>
>
> Thanks Ben for the review. I have folded in your suggestions and pushed to
> master. Also back ported the whole series to branch 2.6.
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
