Re: [ovs-dev] [PATCH v4] Add configurable OpenFlow port name.

2016-10-21 Thread Xiao Liang
On Fri, Oct 21, 2016 at 1:46 AM, Flavio Leitner wrote: > On Tue, Jun 14, 2016 at 10:53:36AM +0800, Xiao Liang wrote: >> On Mon, Jun 6, 2016 at 9:35 AM, Ben Pfaff wrote: >> > On Sun, Jun 05, 2016 at 12:57:02AM +0800, Xiao Liang wrote: >> >> On Sat, Jun 4, 201

Re: [ovs-dev] [RFC PATCH v5] Add support for 802.1ad (QinQ tunneling)

2016-10-16 Thread Xiao Liang
ually, without setting up a flow in the kernel. Is there an example? Thanks, Xiao On Wed, Oct 5, 2016 at 4:08 AM, Ben Pfaff wrote: > On Wed, Sep 14, 2016 at 12:34:36PM +0800, Xiao Liang wrote: >> Flow key handleing changes: >> - Add VLAN header array in struct flow, to record

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-09-09 Thread Xiao Liang
On Fri, Sep 9, 2016 at 6:18 PM, Mooney, Sean K wrote: > > >> -Original Message----- >> From: Xiao Liang [mailto:shaw.l...@gmail.com] >> Sent: Friday, September 9, 2016 5:27 AM >> To: Mooney, Sean K >> Cc: Ben Pfaff ; dev@openvswitch.org >> Subject

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-09-08 Thread Xiao Liang
On Sat, Aug 20, 2016 at 9:41 AM, Mooney, Sean K wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff >> Sent: Friday, August 19, 2016 9:57 PM >> To: Xiao Liang ; dev@openvswitch.org >> Subject: Re:

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-08-06 Thread Xiao Liang
On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote: > Thanks for the replies, I have some further responses below. > > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote: >> On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: >> > I'm concerned about backward

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-30 Thread Xiao Liang
Thanks! I'm working on code changes according to your comments. I think we need more discussion about the ethertype matching. Please see inline. Thanks, Xiao On Thu, Jul 28, 2016 at 2:40 AM, Ben Pfaff wrote: > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: >> Flow

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-26 Thread Xiao Liang
On Tue, Jul 26, 2016 at 12:52 AM, Ben Pfaff wrote: > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: >> Flow key handleing changes: >> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN >> headers. >> - Add dpif multi-VLAN capability pr

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 11:00 PM, Thomas F Herbert wrote: > On 7/15/16 9:08 AM, Xiao Liang wrote: >> >> Thanks a lot. Please see inline. >> >> On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert >> wrote: >>> >>> On 7/2/16 10:17 AM, Xiao Liang

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 10:51 PM, Thomas F Herbert wrote: > On 7/15/16 9:18 AM, Xiao Liang wrote: >> >> On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert >> wrote: >>> >>> On 7/12/16 11:38 AM, Xiao Liang wrote: >>>> >>>> Set d

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert wrote: > On 7/12/16 11:38 AM, Xiao Liang wrote: >> >> Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX >> >> Signed-off-by: Xiao Liang >> --- >> lib/dpif-netdev.c | 1 + >> te

Re: [ovs-dev] [PATCH v4 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert wrote: > On 7/12/16 11:38 AM, Xiao Liang wrote: >> >> When QinQ is supported, ingress VLAN are kept after push_vlan actions, >> so we should expect two VLAN headers. > > Am I reading this wrong but it looks like the 0

Re: [ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
; Eric, please see my comments below. >> >> >> On Tue, Jul 12, 2016 at 11:37:32PM +0800, Xiao Liang wrote: >>> >>> Hi Eric, >>> >>> Nice to hear that we could work together on this feature, and many >>> thanks for you effort. Hop

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
Thanks a lot. Please see inline. On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert wrote: > On 7/2/16 10:17 AM, Xiao Liang wrote: >> >> Hi Tom, >> >> Thanks for your test and comments! Please see inline. >> >> On Sat, Jul 2, 2016 at 1:34 AM, T

Re: [ovs-dev] [PATCH] Add support for 802.1ad (QinQ tunneling)

2016-07-13 Thread Xiao Liang
part to be ready? Thanks, Xiao On Thu, Jul 14, 2016 at 2:35 AM, Carl Baldwin wrote: > On Sat, Jun 25, 2016 at 4:13 AM, Xiao Liang wrote: >> >> Hi, >> >> I'm looking for QinQ support in OVS for some time. And found patches[1-3] >> by Thomas, and Gayath

[ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-12 Thread Xiao Liang
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX Signed-off-by: Xiao Liang --- lib/dpif-netdev.c | 1 + tests/test-odp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 26cfaff..13c10f6 100644 --- a/lib/dpif-netdev.c +++ b

[ovs-dev] [PATCH v4 2/4] tests: Add tests for QinQ VLAN handling

2016-07-12 Thread Xiao Liang
Add dot1q-tunnel ports and ingress packet cases, in ofproto-dpif.at VLAN handling. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 110 +- 1 file changed, 64 insertions(+), 46 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto

[ovs-dev] [PATCH v4 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-12 Thread Xiao Liang
When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 128 +++--- 1 file changed, 70 insertions(+), 58 deletions(-) diff --git a/tests

[ovs-dev] [PATCH v4 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-12 Thread Xiao Liang
check in test-classifier.c Xiao Liang (4): Add support for 802.1ad (QinQ tunneling) tests: Add tests for QinQ VLAN handling tests: Adjust VLAN+MPLS handling cases for QinQ tests: Set default max_vlan_headers include/openvswitch/flow.h| 13 +- include/openvswitch/ofp-actio

Re: [ovs-dev] [PATCH v3 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-09 Thread Xiao Liang
ated. Supporting them is possible at this time, but may have problems in the future (these ethertypes may be used for other purposes). And it also requires changes in kernel, which is not likely. > > Thanks. > Eric. > > On Sun, Jul 03, 2016 at 08:47:06AM +0800, Xiao Liang wrote: >>

Re: [ovs-dev] [ovs-dev, v3, 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-09 Thread Xiao Liang
; Ethernet type of encapsulated frame. */ > } __attribute__((__packed__)); > > Actually, this structures are logically equal. This collision should be fixed > somehow. > > Best regards, Ilya Maximets. > > On 03.07.2016 03:47, Xiao Liang wrote: >> Flow key handlein

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
On Sat, Jul 2, 2016 at 10:17 PM, Xiao Liang wrote: > Hi Tom, > > Thanks for your test and comments! Please see inline. > > On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert > wrote: >> Xiao, >> >> Thanks. I think this is nice work and I think it advances the b

[ovs-dev] [PATCH v3 2/4] tests: Add tests for QinQ VLAN handling

2016-07-02 Thread Xiao Liang
Add dot1q-tunnel ports and ingress packet cases, in ofproto-dpif.at VLAN handling. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 110 +- 1 file changed, 64 insertions(+), 46 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto

[ovs-dev] [PATCH v3 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-02 Thread Xiao Liang
When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 128 +++--- 1 file changed, 70 insertions(+), 58 deletions(-) diff --git a/tests

[ovs-dev] [PATCH v3 4/4] tests: Set default max_vlan_headers

2016-07-02 Thread Xiao Liang
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX Signed-off-by: Xiao Liang --- lib/dpif-netdev.c | 1 + tests/test-odp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index cbf7b97..a60c88a 100644 --- a/lib/dpif-netdev.c +++ b

[ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
netdev and test-odp (fix test failure found by Tom). Fix loop condition when parsing mask in odp-util.c. Clean up comments. Xiao Liang (4): Add support for 802.1ad (QinQ tunneling) tests: Add tests for QinQ VLAN handling tests: Adjust VLAN+MPLS handling cases for QinQ tests: S

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
Hi Tom, Thanks for your test and comments! Please see inline. On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert wrote: > Xiao, > > Thanks. I think this is nice work and I think it advances the ball. > > It needs to be rebased to latest. I got some fuzz applying the patch. > It fails make check on

[ovs-dev] [RFC PATCH v2 3/3] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-06-25 Thread Xiao Liang
When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 128 +++--- 1 file changed, 70 insertions(+), 58 deletions(-) diff --git a/tests

[ovs-dev] [RFC PATCH v2 2/3] tests: Add tests for QinQ VLAN handling

2016-06-25 Thread Xiao Liang
Add dot1q-tunnel ports and ingress packet cases, in ofproto-dpif.at VLAN handling. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 110 +- 1 file changed, 64 insertions(+), 46 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto

Re: [ovs-dev] [PATCH v4] Add configurable OpenFlow port name.

2016-06-13 Thread Xiao Liang
On Mon, Jun 6, 2016 at 9:35 AM, Ben Pfaff wrote: > On Sun, Jun 05, 2016 at 12:57:02AM +0800, Xiao Liang wrote: >> On Sat, Jun 4, 2016 at 1:15 AM, Ben Pfaff wrote: >> > On Tue, May 24, 2016 at 03:07:23PM +0800, Xiao Liang wrote: >> >> Add new column "ofname&qu

Re: [ovs-dev] [PATCH v4] Add configurable OpenFlow port name.

2016-06-04 Thread Xiao Liang
Thanks for your review! On Sat, Jun 4, 2016 at 1:15 AM, Ben Pfaff wrote: > On Tue, May 24, 2016 at 03:07:23PM +0800, Xiao Liang wrote: >> Add new column "ofname" in Interface table to configure port name reported >> to controllers with OpenFlow protocol, thus decoupl

Re: [ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-05-24 Thread Xiao Liang
On Mon, May 23, 2016 at 9:31 PM, Flavio Leitner wrote: > On Sat, May 14, 2016 at 10:11:32PM +0800, Xiao Liang wrote: >> On Fri, May 13, 2016 at 1:16 AM, Flavio Leitner wrote: >> > On Wed, May 11, 2016 at 10:13:48AM +0800, Xiao Liang wrote: >> >> On Wed, May 11, 2

[ovs-dev] [PATCH v4] Add configurable OpenFlow port name.

2016-05-24 Thread Xiao Liang
ollers can recognize ports by their names. Signed-off-by: Xiao Liang --- v2: Added test for ofname Increased db schema version Updated NEWS v3: Rebase v4: Rebase Move prototypes in ofproto/ofproto.h to correct section --- NEWS | 1 + lib/db-ctl-base.h | 2 +

Re: [ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-05-14 Thread Xiao Liang
On Fri, May 13, 2016 at 1:16 AM, Flavio Leitner wrote: > On Wed, May 11, 2016 at 10:13:48AM +0800, Xiao Liang wrote: >> On Wed, May 11, 2016 at 4:31 AM, Flavio Leitner wrote: >> > On Tue, May 10, 2016 at 10:31:19AM +0800, Xiao Liang wrote: >> >> On Tue, May 10, 2

Re: [ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-05-10 Thread Xiao Liang
On Wed, May 11, 2016 at 4:31 AM, Flavio Leitner wrote: > On Tue, May 10, 2016 at 10:31:19AM +0800, Xiao Liang wrote: >> On Tue, May 10, 2016 at 4:28 AM, Flavio Leitner wrote: >> > On Sat, Apr 23, 2016 at 01:26:17PM +0800, Xiao Liang wrote: >> >> Add new column

Re: [ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-05-09 Thread Xiao Liang
On Tue, May 10, 2016 at 4:28 AM, Flavio Leitner wrote: > On Sat, Apr 23, 2016 at 01:26:17PM +0800, Xiao Liang wrote: >> Add new column "ofname" in Interface table to configure port name reported >> to controllers with OpenFlow protocol, thus decouple OpenFlow port

[ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-04-22 Thread Xiao Liang
ollers can recognize ports by their names. Signed-off-by: Xiao Liang --- v2: Added test for ofname Increased db schema version Updated NEWS v3: Rebase --- NEWS | 1 + lib/db-ctl-base.h | 2 +- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-18 Thread Xiao Liang
On Mon, Apr 18, 2016 at 5:46 PM, Takashi YAMAMOTO wrote: > for some reasons you want to change of_name without re-creating a port? > why? (just curious) > I don't have special use cases, just for convenience. > > On Mon, Apr 18, 2016 at 4:19 PM, Xiao Liang wrote: >>

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-18 Thread Xiao Liang
ovs_name = "foo" > kernel_name = "tap0" > > while i don't have strong opinions either ways, > i'm not sure why you want to use different names for of_name and ovs_name > in the first place. eg. what's wrong with "ovs-vsctl add-port br0 wan

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-17 Thread Xiao Liang
Hi Ben, Yamamoto-san, Kindly remind you of this thread. Would like to hear your preference on the way to implement this feature. On Mon, Apr 11, 2016 at 11:18 PM, Ben Pfaff wrote: > On Mon, Apr 11, 2016 at 04:30:04PM +0800, Xiao Liang wrote: >> On Mon, Apr 11, 2016 at 3:42 PM, Takashi

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Xiao Liang
amiliar with netdev-bsd code, but I think this approach will make ports more difficult to manage and need much more effort. Thanks, Xiao > On Mon, Apr 11, 2016 at 4:23 PM, Xiao Liang wrote: >> Add new column "ofname" in Interface table to configure port name reported >>

Re: [ovs-dev] [PATCH] Add configurable OpenFlow port name.

2016-04-11 Thread Xiao Liang
On Mon, Apr 11, 2016 at 1:34 AM, Ben Pfaff wrote: > On Fri, Apr 08, 2016 at 05:38:16PM +0800, Xiao Liang wrote: >> Add new column "ofname" in Interface table to configure port name reported >> to controllers with OpenFlow protocol, thus decouple OpenFlow port name from

[ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Xiao Liang
ollers can recognize ports by their names. Signed-off-by: Xiao Liang --- v2: Added test for ofname Increased db schema version Updated NEWS --- NEWS | 1 + lib/db-ctl-base.h | 2 +- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c

[ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-11 Thread Xiao Liang
ollers can recognize ports by their names. Signed-off-by: Xiao Liang --- v2: Added test for ofname Increased db schema version --- lib/db-ctl-base.h | 2 +- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c | 67 -- ofproto

Re: [ovs-dev] [PATCH] Add configurable OpenFlow port name.

2016-04-09 Thread Xiao Liang
On Sun, Apr 10, 2016 at 7:08 AM, Han Zhou wrote: > > On Friday, April 8, 2016, Xiao Liang wrote: >> >> Add new column "ofname" in Interface table to configure port name reported >> to controllers with OpenFlow protocol, thus decouple OpenFlow port name >>

[ovs-dev] [PATCH] Add configurable OpenFlow port name.

2016-04-08 Thread Xiao Liang
ollers can recognize ports by their names. Signed-off-by: Xiao Liang --- lib/db-ctl-base.h | 2 +- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c | 67 -- ofproto/ofproto.h | 9 ++- utilities/ovs-vsctl.c | 1 +