On Mon, Apr 11, 2016 at 1:34 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Apr 08, 2016 at 05:38:16PM +0800, Xiao Liang wrote: >> Add new column "ofname" in Interface table to configure port name reported >> to controllers with OpenFlow protocol, thus decouple OpenFlow port name from >> device name. >> >> For example: >> # ovs-vsctl set Interface eth0 ofname=wan >> # ovs-vsctl set Interface eth1 ofname=lan0 >> then controllers can recognize ports by their names. >> >> Signed-off-by: Xiao Liang <shaw.l...@gmail.com> > > This seems like a reasonable feature and based on skimming the code it's > a reasonable implementation. > > It needs tests to demonstrate that it works. Please include some corner > cases (e.g. duplicate ofnames, ofnames that duplicate regular names of > ports that don't have ofnames, changing ofnames, ...). > > Please add an item to NEWS as well. > > Thanks, > > Ben.
Hi Ben, Just submitted a new patch. Added some tests in tests/ofproto.at. Since I didn't find any constraints (excpet length) on port name in OpenFlow specs, duplicate names will be accepted. Thanks, Xiao _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
