> On Jul 18, 2015, at 9:46 AM, Ben Pfaff wrote:
>
> I'm happy to encourage people to submit changes via Github, as an
> experiment.
>
> I don't know of a way to experiment with Gerrit, because Gerrit wants
> exclusive access to your repository. There is a Gerrit service for
There is actually
> On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote:
>
> On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote:
>> How about automating this using travis and gerrit, so no commit gets in
>> unless it passes sanity tests? This also simplifies review process
Hi Ben,
How about automating this using travis and gerrit, so no commit gets in
unless it passes sanity tests? This also simplifies review process as well.
Regards,
Pritesh
> On Jul 13, 2015, at 5:14 PM, Ben Pfaff wrote:
>
> Lately I've starting hearing about commits breaking the Windows kerne
On Jun 12, 2015, at 12:44 PM, Anil Gunturu
mailto:anil.gunt...@riftio.com>> wrote:
Hi,
With OVS patch for NSH, what is the format of the packets going to the VM? Do
they have NSH header or the applications inside the VM completely unaware of
the NSH header?
it supports both type of configura
> On May 20, 2015, at 10:47 PM, Ben Pfaff wrote:
>
> On Thu, May 21, 2015 at 02:06:57AM +, Anil Gunturu wrote:
>> Are there any plans to merge the patch for supporting NSH header into
>> the main stream?
>
> I think we're still waiting for revised patches.
yep, still working on it, mean wh
LGTM
Acked-by: Pritesh Kothari
> On Apr 2, 2015, at 9:52 AM, Ben Pfaff wrote:
>
> CC: Mark B Kavanagh
> Signed-off-by: Ben Pfaff
> ---
> INSTALL.md | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/INSTALL.md b/INSTALL.md
> index 273093b..cde
Acked-by: Pritesh Kothari
> On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote:
>
> Currently when printing a userspace tunnel action for VXLAN, the
> VNI is treated as a 32 bit field rather than 24 bit. Even if this
> is the representation that we use internally, we should still s
tested, LGTM, Thanks, appreciated.
Acked-by: Pritesh Kothari
> On Mar 30, 2015, at 9:38 PM, Jesse Gross wrote:
>
> It's probably a good idea although it requires a different type of
> test compared with what we already have since the GRE protocol doesn't
> appear i
LGTM
Acked-by: Pritesh Kothari
will get to rest of series as time permits.
> On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote:
>
> The indication to calculate the GRE checksum is currently the port
> config rather than the tunnel flow. Currently there is a one to one
> mapping
LGTM
Acked-by: Pritesh Kothari
> On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote:
>
> The GRE checksum is a 16 bit field stored in a 32 bit option (the
> rest is reserved). The current code treats the checksum as a 32-bit
> field and places it in the right place for little end
should a test case be added to catch this ?
Regards,
Pritesh
> On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote:
>
> +if (greh->protocol != htons(ETH_TYPE_TEB)) {
> +return -EINVAL;
> +}
> +
___
dev mailing list
dev@openvswitch.org
http
Acked-by: Pritesh Kothari
> On Mar 30, 2015, at 3:14 PM, Jesse Gross wrote:
>
> The IP TTL is currently omitted in the extracted tunnel information
> that is stored in the flow for userspace tunneling. This includes it
> so that the same logic used by the kernel also applies.
LGTM
Acked-by: Pritesh Kothari
mailto:pritesh.koth...@cisco.com>>
Regards,
Pritesh
On Mar 24, 2015, at 12:38 PM, Jesse Gross
mailto:je...@nicira.com>> wrote:
The kernel module can already support outer UDP checksums for
Geneve and VXLAN using the standard checksum flag in tun
> On Jan 13, 2015, at 2:14 PM, Ben Pfaff wrote:
>
> On Mon, Jan 12, 2015 at 05:46:49PM -0800, Pritesh Kothari wrote:
>> IPv6 Flow Label is currently read only. This patch adds support
>> to allow actions like actions=set_field:0x12345->ipv6_label.
>>
>
IPv6 Flow Label is currently read only. This patch adds support
to allow actions like actions=set_field:0x12345->ipv6_label.
Signed-off-by: Pritesh Kothari
---
lib/meta-flow.c | 2 +-
lib/meta-flow.h | 2 +-
tests/ofproto.at | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
d
On Oct 1, 2014, at 8:40 AM, Ben Pfaff wrote:
> On Tue, Sep 30, 2014 at 11:23:46PM -0700, Pritesh Kothari wrote:
>> Signed-off-by: Pritesh Kothari
>> ---
>> v2:
>> * Changed html to mardown syntax instead.
>> * Fix references to README in various places.
>&g
Signed-off-by: Pritesh Kothari
---
v2:
* Changed html to mardown syntax instead.
* Fix references to README in various places.
* Fix whitespace issues.
---
Makefile.am | 1 +
README | 116
README.md
On Sep 30, 2014, at 5:19 PM, Joe Stringer
mailto:joestrin...@nicira.com>> wrote:
On 1 October 2014 12:15, Pritesh Kothari
mailto:pritesh.koth...@cisco.com>> wrote:
diff --git a/README.md b/README.md
new file mode 100644
index 000..318f0e6
--- /dev/null
+++ b/README.md
@@
Signed-off-by: Pritesh Kothari
---
README| 116 --
README.md | 114
2 files changed, 114 insertions(+), 116 deletions(-)
delete mode 100644 README
create mode 100644
Thanks for the review.
>> + OVS_GREP_IFELSE([$KSRC/include/linux/if.h], [IFF_LIVE_ADDR_CHANGE])
>> +
>> OVS_GREP_IFELSE([$KSRC/include/linux/if_vlan.h], [vlan_set_encap_proto])
>>
> Why are you changing existing compat code in this patch? Even if you
> have a reason for such change please send
Acked-by: Pritesh Kothari
On Jul 2, 2014, at 11:47 AM, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
> ---
> INSTALL.DPDK | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/INSTALL.DPDK b/INSTALL.DPDK
> index 2a6d7ef..36bbe54 100644
> --
Signed-off-by: Pritesh Kothari
---
v1: make check passes for 3.2/3.13/3.14/3.15
---
FAQ | 1 +
NEWS| 2 +-
acinclude.m4| 17 -
datapath/linux/Modules.mk
On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote:
> why not just check for HAVE_U64_STATS_FETCH_BEGIN_IRQ?
because of this which was added in 3.13, i guess:
-#if LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0)
-
-#if BITS_PER_LONG == 32 && defined(CONFIG_SMP)
-# define u64_stats_init(syncp) seqco
Acked-by: Pritesh Kothari
On Jun 30, 2014, at 6:01 PM, Jesse Gross wrote:
> The upstream u64_stats API has been changed to remove the _bh()
> versions and switch all consumers to use IRQ safe variants instead.
> This was done to be safe for netpoll generated packets, which can
> o
ff wrote:
>> That's odd. Jesse, did this apply for you?
>>
>> On Mon, Jun 30, 2014 at 08:47:08PM +, Pritesh Kothari (pritkoth) wrote:
>>> LGTM but give error on master:
>>> error: patch failed: datapath/flow_netlink.c:524
>>> error: dat
LGTM but give error on master:
error: patch failed: datapath/flow_netlink.c:524
error: datapath/flow_netlink.c: patch does not apply
Regards,
Pritesh
On Jun 30, 2014, at 1:37 PM, Ben Pfaff wrote:
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
> ---
> datapath/flow_netlink.c |5 +++--
Acked-by: Pritesh Kothari
On Jun 30, 2014, at 11:59 AM, Ben Pfaff wrote:
> If this seems like an improvement, I can do the same thing for the RHEL
> version.
>
> CC: Flavio Leitner
> Signed-off-by: Ben Pfaff
> ---
> INSTALL.Fedora | 24 ++--
Acked-by: Pritesh Kothari
On Jun 25, 2014, at 10:59 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-linux.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
> index 66911c7..0eac3e7 10
Acked-by: Pritesh Kothari
On Jun 24, 2014, at 8:54 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-dpdk.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 6d92969..3359517 1006
Acked-by: Pritesh Kothari
On Jun 9, 2014, at 3:58 PM, Ben Pfaff wrote:
> I think these were leftovers from the removal of %z for MSVC that happened
> some time ago.
>
> VMware-BZ: 1265762
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-bsd.c |4 ++--
> lib
Acked-by: Pritesh Kothari
On May 6, 2014, at 5:02 PM, YAMAMOTO Takashi wrote:
> Co-authored-by: Ben Pfaff
> Signed-off-by: YAMAMOTO Takashi
> ---
> FAQ | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index fc21af4
Signed-off-by: Pritesh Kothari
---
acinclude.m4 | 1 +
datapath/linux/compat/include/linux/skbuff.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 518a66b..e8a8a2e 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -295,6
Signed-off-by: Pritesh Kothari
---
v1: backporting commit from master to fix skb_clear_rxhash.
---
acinclude.m4 | 1 +
datapath/compat.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index cb563c6..d5f5830 100644
--- a/acinclude.m4
+++ b/acinclude.m4
Signed-off-by: Pritesh Kothari
---
v1: backporting commit from master to fix skb_clear_rxhash.
---
acinclude.m4 | 1 +
datapath/compat.h | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index b675e41..f51d66b 100644
--- a/acinclude.m4
Signed-off-by: Pritesh Kothari
---
v1: backporting commit from master to fix skb_clear_rxhash.
---
acinclude.m4 | 1 +
datapath/compat.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index d1271a4..3b7a5eb 100644
--- a/acinclude.m4
+++ b/acinclude.m4
Signed-off-by: Pritesh Kothari
---
v7: change a specific version to HAVE_RXHASH,
fix skb_clear_hash to include l4_rxhash.
v6: rebase for changes in datapath/datapath.c
v5: move skb_clear_rxhash() from compat.h to skbuff.h,
simplify skb_get_hash() integration,
fix random.h order in
Signed-off-by: Pritesh Kothari
---
v1: backporting commit from master to fix skb_clear_rxhash.
---
acinclude.m4 | 1 +
datapath/compat.h | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index fdcdf44..4c569ce 100644
--- a/acinclude.m4
On Apr 30, 2014, at 3:42 PM, Jesse Gross wrote:
> On Tue, Apr 29, 2014 at 3:24 PM, Pritesh Kothari
> wrote:
>> diff --git a/datapath/linux/compat/include/linux/skbuff.h
>> b/datapath/linux/compat/include/linux/skbuff.h
>> index 714c955..de9b29d 100644
>> --- a
Signed-off-by: Pritesh Kothari
---
v6: rebase for changes in datapath/datapath.c
v5: move skb_clear_rxhash() from compat.h to skbuff.h,
simplify skb_get_hash() integration,
fix random.h order in acinclude.m4,
move pcpu_sw_netstats to netdevice.h.
v4: rebase for changes in datapath
works for me here.
Acked-by: Pritesh Kothari
On Apr 29, 2014, at 1:22 PM, Andy Zhou wrote:
> Caught by clang-3.5.
>
> Reported-by: Simon Horman
> Signed-off-by: Andy Zhou
> ---
> ofproto/bond.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> di
Signed-off-by: Pritesh Kothari
---
v5: move skb_clear_rxhash() from compat.h to skbuff.h,
simplify skb_get_hash() integration,
fix random.h order in acinclude.m4,
move pcpu_sw_netstats to netdevice.h.
v4: rebase for changes in datapath/actions.c and datapath/vport.c,
split patch
On Apr 25, 2014, at 12:36 PM, Jesse Gross wrote:
> On Fri, Apr 25, 2014 at 12:16 PM, Pritesh Kothari (pritkoth)
> wrote:
>> Hi Jesse,
>>
>>>>
>>>> diff --git a/datapath/linux/compat/include/linux/etherdevice.h
>>>> b/datapath/linux
Hi Jesse,
>>
>> diff --git a/datapath/linux/compat/include/linux/etherdevice.h
>> b/datapath/linux/compat/include/linux/etherdevice.h
>> index 556729d..c6e8e92 100644
>> --- a/datapath/linux/compat/include/linux/etherdevice.h
>> +++ b/datapath/linux/compat/include/linux/etherdevice.h
>> @@ -34,6
Signed-off-by: Pritesh Kothari
---
v4: rebase for changes in datapath/actions.c and datapath/vport.c,
split patch in two for seperating out skb_clear_hash related stuff.
v3: rebase for changes in datapath/vport.c.
v2: Use OVS_GREP_IFELSE instead of upstream kernel versions as Thomas suggested
Signed-off-by: Pritesh Kothari
---
acinclude.m4 | 1 +
datapath/actions.c | 10 +-
datapath/linux/compat/include/linux/skbuff.h | 4
datapath/linux/compat/ip_tunnels_core.c | 4 ++--
4 files changed, 12 insertions
Signed-off-by: Pritesh Kothari
---
v3: rebase for changes in datapath/vport.c.
v2: Use OVS_GREP_IFELSE instead of upstream kernel versions as Thomas suggested.
---
FAQ | 2 +-
NEWS | 2 +-
acinclude.m4
On Apr 10, 2014, at 3:59 PM, Jesse Gross wrote:
> On Tue, Feb 25, 2014 at 3:44 PM, Pritesh Kothari
> wrote:
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers wh
Does this mean we send in pull requests from github and no more patches on
mailing lists?
Regards,
Pritesh
On Apr 8, 2014, at 5:04 PM, Ben Pfaff wrote:
> Applied to master, thanks!
>
> On Tue, Apr 08, 2014 at 04:46:19PM -0700, Justin Pettit wrote:
>> Acked-by: Justin Pettit
>>
>>
>>
>> On
Signed-off-by: Pritesh Kothari
---
v2: Use OVS_GREP_IFELSE instead of upstream kernel versions as Thomas suggested.
---
FAQ |2 +-
NEWS |2 +-
acinclude.m4
On Apr 8, 2014, at 8:54 AM, Thomas Graf wrote:
>> #endif
>> diff --git a/datapath/linux/compat/include/linux/skbuff.h
>> b/datapath/linux/compat/include/linux/skbuff.h
>> index de0c56a..812ed00 100644
>> --- a/datapath/linux/compat/include/linux/skbuff.h
>> +++ b/datapath/linux/compat/include/
Signed-off-by: Pritesh Kothari
---
FAQ |2 +-
NEWS |2 +-
acinclude.m4 |4 ++--
datapath/actions.c|2 +-
datapath/linux
happy.
Signed-off-by: Pritesh Kothari
---
lib/dpif-netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 8687a47..c5df3b5 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -1734,7 +1734,7 @@ dp_netdev_actions_free(s
: Pritesh Kothari
---
Makefile.am |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index dd0a111..9039389 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -18,12 +18,12 @@ AM_CPPFLAGS += $(PTHREAD_INCLUDES)
AM_LDFLAGS += $(PTHREAD_LDFLAGS)
endif
On Mar 27, 2014, at 4:52 PM, Ben Pfaff wrote:
> On Thu, Mar 27, 2014 at 03:44:59PM -0700, Pritesh Kothari wrote:
>> Sparse is unhappy because the system include path is ahead of the
>> local include path. This patch fixes that and has a clean run for
>> sparse.
>>
Sparse is unhappy because the system include path is ahead of the
local include path. This patch fixes that and has a clean run for
sparse.
Signed-off-by: Pritesh Kothari
---
Makefile.am |4 ++--
lib/dpif-netdev.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Acked-by: Pritesh Kothari
On Mar 14, 2014, at 4:00 PM, Ben Pfaff wrote:
> Reported-by: Mukesh Hira
> Signed-off-by: Ben Pfaff
> ---
> lib/socket-util.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/socket-util.c b/lib/socket-u
Acked-by: Pritesh Kothari
On Mar 15, 2014, at 9:20 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index f46170c..a54bbf9 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -774,6 +774,13 @@
On Mar 7, 2014, at 12:51 PM, Pravin Shelar wrote:
> On Fri, Mar 7, 2014 at 11:52 AM, Pritesh Kothari (pritkoth)
> wrote:
>> Hi Pravin,
>>
>>>>
>>>> if (type > OVS_TUNNEL_KEY_ATTR_MAX) {
>>>> @@ -388,11 +390,16 @@ static
Hi Pravin,
>>
>>if (type > OVS_TUNNEL_KEY_ATTR_MAX) {
>> @@ -388,11 +390,16 @@ static int ipv4_tun_from_nlattr(const struct nlattr
>> *attr,
>>case OVS_TUNNEL_KEY_ATTR_CSUM:
>>tun_flags |= TUNNEL_CSUM;
>>break;
>> +
On Mar 4, 2014, at 5:30 AM, Thomas Graf wrote:
> On 03/04/2014 12:27 AM, Pritesh Kothari wrote:
>> Current VXLAN VTEP receives only VXLAN packets and ethernet over VXLAN-gpe
>> [1]
>> packets are rejected. This patch adds support for receiving "ethernet over
>&g
html/draft-quinn-vxlan-gpe-02
Signed-off-by: Pritesh Kothari
---
datapath/linux/compat/vxlan.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c
index 64877e0..aec291e 100644
--- a/datapath/linux/compat/vxl
NSH service path (nsp) can be set/unset while creating the port
as well nsp can be matched on incoming packets.
Signed-off-by: Pritesh Kothari
---
lib/flow.c |2 +
lib/flow.h |2 +
lib/match.c| 21 ++
lib/match.h|2 +
lib/meta-flow.c| 43
From: pritesh
Support for nsh service index (nsi) is added, mainly incoming
nsi in a flow can be matched and appropriate action can be
taken on the flow based on it.
Signed-off-by: Pritesh Kothari
---
lib/flow.c |2 ++
lib/flow.h |2 ++
lib/match.c| 25
On Feb 26, 2014, at 12:44 PM, Ben Pfaff wrote:
> On Tue, Feb 25, 2014 at 03:44:13PM -0800, Pritesh Kothari wrote:
>> This is version 2 for supporting NSH [1] on vxlan. The changes since
>> last patch set are few and mainly just related to the review earlier.
>
> Thanks for
Hi Guys,
This is version 2 for supporting NSH [1] on vxlan. The changes since
last patch set are few and mainly just related to the review earlier.
datapath/datapath.c|2 +
datapath/flow.h|7 +-
datapath/flow_netlink.c
From: pritesh
Support for nsh service index (nsi) is added, mainly incoming
nsi in a flow can be matched and appropriate action can be
taken on the flow based on it.
Signed-off-by: Pritesh Kothari
diff --git a/lib/flow.c b/lib/flow.c
index 28e96ec..e1b7d74 100644
--- a/lib/flow.c
+++ b/lib
Support for setting nsi using an action namely set_nsi.
It works similar to set_tunnel in vxlan/gre tunnel and
can be used to set the outgoing nsh service index (nsi).
Also NXM_NX_NSI is defined here which enables matching
NSIs.
Signed-off-by: Pritesh Kothari
diff --git a/include/openflow
From: pritesh
Fix for the current test cases which fail due to the nsh changes.
Signed-off-by: Pritesh Kothari
diff --git a/tests/bfd.at b/tests/bfd.at
index 3723d60..23dbf87 100644
--- a/tests/bfd.at
+++ b/tests/bfd.at
@@ -229,7 +229,7 @@ OVS_VSWITCHD_START([add-port br0 p1 -- set Interface
NSH service path (nsp) can be set/unset while creating the port
as well as nsp can be matched on incoming packets.
Signed-off-by: Pritesh Kothari
diff --git a/lib/flow.c b/lib/flow.c
index e7fe4d3..28e96ec 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -563,6 +563,8 @@ flow_tun_flag_to_string
Here, datapath support for setting nsh service index (nsi) is added.
nsi can now be set on outgoing packet depending on port settings or
set_nsi action.
Signed-off-by: Pritesh Kothari
diff --git a/datapath/datapath.c b/datapath/datapath.c
index b96ad1e..46a4f28 100644
--- a/datapath/datapath.c
Support for setting nsp using an action namely set_nsp.
It works similar to set_tunnel in vxlan/gre tunnel and
can be used to set the outgoing nsh service path id.
Also NXM_NX_NSP is defined which enables matching NSPs.
Signed-off-by: Pritesh Kothari
diff --git a/include/openflow/nicira-ext.h b
-quinn-sfc-nsh-02
Signed-off-by: Pritesh Kothari
create mode 100644 datapath/linux/compat/include/net/nsh.h
diff --git a/datapath/datapath.c b/datapath/datapath.c
index f7c3391..b96ad1e 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -361,6 +361,7 @@ static size_t key_attr_size(void
On Feb 11, 2014, at 3:20 PM, Ben Pfaff wrote:
> On Tue, Feb 11, 2014 at 06:48:33PM +0000, Pritesh Kothari (pritkoth) wrote:
>>
>> On Feb 11, 2014, at 8:05 AM, Ben Pfaff wrote:
>>
>>> On Tue, Feb 11, 2014 at 12:00:46AM +, Pritesh Kothari (pritkoth) wrote:
&g
On Feb 11, 2014, at 8:05 AM, Ben Pfaff wrote:
> On Tue, Feb 11, 2014 at 12:00:46AM +0000, Pritesh Kothari (pritkoth) wrote:
>> Hi Ben,
>>
>>> -static const struct tnl_match_pattern patterns[] = {
>>> -{ false, false, IP_SRC_CFG }
looks good to me.
Acked-by: pritesh
On Feb 4, 2014, at 1:19 PM, Ben Pfaff wrote:
> There are 12 possible ways to specify a tunnel (2 * 2 * 3 == 12):
>
>- Specific in_key or flow-based (2 choices).
>
>- Specific ip_dst or flow-based (2 choices).
>
>- Specific ip_src, wildcarded,
Hi Ben,
> -static const struct tnl_match_pattern patterns[] = {
> -{ false, false, IP_SRC_CFG }, /* remote_ip, local_ip, in_key. */
> -{ false, false, IP_SRC_ANY }, /* remote_ip, in_key. */
> -{ true, false, IP_SRC_CFG }, /* remote_ip, local_ip. */
> -{ true
looks good to me.
Acked-by: pritesh
On Dec 17, 2013, at 10:51 AM, Jesse Gross wrote:
> Reported-by: Ben Pfaff
> Signed-off-by: Jesse Gross
> ---
> FAQ | 23 +--
> 1 file changed, 9 insertions(+), 14 deletions(-)
>
> diff --git a/FAQ b/FAQ
> index 2508c8c..3df1c54 100644
>
On Oct 1, 2013, at 3:13 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> Support for setting the nsh network and service contexts is added here.
>> The support is added only for adding context while the port is created.
>
> I understand that this may be an inter
On Oct 1, 2013, at 3:09 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> Support for setting nsi using an action namely set_nsi. It works similar to
>> set_tunnel in vxlan/gre tunnel and can be used to set the outgoing nsh
>> service index (nsi).
>>
>
> Again,
>> vxlan.c:118: if (vxh->vx_flags != htonl(VXLAN_FLAGS) || (vxh->vx_vni &
>> htonl(0xff))) {
>>
>> or if (unlikely(nsh->b.svc_path & htonl(NSH_M_NSI))) { // NSH_M_NSI ==>
>> 0x00ff which is same as 0xff above?
>> am i missing something here?
>>
>
> I did not check if the NSH spec tells to
On Oct 1, 2013, at 3:07 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> Support for nsh service index (nsi) is added, mainly incoming
>> nsi in a flow can be matched and appropriate action can be
>> taken on the flow based on it.
>>
>> Signed-off-by: pritesh
>
>> diff --git a/datapath/flow.c b/datapath/flow.c
>> index 4f47a48..4335d67 100644
>> --- a/datapath/flow.c
>> +++ b/datapath/flow.c
>> @@ -46,6 +46,8 @@
>>
>> #include "vlan.h"
>>
>> +#define NSH_M_NSI 0x00FF
>> +
>
> Is this the same as NSH_M_NSI currently defined in nsh.h?
>
>> stat
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> Support for setting nsp using an action namely set_nsp. It works similar to
>> set_tunnel in vxlan/gre tunnel and can be used to set the outgoing nsh
>> service path id.
>
> Should tell here that NXM_NX_NSP is also defined, which enables
> match
>>
>> +{
>> +MFF_NSP, "nsp", NULL,
>> +sizeof(ovs_be32), 24,
>> +MFM_FULLY,
>> +MFS_HEXADECIMAL,
>> +MFP_NONE,
>> +false,
>> +0, NULL,
>> +0, NULL,
>> +OFPUTIL_P_OF10_NXM_ANY,
>> +OFPUTIL_P_OF10_NXM_ANY,
>
> These
btw, first and foremost, thanks for the review, i greatly appreciate it :)
>> diff --git a/datapath/flow.c b/datapath/flow.c
>> index 29122af..4f47a48 100644
>> --- a/datapath/flow.c
>> +++ b/datapath/flow.c
>> @@ -1235,6 +1235,7 @@ int ovs_ipv4_tun_from_nlattr(const struct nlattr *attr,
>> i
On Oct 1, 2013, at 11:03 AM, Jarno Rajahalme wrote:
>
> On Oct 1, 2013, at 10:07 AM, Pritesh Kothari (pritkoth)
> wrote:
>
>>
>> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>>
>>> On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
>>>>
On Oct 1, 2013, at 12:08 PM, Jesse Gross wrote:
> On Tue, Oct 1, 2013 at 10:07 AM, Pritesh Kothari (pritkoth)
> wrote:
>> On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
>>> One other thing - would you mind using your full name in the signed-off-by
>>> line?
>
On Sep 30, 2013, at 5:46 PM, Jesse Gross wrote:
> On Fri, Sep 20, 2013 at 1:04 AM, pritesh wrote:
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers whenever a vxlan port with destination port as
>> Sure. How about this, then.
>
> --8<--cut here-->8--
>
> From: Ben Pfaff
> Date: Wed, 25 Sep 2013 15:56:21 -0700
> Subject: [PATCH] FAQ: Explain why allowing only IP traffic breaks IP
> connectivity.
>
> Signed-off-by: Ben Pfaff
> ---
> FAQ |
On Sep 25, 2013, at 3:56 PM, Ben Pfaff wrote:
> On Wed, Sep 25, 2013 at 01:28:33PM -0700, Justin Pettit wrote:
>> Thanks for writing this up. I think the example may be clearer if
>> you defined the flow in terms of IP addresses instead of MAC
>> addresses, since those are typically the flows th
On Sep 24, 2013, at 4:17 PM, Ben Pfaff wrote:
> On Tue, Sep 24, 2013 at 04:10:36PM -0700, Jesse Gross wrote:
>> On Tue, Sep 24, 2013 at 2:58 PM, Ben Pfaff wrote:
>>> diff --git a/datapath/vport.c b/datapath/vport.c
>>> index f62201d..3878510 100644
>>> --- a/datapath/vport.c
>>> +++ b/datapath/v
Acked-by: pritesh
On Sep 24, 2013, at 2:58 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> datapath/vport.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath/vport.c b/datapath/vport.c
> index f62201d..3878510 100644
> --- a/datapath/vport.c
> +++ b/da
Acked-by: pritesh
On Sep 24, 2013, at 2:58 PM, Ben Pfaff wrote:
> ---
> ofproto/ofproto-dpif-upcall.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
> index d75c61b..16c53e5 100644
> --- a/ofprot
Hi Guys,
I have been working on supporting NSH [1] on vxlan and have few things
ready and wanted to get an opinion.
datapath/datapath.c|2 +
datapath/flow.c| 22 +++
datapath/flow.h|4 +-
datapa
ack, looks good to me.
-pritesh
On Aug 30, 2013, at 10:02 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index 75d9007..5406e84 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -250,6 +250,
Looks good and simple to understand. (passed tests also).
Acked-by: pritesh
On Aug 27, 2013, at 11:12 AM, Ben Pfaff wrote:
> Suggested-by: pritesh
> Signed-off-by: Ben Pfaff
> ---
> ofproto/tunnel.c | 100 +-
> 1 file changed, 46 insertions(
96 matches
Mail list logo
