> On Jul 13, 2015, at 9:40 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Tue, Jul 14, 2015 at 12:34:14AM +0000, Pritesh Kothari (pritkoth) wrote: >> How about automating this using travis and gerrit, so no commit gets in >> unless it passes sanity tests? This also simplifies review process as well. > > Travis doesn't test the kernel module, and as far as I know it can’t.
weird, i saw one patch few days ago doing it [1], anyways I may be mistaken. > > I am the wrong person to evangelize Gerrit to: > http://benpfaff.org/writings/gerrit.html This seems to be all about web interface, any chance you happen to use the cli for gerrit mainly git review [2] -d [3] or -m [3] or gerritmander [4]? both of them are really good utilities and you never have to really leave your command line tools to use them. To answer a few points from your webpage from Review text section: Q) Gerrit provides the patch submitter no way to say what has changed in the second or later version of a patch, even though this is critical information. (Gerrit does provide an interface to view differences relative to a prior versions of a patch set, but it isn't useful because it folds in unrelated changes that have occurred in the repository in the meantime.) A) it does: If you want to compare patchset 4 with patchset 10 of change 781 from gerrit: git review -m 781,4-10 Q) Gerrit does not provide a way to save a draft of a review. A) it does: If you want to download patchset 4 for change 781 from gerrit to review it: git review -d 781,4 Q) Gerrit adds extra data with no obvious value to commit messages (Change-Id: …). A) The extra data provides a way to link dependencies across projects ;) check this [5] by clicking the Depends-on link and you will see that python-neutronclient patch depends upon neutron project patch. [1]: https://github.com/suffuse/go-suffuse/pull/14/files#diff-d92eb0153aa9cbf834f7ab1aeab150a7R16 [2]: https://launchpad.net/git-review [3]: https://github.com/openstack-infra/git-review/blob/master/doc/source/usage.rst [4]: https://github.com/berrange/gerrymander [5]: https://review.openstack.org/#/c/162040/ _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
