On Dec 14, 2013, at 11:27 AM, Gurucharan Shetty wrote:
> On Fri, Dec 13, 2013 at 6:53 PM, Kyle Mestery wrote:
>> Fixes the OVS builds on Fedora, which are currently broken upstream.
>>
>> Signed-off-by: Kyle Mestery
> Thanks for fixing.
> I applied this to master.
>
Thanks for the review and
On Dec 2, 2013, at 11:58 AM, Ben Pfaff wrote:
> On Mon, Dec 02, 2013 at 05:42:58PM +0000, Kyle Mestery (kmestery) wrote:
>> My only curiosity here was what would the advantages of implementing
>> VEPA in OVS be over using the existing lldpad approach. I'd also be
>> i
ach.
Thanks,
Kyle
>
> > From: qianhui...@huawei.com
> > To: jerry.lili...@huawei.com
> > Date: Mon, 2 Dec 2013 06:07:20 +
> > CC: dev@openvswitch.org; zh...@huawei.com
> > Subject: [ovs-dev] $)A4p84: VEPA support in OVS
> >
> > $)AUb8vHKJGK >
On Nov 30, 2013, at 12:46 AM, jerry wrote:
> Hi all,
>
> Does anyone have a plan to support for VEPA in OVS?
>
> In my opinion, we can achieve such function using two methods:
> 1) Add flow rules on each VM port to lead traffic to physical port.
> 2) Add a port type for physical port and do MAC-
On Oct 29, 2013, at 10:57 AM, Gurucharan Shetty wrote:
> The ovs-dpctl-top related changes were also needed for branch-2.0. I
> sent in a separate patch for that.
> http://openvswitch.org/pipermail/dev/2013-October/033362.html
>
Thanks, I just Acked that patch.
> On Thu, Oct 24, 2013 at 2:05 PM,
On Oct 29, 2013, at 10:56 AM, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
> rhel/openvswitch-fedora.spec.in |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 27a3b03..a818191 100644
> ---
I'm seeing the following error on *one* of my Fedora test VMs.
It's strange because on the other two, I don't see the GRE errors
below. Any ideas as to what might be going wrong?
[kmestery@km-dhcp-64-197 ~]$ dmesg|grep gre
[0.175404] ACPI: Added _OSI(Processor Aggregator Device)
[8.365982]
On Oct 4, 2013, at 6:07 AM, Lorand Jakab wrote:
> Signed-off-by: Lorand Jakab
Looks fine to me Lori.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 3, 2013, at 2:31 PM, Jesse Gross wrote:
> On Thu, Oct 3, 2013 at 9:46 AM, Kyle Mestery (kmestery)
> wrote:
>> So, we realize the need to add the NSH code upstream into the kernel.
>> But in parallel to this work, we're wondering if it would be ok to add a new
>&g
On Oct 1, 2013, at 4:44 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers whenever a vxlan port with destination po
On Sep 4, 2013, at 7:11 PM, Ben Pfaff wrote:
> This email is an update for the initial hackathon plan that I sent out
> earlier this month. Everything in that email is still accurate. You
> can read the earlier email at:
>http://openvswitch.org/pipermail/announce/2013-August/53.html
>
On Aug 21, 2013, at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Aug 15, 2013, at 2:33 PM, Chris Wright wrote:
> Andrei Andone reported an oops on CentOS 6.4 when adding a device to an
> ovs instance. The problem is easy to reproduce and generates the
> following stack trace:
>
> kernel tried to execute NX-protected page - exploit attempt? (uid: 0)
> BUG:
On Aug 9, 2013, at 5:30 PM, Jesse Gross wrote:
> A bit shift operation is using the value '11' instead of '1' as the
> starting value. This only makes validation weaker than it should be
> so unless userspace is trying to install an invalid flow there will
> be no effect.
>
> Signed-off-by: Jesse
On Aug 2, 2013, at 1:38 PM, Pravin B Shelar
wrote:
> Changes are mostly related API changes in vlan, GRE
> restructuring.
>
> Signed-off-by: Pravin B Shelar
Looks good and works with this kernel. Only nit is to add FAQ
and NEWS items for this.
Acked-by: Kyle Mestery
[kmester
On Aug 2, 2013, at 1:38 PM, Pravin B Shelar
wrote:
> Changes are mostly related API changes in vlan, GRE
> restructuring.
>
> Signed-off-by: Pravin B Shelar
Testing this one now. Mental to always read all the unread
email in a list before testing and replying. :)
_
On Aug 1, 2013, at 5:21 PM, Pravin B Shelar wrote:
> Changes are mostly related API changes in vlan, GRE
> restructuring.
>
> Signed-off-by: Pravin B Shelar
Thanks Pravin, looks good and works for me. Tested on this
kernel:
[kmestery@km-dhcp-64-245 ~]$ uname -a
Linux km-dhcp-64-245.kmestery.c
On Jul 31, 2013, at 3:41 PM, Jesse Gross wrote:
> On Tue, Jul 30, 2013 at 7:17 PM, Kyle Mestery wrote:
>> Ensure that in tunnel.c:handle_offloads() we save off skb->cb before
>> calling __skb_gso_segment() and restore it after the return.
>>
>> Signed-off-by: Pravin B Shelar
>> Signed-off-by: K
On Jul 30, 2013, at 7:17 PM, Jesse Gross wrote:
> On Fri, Jul 26, 2013 at 2:21 PM, Kyle Mestery wrote:
>> Add support for Linux kernel 3.9.
>>
>> Signed-off-by: Kyle Mestery
>> CC: Pravin B Shelar
>
> I think it's not strictly required to do the restoration here since
> the only user of skb
I'm hoping to get this done today, but had a question (was on PTO yesterday):
I see in Jesse's reply to Pravin's patch [1] a mention of putting the new code
into the main path, and the compatibility code should be for older kernels.
My question to Jesse is this: When you made this comment, did you
On Jul 19, 2013, at 3:31 PM, Pravin Shelar wrote:
> On Fri, Jul 19, 2013 at 6:28 AM, Kyle Mestery (kmestery)
> wrote:
>>
>> On Jul 18, 2013, at 5:22 PM, Pravin B Shelar wrote:
>>
>>> Following patch restructures vxlan tunneling so that it is more
>>>
On Jul 18, 2013, at 5:22 PM, Pravin B Shelar wrote:
> Following patch restructures vxlan tunneling so that it is more
> in sync with upstream vxlan tunneling code.
>
> Signed-off-by: Pravin Shelar
> ---
> v3-v2:
> - Moved kernel version in flow_dissector check to top.
> v1-v2:
> - Added create
On May 30, 2013, at 6:13 PM, Jesse Gross wrote:
> On Wed, May 29, 2013 at 11:16 PM, James Page wrote:
>> Hi OpenvSwitch Devs
>>
>> Ubuntu Saucy development has been open for a while and the Ubuntu kernel
>> team are currently targeting either Linux 3.9 or 3.10 for this release.
>>
>> Currently
On May 23, 2013, at 6:08 PM, Ben Pfaff wrote:
> OpenFlow 1.2 and later define a value of 65535 (OFPCML_NO_BUFFER) for
> the max_len field in an output action to mean that the switch should send
> the entire packet without buffering it. Open vSwitch never buffers packets
> sent via an output actio
On May 23, 2013, at 5:51 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks fine to me Ben, the wording is quite clear here.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 22, 2013, at 11:33 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 21, 2013, at 11:58 AM, Ben Pfaff wrote:
> On Tue, May 21, 2013 at 04:05:50PM +0000, Kyle Mestery (kmestery) wrote:
>> On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
>>> As an organizational tool for developers who might be interested in
>>> reviewing my c
On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
> As an organizational tool for developers who might be interested in
> reviewing my code, I've now posted all my outstanding unreviewed (or
> review in progress) code as branches in the github repository visible on
> the web at:
>https://gith
On May 16, 2013, at 12:36 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good Ben.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 13, 2013, at 4:07 PM, Pravin B Shelar wrote:
> __sum16 and __wsum are defined in types.h from kernel 3.7.
>
> Signed-off-by: Pravin B Shelar
Looks good.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
On May 13, 2013, at 10:33 AM, Jesse Gross wrote:
> When sending a packet, a positive length indicates success and a
> negative length indicates failure. However, the check for success
> looked for non-zero values which catches both of these cases. This
> can result in incorrect stats and leak memo
Just one minor nit, otherwise this is a nice cleanup Jarno! See below.
On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote:
> This reduces repeated code and makes it easier to add new UDP tunneling
> protocols.
>
> Signed-off-by: Jarno Rajahalme
> ---
> datapath/tunnel.c | 126
On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote:
> This reduces repeated code and makes it easier to add new UDP tunneling
> protocols.
>
I haven't reviewed this in detail yet, but when I tried to compile it on
Fedora, it
failed. The small incremental below fixes this on Fedora. I'll continu
On May 3, 2013, at 7:52 PM, Jesse Gross wrote:
> The get_config vport op is left over from old compatibility code,
> it is neither used nor implemented any more.
>
> Signed-off-by: Jesse Gross
Looks good Jesse.
___
dev mailing list
dev@openvswitch.or
On Apr 26, 2013, at 1:40 PM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 11:30 AM, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This
>> comit updates the OVS VXLAN implementation to reflect the new UDP port
>> number.
>>
>> Cc: Kenneth Duda
>> Signed-off-by: Kyle M
On Apr 26, 2013, at 12:57 PM, Justin Pettit wrote:
> On Apr 26, 2013, at 10:40 AM, Kyle Mestery wrote:
>
>> +Q: How much of the VXLAN protocol does Open vSwitch currently support?
>> +
>> +A: Open vSwitch currently supports the framing format for packets on the
>> + wire. There is currently no
On Apr 26, 2013, at 12:42 PM, Ben Pfaff wrote:
> On Fri, Apr 26, 2013 at 01:40:55PM -0400, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This
>> comit updates the OVS VXLAN implementation to reflect the new UDP port
>> number.
>>
>> Cc: Kenneth Duda
>> Signed-off-by:
On Apr 26, 2013, at 11:48 AM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 9:36 AM, Kyle Mestery (kmestery)
> wrote:
>> On Apr 26, 2013, at 11:12 AM, Jesse Gross wrote:
>>> On Fri, Apr 26, 2013 at 6:53 AM, Kyle Mestery wrote:
>>>> VXLAN was recently assigned UD
On Apr 26, 2013, at 11:12 AM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 6:53 AM, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This updates the OVS VXLAN
>> implementation to reflect the new UDP port number. It also updates the unit
>> test for VXLAN to pass with th
On Apr 23, 2013, at 11:30 AM, Ben Pfaff wrote:
> I keep seeing this question.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben, very succinct explanation.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Apr 22, 2013, at 11:15 PM, Ben Pfaff wrote:
> This question keeps coming up.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mar 25, 2013, at 2:01 PM, Pravin B Shelar wrote:
> While sending packet over tunnel it can get segmented or reallocated.
> In that case we loose OVS_CB(). But some tunneling protocol
> implementation needs OVS_CB(), e.g. vxlan needs OVS_CB()->flow which
> leads to kernel panic.
> Following patc
On Mar 21, 2013, at 5:26 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index 90d0003..d9224fa 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -714,6 +714,20 @@ A: It is to be expected that the VMs can't acc
On Mar 20, 2013, at 6:44 PM, Jesse Gross wrote:
> Allocation of the Netlink notification skb can potentially fail
> after changing vport configuration. In general, we try to avoid
> this by undoing any change we made but that is difficult for existing
> objects. This avoids the problem by preall
On Mar 14, 2013, at 5:21 PM, Ben Pfaff wrote:
> On other platforms there is no benefit to linking against libpcap, because
> it is not used.
>
> Signed-off-by: Ben Pfaff
> CC: Ed Maste
Looks fine to me.
___
dev mailing list
dev@openvswitch.org
http:
On Feb 28, 2013, at 11:21 AM, Jesse Gross
wrote:
> On Thu, Feb 28, 2013 at 6:30 AM, Kyle Mestery wrote:
>> In get_tunnel_config(), distinguish between VXLAN and LISP when deciding
>> whether or not to print UDP destination port. Only add the UDP
>> destination port for either protocol if it is n
On Feb 27, 2013, at 6:31 PM, Jesse Gross wrote:
> On Wed, Feb 27, 2013 at 10:43 AM, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>> ---
>> tests/tunnel.at | 69
>> +
>> 1 file changed, 69 insertions(+)
>
> Applied, thanks a lot for w
On Feb 27, 2013, at 11:26 AM, Ben Pfaff wrote:
> On Wed, Feb 27, 2013 at 11:08:49AM -0500, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>
> How's this version? I did a lot of editing so I added myself as a
> Co-authored-by:, but I'll remove that if you object.
>
I'm fine with that. This
On Feb 27, 2013, at 10:47 AM, Jesse Gross wrote:
> On Wed, Feb 27, 2013 at 7:49 AM, Kyle Mestery wrote:
>> This adds unit tests for VXLAN and LISP. I'd like some feedback on this in
>> the
>> following areas:
>>
>> 1. Should I rename the existing tunnel.at to tunnel-gre.at and make the
>> equ
26, 2013 at 11:36 AM, Ethan Jackson wrote:
>> I'm doing the backport now. Whats the name of Pravin's patch you're
>> referring to? Is that on master, or still in review?
>>
>> Ethan
>>
>>
>> On Tue, Feb 26, 2013 at 11:27 AM, Kyle Mestery (kmes
el infrastructure.
> Ethan
>
>
> On Tue, Feb 26, 2013 at 11:27 AM, Kyle Mestery (kmestery)
> wrote:
> On Feb 26, 2013, at 1:19 PM, Jesse Gross wrote:
> > On Tue, Feb 26, 2013 at 11:10 AM, Ethan Jackson wrote:
> >> Looks good to me with the following incremental
On Feb 26, 2013, at 1:16 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Feb 26, 2013, at 1:21 PM, Ethan Jackson wrote:
>
>
> Ah yes, I think you're right. This interface is confusing, I assumed that
> assignment was just unnecessary. I'll send out a patch.
>
>
> Ah nevermind, I haven't merged it yet. Good catch, thanks.
>
> Ethan
Cool, glad we caught it
On Feb 26, 2013, at 1:19 PM, Jesse Gross wrote:
> On Tue, Feb 26, 2013 at 11:10 AM, Ethan Jackson wrote:
>> Looks good to me with the following incremental which I've applied. I'll
>> merge
>> shortly. Thanks for doing this work Kyle.
>
> We should make sure that whatever patches are necessar
Thanks for the review Ethan, one question on this below.
On Feb 26, 2013, at 1:10 PM, Ethan Jackson
wrote:
> Looks good to me with the following incremental which I've applied. I'll
> merge
> shortly. Thanks for doing this work Kyle.
>
> Ethan
>
> ---
> ofproto/ofproto-dpif.c |4 +---
>
On Feb 26, 2013, at 9:21 AM, Changbin Liu wrote:
>
>
> On Tue, Feb 26, 2013 at 9:54 AM, Kyle Mestery (kmestery)
> wrote:
> On Feb 25, 2013, at 10:00 PM, Changbin Liu wrote:
> >
> > Hi Kyle,
> >
> > Thanks so much for your reply!
> >
> > To
you mean does VXLAN encapsulate STP packets? Or
are you looking for how VXLAN interacts with STP?
> Changbin
>
>
> On Mon, Feb 25, 2013 at 9:53 PM, Kyle Mestery (kmestery)
> wrote:
> On Feb 25, 2013, at 8:40 PM, Changbin Liu
> wrote:
> > Hi folks,
> >
> >
On Feb 25, 2013, at 8:40 PM, Changbin Liu
wrote:
> Hi folks,
>
> I have been using OpenvSwtich for a while and the VXLAN feature is awesome.
> We are able to run OpenStack on top of it now. During deployment, I have one
> question: how to set the VNI (VXLAN Network ID) of VXLAN tunnels? I have
On Feb 25, 2013, at 12:05 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Feb 24, 2013, at 8:58 PM, Lorand Jakab wrote:
> The VXLAN draft just got updated from -02 to -03, with no major changes.
> Update documentation to reflect the change.
>
> Signed-off-by: Lorand Jakab
Looks good to me.
Acked-by: Kyle Mestery
___
d
On Feb 15, 2013, at 4:12 PM, Kyle Mestery wrote:
> v3 Changes to main loop from Ethan along with comments from Ben.
> v2 fixes error handling noticed by Ben.
Ethan:
Any chance you can review this and possibly push it up? This, combined with
Pravin's latest tunnel cleanup patch seems to get VXLA
On Feb 21, 2013, at 10:52 AM, Pravin B Shelar wrote:
> Since userspace flow based tunneling code is checked in, the kernel
> port based tunneling code can be removed.
>
> Patch removes following components:
> - tunnel ports hash table and moved tunnel ports list to individual
> vports.
> - Clea
On Feb 20, 2013, at 1:56 PM, Kyle Mestery (kmestery) wrote:
> On Feb 20, 2013, at 12:44 PM, Jesse Gross wrote:
>> Here are a couple of small comments that I'd already written. I
>> haven't gone through the main part of the patch yet but I figured that
>> I mig
On Feb 20, 2013, at 12:44 PM, Jesse Gross wrote:
> Here are a couple of small comments that I'd already written. I
> haven't gone through the main part of the patch yet but I figured that
> I might as well send them if you are going to respin the patch.
>
> On Tue, Feb 19, 2013 at 5:35 PM, Pravi
On Feb 20, 2013, at 10:15 AM, "Rajahalme, Jarno (NSN - FI/Espoo)"
wrote:
>
> On Feb 20, 2013, at 18:00 , ext Kyle Mestery (kmestery) wrote:
>
>> On Feb 19, 2013, at 7:35 PM, Pravin B Shelar wrote:
>>> Since userspace flow based tunneling code is checked in, t
On Feb 19, 2013, at 7:35 PM, Pravin B Shelar wrote:
> Since userspace flow based tunneling code is checked in, the kernel
> port based tunneling code can be removed. Following patch removes
> this tunnel compatibility code and simplifies it.
>
> Signed-off-by: Pravin B Shelar
>
> Bug #15078
I
VXLAN is currently in a state of flux upstream due to the flow-based tunneling
changes. I would
wait another few weeks for things to settle down.
Alternatively, you could move to the below commit. I've tested things fairly
well at this commit
and it works for what I was using it for:
commit 3b6
On Feb 15, 2013, at 4:04 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 02:00:59PM -0800, Ethan Jackson wrote:
>>> I don't think so. If you look, the code which is assigning iter->odp_port
>>> first
>>> checks if node is NULL.
>>
>> Actually no I think he's right. In the condition where the nod
Ignore this one, I had some issues on my end with sending it.
On Feb 15, 2013, at 4:01 PM, Kyle Mestery
wrote:
> v3 Changes to main loop from Ethan.
> v2 fixes error handling noticed by Ben.
> ---
> Garbage collect tnl_backers during type_run(). Add new
> tnl_backers if a VXLAN ports UDP port c
On Feb 15, 2013, at 3:56 PM, Kyle Mestery (kmestery) wrote:
> On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
>> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>>> I think the main loop of this version still has some bugs. It doesn't
>>> properly
&
On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>> I think the main loop of this version still has some bugs. It doesn't
>> properly
>> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s
>> backer
>> changes (in
On Feb 15, 2013, at 2:49 PM, Ethan Jackson wrote:
> I think the main loop of this version still has some bugs. It doesn't
> properly
> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
> changes (in some cases). What about something like the following? I think
> it
On Feb 15, 2013, at 10:58 AM, Jesse Gross wrote:
> On Thu, Feb 14, 2013 at 6:37 AM, Kyle Mestery wrote:
>> In tnl_set_config(), when determining if a tunnel port
>> already exists, make sure to also check the destination port. For VXLAN, this
>> can be different and allows multiple VXLAN ports in
On Feb 14, 2013, at 12:49 PM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 06:47:56PM +0000, Kyle Mestery (kmestery) wrote:
>> On Feb 14, 2013, at 12:33 PM, Ben Pfaff wrote:
>>> On Thu, Feb 14, 2013 at 09:37:30AM -0500, Kyle Mestery wrote:
>>>> Garbage collect tnl_
On Feb 14, 2013, at 12:33 PM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 09:37:30AM -0500, Kyle Mestery wrote:
>> Garbage collect tnl_backers during type_run(). Add new
>> tnl_backers if a VXLAN ports UDP port changes.
>>
>> Signed-off-by: Kyle Mestery
>
> The error handling here is bad. If it
On Feb 14, 2013, at 12:07 PM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 09:37:28AM -0500, Kyle Mestery wrote:
>> Move dpif_backer->tnl_backers from a "struct sset" to a
>> "struct simap". Store odp_port in the new map. This will make it easier to
>> access the odp_port for future patches.
>>
>>
On Feb 14, 2013, at 12:00 PM, Ben Pfaff
wrote:
> On Thu, Feb 14, 2013 at 09:37:26AM -0500, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>> Acked-by: Ethan Jackson
>
> I'm pretty sure this introduces a memory leak because ofpbuf_init()
> allocates data and I don't see it getting freed any
On Feb 14, 2013, at 11:55 AM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 09:37:25AM -0500, Kyle Mestery wrote:
>> Modify netdev_vport_get_dpif_port() to return a name for
>> VXLAN ports which includes the destination UDP port number as a part of the
>> name.
>>
>> Signed-off-by: Kyle Mestery
>>
On Feb 14, 2013, at 11:37 AM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 09:37:27AM -0500, Kyle Mestery wrote:
>> Add utility functions to the simap structure. These are
>> used by future patches in this seris. The functions added are.
>>
>> Signed-off-by: Kyle Mestery
>> Acked-by: Ethan Jackson
On Feb 14, 2013, at 8:37 AM, Kyle Mestery
wrote:
> With the recent flow based tunneling changes, VXLAN support was broken. These
> patches address this by enabling VXLAN to work as it did before flow based
> tunneling was pushed upstream.
>
> Kyle Mestery (6):
> Modify netdev_vport_get_dpif_por
On Feb 6, 2013, at 12:57 PM, Ethan Jackson
wrote:
>> I see an issue right now. It looks like netdev_vport_get_dpif_port()
>> currently just returns a const char * by returning a pointer to the dpif_port
>> pointer on vport_class. Modifying this behavior to return a dynamic
>> name here means we n
On Feb 6, 2013, at 11:16 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Feb 4, 2013, at 3:50 PM, Ethan Jackson wrote:
>> Yes, I'd like to help here. Can you shoot me any ideas you may have?
>> I've been looking at this in my free time today. Tomorrow I should be
>> able to dedicate most of the day to it.
>
> Ok sounds good. Thanks for taking this on.
>
Just ge
On Feb 4, 2013, at 2:59 PM, Ethan Jackson wrote:
>> I figured this out. It looks like the flow based tunneling changes no longer
>> propagate the destination UDP port down to VXLAN, which requires it. Because
>> of this, the VXLAN vport code in the kernel is returning an error. I'll go
>> ahead
On Feb 3, 2013, at 8:56 PM, Kyle Mestery (kmestery) wrote:
> I'm running with the latest master, and I noticed I can no longer configure
> VXLAN ports. I'm tracking this down, but wanted to let folks on the list know
> as well.
>
> I am configure my VXLAN port like th
I'm running with the latest master, and I noticed I can no longer configure
VXLAN ports. I'm tracking this down, but wanted to let folks on the list know
as well.
I am configure my VXLAN port like this:
ovs-vsctl add-port br2 vxlan1 -- set interface vxlan1 \
type=vxlan o
On Feb 2, 2013, at 10:53 AM, Ben Pfaff wrote:
> We've had this question a few times lately.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Feb 1, 2013, at 6:58 PM, Jesse Gross wrote:
> Some tunnel code in OVS (for example, CAPWAP) uses the skb->cb to
> store information while processing packets. However, if we don't
> find an appropriate tunnel port on receive, then we send an ICMP
> port unreachable message, which calls back int
On Feb 1, 2013, at 12:03 PM, Jesse Gross wrote:
> On Fri, Feb 1, 2013 at 6:30 AM, Kyle Mestery (kmestery)
> wrote:
>> On Jan 29, 2013, at 9:13 PM, Kyle Mestery (kmestery)
>> wrote:
>>> On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote:
>>>> On Tue, Jan 29,
On Jan 29, 2013, at 9:13 PM, Kyle Mestery (kmestery) wrote:
> On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote:
>> On Tue, Jan 29, 2013 at 3:27 PM, Kyle Mestery (kmestery)
>> wrote:
>>> On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote:
>>>> The other area that
On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote:
> On Tue, Jan 29, 2013 at 3:27 PM, Kyle Mestery (kmestery)
> wrote:
>> On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote:
>>> The other area that I'm somewhat concerned about is with upstreaming.
>>> Once we get OV
On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote:
> On Fri, Jan 25, 2013 at 2:13 PM, Kyle Mestery (kmestery)
> wrote:
>> On Jan 23, 2013, at 12:02 PM, Jesse Gross wrote:
>>> On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote:
>>>> The following two pat
On Jan 28, 2013, at 1:00 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> Now that userspace implements patch ports completely internally,
> it's possible to remove the kernel implementation of them.
>
> Signed-off-by: Jesse Gross
Looks good.
Acked-by: Kyle Mestery
___
de
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> When tunnel header caching was in use, it was necessary to detect
> configuration changes that would invalidate the cache. This was
> done using a sequence number on the configuration. However, now
> that header caching has been removed the seque
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> Path MTU discovery can improve tunnel performance in some cases
> but is non-standard and can introduce problems in others. As a
> result it has already been deprecated and removed from userspace.
> This removes the corresponding kernel support to
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> The ability to retrieve and set MAC addresses on vports is only
> necessary for tunnel ports (the addresses for actual devices can be
> retrieved through direct Linux mechanisms). Tunnel ports only used
> the information for the purpose of generat
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> We want to move the GRE vport ID into the upstream range but in
> order to ease the transition kept the old ID around for one release.
> This removes the old value.
>
> Signed-off-by: Jesse Gross
Looks good.
Acked-by: Kyle Mestery
___
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote:
> Inheritance of the Don't Fragment bit in tunnels will not be
> supported with flow based tunneling and has already been removed
> from userspace. This removes the corresponding kernel support.
>
> Signed-off-by: Jesse Gross
Looks good to me.
On Jan 23, 2013, at 12:02 PM, Jesse Gross wrote:
> On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote:
>> The following two patches provide support for the LISP tunneling protocol
>> into
>> Open vSwitch. See the latest IETF draft for LISP here:
>>
>> http://tools.ietf.org/html/draft-ietf-lis
1 - 100 of 253 matches
Mail list logo
