On Feb 20, 2013, at 10:15 AM, "Rajahalme, Jarno (NSN - FI/Espoo)" <jarno.rajaha...@nsn.com> wrote: > > On Feb 20, 2013, at 18:00 , ext Kyle Mestery (kmestery) wrote: > >> On Feb 19, 2013, at 7:35 PM, Pravin B Shelar <pshe...@nicira.com> wrote: >>> Since userspace flow based tunneling code is checked in, the kernel >>> port based tunneling code can be removed. Following patch removes >>> this tunnel compatibility code and simplifies it. >>> >>> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> >>> >>> Bug #15078 >> >> >> I'm in the process of reviewing this now, and testing with patch 6/6 of the >> series I posted last week. Initial results show the destination port not >> being >> set for VXLAN ports. Looking into that now. >> > > I looked over this earlier today and it seems to me that also the vport_vxlan > now ever keeps one vport around. For example, vxlan_tnl_destroy() does > ovs_net->vport_net.vxlan_vport = NULL; which does not seem right, if there > are multiple vxlan vports (one for each configured UDP destination port). > > Jarno >
There's also a crash with this patch when changing the destination UDP port of a VXLAN tunnel: [ 7637.743173] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 [ 7637.743340] IP: [<ffffffffa04db321>] vxlan_tunnel_release+0x11/0x40 [openvswitch] [ 7637.743504] PGD 79712067 PUD 79780067 PMD 0 [ 7637.743594] Oops: 0002 [#1] SMP [ 7637.743666] Modules linked in: ip6table_filter ip6_tables ebtable_nat ebtables nfsv3 nfs_acl nfsv4 auth_rpcgss nfs dns_resolver fscache ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat openvswitch(OF) nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack lockd sunrpc xt_CHECKSUM iptable_mangle bridge stp llc be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i cxgb4 cxgb3i cxgb3 mdio libcxgbi ib_iser rdma_cm ib_addr iw_cm ib_cm ib_sa ib_mad ib_core iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi snd_ens1371 gameport snd_rawmidi snd_ac97_codec ac97_bus snd_seq snd_seq_device snd_pcm snd_page_alloc snd_timer snd btusb vmwgfx coretemp crc32c_intel ghash_clmulni_intel ppdev bluetooth vmw_balloon microcode rfkill ttm drm soundcore e1000 binfmt_misc shpchp i2c_piix4 i2c_core parport_pc parport vhost_net [ 7637.744570] tun macvtap macvlan kvm_intel kvm mptspi mptscsih mptbase scsi_transport_spi [ 7637.744653] CPU 1 [ 7637.744721] Pid: 889, comm: ovs-vswitchd Tainted: GF O 3.7.8-202.fc18.x86_64 #1 VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform [ 7637.744926] RIP: 0010:[<ffffffffa04db321>] [<ffffffffa04db321>] vxlan_tunnel_release+0x11/0x40 [openvswitch] [ 7637.745072] RSP: 0018:ffff88007a27d968 EFLAGS: 00010292 [ 7637.745145] RAX: 0000000000000002 RBX: 0000000000000000 RCX: 0000000000000000 [ 7637.745873] RDX: 0000000000000000 RSI: ffffffff81ca3b40 RDI: 0000000000000000 [ 7637.746232] RBP: ffff88007a27d978 R08: 0000000000000000 R09: 0000000000000000 [ 7637.746589] R10: dead000000200200 R11: 0000000000000000 R12: ffff88007952cbc0 [ 7637.746945] R13: ffff880036751a00 R14: ffff880036750e00 R15: ffffffff81ca3b40 [ 7637.747296] FS: 00007fcde73c1800(0000) GS:ffff88007f620000(0000) knlGS:0000000000000000 [ 7637.747980] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 7637.748322] CR2: 0000000000000020 CR3: 0000000079717000 CR4: 00000000001407e0 [ 7637.748689] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 7637.749053] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 7637.749398] Process ovs-vswitchd (pid: 889, threadinfo ffff88007a27c000, task ffff880079611720) [ 7637.750061] Stack: [ 7637.750368] ffff880036751a00 ffff88007a2ab400 ffff88007a27d998 ffffffffa04db3cd [ 7637.750987] ffff88007a2ab400 ffff88007a2ab400 ffff88007a27d9b8 ffffffffa04d9dc6 [ 7637.751643] ffff88007a27d9d8 ffff88007a2ab400 ffff88007a27d9d8 ffffffffa04d53f4 [ 7637.752265] Call Trace: [ 7637.752570] [<ffffffffa04db3cd>] vxlan_tnl_destroy+0x7d/0xb0 [openvswitch] [ 7637.752880] [<ffffffffa04d9dc6>] ovs_vport_del+0x46/0x70 [openvswitch] [ 7637.753193] [<ffffffffa04d53f4>] ovs_dp_detach_port+0x44/0x70 [openvswitch] [ 7637.758413] [<ffffffffa04d5d99>] ovs_vport_cmd_del+0x79/0xc0 [openvswitch] [ 7637.759029] [<ffffffff81551870>] genl_rcv_msg+0x250/0x2d0 [ 7637.759391] [<ffffffff81551620>] ? genl_rcv+0x40/0x40 [ 7637.759917] [<ffffffff81551221>] netlink_rcv_skb+0xb1/0xc0 [ 7637.760248] [<ffffffff81551605>] genl_rcv+0x25/0x40 [ 7637.760534] [<ffffffff81550b41>] netlink_unicast+0x1a1/0x220 [ 7637.760835] [<ffffffff81550ec1>] netlink_sendmsg+0x301/0x3c0 [ 7637.761142] [<ffffffff8150f17c>] sock_sendmsg+0xbc/0xf0 [ 7637.761437] [<ffffffff81510027>] ? sock_recvmsg+0xd7/0x110 [ 7637.761728] [<ffffffff8150fddc>] __sys_sendmsg+0x3ac/0x3c0 [ 7637.762007] [<ffffffff8154f8b3>] ? netlink_table_ungrab+0x33/0x40 [ 7637.762283] [<ffffffff8154f9e2>] ? netlink_insert+0x122/0x200 [ 7637.762558] [<ffffffff812fbb41>] ? list_del+0x11/0x40 [ 7637.762824] [<ffffffff811d890a>] ? ep_call_nested.constprop.12+0xca/0xe0 [ 7637.763086] [<ffffffff811d8738>] ? clear_tfile_check_list+0x28/0x60 [ 7637.763349] [<ffffffff81511f29>] sys_sendmsg+0x49/0x90 [ 7637.763623] [<ffffffff8163f999>] system_call_fastpath+0x16/0x1b [ 7637.763888] Code: 65 e0 4c 8b 6d e8 4c 8b 75 f0 4c 8b 7d f8 c9 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 53 48 89 fb 48 83 ec 08 <83> 6f 20 01 75 1d 48 8b 47 18 48 8b 78 20 e8 7c 96 03 e1 48 89 [ 7637.764742] RIP [<ffffffffa04db321>] vxlan_tunnel_release+0x11/0x40 [openvswitch] [ 7637.765272] RSP <ffff88007a27d968> [ 7637.765525] CR2: 0000000000000020 [ 7637.766329] ---[ end trace eb00feb71edd56b4 ]--- _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
