On Feb 14, 2013, at 11:37 AM, Ben Pfaff <b...@nicira.com> wrote: > On Thu, Feb 14, 2013 at 09:37:27AM -0500, Kyle Mestery wrote: >> Add utility functions to the simap structure. These are >> used by future patches in this seris. The functions added are. >> >> Signed-off-by: Kyle Mestery <kmest...@cisco.com> >> Acked-by: Ethan Jackson <et...@nicira.com> > > Applied to master, thanks. > > The standards fascist in me worried a bit about: >> + if (node) { >> + simap_delete(simap, node); >> + } >> + return node != NULL; > because in C it is technically undefined behavior to do anything to a > freed pointer, even compare it against NULL, so I changed it to avoid > that.
That works for me, thanks Ben! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev