On Jul 30, 2013, at 7:17 PM, Jesse Gross <je...@nicira.com> wrote: > On Fri, Jul 26, 2013 at 2:21 PM, Kyle Mestery <kmest...@cisco.com> wrote: >> Add support for Linux kernel 3.9. >> >> Signed-off-by: Kyle Mestery <kmest...@cisco.com> >> CC: Pravin B Shelar <pshelar at nicira.com> > > I think it's not strictly required to do the restoration here since > the only user of skb->cb in this function block is vlans, which isn't > a problem on the kernels that have the new behavior with > skb_gso_segment(). It's a little bit more tenuous then I would > normally like but if we do it here then we should also do it for > datapath.c:queue_gso_packet() which seems like overkill. > OK, fair enough, I'll remove it from netdev_send().
> However, I think we do need it in tunnel.c since LISP accesses skb->cb > to get the flow to compute the source port. Yes, I forgot about this one. New patch inbound, thanks for the review Jesse! Kyle _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
