Hey Uri,
* Elzur, Uri (uri.el...@intel.com) wrote:
> I find it strange and misleading for full time employees to use aliases on
> OPEN SOURCE mailing lists. Is the code OPEN but affiliation is not? Does
> anyone work pro bono?
This is actually a pretty normal practice for open source developers
kport".
Reported-by: Andrei Andone
Signed-off-by: Chris Wright
Cc: Thomas Graf
Cc: Pravin Shelar
---
datapath/linux/compat/include/linux/netdevice.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/linux/compat/include/linux/netdevice.h
b/datapath/linux/comp
* Justin Pettit (jpet...@nicira.com) wrote:
> On Apr 26, 2013, at 10:40 AM, Kyle Mestery wrote:
>
> > +Q: How much of the VXLAN protocol does Open vSwitch currently support?
> > +
> > +A: Open vSwitch currently supports the framing format for packets on the
> > + wire. There is currently no sup
* christopher barry (cba...@rjmetrics.com) wrote:
> What will be the latest valid tag to build from to include brcompat?
it's still there (just deprecated and gives a warning). so at least
v1.9.x tags will have it (in deprecated/warning form).
thanks,
-chris
_
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> > * Kyle Mestery (kmest...@cisco.com) wrote:
> >> + udp_encap_enable();
> >
> > This is a new function, did you provide a fallback/noop (since it looks
> &
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 28, 2012, at 11:01 AM, Chris Wright wrote:
> > Right. OTV is commonly, but not exclusively, used now. Post draft
> > we should expect a final port number. But it's a relatively small set
> > of functionali
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 28, 2012, at 10:34 AM, Chris Wright
> wrote:
> > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> >>> * Kyle M
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote:
> > * Kyle Mestery (kmest...@cisco.com) wrote:
> >> +
> >> + vxlan_port->port = dst_port;
> >> + vxlan_port->count++;
>
* Kyle Mestery (kmest...@cisco.com) wrote:
> @@ -23,6 +23,7 @@
> /kmemdup.c
> /loop_counter.c
> /modules.order
> +/net_namespace.c
> /netdevice.c
> /net_namespace.c
> /random32.c
spurious change?
> @@ -39,5 +40,6 @@
> /vport-internal_dev.c
> /vport-netdev.c
> /vport-patch.c
> +/vport-vxl
* Pravin Shelar (pshe...@nicira.com) wrote:
> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote:
> > @@ -458,6 +477,9 @@ int ovs_execute_actions(struct datapath *dp, struct
> > sk_buff *skb)
> > struct sw_flow_actions *acts =
> > rcu_dereference(OVS_CB(skb)->flow->sf_acts);
> >
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> On Sep 25, 2012, at 12:06 PM, Chris Wright wrote:
> > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> >> They are different, and not as flexible as the RHEL ones.
> >>
> >> Let me give the RH
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote:
> They are different, and not as flexible as the RHEL ones.
>
> Let me give the RHEL ones with the latest OVS a try on Fedora and see
> what happens there, and based on the result of that I'll see about fixing
> these
> up as well.
You should
his for
> >> stable in 3.4/3.5? It's currently in Linus's tree as
> >> 7fe99e2d434eafeac0c57b279a77e5de39212636.
> >>
> >
> > What vendor is shipping openvswitch enabled and requires the fix to
> > be in -stable before they'll ship it to cus
* ravi kerur (rke...@gmail.com) wrote:
> Thanks Ben, I don't remember seeing core file under
> tests/testsuite.dir/0449 directory. I will double-check, if its
> available it will be definitely helpful.
Core file creation might be disabled (check ulimit).
___
* Ethan Jackson (et...@nicira.com) wrote:
> It will be garbage collected later when the bridge notices a port in
> the datapath which it doesn't know about.
OK, thanks for clarifying.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
* Ethan Jackson (et...@nicira.com) wrote:
> > Is this part correct when !may_port_action?
>
> Seems correct to me, wether or not we can delete the port from
> ofproto, we can go ahead and clean up the interface's netdev. The
> ofproto port will be cleaned up later. I may be missing something
> t
* Ethan Jackson (et...@nicira.com) wrote:
> @@ -1039,7 +1079,8 @@ add_del_bridges(const struct ovsrec_open_vswitch *cfg)
> * port already belongs to a different datapath, so we must do all port
> * deletions before any port additions. */
> static void
> -bridge_del_ofproto_ports(struct bridge
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 16, 2012 at 04:30:17PM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Fri, Mar 16, 2012 at 04:03:23PM -0700, Jesse Gross wrote:
> > > > On Fri, Mar 16, 2012 at 1:13 PM, Ben Pfaff
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 16, 2012 at 04:03:23PM -0700, Jesse Gross wrote:
> > On Fri, Mar 16, 2012 at 1:13 PM, Ben Pfaff wrote:
> > > diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
> > > index 0d858a1..57f76d5 100644
> > > --- a/utilities/ovs-vsctl.8.in
* Ben Pfaff (b...@nicira.com) wrote:
> >From early days, Nicira used the --with-build-number option to configure to
> stamp our internal builds. We've since switched to another scheme, so
> this option is obsolete.
Looks good to me.
Two hits left on grep, look unrelated:
tests/interface-reconfi
* Ben Pfaff (b...@nicira.com) wrote:
> On Wed, Mar 14, 2012 at 10:24:53AM -0700, Chris Wright wrote:
> > The recipe above is working around the network initscripts lack of DHCP
> > support (I'll fix that in Fedora). It's also being careful to not
> > trigger Networ
* Gary Kotton (gkot...@redhat.com) wrote:
> I have a host that has 1 NIC (em1). The IP address was received via
> DHCP. After installing openvswitch (openvswitch.x86_64 1.4.0-4.fc17)
> I did the following:
>
>ovs-vsctl add-br br-int
>ovs-vsctl add-port br-int em1
>
> This cases a loss of
relevant for brcompat module.
Cc: Jesse Gross
Signed-off-by: Chris Wright
---
v2:
- changed the conditional to allow keeping linux/Modules.mk as one file
- split build_modules and dist_modules setting to ensure brcompat
module source is distributed
- verified against distcheck w/ both --{disable
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Mar 13, 2012 at 02:58:30PM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > In the OVS_CHECK_BRCOMPAT macro definition, the "yes" case and the
> > > "not specified" case ar
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Mar 13, 2012 at 12:18:07PM -0700, Chris Wright wrote:
> > This adds ability to do:
> >
> > ./configure --disable-brcompat
> >
> > to disable building userspace and kernel module associated with
> > providi
relevant for brcompat module.
Signed-off-by: Chris Wright
---
v2:
- changed the conditional to allow keeping linux/Modules.mk as one file
- split build_modules and dist_modules setting to ensure brcompat
module source is distributed
- verified against distcheck w/ both --{disable,enable
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 11:18:58AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > > > This adds ability to do:
> > > >
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > This adds ability to do:
> >
> > ./configure --disable-brcompat
> >
> > to disable building userspace and kernel module associated with
> &g
Thanks.
Acked-by: Chris Wright
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ion number changes, so we can just "touch" it when it doesn't
> really need to change.
>
> The same pattern is used elsewhere in the tree for other files in the same
> situation, e.g. the various RPM spec files.
Thanks.
Acked-by: Chris Wright
___
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > Without this change, these tests try to write to /var/run, which fails
> > > unless "make check" is run as root.
* Ben Pfaff (b...@nicira.com) wrote:
> Without this change, these tests try to write to /var/run, which fails
> unless "make check" is run as root.
Yay! This was breaking for me on Friday too.
I'm still hitting this from make distcheck (haven't dug into it yet):
mv ovsdb/ovsdb-server.1.tmp ovsd
This adds ability to do:
./configure --disable-brcompat
to disable building userspace and kernel module associated with
providing linux bridge compatibility.
Signed-off-by: Chris Wright
---
configure.ac|1 +
datapath/Makefile.am|2 ++
datapath/linux
build stages which have differing conditional syntax.
Signed-off-by: Chris Wright
---
datapath/Makefile.am |3 +-
datapath/linux/Kbuild.in |3 +-
datapath/linux/Makefile.main.in |3 +-
datapath/linux/Module-brcompat.mk|3 +
datapath/linux/M
This short series adds ability to disable building brcompat user and
kernel space bits. I've done some light testing to verify it's doing
what I expected, but may have missed some subtleties of the build
system.
thanks,
-chris
Chris Wright (2):
datapath: split out linux/Modules.mk
ath: omit _mod from module names).
Sorry about that, initial grep of _mod turned up enough noise that I
completley missed that.
FWIW:
Acked-by: Chris Wright
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
27;s coming from upstream
linux or built from datapath/ as part of a local build.
Signed-off-by: Chris Wright
---
Minor NEWS conflict w/ Ethan's patch nicira-ext: Add a 6th NXM register.
INSTALL.Linux | 14 +++---
INSTALL.XenServer
* Jesse Gross (je...@nicira.com) wrote:
> On Thu, Mar 8, 2012 at 2:52 PM, Chris Wright wrote:
> > * Jesse Gross (je...@nicira.com) wrote:
> >> On Wed, Mar 7, 2012 at 10:28 AM, Chris Wright wrote:
> >> > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
> &
* Jesse Gross (je...@nicira.com) wrote:
> On Wed, Mar 7, 2012 at 10:28 AM, Chris Wright wrote:
> > This renames the datapath modules:
> >
> > openvswitch_mod -> openvswitch
> > brcompat_mod -> brcompat
> >
> > The first makes the module name consist
path/linux/net_namespace.c
# datapath/linux/workqueue.c
Signed-off-by: Chris Wright
---
Applies after [PATCH 1/2] datapath: rename brcompat.c to brcompat_main.c
datapath/linux/.gitignore |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/datapath/linux/.gitignore
27;s coming from upstream
linux or built from datapath/ as part of a local build.
Signed-off-by: Chris Wright
---
INSTALL.Linux | 14 +++---
INSTALL.XenServer |2 +-
INSTALL.bridge |4 ++-
This just makes it easier to subsequently rename the brcompat_mod module
to brcompat without introducing circular dependencies.
Signed-off-by: Chris Wright
---
datapath/brcompat.c | 578 -
datapath/brcompat_main.c | 578
This simply renames the datapath modules, omitting the trailing _mod.
Patch 2/2 has details on why.
Chris Wright (2):
datapath: rename brcompat.c to brcompat_main.c
datapath: omit _mod from module names
INSTALL.Linux | 14 +-
INSTALL.XenServer
* Ansis Atteka (aatt...@nicira.com) wrote:
> On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote:
> > insert_openvswitch_mod_if_required () {
> > -# If openvswitch_mod is already loaded then we're done.
> > -test -e /sys/module/openvswitch_mod && r
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 02, 2012 at 11:31:44AM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > I wonder whether we should just drop the "_mod" from our out-of-tree
> > > module names. Seems simpl
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote:
> > This is just an RFC, partly because it ignores datapath/ so you could
> > build a module that the runtime can't install. Now that the ovs datapath
> > is upstream an
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Mar 01, 2012 at 11:09:07PM -0800, Chris Wright wrote:
> > I'm pondering adding a way to disable brcompat. This would keep from
> > building it and strip it from config templates, init scripts, ovs-ctl,
> > etc... Here'
I'm pondering adding a way to disable brcompat. This would keep from
building it and strip it from config templates, init scripts, ovs-ctl,
etc... Here's a quick hack to give an idea.
Any thoughts whether this is worth pursuing, and if so ideas on best way
to do it?
thanks,
-chris
diff --git a
This is just an RFC, partly because it ignores datapath/ so you could
build a module that the runtime can't install. Now that the ovs datapath
is upstream and named simply openvswitch, tools like ovs-ctl fail to
function w/ the native datapath module. This is a simple example using
an environment
s/ovsdmonitor/ovsdbmonitor/
Signed-off-by: Chris Wright
---
INSTALL.Linux |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/INSTALL.Linux b/INSTALL.Linux
index 8ef2315..da992b5 100644
--- a/INSTALL.Linux
+++ b/INSTALL.Linux
@@ -120,7 +120,7 @@ following software:
You
Needed for Fedora builds, might as well share it.
Signed-off-by: Chris Wright
---
ovsdb/ovsdbmonitor/automake.mk |5 -
ovsdb/ovsdbmonitor/ovsdbmonitor.desktop |7 +++
2 files changed, 11 insertions(+), 1 deletions(-)
create mode 100644 ovsdb/ovsdbmonitor
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 02, 2012 at 12:35:09AM +0100, Andreas Beckmann wrote:
> > On 2012-03-02 00:11, Ben Pfaff wrote:
> > > +mv /usr/share/openvswitch/pki /var/lib/openvswitch
> > > +ln -s /usr/share/openvswitch/pki /var/lib/openvswitch
> >
> >
It doesn't have dependencies on any packages that would install into
pkgdatadir, and for Fedora it makes directory ownership work better.
So move ovsdbmonitor python internals to its own data directory.
Signed-off-by: Chris Wright
---
I updated the debian install file here, although t
pletely follow all the debian
postinstall scripts, but looks sane ;) The m4 bit is obviously correct,
and it shouldn't effect the rhel spec file, which already sucks in
/var/lib/openvswitch.
Acked-by: Chris Wright
thanks,
-chris
___
d
* Simon Horman (ho...@verge.net.au) wrote:
> This makes struct nx_set_flow_format consistent with
> other similar structures.
>
> Signed-off-by: Simon Horman
Looks good to me.
Acked-by: Chris Wright
BTW, struct nx_flow_mod_table_id vendor/subtype would default to arch-Endian,
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Dec 22, 2011 at 10:00:34AM -0800, Chris Wright wrote:
> > Looks like one is missing for branch-1.4:
> >
> > b4059ef Update FSF address in LGPL notices in bugtool plugins.
>
> Thanks for pointing that out. I cherry-pic
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Dec 09, 2011 at 09:41:11AM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > All applied to master, thanks Chris. Do you want these on branch-1.4
> > > also?
> >
> > Yes, please.
&g
and the lib/sflow* sources). Let me know if
> this looks OK or not.
This looks good to me, thanks for doing that Neil.
Not sure if debian/copyright.in should get an update (never actually
mentioned sFlow to begin with).
> Signed-off-by: Neil McKee
Acke
* Ben Pfaff (b...@nicira.com) wrote:
> Pushed to master.
Thanks.
> Now I'm working on a Git hook to reject commits without S-o-b.
Nice idea.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This adds the Developer's Certificate of Origin to SubmittingPatches
to document the requirement to add Signed-off-by to patches.
Signed-off-by: Chris Wright
---
v2 Use new commit to illustrate S-o-b
SubmittingPatches | 151 +
1
This adds the Developer's Certificate of Origin to SubmittingPatches
to document the requirement to add Signed-off-by to patches.
Signed-off-by: Chris Wright
---
SubmittingPatches | 51 +++
1 files changed, 51 insertions(+), 0 deletions(-)
Is there any reason not to adopt consistent use of the Developer's
Certificate of Origin[1] as commonly used by the kernel and other
projects? It appears (understandably) consistent in the datapath,
however less consistent throughout userspace.
I can send a patch to SubmittingPatches if folks agr
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Dec 08, 2011 at 11:35:59PM -0800, Chris Wright wrote:
> > Here's a short series of small cleanups that have come from packaging
> > openvswitch for Fedora. Nothing terribly exciting here, the last two
> > may not be to every
27;
However, rpmlint generates the same warning as manpage-check was (it
uses -Tutf8), and manpages are generated using -Tutf8 (leading to an
fairly unreadable drawing). So let's change the logic a bit and allow
pdf generation w/ nice drawing and kill it for tty's.
Cc: Ethan Jackson
. Of course, the rpmlint warnings are as well,
however, this seems like a more logical place for the bugtool plugins.
Signed-off-by: Chris Wright
---
debian/openvswitch-common.install |2 +-
rhel/openvswitch.spec.in |2 +-
utilities/bugtool/automake.mk |2 +-
utilities/bu
Rename this helper script to simply ovs-lib, since it's primarily
a library of helper functions.
Signed-off-by: Chris Wright
---
debian/openvswitch-switch.init |2 +-
debian/openvswitch-switch.install |2 +-
rhel/etc_init.d_openvswitch |2 +-
Currently, ovs-lib.sh is installed as an executable. It's meant to be
sourced by external scripts, so install as data. Fixes rpmlint error:
E: script-without-shebang /usr/share/openvswitch/scripts/ovs-lib.sh
Could drop the .sh suffix in another commit.
Signed-off-by: Chris W
Fixes rpmlint warning:
W: spurious-executable-perm /etc/logrotate.d/openvswitch
W: non-conffile-in-etc /etc/logrotate.d/openvswitch
E: script-without-shebang /usr/share/openvswitch/scripts/sysconfig.template
Define rhel_cp() shell func and include file mode on install.
Signed-off-by: Chris
-configuration.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/network-status/openvswitch.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/kernel-info/openvswitch.xml
Signed-off-by: Chris Wright
---
.../bugtool/plugins/kernel-info/openvswitch.xml|2 +-
.../bugtool/plugins
Here's a short series of small cleanups that have come from packaging
openvswitch for Fedora. Nothing terribly exciting here, the last two
may not be to everyone's taste. I'm happy to rework if needed.
Chris Wright (7):
Update FSF address in LGPL notices in bugtool
Fix this rpmlint warning:
W: spurious-executable-perm /usr/share/doc/openvswitch-1.4.0/README.RHEL
by specifying mode on install.
Signed-off-by: Chris Wright
---
rhel/openvswitch.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rhel/openvswitch.spec.in b/rhel
* Brian Haley (brian.ha...@hp.com) wrote:
> On 12/06/2011 06:55 PM, Ben Pfaff wrote:
> > The comment on this function says that negative values indicate errors, and
> > the callers assume that too, but in fact it was returning positive errno
> > values, which are indistinguishable from valid fd num
* Pravin Shelar (pshe...@nicira.com) wrote:
> On Tue, Dec 6, 2011 at 2:29 PM, Jesse Gross wrote:
> > On Tue, Dec 6, 2011 at 12:45 PM, Pravin B Shelar wrote:
> >> diff --git a/datapath/linux/compat/include/linux/jiffies.h
> >> b/datapath/linux/compat/include/linux/jiffies.h
> >> index a64f226..77
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Dec 06, 2011 at 12:17:34PM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > > > If I pull the userspace utils from git, which ones ar
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > If I pull the userspace utils from git, which ones are best to use
> > with the code that's making it's way upstream, branch-1.3, branch-1.4,
> > master ?
>
> Either branch-1.4 or master should be
* John Fastabend (john.r.fastab...@intel.com) wrote:
> He is pushing and popping entire tags off 802.1Q for now but
> you can easily imagine MPLS tags and all sorts of other things
> people will _need_.
Right, already doing some generic encap/decap for tunnelling.
> Do we want tc and likely the s
* Stephen Hemminger (shemmin...@vyatta.com) wrote:
> Maybe someone with more insight than me can explain the relationship
> between Openflow and Open vSwitch. It maybe that the portability
> of Openflow makes the old qdisc, classifiers to use/implement.
I'm sure I can't answer the last bit as well
77 matches
Mail list logo
