Thanks for the effort, I think the split clarifies a lot of things and adds
some useful piece of information
A couple of comments below, otherwise this looks good to me
2016-07-03 7:48 GMT-07:00 Bhanuprakash Bodireddy <
bhanuprakash.bodire...@intel.com>:
> Refactor the INSTALL.DPDK in to two doc
I agree, maybe the section about static analysis could be added to
INSTALL.md (doesn't need to be part of this series).
Other than that the patch looks good to me
Thanks,
Daniele
2016-07-04 1:19 GMT-07:00 Bodireddy, Bhanuprakash <
bhanuprakash.bodire...@intel.com>:
> >-Original Message---
Markos Chandras writes:
> On 07/05/2016 03:08 PM, Aaron Conole wrote:
>> Markos Chandras writes:
>>
>>> On 07/02/2016 03:22 AM, Aaron Conole wrote:
Markos Chandras writes:
> The ovs-ctl script is used to launch ovs-vswitchd among other things.
> However it does not make it po
applied to master, thank you.
On Wed, Jul 6, 2016 at 12:36 AM, Ben Pfaff wrote:
> On Tue, Jul 05, 2016 at 06:35:04PM +0900, YAMAMOTO Takashi wrote:
> > == is a GNU extension which might not be available.
> >
> > Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
>
On 7/6/16 01:11, Ben Pfaff wrote:
> On Tue, Jul 05, 2016 at 02:57:11PM +0800, Zhang Haoyu wrote:
>>
>>
>> On 7/5/16 13:26, Ben Pfaff wrote:
>>> On Tue, Jul 05, 2016 at 11:09:26AM +0800, Zhang Haoyu wrote:
How to invalidate a dp-flow which was generated by of-flow, like
recirc_id(0),in_p
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
> index 2ed9ad1..dbb220f 100644
> --- a/datapath/linux/compat/geneve.c
> +++ b/datapath/linux/compat/geneve.c
I think it would probably be nice to mention that the
"dev" wrote on 06/26/2016 08:34:01 PM:
> From: Darrell Ball
> To: dlu...@gmail.com, d...@openvswitch.com
> Date: 06/26/2016 08:34 PM
> Subject: [ovs-dev] [patch_v3 1/2] ovn: Fix receive from vxlan in
> ovn-controller.
> Sent by: "dev"
>
> OVN only supports source_node replication and previously
"dev" wrote on 06/24/2016 11:30:39 PM:
> From: Ben Pfaff
> To: dev@openvswitch.org
> Cc: Ben Pfaff
> Date: 06/24/2016 11:31 PM
> Subject: [ovs-dev] [PATCH v2] sset: New function
sset_from_delimited_string().
> Sent by: "dev"
>
> This simplifies code in a couple of places.
>
> Signed-off-by: Be
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote:
> diff --git a/acinclude.m4 b/acinclude.m4
> index 263c31d..05b5f48 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -556,6 +556,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>
>OVS_GREP_IFELSE([$KSRC/include/net/dst.h], [dst_discard_sk])
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/ip6_tunnel.h
> b/datapath/linux/compat/include/net/ip6_tunnel.h
> index ce65087..565b69b 100644
> --- a/datapath/linux/compat/include/net/ip6_tunnel.h
> +++ b/datapath/linux/compat/include/net/
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote:
> diff --git a/FAQ.md b/FAQ.md
> index 242147d..cc88d8f 100644
> --- a/FAQ.md
> +++ b/FAQ.md
> @@ -199,6 +199,9 @@ Tunnel - STT | NO| YES |
>NO | YES |
> Tunnel - GRE | 3.11 |
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/linux/udp.h
> b/datapath/linux/compat/include/linux/udp.h
> new file mode 100644
> index 000..65cb77c
> --- /dev/null
> +++ b/datapath/linux/compat/include/linux/udp.h
[...]
> +static inline vo
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
> index db1c713..a7229c8 100644
> --- a/datapath/linux/compat/geneve.c
> +++ b/datapath/linux/compat/geneve.c
> @@ -578,6 +574,7 @@ static int geneve_build_skb(stru
On Fri, Jul 1, 2016 at 8:15 PM, Ben Pfaff wrote:
> On Fri, Jun 17, 2016 at 04:25:32PM -0700, Andy Zhou wrote:
> > When calling ovs_thread_create() without calling fatal_signal_init()
> > first, ovs_thread_create() some times asserts. This dependency is
> > subtle and not very obvious.
> >
> > The
Hi Ben,
Thanks, I've fixed it and submitted new version.
Regards,
William
On Fri, Jul 1, 2016 at 9:28 PM, Ben Pfaff wrote:
> On Fri, Jul 01, 2016 at 12:43:02PM -0700, William Tu wrote:
>> This patch adds a 'snaplen' field in sample action (nx_action_sample2).
>> Currently, sample action is use
This patch adds a 'snaplen' field in sample action (nx_action_sample2).
Currently, sample action is used by sFlow and IPFIX. For IPFIX, nothing
is changed. For sFlow configuration, the patch translates header=N to
a sample action with snaplen=N, then the snaplen=N translates to trunc(N)
in kernel
Hi Charlie,
Thanks for providing the setup scripts and steps to reproduce the issue.
Unfortunately though, I’m still unable to trigger the behavior that you’re
seeing – on the second run of the script (following the reboot, and minus the
build steps), the bridge setup completes successfully, an
>
>
>>
> The documentation explains where 'reg0' comes from. I think it makes sense
> to also say where 'reg0' is populated.
>
> Sorry, I meant "The documentation explains where 'reg1' comes from."
>
>
>
>> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
>> index f4b4435..afcd7fd 1
On 4 July 2016 at 06:53, Chandra S Vejendla wrote:
> TPA in arp requests generated for unknown MAC-to-IP bindings is currently
> set
> to DST_IP of the original packet. These arps will not be resolved when the
> DST_IP is rechable via the default gateway. This patch fixes the issue by
> setting t
> On Jul 1, 2016, at 6:10 PM, Ben Pfaff wrote:
>
> On Fri, Jul 01, 2016 at 03:11:04AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> include/openflow/openflow-common.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/openflow/openflow-co
Changes for v3:
- Move create_symtab to expr.[ch] and rename create_symtab ->
create_symtab_helper (also added comment above that method is for testing).
- update test-ovn-utils.at to skip the tests if the ovs.ovn_utils libraries
is not installed. I figure this is a good work around until we can g
This patch exposes the c function expr_parse_string() to be called via
python. The motivation for this is so that clients interfacing with
ovn can call this method in order to validate the data they are writting
to ovn.
Previously, there were several bugs in the neutron/ovn integration
that went u
On Fri, Jul 1, 2016 at 6:00 PM, Pravin B Shelar wrote:
> Upstream commit:
> commit bc22a0e2ea03b75b51a1f722f93821744b5b5ff1
> Author: Nicolas Dichtel
>
> iptunnel: make rx/tx bytes counters consistent
>
> This was already done a long time ago in
> commit 64194c31a0b6 ("inet: Make tunn
Set the DPDK pmd thread scheduling policy to SCHED_RR and static
priority to highest priority value of the policy. This is to deal with
pmd thread starvation case where another cpu hogging process can get
scheduled/affinitized on to the same core the pmd thread is running there
by significantly imp
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote:
> To better represent the meaning of symbol.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote:
> Introduce xnet parameter to iptunnel_pull_header().
>
> Signed-off-by: Pravin B Shelar
Can you add that this is a backport of
7f290c94352e59b1d720055fce760a69a63bd0a1 ("iptunnel: scrub packet in
iptunnel_pull_header") and perhaps some othe
On Tue, Jul 5, 2016 at 12:07 PM, Jesse Gross wrote:
> I guess it's not applicable in the sense that the fix is not really in
> OVS. Kernels with that bug will continue to have it even after this
> backport.
>
> I think it would be pretty challenging to fully backport this through
> the OVS tree -
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
> index 0399de7..b6c091c 100644
> --- a/datapath/linux/compat/geneve.c
> +++ b/datapath/linux/compat/geneve.c
> @@ -669,7 +667,6 @@ netdev_tx_t rpl_geneve_xmit(stru
I guess it's not applicable in the sense that the fix is not really in
OVS. Kernels with that bug will continue to have it even after this
backport.
I think it would be pretty challenging to fully backport this through
the OVS tree - it would likely require pulling in the whole UDP
offloads module
On Mon, Jul 04, 2016 at 03:48:30AM -0700, Jarno Rajahalme wrote:
>
> > On Jun 29, 2016, at 4:58 PM, Flavio Leitner wrote:
> >
> > On Wed, Jun 29, 2016 at 05:04:06AM -0700, Jarno Rajahalme wrote:
> >>
> >>> On Jun 23, 2016, at 11:40 AM, Flavio Leitner wrote:
> >>>
> ...
> >
> >>> +
> >>> +
Image data has been attached to this email.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Currently, when a client looks at a load balancer VIP,
it notices that it is in a different subnet than itself
and sends the packet to its connected router port's
MAC address. The load balancer intercepts it.
If the load balancer VIP translates to an endpoint IP in a
different subnet (than the one
Clarify that the load balancers needs a router in
the topology.
Signed-off-by: Gurucharan Shetty
---
ovn/ovn-nb.xml | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
index ff2e695..a1f560a 100644
--- a/ovn/ovn-nb.xml
+++ b/ovn/ovn-nb.xml
@@ -567,6 +567,13
Robert,
Two comments:
(1) To add an sFlow extension like this you tag it with an
IANA-assigned enterprise number from:
https://www.iana.org/assignments/enterprise-numbers/enterprise-numbers
The enterprise number goes in the high 20 bits, as described on page
25 of http://sflow.org/sflow_versio
Hi Ben,
I finally got some time to catch up with this. Thanks for the suggestions, I
agree with all of them.
I integrated them with the rest of the code and all everything worked well.
Should I send an updated patch set with that includes your suggestions?
Also, I noticed that you closed the p
On Tue, Jul 05, 2016 at 02:57:11PM +0800, Zhang Haoyu wrote:
>
>
> On 7/5/16 13:26, Ben Pfaff wrote:
> > On Tue, Jul 05, 2016 at 11:09:26AM +0800, Zhang Haoyu wrote:
> >> How to invalidate a dp-flow which was generated by of-flow, like
> >> recirc_id(0),in_port(2),eth(src=50:1c:bf:71:13:22,dst=50
This patch adds local router support. The idea is to do openflow rule
calculations and download for logical routers only on HVs where this is
needed. The approach used is to do a flood fill, based local VIF presence
and factoring in logical data path associations recursively. Presently, the
recur
- Original Message -
> From: "Bhanuprakash Bodireddy"
> To: dev@openvswitch.org
> Cc: b...@ovn.org, lrich...@redhat.com, "Bhanuprakash Bodireddy"
>
> Sent: Tuesday, July 5, 2016 12:34:54 PM
> Subject: [PATCH v4] Makefile.am: Add clang static analysis support
>
> Clang Static Analyzer is
Clang Static Analyzer is a source code analysis tool to find bugs. This
patch adds make target to trigger static analysis using below commands.
./boot.sh
For Clang: ./configure CC=clang --with-dpdk
For GCC: ./configure CC=gcc --with-dpdk CFLAGS="-std=gnu99"
make clang-analyze
scan-view --host= --p
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, July 5, 2016 12:17:17 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl
> statemachine
>
> "dev" wrote on 07/05/2016 07:58:24 AM:
>
> > Fro
Image data has been attached to this email.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
"dev" wrote on 07/05/2016 07:58:24 AM:
> From: Lance Richardson
> To: dev@openvswitch.org
> Date: 07/05/2016 07:58 AM
> Subject: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl
> state machine
> Sent by: "dev"
>
> The "ovn -- 2 HVs, 3 LRs connected via LS, static routes"
> test case
The attachment (Fedora_server_23.sh) was rejected.
Renamed it to Fedora_server_23.sh_txt and try it again
On Tue, Jul 5, 2016 at 11:09 AM, Charlie Li wrote:
> Hi Mark,
>
> It does not make any difference if I use "PCI bus:device.function"
> instead of logical interface name.
>
> Sorry I acci
Image data has been attached to this email.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi Mark,
It does not make any difference if I use "PCI bus:device.function" instead
of logical interface name.
Sorry I accidentally deleted following line while trying to adding some
comments
sudo ./ovs-vsctl add-br br0 -- set bridge br0 datapath_type=netdev
Attached is my real script without a
Hello,
I'd like to request for the following 5 commits to be backported to
2.5.0, if it's appropriate:
314ce6479a8380e2aeaa53eb5bab96a23c06d62d - ovs-tcpdump: Add a tcpdump
wrapper utility
8647686ee8ac496b54499d14f3c37de84fdd47df - fedora: Add pcap, tcpd
On Tue, Jul 05, 2016 at 06:35:04PM +0900, YAMAMOTO Takashi wrote:
> == is a GNU extension which might not be available.
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/lis
On Tue, Jul 05, 2016 at 07:30:11AM -0700, William Tu wrote:
> Hi Ben,
>
> Thanks, this indeed fixes the "possible" leaks.
Thanks, I applied this to master as follows.
--8<--cut here-->8--
From: Ben Pfaff
Date: Tue, 5 Jul 2016 08:33:05 -0700
Subje
Thanks, applied to master.
On Tue, Jul 05, 2016 at 06:54:41AM -0700, William Tu wrote:
> Hi Ben,
>
> Thanks, I tested your patch below and clang no longer reports no error.
>
> Regards,
> William
>
> > A port is guaranteed to have at least one interface, so 'iface' can't be
> > null here. Even
On 07/05/2016 03:08 PM, Aaron Conole wrote:
> Markos Chandras writes:
>
>> On 07/02/2016 03:22 AM, Aaron Conole wrote:
>>> Markos Chandras writes:
>>>
The ovs-ctl script is used to launch ovs-vswitchd among other things.
However it does not make it possible to pass DPDK options to the
>
>Thanks Mark and Ben for looking into this.
>
>Attached please find the script I use to set up the OVS-DPDK. If both DPDK and
>OVS are re-
>built, it works fine. However, if DPDK and OVS are not rebuilt, then it will
>cause the
>problem.
Hi Charlie,
I found some issues with this script:
su
On 5 July 2016 at 07:31, Zong Kai LI wrote:
> Hi, Ben and Guru. I tried to test lb feature on my OpenStack env, but
> failed.
> The simplest topology, three VMs(cirros) and VIP are on the same switch.
> VM2 and VM3 are endpoints for the VIP.
> I tried to use ping and ssh to test VIP, but things d
On Mon, Jul 04, 2016 at 07:22:40AM +, Wojciechowicz, RobertX wrote:
> Hi,
>
> > -Original Message-
> > From: Ben Pfaff [mailto:b...@ovn.org]
> > Sent: Saturday, July 2, 2016 2:49 AM
> > To: Wojciechowicz, RobertX
> > Cc: dev@openvswitch.org
> > Subject: Re: [ovs-dev] [PATCH v2] ovsdb:
Hi Robert,
"Wojciechowicz, RobertX" writes:
> Hi,
>
>> -Original Message-
>> From: Ben Pfaff [mailto:b...@ovn.org]
>> Sent: Saturday, July 2, 2016 2:49 AM
>> To: Wojciechowicz, RobertX
>> Cc: dev@openvswitch.org
>> Subject: Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket direct
On 5 July 2016 at 07:31, Zong Kai LI wrote:
> Hi, Ben and Guru. I tried to test lb feature on my OpenStack env, but
> failed.
> The simplest topology, three VMs(cirros) and VIP are on the same switch.
> VM2 and VM3 are endpoints for the VIP.
> I tried to use ping and ssh to test VIP, but things d
Thanks Mark and Ben for looking into this.
Attached please find the script I use to set up the OVS-DPDK. If both DPDK
and OVS are re-built, it works fine. However, if DPDK and OVS are not
rebuilt, then it will cause the problem.
The OS is Fedora Server 23 with updated kernel (4.5.7-200.fc23.x86_6
Hi, Ben and Guru. I tried to test lb feature on my OpenStack env, but
failed.
The simplest topology, three VMs(cirros) and VIP are on the same switch.
VM2 and VM3 are endpoints for the VIP.
I tried to use ping and ssh to test VIP, but things don't work.
I think it should be arp issue.
First, in ta
Hi Ben,
Thanks, this indeed fixes the "possible" leaks.
Regards,
William
On Fri, Jul 1, 2016 at 8:24 PM, Ben Pfaff wrote:
> Hi William, please try this patch as a substitute for yours. It should
> ensure that pointers to nln_notifiers are to the beginning of the
> structs instead of to the mi
Message could not be delivered
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Markos Chandras writes:
> On 07/02/2016 03:22 AM, Aaron Conole wrote:
>> Markos Chandras writes:
>>
>>> The ovs-ctl script is used to launch ovs-vswitchd among other things.
>>> However it does not make it possible to pass DPDK options to the
>>> daemon. We fix this by explicitly looking and ex
Hi Ben,
Thanks, I tested your patch below and clang no longer reports no error.
Regards,
William
> A port is guaranteed to have at least one interface, so 'iface' can't be
> null here. Even if it could, this patch wouldn't help because a few
> lines down there's an unconditional dereference.
>
The PMD thread needs to keep processing RX queues in order
to achieve maximum throughput. It also needs to sweep emc
cache and quiesce which use seq_mutex. That mutex can
eventually block the PMD thread causing latency spikes and
affecting the throughput.
Since there is no requirement for running
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Tuesday, July 5, 2016 8:58:24 AM
> Subject: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state
> machine
>
> The "ovn -- 2 HVs, 3 LRs connected via LS, static routes"
> test case currently
The "ovn -- 2 HVs, 3 LRs connected via LS, static routes"
test case currently exhibits frequent failures. These failures
occur because, at the time that the test packets are sent to
verify forwarding, no flows have been installed in the vswitch
for one of the hypervisors.
Investigation shows that,
"dev" wrote on 07/05/2016 04:35:04 AM:
> From: YAMAMOTO Takashi
> To: dev@openvswitch.org
> Cc: YAMAMOTO Takashi
> Date: 07/05/2016 04:40 AM
> Subject: [ovs-dev] [PATCH] ovn.at: Use = instead of == for test
> Sent by: "dev"
>
> == is a GNU extension which might not be available.
>
> Signed-off
>
> Hi Ciara,
>
> Ciara Loftus writes:
>
> > This commit introduces support for DPDK 16.07 and consequently breaks
> > compatibility with DPDK 16.04.
> >
> > DPDK 16.07 introduces some changes to various APIs. These have been
> > updated in OVS, including:
> > * xstats API: changes to structure
Hi Ciara,
Ciara Loftus writes:
> This commit introduces support for DPDK 16.07 and consequently breaks
> compatibility with DPDK 16.04.
>
> DPDK 16.07 introduces some changes to various APIs. These have been
> updated in OVS, including:
> * xstats API: changes to structure of xstats
> * vhost AP
The OVS PMD threads utilization has been identified
as important metric when managing large deployments.
This patch exposes via sFlow PMD utilization metrics,
which are also available using ovs-appctl utility
(command: dpif-netdev/pmd-stats-show).
Signed-off-by: Robert Wojciechowicz
---
lib/dpif
>
>The logs show that ovs-vswitchd failing to log anything after it
>receives the initial configuration from the database. This is probably
>a bug in the DPDK portion of OVS. OVS-DPDK folks, have you noticed
>anything like this before? Can you take over the investigation?
>
I can take this Ben
If the PID file isn't locked then appctl.py detects it as stale and
bails out without doing anything. Because of this lots of Python tests fail.
Also this protects the PID file from being overwritten.
I used only shared lock, in order to be compatible with Python tests,
which try to acquire the lo
== is a GNU extension which might not be available.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index feb68d3..3436417 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -839,7 +839,7 @@ for is
Hello,
I would like to ask where can I download the patches that make it work ovs with
nat as described in below article.
Patches 3-6 make the openvswitch kernel module ready for the
patch 7 that adds the NAT support by calling into netfilter NAT code
from the openvswitch conntrack action.
htt
73 matches
Mail list logo
