I agree, maybe the section about static analysis could be added to INSTALL.md (doesn't need to be part of this series).
Other than that the patch looks good to me Thanks, Daniele 2016-07-04 1:19 GMT-07:00 Bodireddy, Bhanuprakash < bhanuprakash.bodire...@intel.com>: > >-----Original Message----- > >From: Lance Richardson [mailto:lrich...@redhat.com] > >Sent: Sunday, July 3, 2016 4:17 PM > >To: Bodireddy, Bhanuprakash <bhanuprakash.bodire...@intel.com> > >Cc: dev@openvswitch.org; daniele di proietto > ><daniele.di.proie...@gmail.com> > >Subject: Re: [ovs-dev] [PATCH v8 2/2] INSTALL.DPDK: Refactor DPDK install > >guide, add ADVANCED doc > > > >----- Original Message ----- > >> From: "Bhanuprakash Bodireddy" <bhanuprakash.bodire...@intel.com> > >> To: dev@openvswitch.org > >> Cc: "daniele di proietto" <daniele.di.proie...@gmail.com> > >> Sent: Sunday, July 3, 2016 10:48:25 AM > >> Subject: [ovs-dev] [PATCH v8 2/2] INSTALL.DPDK: Refactor DPDK install > >> guide, add ADVANCED doc > >> > >> Add INSTALL.DPDK-ADVANCED document that is forked off from original > >> INSTALL.DPDK guide. This document is targeted at users looking for > >> optimum performance on OVS using dpdk datapath. > >> > >> Signed-off-by: Bhanuprakash Bodireddy > >> <bhanuprakash.bodire...@intel.com> > >> Acked-by: Flavio Leitner <f...@sysclose.org> > >> --- > > > >> +## <a name="staticanalyzer"></a> 9. Static Code Analysis > >> + > >> +Static Analysis is method of debugging SW by examining the code > >> +rather than actually executing it. Many third party Software is > >> +available to carry Static analysis, few being open source and rest > >commercial. > >> + > >> +Below are the steps to run clang static analyzer on OVS codebase. > >> + > >> + ``` > >> + apt-get install clang [ On Ubuntu] > >> + dnf install clang clang-analyzer -y [ On fedora] > >> + > >> + cd $OVS_DIR > >> + ./boot.sh > >> + ./configure --with-dpdk > >> + make clean > >> + scan-build make CFLAGS="-std=gnu99" > >> + scan-view --host=<ip address> --port 8183 > >> /tmp/scan-build-yyyy-mm-dd-114251-1027-1 --allow-all-hosts > >> + ``` > >> + > >> + The results can be viewed on the browser using ip address and port > no. > >> + > >> + `http://<ip address>:8183/` > >> + > > > >Static analysis support (which is a very nice addition by the way) really > should > >be documented elsewhere. It is just as useful (and usable) for non-DPDK > >builds. I think INSTALL.md would be a better place to document it. > > I agree with you Lance. I am going to send out another version of static > analysis patch where in INSTALL.md > shall be updated with necessary instructions. > > Regards, > Bhanu Prakash. > > > > >Regards, > > > > Lance > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
