> > Hi Ciara, > > Ciara Loftus <ciara.lof...@intel.com> writes: > > > This commit introduces support for DPDK 16.07 and consequently breaks > > compatibility with DPDK 16.04. > > > > DPDK 16.07 introduces some changes to various APIs. These have been > > updated in OVS, including: > > * xstats API: changes to structure of xstats > > * vhost API: replace virtio-net references with 'vid' > > > > Signed-off-by: Ciara Loftus <ciara.lof...@intel.com> > > --- > > Thanks for this patch - I started work on a similar patchset. Have you > considered changing the stats lookup design so that we only strcmp once > at initialization and then use the stats id to do the actual stats > processing? If thing it's worthwhile, I would gladly donate some code to > the cause :-)
Hi Aaron, You're welcome. Certainly, I thought there must be a better way to handle the new xstats but since we're at RFC I didn't pursue much of an investigation. If you have some code to donate I'll happily merge it into the patch and add you as co-author :-) I will probably wait until another release candidate to upload a v2. Thanks, Ciara > > Otherwise it looks good. Thanks for posting it ahead of the DPDK > release, so we can evaluate it! > > Reviewed-by: Aaron Conole <acon...@redhat.com> > > -Aaron _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
