Re: [ovs-dev] [PATCH v9 1/1] Separating OVN NB and SB database processes

> On Mar 3, 2016, at 12:13 PM, Russell Bryant wrote: > > Can you update tutorial/ovs-sandbox to run the DBs in separate processes? > Otherwise, this patch breaks a lot of instructions based on ovs-sandbox, as > ovn-nbctl and ovn-sbctl commands won't work without an additional parameter > specify

Re: [ovs-dev] [PATCH] Use 'RUNDIR' from make for rhel/ovn-controller.service

Hi Flavio, Can you have a look at this patch, please? Thank you, Babu On Thursday 25 February 2016 08:29 PM, Russell Bryant wrote: On Thu, Feb 25, 2016 at 1:45 AM, > wrote: Perviously it was using the platform's runtime directory which can be different from

[ovs-dev] mask_set_prefix_bits may causes discontiguous bit mask

Hi, I installed some rulesets generated by ClassBench (a ruleset benchmark for generating ACL and FW rules) in Open vSwitch, and I find many megaflow's mask has discontiguous bits. Like mask = 0xfc in network byte order. After some code investigation I find the problem is in the function *

[ovs-dev] Returned mail: Data format error

9ÑÑ:Ï7\qµ‚¡„cS(¢‚¨|ùJRßÕ%;¡ò[ÅoA¹7µ,7¯\êÀvñt$Ù'ݵ[%bi}&-Ïq¨÷½»v¿/•²ø¤‰ê'U¬Î0Ï  Rc ”&éð28À‚(â¡úŠlXÝ TðÁÄ5ºÄ2¢ÀF~t³ÎEŠ-Ô#ò&¡axɳ’ŠpŽ|Ù GƒNHÞþSÓßߍà vLxÚE08·±³¿WݞWؤÊG¯ó|òhȬ©¸A°Ì#ëØ¸Ñ W{Ï'Uv¯ ؗgþF$]ÓjU¢6›Liõöò0Û.¸kúöØ_ðՌŒ$b$ÁîÇ#¤}uìXþü«'úEÁhoœßÊÔ|Ñå8!³¾Óz÷Np¬â1¼š/æãlL,ªÚvØق­ŸŠ;×ëMW´mê¥ÎÝw

[ovs-dev] [PATCH v4 3/3] tests/automake.mk: Prohibition of parallel system-traffic test execution.

'make check-system-userspace', 'make check-kernel' and 'make check-kmod' work with real environment and can not be run in parallel mode. To prevent violation of the system environment force '-j1' option for this targets. Signed-off-by: Ilya Maximets --- tests/automake.mk | 4 ++-- 1 file change

[ovs-dev] [PATCH v4 2/3] check-system-userspace: Waiting for port's availability before creation.

Fixes failure of test due to not yet fully destroyed ports from previous test if ovs-vswitchd was killed. Example: netdev_linux|WARN|br0: creating tap device failed: Device or resource busy bridge|WARN|could not open network device br0 (Device or resource busy) Signed-off-by: Ilya Maximets ---

[ovs-dev] [PATCH v4 0/3] Testsuite fixes.

version 4: * Reworked prohibition of parallel execution. version 3: * AT_SKIP_IF ---> AT_CHECK(... || return 77). * Using of GNU make extentions removed. version 2: * 'testsuite: Add timeout to add_of_br() command.' removed because already applied.

[ovs-dev] [PATCH v4 1/3] system-traffic.at: Skip tests if namespaces or veths aren't supported.

This prevents failure of test scenarios 'make check-kernel' and 'make check-system-userspace' if creation of veth pairs or network namespaces is not supported by kernel (or module isn't loaded). Signed-off-by: Ilya Maximets --- tests/system-common-macros.at | 6 +++--- 1 file changed, 3 insertio

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

Hi Ian, I haven't looked at every detail nor tested the patch yet, I just wanted to give some early feedback. Thanks, Daniele On 24/02/2016 06:17, "dev on behalf of Ian Stokes" wrote: >This patch provides the modifications required in netdev-dpdk.c and >vswitch.xml to enable ingress policing

Re: [ovs-dev] Implementation of Packet-Out in Bundles

It should still work, if you use ovs-ctl while testing. Usually, though, when I'm testing, I just run ovs-vswitchd from the command-line, and in that case you can just invoke "valgrind ovs-vswitchd ...". OVS_CTL_OPTS is just an environment variable so you can define it wherever that is convenient

[ovs-dev] Bug#816687: -switch: Please use ifquery in init script

Package: openvswitch-switch Version: 2.3.0+git20140819-3 Severity: minor In /etc/init.d/openvswitch-switch, the function network_interfaces does a manual parse of /etc/network/interfaces. This prevents it from finding interfaces defined in /etc/network/interfaces.d. Please switch to use "ifqu

[ovs-dev] [PATCH 1/2] ofpbuf: Rename 'data_delta' to 'xxx_offset'

Use more accurate variable names, and use the same method of offset calculation in ofpbuf_clone_with_headroom() as in ofpbuf_resize__(). Signed-off-by: Jarno Rajahalme --- lib/ofpbuf.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/ofpbuf.c b/lib

[ovs-dev] [PATCH 2/2] ofpbuf: Fix setting of 'msg' in ofpbuf_clone_with_headroom()

Commit 38876d31 fixed setting 'msg' when resizing an ofpbuf, but failed to fix the same issue in ofpbuf_clone_with_headroom(). Without this fix the newly cloned ofpbuf's 'msg', if non-NULL, will point to the buffer of the original ofpbuf. Signed-off-by: Jarno Rajahalme --- lib/ofpbuf.c | 6

Re: [ovs-dev] Implementation of Packet-Out in Bundles

Looks like what I need. What's the quickest way to enable valgrind? I found this: http://openvswitch.org/pipermail/discuss/2013-May/010113.html Does it still apply to today? Where can I define OVS_CTL_OPTS? Ben Pfaff escreveu no dia quinta, 3/03/2016 às 18:16: > On Thu, Mar 03, 2016 at 05:54:4

Re: [ovs-dev] [PATCH v5 3/5] ovn-controller: Add data structure for indexing lports, multicast groups.

On Thu, Mar 03, 2016 at 02:29:16PM -0800, Justin Pettit wrote: > > > On Feb 19, 2016, at 4:40 PM, Ben Pfaff wrote: > > > +struct mcgroup { > > +struct hmap_node dp_name_node; /* Index by (logical datapath, name). */ > > +const struct sbrec_multicast_group *mg; > > +}; > > + > > +void > >

Re: [ovs-dev] [PATCH 4/4] ofpbuf: Use ptrdiff_t for pointer delta.

On 3 March 2016 at 13:27, Jarno Rajahalme wrote: > For the series: > > Acked-by: Jarno Rajahalme > > While looking at lib/ofpbuf.c, I noticed a bug for which I’ll send a separate > patch. > > Jarno Thanks, I applied the series to master. ___ dev mai

Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

On 3 March 2016 at 00:22, Joe Stringer wrote: > When decoding a variable-length action, if the length of the action > exceeds the length storable in a uint16_t then something has gone > terribly wrong. Assert that this is not the case. > > Signed-off-by: Joe Stringer With Jarno's ack from patch

Re: [ovs-dev] [PATCH v5 3/5] ovn-controller: Add data structure for indexing lports, multicast groups.

> On Feb 19, 2016, at 4:40 PM, Ben Pfaff wrote: > +struct mcgroup { > +struct hmap_node dp_name_node; /* Index by (logical datapath, name). */ > +const struct sbrec_multicast_group *mg; > +}; > + > +void > +mcgroup_index_init(struct mcgroup_index *mcgroups, struct ovsdb_idl > *ovnsb_idl

Re: [ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

On 3 March 2016 at 00:22, Joe Stringer wrote: > Add a test which causes internal reallocation of the ofpacts buffer, > followed by a large bundle action which should cause a subsequent > reallocation while decoding slave ports. Running this test under > valgrind reveals the issue below, which is f

Re: [ovs-dev] [PATCH 2/4] ofp-actions: Fix use-after-free in bundle action.

On 3 March 2016 at 00:22, Joe Stringer wrote: > If the actions list in an incoming flow mod is long enough, and there is > a bundle() action with 3 or more slaves, then it is possible for a > reallocation to occur after placing the ofpact_bundle into the ofpacts > buffer, while appending all of th

[ovs-dev] [PATCH] datapath: STT: Fix checksum handling.

On packet receive STT verifies the checksum if not done in hardware. But IP and TCP were pulled before the verification step. The verification expect to see packet with TCP header. This causes STT to drop packet in certain cases. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/stt.c | 3

Re: [ovs-dev] [PATCH 4/4] ofpbuf: Use ptrdiff_t for pointer delta.

For the series: Acked-by: Jarno Rajahalme While looking at lib/ofpbuf.c, I noticed a bug for which I’ll send a separate patch. Jarno > On Mar 3, 2016, at 12:22 AM, Joe Stringer wrote: > > Signed-off-by: Joe Stringer > --- > lib/ofpbuf.c | 7 +++ > 1 file changed, 3 insertions(+), 4 de

Re: [ovs-dev] [PATCH 2/3] ovn: Add ct_commit(ct_mark=INTEGER); action.

On 3 March 2016 at 05:40, Russell Bryant wrote: > On Wed, Mar 2, 2016 at 8:31 PM, Han Zhou wrote: > >> >> >> On Wed, Mar 2, 2016 at 1:43 PM, Russell Bryant wrote: >> > >> > Update the "ct_commit;" logical flow action to optionally take a >> > parameter, setting the value of "ct_mark" to a 32-bit

Re: [ovs-dev] [PATCH v9 1/1] Separating OVN NB and SB database processes

Can you update tutorial/ovs-sandbox to run the DBs in separate processes? Otherwise, this patch breaks a lot of instructions based on ovs-sandbox, as ovn-nbctl and ovn-sbctl commands won't work without an additional parameter specifying the db location. Otherwise, this seems to work fine in my bas

[ovs-dev] upcall fairness

I have some concerns about the fairness of upcalls and flow cache evictions in the kernel dataplane. My motivation for investigating this is based on my experience operating a hardware vendor's solution which use a similar method: caching routing decisions as flows after the first packet was punted

Re: [ovs-dev] [PATCH 2/3] Enable some existing OVN BUM tests

Resending, as patches are visible in the mailing list archive, but not actually received by all On 2/12/16, 5:12 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > tests/ovn.at | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/tests/ovn.at b/tests/ov

Re: [ovs-dev] [PATCH 1/3] VTEP Schema - Support mcast macs remote table updates

Resending, as patches are visible in the mailing list archive, but not actually received by all On 2/12/16, 5:12 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > AUTHORS| 1 + > ovn/controller-vtep/vtep.c | 207

Re: [ovs-dev] [RFC 0/4] testsuite code coverage usability fixes, lcov

- Original Message - > From: "Aaron Conole" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Wednesday, March 2, 2016 5:40:32 PM > Subject: Re: [ovs-dev] [RFC 0/4] testsuite code coverage usability fixes, lcov > > Lance Richardson writes: > > > This series addresses usability

[ovs-dev] [PATCH v2 23/23] Debian: add libopenvswitch-dev build target

From: Ben Warren Add shared objects and header files Signed-off-by: Ben Warren --- debian/automake.mk| 1 + debian/control| 15 +++ debian/libopenvswitch-dev.install | 5 + 3 files changed, 21 insertions(+) create mode 100644 debian/libope

[ovs-dev] [PATCH v2 22/23] Debian: build openvswitch as shared libraries

From: Ben Warren Signed-off-by: Ben Warren --- debian/openvswitch-common.install | 3 +++ debian/rules | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/debian/openvswitch-common.install b/debian/openvswitch-common.install index 3264ea5..73c8fc9 1006

[ovs-dev] [PATCH v2 20/23] Assorted #include additions

From: Ben Warren Necessary in preparation for making ofp-util.h public Signed-off-by: Ben Warren --- ofproto/ofproto-dpif-ipfix.c | 1 + ovn/controller/ofctrl.c | 3 +++ ovn/controller/physical.c| 2 ++ ovn/lib/expr.c | 1 + tests/test-ovn.c | 1 + tests/test

[ovs-dev] [PATCH v2 19/23] Break netdev.h into private and public parts

From: Ben Warren Public (struct definitions and some prototypes) go in include/openvswitch Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/netdev.h| 87 + lib/netdev.h| 66 +---

[ovs-dev] [PATCH v2 17/23] Move lib/type-props.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/type-props.h | 55 lib/automake.mk | 1 - lib/classifier.h | 2 +- lib/fatal-signal.c | 2 +- li

[ovs-dev] [PATCH v2 11/23] Break packets.h into private and public parts

From: Ben Warren Public (struct definitions and some prototypes) go in include/openvswitch Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/packets.h | 64 + lib/packets.h | 43 +---

[ovs-dev] [PATCH v2 18/23] Move another macro to include/openvswitch/util.h

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/util.h | 4 lib/util.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h index b47c5cd..cfafc36 100644 --- a/include/openvswitch

[ovs-dev] [PATCH v2 12/23] Break flow.h into private and public parts

From: Ben Warren Public (struct definitions and some prototypes) go in include/openvswitch Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/flow.h | 197 lib/flow.h | 175 +-

[ovs-dev] [PATCH v2 16/23] Break uuid.h into private and public parts

From: Ben Warren Public (struct definitions and some prototypes) go in include/openvswitch Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/uuid.h | 35 +++ lib/ofp-print.c | 1 + lib/ofp-util.c

[ovs-dev] [PATCH v2 14/23] Remove inter-header dependencies in OVN files

From: Ben Warren These includes were needed when "meta-flow.h" was refactored, even though neither of affected files included that header file directly. Signed-off-by: Ben Warren --- ovn/controller/ovn-controller.c | 2 ++ ovn/northd/ovn-northd.c | 1 + 2 files changed, 3 insertions(+)

[ovs-dev] [PATCH v2 10/23] Misc cleanup with "util.h" header files

From: Ben Warren Removed from redundant #includes and moved some macros to different file scope Signed-off-by: Ben Warren --- include/openvswitch/compiler.h | 3 +++ include/openvswitch/util.h | 46 - lib/util.h | 47

[ovs-dev] [PATCH v2 13/23] Move lib/match.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/match.h | 210 +++ lib/automake.mk | 1 - lib/classifier.h| 2 +- lib/dpctl.c | 2 +- lib

[ovs-dev] [PATCH v2 08/23] Move BLDASSERT macros to compiler header file

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/compiler.h | 30 ++ lib/util.h | 28 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/include/openvswitch/compiler.h b/include/openvswi

[ovs-dev] [PATCH v2 07/23] Move lib/ofpbuf.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/ofpbuf.h| 277 lib/automake.mk | 1 - lib/bfd.c | 2 +- lib/bundle.c| 2 +- li

[ovs-dev] [PATCH v2 09/23] Break tun-metadata.h into private and public parts

From: Ben Warren Public (struct definitions and some prototypes) go in include/openvswitch Signed-off-by: Ben Warren --- include/openvswitch/automake.mk| 1 + include/openvswitch/tun-metadata.h | 101 + lib/tun-metadata.h | 80 +---

[ovs-dev] [PATCH v2 06/23] Move lib/dynamic-string.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/dynamic-string.h | 93 +++ lib/automake.mk | 1 - lib/backtrace.h | 2 +- lib/bfd.c

[ovs-dev] [PATCH v2 05/23] Remove lib/list.h completely

From: Ben Warren All code is now in include/openvswitch/list.h Signed-off-by: Ben Warren --- lib/automake.mk | 1 - lib/bfd.c | 2 +- lib/dp-packet.h | 2 +- lib/dpif-netdev.c | 2 +- lib/fat-rwlock.c | 2 +- lib/fat

[ovs-dev] [PATCH v2 04/23] Move contents of lib/list.h to include/openvswitch directory

From: Ben Warren Most of the list code is properly namespaced, so is OK to move to the global export directory. Some "lib/util.h" code had to move to the other directory as well, but I've tried to make that as small as possible Signed-off-by: Ben Warren --- include/openvswitch/list.h | 260 ++

[ovs-dev] [PATCH v2 03/23] Move lib/ofp-errors.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- FAQ.md | 2 +- build-aux/extract-ofp-errors | 4 +- include/openvswitch/automake.mk | 1 + include/openvswitch/ofp-errors.h | 807 +++ lib/automake.mk | 5 +

[ovs-dev] [PATCH v2 02/23] Move lib/geneve.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/geneve.h| 63 + lib/automake.mk | 1 - lib/geneve.h| 63 - lib/pack

[ovs-dev] [PATCH v2 00/23] RFC: rework code base for third-party linking

From: Ben Warren This patch set is a first stab at making a 'dev' distribution for OpenVswitch The goal is to provide shared libraries and header files so that third party applications can link in OVS rather than always using the command line utilities. Changes in V2: - Work to move all of ofp-u

[ovs-dev] [PATCH v2 01/23] Move ofp-parse.h to include/openvswitch directory

From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/ofp-parse.h | 106 lib/automake.mk | 1 - lib/dpctl.c | 2 +- lib/learning-switch.c | 2 +- li

Re: [ovs-dev] Implementation of Packet-Out in Bundles

On Thu, Mar 03, 2016 at 05:54:42PM +, André Mantas wrote: > Hi again. > > For now, I'm testing the implementation with a floodlight controller that > opens a bundle, adds a packet_out message and tries to commit the bundle. > I'm using mininet to start a simple topology with 1 switch and 2 hos

Re: [ovs-dev] [PATCH] datapath-windows: Fix a couple of bugs during port enumeration

Acked-by: Sairam Venugopal On 3/3/16, 12:51 AM, "Nithin Raju" wrote: >While enumerating the ports on a switch, if adding one of the >ports fails, we are not handling that error gracefully. Instead, >we fail adding of all the ports. This patch rectifies that. > >Signed-off-by: Nithin Raju >--

Re: [ovs-dev] Implementation of Packet-Out in Bundles

Hi again. For now, I'm testing the implementation with a floodlight controller that opens a bundle, adds a packet_out message and tries to commit the bundle. I'm using mininet to start a simple topology with 1 switch and 2 hosts and connect the switch to the remote controller. I followed INSTALL.m

Re: [ovs-dev] [PATCH] ovs-ofctl.8: commit is required with alg in ct().

On Thu, Mar 3, 2016 at 12:09 PM, Justin Pettit wrote: > > > On Mar 3, 2016, at 7:18 AM, Russell Bryant wrote: > > > > The "alg=" argument to the ct() action only makes sense when used in > > combination with "commit". Add this to the documentation to help make > > it clear. > > > > Signed-off-b

Re: [ovs-dev] [PATCH] ovs-ofctl.8: commit is required with alg in ct().

> On Mar 3, 2016, at 7:18 AM, Russell Bryant wrote: > > The "alg=" argument to the ct() action only makes sense when used in > combination with "commit". Add this to the documentation to help make > it clear. > > Signed-off-by: Russell Bryant > --- > utilities/ovs-ofctl.8.in | 3 +++ > 1 file

Re: [ovs-dev] [PATCH v2 3/3] tests/automake.mk: Prohibition of parallel system-traffic test execution.

On Thu, Mar 03, 2016 at 05:01:53PM +0300, Ilya Maximets wrote: > On 02.03.2016 22:28, Ben Pfaff wrote: > > How about this: > > > > diff --git a/tests/automake.mk b/tests/automake.mk > > index 592f648..3c5c848 100644 > > --- a/tests/automake.mk > > +++ b/tests/automake.mk > > @@ -209,7 +209,7 @@ EX

[ovs-dev] weekly OVN report

Here's my OVN report for the week, since I'll be in a meeting during the IRC session today. The "continuation" feature needed as a basis for others is in. Justin is reviewing the ARP support patches. I've spent most of the week in meetings, so there's been minimal progress. I'm currently workin

[ovs-dev] vhost-user invalid txqid cause discard of packets

Hi, I ran an OVS multiqueue test with very simple traffic topology, basically 2 ports each with 4 queues, 8 rxqs in total, like below: Pktgen <=4q=> PHY <=4q=> OVS <=4q=> testpmd in the guest First set pmd-cpu-mask to 8 cores, and everything works fine, each rxq got a core, and all txqids are va

[ovs-dev] [PATCH] ovs-ofctl.8: commit is required with alg in ct().

The "alg=" argument to the ct() action only makes sense when used in combination with "commit". Add this to the documentation to help make it clear. Signed-off-by: Russell Bryant --- utilities/ovs-ofctl.8.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/ovs-ofctl.8.in b/utili

Re: [ovs-dev] [PATCH v9 0/6] Convert DPDK configuration from command line to DB based

> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Wednesday, March 2, 2016 10:52 PM > To: dev@openvswitch.org > Cc: Mooney, Sean K ; Flavio Leitner > ; Daniele Di Proietto ; Andy > Zhou ; Traynor, Kevin > Subject: Re: [ovs-dev] [PATCH v9 0/6] Convert DPDK config

Re: [ovs-dev] [PATCH v2 00/11] Reconfigure netdev at runtime

Thanks, Daniele. This version works for me. It should be rebased on top of current master. I'll try to review the code more carefully soon. For now: Tested-by: Ilya Maximets On 03.03.2016 04:33, Daniele Di Proietto wrote: > Currently we treat set_multiq() calls specially in netdev and dpif-netdev

Re: [ovs-dev] [PATCH v2 3/3] tests/automake.mk: Prohibition of parallel system-traffic test execution.

On 02.03.2016 22:28, Ben Pfaff wrote: > How about this: > > diff --git a/tests/automake.mk b/tests/automake.mk > index 592f648..3c5c848 100644 > --- a/tests/automake.mk > +++ b/tests/automake.mk > @@ -209,7 +209,7 @@ EXTRA_DIST += tests/run-ryu >  > # Run kmod tests. Assume kernel modules has b

Re: [ovs-dev] [PATCH 2/3] ovn: Add ct_commit(ct_mark=INTEGER); action.

On Wed, Mar 2, 2016 at 8:31 PM, Han Zhou wrote: > > > On Wed, Mar 2, 2016 at 1:43 PM, Russell Bryant wrote: > > > > Update the "ct_commit;" logical flow action to optionally take a > > parameter, setting the value of "ct_mark" to a 32-bit integer. > > Supported ct_commit syntax now includes: > >

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix memory leak in netdev_dpdk_vhost_destruct().

On Thu, 03 Mar 2016 11:30:06 +0300 Ilya Maximets wrote: > Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support") > Signed-off-by: Ilya Maximets > --- > lib/netdev-dpdk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index d21bb

[ovs-dev] [PATCH] datapath-windows: Fix a couple of bugs during port enumeration

While enumerating the ports on a switch, if adding one of the ports fails, we are not handling that error gracefully. Instead, we fail adding of all the ports. This patch rectifies that. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Vport.c | 41 +

[ovs-dev] [PATCH] netdev-dpdk: Fix memory leak in netdev_dpdk_vhost_destruct().

Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support") Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index d21bb4c..0233b3c 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -882

Re: [ovs-dev] [ovsdb-server multithreading RFC 1/9] ovsdb: Do not group sessions by remote.

This series is also available at github at https://github.com/azhou-nicira/ovs-review/tree/mt On Thu, Mar 3, 2016 at 12:13 AM, Andy Zhou wrote: > Currently ovsdb_jsonrpc_session are grouped together in a linked > list within 'ovsdb_jsonrpc_remote'. This makes sense since most > session operatio

[ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

Add a test which causes internal reallocation of the ofpacts buffer, followed by a large bundle action which should cause a subsequent reallocation while decoding slave ports. Running this test under valgrind reveals the issue below, which is fixed in the following commit. Invalid read of size 4

[ovs-dev] [PATCH 4/4] ofpbuf: Use ptrdiff_t for pointer delta.

Signed-off-by: Joe Stringer --- lib/ofpbuf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/ofpbuf.c b/lib/ofpbuf.c index a3c4da4bcbbe..02c9d15f82bf 100644 --- a/lib/ofpbuf.c +++ b/lib/ofpbuf.c @@ -183,8 +183,7 @@ ofpbuf_clone_with_headroom(const struct ofpbuf *buf

[ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

When decoding a variable-length action, if the length of the action exceeds the length storable in a uint16_t then something has gone terribly wrong. Assert that this is not the case. Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) di

[ovs-dev] [PATCH 2/4] ofp-actions: Fix use-after-free in bundle action.

If the actions list in an incoming flow mod is long enough, and there is a bundle() action with 3 or more slaves, then it is possible for a reallocation to occur after placing the ofpact_bundle into the ofpacts buffer, while appending all of the slaves into the buffer. If the buffer freed by this r

[ovs-dev] [ovsdb-server multithreading RFC 9/9] test: Add an ovsdb-server multi-threading test

Add a test that executes OVSDB transactions when OVSDB server is running with multiple threads. Signed-off-by: Andy Zhou --- tests/ovsdb-server.at | 42 ++ 1 file changed, 42 insertions(+) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index c

[ovs-dev] [ovsdb-server multithreading RFC 8/9] ovsdb: Add ovsdb-server/list-threads command.

Signed-off-by: Andy Zhou --- ovsdb/jsonrpc-server.c | 9 + ovsdb/jsonrpc-server.h | 4 ovsdb/ovsdb-server.1.in | 5 + ovsdb/ovsdb-server.c| 18 ++ 4 files changed, 36 insertions(+) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 09b89b

[ovs-dev] [ovsdb-server multithreading RFC 6/9] ovsdb: Add IPC messages for thread communication

Add a command queue for the main thread to pass commands to the sessions thread. Defined an implemented a set of IPC messages for creating, closing and managing jsonrpc sessions from the main process to jsonrpc sessions threads. Add a doorbell mechanism for a jsonrpc session to inform other sessi

[ovs-dev] [ovsdb-server multithreading RFC 3/9] ovsdb: Spawn threads to handle jsonrpc sessions

Add the basic infrastructure to create and destroy threads that will be used to handle jsonrpc sessions. This patch implements a simple logic to create thread on demand. Using number of sessions a server services as an rough measure of system load, A jsonrpc server creates more threads as the numb

[ovs-dev] [ovsdb-server multithreading RFC 7/9] ovsdb: Add --max-num-threads commad line option

See ovsdb-server.1.in changes for details. Signed-off-by: Andy Zhou --- NEWS| 4 ovsdb/ovsdb-server.1.in | 6 ++ ovsdb/ovsdb-server.c| 55 +++-- 3 files changed, 54 insertions(+), 11 deletions(-) diff --git a/NEWS b/

[ovs-dev] [ovsdb-server multithreading RFC 4/9] ovsdb: Convert ovsdb_jsonrpc_server's n_sessions into atomic_count

To allow this variable be updated from multiple threads. Signed-off-by: Andy Zhou --- ovsdb/jsonrpc-server.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 63788ec..5a323e0 100644 --- a/ovsdb/jsonrpc-se

[ovs-dev] [ovsdb-server multithreading RFC 1/9] ovsdb: Do not group sessions by remote.

Currently ovsdb_jsonrpc_session are grouped together in a linked list within 'ovsdb_jsonrpc_remote'. This makes sense since most session operations applies to sessions within a remote. However, in order to scale up ovsdb-server with multi-threading, it is more convenient to distribute a sessions

[ovs-dev] [ovsdb-server multithreading RFC 5/9] ovsdb: Add a 'big lock' to serialize all OVSDB operations

Add a global lock to serialize all OVSDB operations. It is a simple locking scheme to implement and to reason about correctness, without much changes to core of OVSDB implementation. Signed-off-by: Andy Zhou --- ovsdb/jsonrpc-server.c | 31 ++- 1 file changed, 26 inse

[ovs-dev] [ovsdb-server multithreading RFC 2/9] ovsdb: Make 'remote' opaque in ovsdb_jsonrpc_session

It turns out there is no need for ovsdb_jsonrcp_session to have access to the remote data structure. Make it opaque as a 'void *' pointer. The pointer value is still useful when selecting ovsdb_jsonrpc_sessions that of the same 'remote'. This change will laster multi-threading patches easier becau