> -----Original Message-----
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Wednesday, March 2, 2016 10:52 PM
> To: dev@openvswitch.org
> Cc: Mooney, Sean K <sean.k.moo...@intel.com>; Flavio Leitner
> <f...@sysclose.org>; Daniele Di Proietto <diproiet...@vmware.com>; Andy
> Zhou <az...@ovn.org>; Traynor, Kevin <kevin.tray...@intel.com>
> Subject: Re: [ovs-dev] [PATCH v9 0/6] Convert DPDK configuration from
> command line to DB based
>
>
> Ping re: this series. At this point, it has lingered for a while; I have
> added some updates to concerns in the following links:
>
> http://openvswitch.org/pipermail/dev/2016-February/066073.html
> http://openvswitch.org/pipermail/dev/2016-February/066502.html
Hi I tested your v9 patches with a modified version of our devstack plugin it
worked
As expected. The required modification were trivial as expected so I think the
same should be
True of any other deployment tool.
> http://openvswitch.org/pipermail/dev/2016-February/066990.html
We have never used ovs-ctl to start/stop ovs partly because of this issue so
Its nice to see this change.
>
> Is there anything else I can do? I'm planning on rebasing this series,
> and including the minor fixes from Kevin in my v10. Do I need to include
> anything else?
It probably not for this patch series but maybe as a follow up change it would
be
Nice to initializes the ovs logging sooner(or possibly configure dpdk to use
it?).
You may have noticed that we start ovs as follows
screen -dms ovs-vswitchd sudo sg $qemu_group -c "umask 002;
${OVS_INSTALL_DIR}/sbin/ovs-vswitchd -- unix:$OVS_DB_SOCKET 2>&1 | tee
${OVS_LOG_DIR}/ovs-vswitchd.log
this is because if you use the standard way of logging to a file with ovs it
does not log the dpdk eal init output so if you have an issue
in dpdk setup it will not appear in the log. From a usability point of view it
would be nice the dpdk init logs were captures by the standard
logging mechanism. So no other then the change you already plan to make when
rebasing there is nothing else from me at least.
> Aaron Conole <acon...@redhat.com> writes:
> > Currently, configuration of DPDK parameters is done via the command
> > line through a --dpdk **OPTIONS** -- command line argument. This has a
> > number of challenges, including:
> > * It must be the first option passed to ovs-vswitchd
> > * It is the only datapath feature in OVS to be configured on the
> > command line
> > * It requires specialized knowledge of sub-component command switches
> > * It also inteprets non-EAL arguments (confusing users)
> > * It is a broken model.
> >
> >
> > This series brings the following changes to openvswitch:
> > * All DPDK options are taken from the ovs database rather than the
> > command line
> > * Non-EAL arguments also have separate database entries
> > * DPDK lcores are optionally auto-assigned to a single core based on
> the
> > bridge coremask.
> > * DPDK options have default behaviors
> > * Updated documentation
> >
> > v2:
> > * Dropped the vhost-user socket configuration options. Those can be
> re-added
> > as an extension
> > * Incorporated feedback from Kevin Traynor.
> >
> > v3:
> > * Went back to a global dpdk-init
> > * Language cleanup and various minor fixes
> >
> > v4:
> > * Added a way to pass arbitrary eal arguments
> >
> > v5:
> > * Restore the socket-mem default, and fix up the ovs-dev.py script,
> along
> > with the manpage for ovsdb-server
> >
> > v6:
> > * Correct a documentation issue with INSTALL.DPDK.md
> > * Correct a non-dpdk enabled OVS incorrect warning variable
> > * Remove an excess whitespace
> >
> > v7:
> > * After testing by Christian with dpdk-alloc-mem
> >
> > v8:
> > * Confirmed ``make check`` operation with and without dpdk.
> > Retested on live-host
> >
> > v9:
> > * Cleanup of comments
> > * Cleanup of one place where headers are specified
> > * Mark the dpdk coremask and numa config as optional
> > * Added 5/6 to scan the extras and warn the user when conflicting
> > DB entries are present
> > * Acks given for all but patch 5/6
> >
> > Aaron Conole (5):
> > netdev-dpdk: Restore thread affinity after DPDK init
> > netdev-dpdk: Convert initialization from cmdline to db
> > netdev-dpdk: Autofill lcore coremask if absent
> > netdev-dpdk: Allow arbitrary eal arguments
> > NEWS: Announce the DPDK EAL configuration change
> >
> > FAQ.md | 6 +-
> > INSTALL.DPDK.md | 90 ++++++++++---
> > NEWS | 5 +
> > lib/netdev-dpdk.c | 327
> ++++++++++++++++++++++++++++++++++++++-------
> > lib/netdev-dpdk.h | 22 ++-
> > utilities/ovs-dev.py | 7 +-
> > vswitchd/bridge.c | 3 +
> > vswitchd/ovs-vswitchd.8.in | 5 +-
> > vswitchd/ovs-vswitchd.c | 25 +---
> > vswitchd/vswitch.xml | 128 +++++++++++++++++-
> > 10 files changed, 515 insertions(+), 107 deletions(-)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
