> On Feb 19, 2016, at 4:40 PM, Ben Pfaff <b...@ovn.org> wrote: > +struct mcgroup { > + struct hmap_node dp_name_node; /* Index by (logical datapath, name). */ > + const struct sbrec_multicast_group *mg; > +}; > + > +void > +mcgroup_index_init(struct mcgroup_index *mcgroups, struct ovsdb_idl > *ovnsb_idl) > +{ > + hmap_init(&mcgroups->by_dp_name); > + > + const struct sbrec_multicast_group *sb;
Pretty minor, but when looking at the code later in the function, I would have thought "sb" was a pointer to the database. I think I was particularly thrown because it's referred to as "mg" in the "mcgroup" definition. Acked-by: Justin Pettit <jpet...@ovn.org> --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev