On Thu, Mar 3, 2016 at 12:09 PM, Justin Pettit <jpet...@ovn.org> wrote:

>
> > On Mar 3, 2016, at 7:18 AM, Russell Bryant <russ...@ovn.org> wrote:
> >
> > The "alg=" argument to the ct() action only makes sense when used in
> > combination with "commit".  Add this to the documentation to help make
> > it clear.
> >
> > Signed-off-by: Russell Bryant <russ...@ovn.org>
> > ---
> > utilities/ovs-ofctl.8.in | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> > index 1b280ef..74b88d8 100644
> > --- a/utilities/ovs-ofctl.8.in
> > +++ b/utilities/ovs-ofctl.8.in
> > @@ -1745,6 +1745,9 @@ connection arrives which is related, the \fBct\fR
> action will set the
> > .RE
> > .
> > .IP
> > +The \fBcommit\fR parameter should be specified to use \fBalg=\fIalg\fR.
>
> RFC-related feedback: Your suggestion sounds nicer, but do you think that
> should be "must" instead of "should"?  I'm fine either way, though.
>

"must" does sound more correct.  I actually just copied this from:

"The commit parameter should be specified to use exec(...)."

I'll change both to "must" and push this to master.

Acked-by: Justin Pettit <jpet...@ovn.org>
>

Thanks!

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to