[ovs-dev] Doubt about Packet flow in Openvswitch

Dear Sir, How do I get into the packet that comes through the flow in the openvswitch code. But I am not able to reach out to lib/packets.c even by tracing any pre-defined action. I am stuck at function HMAP_FOR_EACH_WITH_HASH() defined in lib/hmap.h and called at ofpact_raw_lookup() function in of

Re: [ovs-dev] [PATCH v3] ovs-bugtool: Create OVN plugin and add output.

Thank you for finding this mistake. I've fixed it and resubmitted. On Fri, Feb 5, 2016 at 3:54 PM, Ben Pfaff wrote: > On Thu, Jan 21, 2016 at 09:08:50AM -0800, William Tu wrote: > > Create a new ovn/utilities/bugtool directory, add ovn.xml to bugtool > > plugins, and add ovn-nbctl show, ovn-sbct

[ovs-dev] [PATCH v4] ovs-bugtool: Create OVN plugin and add output.

Create a new ovn/utilities/bugtool directory, add ovn.xml to bugtool plugins, and add ovn-nbctl show, ovn-sbctl show, and ovn-sbctl lflow-list. Signed-off-by: William Tu --- v4: fix the unmatched file names at ovn.xml to ovn-bugtool-nbctl-show ovn-bugtool-sbctl-show ovn-bugtool-sbctl-lflow

Re: [ovs-dev] [PATCH 4/4] tests: Add IPv6-over-vxlan-over-IPv4 tests.

On Fri, Jan 29, 2016 at 11:37:54AM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/4] tests: Add IP fragmentation expiry tests.

On Fri, Jan 29, 2016 at 11:37:53AM -0800, Joe Stringer wrote: > These tests indirectly trigger the kernel IP fragment expiry code by > ensuring that not all fragments are assembled. > > This reproduces the bug that was fixed in the following commit: > bf1f0d35ceb9 datapath: Fix IPv6 fragment expir

Re: [ovs-dev] [PATCH 2/4] tests: Make vxlan frag test more reliable.

On Fri, Jan 29, 2016 at 12:34:12PM -0800, Joe Stringer wrote: > On 29 January 2016 at 11:37, Joe Stringer wrote: > > Depending on the kernel version in use, the nf_conntrack module may > > register hooks for each namespace and execute conntrack prior to passing > > packets to OVS (or not). In case

Re: [ovs-dev] [PATCH 1/4] tests: Fix typo in IPv6 tests.

On Fri, Jan 29, 2016 at 11:37:51AM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-xlate: Don't consider mirrors used when excluded by VLAN.

On Fri, Feb 05, 2016 at 04:41:29PM -0800, Jarno Rajahalme wrote: > > > On Feb 5, 2016, at 3:30 PM, Ben Pfaff wrote: > > > > Mirroring is supposed to happen at most once for any destination on a given > > packet, so the implementation keeps track of which mirrors have already > > been used. Howe

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix dpdk_watchdog failure to quiesce.

Patrik, thanks for debugging this issue, I've added you to AUTHORS. Thanks for the patch Kevin, I updated a comment (below) and pushed this up to branch-2.4. On 05/02/2016 09:07, "Kevin Traynor" wrote: >Fix issue whereby vhost_thread is waiting for dpdk_watchdog >thread to quiesce and at the s

Re: [ovs-dev] [PATCH branch-2.3 v2 4/5] ofproto: Allow in-place modifications of datapath flows.

Thanks for the reviews, series pushed to branch-2.3. Jarno > On Feb 5, 2016, at 5:44 PM, Joe Stringer wrote: > > On 4 February 2016 at 16:10, Jarno Rajahalme > wrote: >> From: Ethan Jackson >> >> There are certain use cases (such as bond rebalancing) where a >> datapa

Re: [ovs-dev] [PATCH branch-2.3 v2 4/5] ofproto: Allow in-place modifications of datapath flows.

On 4 February 2016 at 16:10, Jarno Rajahalme wrote: > From: Ethan Jackson > > There are certain use cases (such as bond rebalancing) where a > datapath flow's actions may change, while it's wildcard pattern > remains the same. Before this patch, revalidators would note the > change, delete the f

[ovs-dev] [PATCH nf-next v7 6/7] openvswitch: Delay conntrack helper call for new connections.

There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[ovs-dev] [PATCH nf-next v7 7/7] openvswitch: Interface with NAT.

Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[ovs-dev] [PATCH nf-next v7 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/con

[ovs-dev] [PATCH nf-next v7 0/7] openvswitch: NAT support.

This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-2/7). Patches 3-6 make the openvswitch kernel module ready for the patch 7 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[ovs-dev] [PATCH nf-next v7 1/7] netfilter: Remove IP_CT_NEW_REPLY definition.

Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

[ovs-dev] [PATCH nf-next v7 4/7] openvswitch: Find existing conntrack entry after upcall.

Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[ovs-dev] [PATCH nf-next v7 3/7] openvswitch: Update the CT state key only after nf_conntrack_in().

Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++--- 1 file changed

[ovs-dev] [PATCH nf-next v7 2/7] netfilter: Allow calling into nat helper without skb_dst.

NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

Re: [ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

On Fri, Feb 05, 2016 at 07:45:35PM -0500, Russell Bryant wrote: > On 02/05/2016 07:43 PM, Ben Pfaff wrote: > > I'm trying to keep up with patches, but I don't understand whether this > > one is needed or what the verdict on it is. > > This was resolved. This issue had to do with building a RHEL7

Re: [ovs-dev] [PATCH] ovs-benchmark: Remove.

Thanks, applied to master. On Fri, Feb 05, 2016 at 04:42:51PM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Feb 5, 2016, at 4:02 PM, Ben Pfaff wrote: > > > > This utility was completely broken and no one noticed for the time of a > > full release, so I think that's a safe

Re: [ovs-dev] [PATCH] ovsdb-idl: log error in client when db schema does not exist on server

On Thu, Jan 28, 2016 at 09:26:55AM -0500, Lance Richardson wrote: > A common error scenario with OVN is to attempt to use ovn-nbctl when > the OVN databases have not been created in ovsdb-server: >1. ovn-nbctl sends "get_schema" request for OVN db to ovsdb-server. >2. ovsdb-server fails to

Re: [ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

On 02/05/2016 07:43 PM, Ben Pfaff wrote: > I'm trying to keep up with patches, but I don't understand whether this > one is needed or what the verdict on it is. This was resolved. This issue had to do with building a RHEL7 rpm using the RHEL6 spec file. Related fixes that already merged: https:

Re: [ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

On Thu, Jan 28, 2016 at 01:20:49PM -0500, Thomas F Herbert wrote: > On 1/28/16 11:07 AM, Guru Shetty wrote: > >It should ideally work. If not, it is a bug. Just to make sure that you > >are doing the right thing, have you read the following piece of > >instruction in INSTALL.RHEL.md

Re: [ovs-dev] [PATCH] ovs-benchmark: Remove.

Acked-by: Jarno Rajahalme > On Feb 5, 2016, at 4:02 PM, Ben Pfaff wrote: > > This utility was completely broken and no one noticed for the time of a > full release, so I think that's a safe sign that we should remove it. > > Signed-off-by: Ben Pfaff > --- > NEWS

Re: [ovs-dev] [PATCH 3/3] tests: Add mirror-related keywords to all the mirroring tests.

Acked-by: Jarno Rajahalme > On Feb 5, 2016, at 3:30 PM, Ben Pfaff wrote: > > Autotest isn't too smart, so if you try to use "mirroring" as a keyword > before this commit it doesn't select most of the tests due to the comma in > the test names. > > Signed-off-by: Ben Pfaff > --- > tests/ofprot

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-xlate: Don't consider mirrors used when excluded by VLAN.

> On Feb 5, 2016, at 3:30 PM, Ben Pfaff wrote: > > Mirroring is supposed to happen at most once for any destination on a given > packet, so the implementation keeps track of which mirrors have already > been used. However, until this commit it did that incorrectly: it > considered a mirror "use

Re: [ovs-dev] [PATCH] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

On Thu, Feb 04, 2016 at 09:12:25PM -0200, Flavio Leitner wrote: > On Thu, 28 Jan 2016 14:23:52 +0200 > Panu Matilainen wrote: > > > Requires DPDK >= 2.2 as that is the first version to have a standard > > install layout which we can discover without help from user. > > Additionally document the o

Re: [ovs-dev] [PATCH 1/2 v2] ofctl: This patch add support for setting the first egress table for egress processing.

On Wed, Jan 27, 2016 at 05:14:33PM +0530, niti1...@gmail.com wrote: > From: Niti Rohilla > > "ovs-ofctl set-first-egress-table " can be used to set > first egress > table. > This patch enhances TABLE_FEATURES_REQUEST message to set the first egress > table and > TABLE_FEATURES_REPLY to identif

Re: [ovs-dev] [PATCH] CONTRIBUTING: Strengthen testing guidelines

On Mon, Jan 25, 2016 at 03:15:23PM +, Mark Kavanagh wrote: > Current testing guidelines do not take account of two distinct > OVS builds: >a) 'standard' OVS >b) OVS with DPDK integration > > It is critical that all patches are tested against both builds; if not, > there is a strong pos

Re: [ovs-dev] [PATCH] ovs-numa: Fix cpu discovering if CONFIG_NUMA disabled.

On Mon, Jan 25, 2016 at 05:37:19PM +0300, Ilya Maximets wrote: > If CONFIG_NUMA disabled in the system, PMD threads can't > be created: > > |ovs_numa|INFO|Discovered 0 NUMA nodes and 0 CPU cores > > Signed-off-by: Ilya Maximets Applied to master, thanks.

Re: [ovs-dev] [PATCH] ovn-controller: Fix typo in comment.

On Fri, Feb 05, 2016 at 04:36:16PM -0600, Kyle Mestery wrote: > On Fri, Feb 5, 2016 at 4:18 PM, Ben Pfaff wrote: > > Too much asss. > > > > Signed-off-by: Ben Pfaff > > --- > > ovn/controller/lflow.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ovn/controller/lf

Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

> On Feb 5, 2016, at 4:06 PM, Ben Pfaff wrote: > > On Fri, Feb 05, 2016 at 03:49:24PM -0800, Jarno Rajahalme wrote: >> Sorry for not spotting this on review, I must have assumed that if the >> tests pass it must be correct! > > It's funny, I remember fixing this particular bug at some point bef

Re: [ovs-dev] [PATCH 1/1] ovsdb: fix typo in libovsdb's pkg-config

On Fri, Jan 22, 2016 at 08:06:28PM +, Ansari, Shad wrote: > Fix typo in the library name of pkg-config of libovsdb. > > Reported-by: Javier Albornz > Signed-off-by: Shad Ansari Thanks, applied to master, branch-2.5, and branch-2.4. ___ dev mailing

Re: [ovs-dev] [PATCH v9] Implement OFPT_TABLE_STATUS Message.

On Fri, Jan 22, 2016 at 02:34:42PM +0530, saloni.jai...@gmail.com wrote: > From: Saloni Jain > > On change in a table state, the controller needs to be informed with > the OFPT_TABLE_STATUS message. The message is sent with reason > OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in rema

Re: [ovs-dev] [PATCH v2] test-ovsdb: fix memory leak reported by valgrind.

On Fri, Jan 22, 2016 at 01:04:50PM -0800, William Tu wrote: > Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak > below: > xmalloc (util.c:112) > do_query_distinct (test-ovsdb.c:1208) > ovs_cmdl_run_command (command-line.c:121) > main (test-ovsdb.c:72) > > Sign

Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

On Fri, Feb 05, 2016 at 03:49:24PM -0800, Jarno Rajahalme wrote: > Sorry for not spotting this on review, I must have assumed that if the > tests pass it must be correct! It's funny, I remember fixing this particular bug at some point before I applied the earlier patch, but I guess it got lost. >

[ovs-dev] [PATCH] ovs-benchmark: Remove.

This utility was completely broken and no one noticed for the time of a full release, so I think that's a safe sign that we should remove it. Signed-off-by: Ben Pfaff --- NEWS | 2 + debian/openvswitch-common.install | 1 - debian/openvswitch-common.manpages |

Re: [ovs-dev] [PATCH] ovs-benchmark: fix return value of do_poll

On Thu, Jan 21, 2016 at 10:16:23AM -0800, William Tu wrote: > A positive number is returned when do_poll successes. > > Signed-off-by: William Tu Thanks, I applied this. I think that this is a good sign that ovs-benchmark never gets used, though. I'm going to send out a patch that removes it.

Re: [ovs-dev] [PATCH v3] ovs-bugtool: Create OVN plugin and add output.

On Thu, Jan 21, 2016 at 09:08:50AM -0800, William Tu wrote: > Create a new ovn/utilities/bugtool directory, add ovn.xml to bugtool > plugins, and add ovn-nbctl show, ovn-sbctl show, and ovn-sbctl > lflow-list. > > Signed-off-by: William Tu The script names in the .xml file don't match the actual

Re: [ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

Sorry for not spotting this on review, I must have assumed that if the tests pass it must be correct! A reference to the commit this fixes would be nice. Acked-by: Jarno Rajahalme > On Feb 5, 2016, at 3:30 PM, Ben Pfaff wrote: > > This definition just didn't work, and caused lots of tests to

Re: [ovs-dev] question about mirror code

On Tue, Jan 26, 2016 at 12:13:08AM +0800, Huanle Han wrote: > 2016-01-25 1:00 GMT+08:00 Ben Pfaff : > > > On Sun, Jan 24, 2016 at 11:59:57PM +0800, Huanle Han wrote: > > > I think a more line "mirrors &= ~ctx->mirrors;" is needed at the end of > > the > > > "while" loop. > > > Otherwise, duplicate

[ovs-dev] [PATCH 3/3] tests: Add mirror-related keywords to all the mirroring tests.

Autotest isn't too smart, so if you try to use "mirroring" as a keyword before this commit it doesn't select most of the tests due to the comma in the test names. Signed-off-by: Ben Pfaff --- tests/ofproto-dpif.at | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/ofproto-dpif

[ovs-dev] [PATCH 1/3] ofproto-macros: Fix definition of add_of_ports.

This definition just didn't work, and caused lots of tests to inadvertently be effectively skipped. Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 354a384..c6c332

[ovs-dev] [PATCH 2/3] ofproto-dpif-xlate: Don't consider mirrors used when excluded by VLAN.

Mirroring is supposed to happen at most once for any destination on a given packet, so the implementation keeps track of which mirrors have already been used. However, until this commit it did that incorrectly: it considered a mirror "used" even if it had been rejected on the basis of VLAN. This

Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's lflow incremental processing

Ben Pfaff wrote on 02/05/2016 04:20:04 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 02/05/2016 04:20 PM > Subject: Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's > lflow incremental processing > > On Fri, Feb 05, 2016 at 03:41:24PM -0600, Ryan

[ovs-dev] [PATCH] ofproto-macros: Fix definition of add_of_ports.

This definition just didn't work, and caused lots of tests to inadvertently be effectively skipped. Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 354a384..c6c332

[ovs-dev] [PATCH v3] ovn: Connect to remote lports through localnet port.

Before this patch, inter-chassis communication between VIFs of same lswitch will always go through tunnel, which end up of modeling a single physical network with many lswitches and pairs of lports, and complexity in CMS like OpenStack neutron to manage the lswitches and lports. With this patch, i

Re: [ovs-dev] [PATCH] ovn-controller: Fix typo in comment.

On Fri, Feb 5, 2016 at 4:18 PM, Ben Pfaff wrote: > Too much asss. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/lflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c > index e586365..d53213c 100644 > --- a/ovn/contr

Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's lflow incremental processing

On Fri, Feb 05, 2016 at 03:41:24PM -0600, Ryan Moats wrote: > Ben Pfaff wrote on 02/05/2016 01:01:56 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 02/05/2016 01:02 PM > > Subject: Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's > > lfl

[ovs-dev] [PATCH] ovn-controller: Fix typo in comment.

Too much asss. Signed-off-by: Ben Pfaff --- ovn/controller/lflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c index e586365..d53213c 100644 --- a/ovn/controller/lflow.c +++ b/ovn/controller/lflow.c @@ -285,7 +285,7 @@ lflow

Re: [ovs-dev] [PATCH 3/3] ovn: Qos options for VMI updated in ovn-nb.xml

On Tue, Jan 05, 2016 at 07:33:19PM +0530, bscha...@redhat.com wrote: > Signed-off-by: Babu Shanmugam Again I'd squash this with patch 1. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] ovn: Qos options for VMI updated in ovn-sb.xml

On Tue, Jan 05, 2016 at 07:33:18PM +0530, bscha...@redhat.com wrote: > Signed-off-by: Babu Shanmugam I'd probably copy at least some of the more extensive documentation from vswitch.xml in here. I'd squash this with patch 1. ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH 1/3] ovn: ovn-controller changes for qos settings

On Tue, Jan 05, 2016 at 07:33:17PM +0530, bscha...@redhat.com wrote: > The qos settings are managed using the 'options' fields in the > "Port_Binding" table. > > Signed-off-by: Babu Shanmugam This seems more complicated than necessary. In the SBREC_PORT_BINDING_FOR_EACH loop in binding_run(), I

Re: [ovs-dev] [PATCH] ovsdb-server: fix monitor counters reported by memory/show

On Fri, Feb 5, 2016 at 11:02 AM, Ben Pfaff wrote: > On Wed, Feb 03, 2016 at 09:35:36PM -0800, Andy Zhou wrote: > > Commit 4c2809787cdbc774 (ovsdb-monitor: add json cache) introduced > > an optimization that allows jsonrpc session to share monitors. > > However, the memory/show implementation was

Re: [ovs-dev] [PATCH 0/3] QOS support in OVN

On Mon, Feb 01, 2016 at 01:32:49PM +0530, Babu Shanmugam wrote: > Do you have more questions on this topic? I'm still not entirely convinced of the value of policing, but it seems that there's demand for it. I'll review the series. ___ dev mailing list

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

On 05/02/2016 13:18, "Ben Pfaff" wrote: >On Thu, Feb 04, 2016 at 09:30:59AM +, Stokes, Ian wrote: >> Just wondering is there any feedback for the V3 patch below for QoS >>functionality? >> >> This patch has been in and out of review since October, I think I've >>reworked it to meet any spe

Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's lflow incremental processing

Ben Pfaff wrote on 02/05/2016 01:01:56 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 02/05/2016 01:02 PM > Subject: Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's > lflow incremental processing > > On Wed, Feb 03, 2016 at 04:20:23PM -0600, RY

Re: [ovs-dev] [PATCH] ovn-controller: Use ofputil_encode_set_config to set the switch config

On Wed, Feb 03, 2016 at 04:08:04PM +0530, Numan Siddique wrote: > After the commit ad99e2e, setting the switch config 'miss_send_len' > is failing in ovn-controller because of validation in OFPT_SET_CONFIG > messages. > > Signed-off-by: Numan Siddique This is an improvement in any case, because

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

On 02/05/2016 02:22 AM, Justin Pettit wrote: > Joe and I spent some time today discussing our options. This is > pretty tricky to get right and most of the options that come > immediately to mind have subtle corner cases. We're planning to > whiteboard more options tomorrow, but I wanted to get d

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

On Thu, Feb 04, 2016 at 09:30:59AM +, Stokes, Ian wrote: > Just wondering is there any feedback for the V3 patch below for QoS > functionality? > > This patch has been in and out of review since October, I think I've reworked > it to meet any specific issues raised. > > If there is anything

Re: [ovs-dev] [PATCH V2] Add tunnel key to Physical_Locator

On Thu, Feb 04, 2016 at 09:49:35AM +, Ofer Ben-Yacov wrote: > The tunnel key in decoupled from the actual implementation of the tunnel. > The only tunnel protocol that is currently supported in this schema is > VxLAN. (the encapsulation is set by enum with single value: > vxlan_over_ipv4 ). Th

[ovs-dev] [PATCH v4] vtep: Support per-tunnel tunnel key in schema.

From: Ofer Ben Yacov Currently the scenario of single logical bridge that use multiple locators with different tunnel key on each of the locators is not supported. In order to support much more flexibility in the tunnel settings, we need to add tunnel key column to the Physical_Locator table. Th

Re: [ovs-dev] [OVS-dev]: OVN: RFC re: logical and physical endpoint separation proposal

On 01/29/2016 09:36 PM, Darrell Lu wrote: > The following is a proposal regarding how to allow logical > and physical endpoint contexts for OVN to stay separated, from > a CMS POV. > > A logical endpoint has the form: ls1-port1. > A physical endpoint has the general form: > chassis/physical port o

Re: [ovs-dev] [RFC 3/3] netdev-dpdk: Unlink vhost user socket before creation.

On 5 February 2016 at 00:53, Aaron Conole wrote: > Hi Ansis, > > Ansis Atteka writes: > > On 2 February 2016 at 17:56, Daniele Di Proietto > > > wrote: > > > >> If ovs-vswitchd crashes, it will not be able to recreate the same > >> vhost user ports, since the socket will still be in the file sy

Re: [ovs-dev] [PATCH] dpif-netdev: Add dpif-netdev/pmd-show-poll-lists appctl command.

On Thu, 28 Jan 2016 16:33:51 +0300 Ilya Maximets wrote: > This command can be used to check the port/rxq assignment to > pmd threads. For each pmd thread of the datapath shows list > of queue-ids with port names. > > Additionally log message from pmd_thread_main() extended with > queue-id, and t

Re: [ovs-dev] [CudaMailTagged] [PATCH 0/2] Add color output to `ovs-ofctl dump-flows` command

On 5 February 2016 at 04:45, Quentin Monnet wrote: > 2016-02-02 19:14 GMT+01:00 Ben Pfaff : > >> On Tue, Feb 02, 2016 at 09:31:22AM +0100, Quentin Monnet wrote: >> > 2016-02-01 18:14 GMT+01:00 Ben Pfaff : >> > >> > > On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote: >> > > > Proposal

Re: [ovs-dev] [PATCH v2] ovn: Connect to remote lports through localnet port.

On Fri, Feb 5, 2016 at 10:55 AM, Russell Bryant wrote: > > On 02/03/2016 07:03 PM, Han Zhou wrote: > > Before this patch, inter-chassis communication between VIFs of same > > lswitch will always go through tunnel, which end up of modeling a > > single physical network with many lswitches and pairs

Re: [ovs-dev] [PATCH] ovs-vswitchd: Preserve datapath ports across graceful shutdown.

On Thu, Feb 04, 2016 at 12:25:48PM -0800, Guru Shetty wrote: > On 4 February 2016 at 09:49, Ben Pfaff wrote: > > > Until now, asking ovs-vswitchd to shut down gracefully, e.g. with > > "ovs-appctl exit", would cause it to first remove all the ports from > > kernel-based datapaths. This has the u

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Do not add vhost-user ports with '/' in name.

On Thu, Feb 04, 2016 at 03:42:34AM +, Daniele Di Proietto wrote: > > > On 03/02/2016 14:47, "Ben Pfaff" wrote: > > >On Tue, Feb 02, 2016 at 05:56:35PM -0800, Daniele Di Proietto wrote: > >> This check prevents an obvious way for a vhost-user socket to escape the > >> intended directory. > >

Re: [ovs-dev] [RFC 3/3] netdev-dpdk: Unlink vhost user socket before creation.

On Fri, Feb 05, 2016 at 03:53:08AM -0500, Aaron Conole wrote: > IMHO, this is all just guessing games - testing this way is non-atomic. There > must be a way to have DPDK (or even if there is some non-dpdk vhost-user > library, really) know that this socket is orphaned. I guess, I'm saying > it's *

Re: [ovs-dev] [ovs-dev, RFC, 3/3] netdev-dpdk: Unlink vhost user socket before creation.

On Thu, Feb 04, 2016 at 10:02:08AM +0300, Ilya Maximets wrote: > On 04.02.2016 00:55, Ben Pfaff wrote: > > On Wed, Feb 03, 2016 at 05:50:19PM +0300, Ilya Maximets wrote: > >> > >> On 03.02.2016 04:56, Daniele Di Proietto wrote: > >>> If ovs-vswitchd crashes, it will not be able to recreate the same

Re: [ovs-dev] [PATCH branch 2.5] tunneling: Disable IPv6 tunnel

On Fri, Feb 5, 2016 at 12:15 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Feb 04, 2016 at 08:04:53PM -0800, Jesse Gross wrote: >> On Thu, Feb 4, 2016 at 7:55 PM, Pravin B Shelar wrote: >> > There are multiple issues in IPv6 userspace tunnel >> > implementation. There is not enough time to g

Re: [ovs-dev] [CudaMailTagged] [PATCH 0/2] Add color output to `ovs-ofctl dump-flows` command

On Fri, Feb 05, 2016 at 01:45:04PM +0100, Quentin Monnet wrote: > Does someone have an opinion about this kind of patches? Regardless of > implementation details, is output coloring something that people find > interesting for OVS? I made the patch because I found it somewhat difficult > to read ou

Re: [ovs-dev] [PATCH][V3] lib/ovs-thread: enforce min thread stack size to 512k

On Thu, Feb 04, 2016 at 09:20:34AM +0200, Alexandru Ardelean wrote: > In case of certain libc implementations (such as musl libc) > that have a really small default pthread stack size. > > Will reference this discussion: > http://patchwork.ozlabs.org/patch/572340/ > > Thanks to Robert McKay for r

Re: [ovs-dev] [PATCH] ovsdb-server: fix monitor counters reported by memory/show

On Wed, Feb 03, 2016 at 09:35:36PM -0800, Andy Zhou wrote: > Commit 4c2809787cdbc774 (ovsdb-monitor: add json cache) introduced > an optimization that allows jsonrpc session to share monitors. > However, the memory/show implementation was not updated to match the > implementation; it still assumes

Re: [ovs-dev] [PATCH] [ovn-controller] [RFC] Poor man's lflow incremental processing

On Wed, Feb 03, 2016 at 04:20:23PM -0600, RYAN D. MOATS wrote: > Add incremental processing of lflows in ovn-controller by > taking the simple approach of marking each lflow dirty when > touched and have lflow_run only process dirty flows. > > This needs unit test code before the RFC tag comes off

Re: [ovs-dev] [PATCH v2] ovn: Connect to remote lports through localnet port.

On 02/03/2016 07:03 PM, Han Zhou wrote: > Before this patch, inter-chassis communication between VIFs of same > lswitch will always go through tunnel, which end up of modeling a > single physical network with many lswitches and pairs of lports, and > complexity in CMS like OpenStack neutron to mana

Re: [ovs-dev] [PATCH v1] Basic GTP-U tunnel implementation in ovs

On Fri, Feb 05, 2016 at 04:17:43PM +0530, Niti Rohilla wrote: > GPRS Tunneling Protocol (GTP) is a group of IP-based communications protocols > used to carry general packet radio service (GPRS) within GSM, UMTS > and LTE networks. GTP-U is used for carrying user data within the GPRS core > network

Re: [ovs-dev] [PATCH branch-2.3 v2 5/5] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

On Thu, Feb 04, 2016 at 04:10:11PM -0800, Jarno Rajahalme wrote: > From: Alex Wang > > In the push_dump_ops__(), when flow_del operation returns error, the 'struct > stats' passed to the operation function will be set to all zero. And we > should not use it to calculate the delta (i.e. minus the

Re: [ovs-dev] [PATCH branch-2.3 v2 4/5] ofproto: Allow in-place modifications of datapath flows.

On Thu, Feb 04, 2016 at 04:10:10PM -0800, Jarno Rajahalme wrote: > From: Ethan Jackson > > There are certain use cases (such as bond rebalancing) where a > datapath flow's actions may change, while it's wildcard pattern > remains the same. Before this patch, revalidators would note the > change,

[ovs-dev] [PATCH] netdev-dpdk: Fix dpdk_watchdog failure to quiesce.

Fix issue whereby vhost_thread is waiting for dpdk_watchdog thread to quiesce and at the same time dpdk_watchdog thread is waiting for vhost_thread to give up dpdk_mutex. Reported-by: Patrik Andersson R Signed-off-by: Patrik Andersson R Signed-off-by: Kevin Traynor --- lib/netdev-dpdk.c | 35

[ovs-dev] [PATCH v1] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

Kernel network devices in a guest should have the number of multi-purpose channels configured when used with DPDK multiqueue on the host. This commit adds an example of how this can be done. Also add QEMU 2.5 requirements for multiqueue with DPDK in NEWS. Signed-off-by: Ian Stokes --- INSTALL.DP

Re: [ovs-dev] [PATCH branch-2.3 v2 2/5] type-props: Suppress warnings in newer Clang and GCC.

On Thu, Feb 04, 2016 at 04:10:08PM -0800, Jarno Rajahalme wrote: > From: Ben Pfaff > > Until now, Clang 3.7+ and sufficiently new versions of GCC complained about > TYPE_MAXIMUM(int), etc., because it shifts a negative value. This commit > fixes the problem. > > This commit also gives these mac

Re: [ovs-dev] [PATCH branch-2.3 v2 1/5] type-props: Avoid a MSVC warning.

On Thu, Feb 04, 2016 at 04:10:07PM -0800, Jarno Rajahalme wrote: > From: Gurucharan Shetty > > Currently, MSVC complains when you have a macro of the > form TYPE_MAXIMUM(uint64_t) because a part of macro becomes > ~(uint64_t)0 << 64 with a warning: > > C4293: '<<' : shift count negative or too b

Re: [ovs-dev] [PATCH] ovn: Connect to remote lports through localnet port.

On 02/03/2016 03:26 PM, Han Zhou wrote: > > > On Wed, Feb 3, 2016 at 11:35 AM, Russell Bryant > wrote: >> >> On 01/30/2016 11:23 PM, Han Zhou wrote: >> > Before this patch, inter-chassis communication between VIFs of same >> > lswitch will always go through tunnel, which

Re: [ovs-dev] [PATCH v2] ovn-northd: Revert "ovn-northd: Only run idl loop if something changed"

On 02/04/2016 09:41 AM, Numan Siddique wrote: > This reverts f20396e051ea4fd623bfc022cc78d9bd52a850e5 > > f20396e.. was required to fix the failing ovn-sbctl testsuites. > commit fb496f92ca1eeead8760b5cdfd857165f64deadf addresses these failing > test cases in a proper way. > > With commit f20396e

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

On 01/28/2016 09:08 PM, Na Zhu wrote: > Hi Russell, > > Will you create a provide network for floating ip? > I draw a diagram about the model you prefer (classic ovs model), is it > right? > 内嵌图片 1 > Only logical router connects the provider network, the provider network > is for FIP. Yes, that

[ovs-dev] [PATCH v1] INSTALL.DPDK: Update details of XL710 restrictions for DPDK 2.2

DPDK 2.2 removes restrictions related to maximum number of TX queues for XL710 devices. Update documentation to reflect these changes. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/INSTALL.DPDK.md b/I

Re: [ovs-dev] [CudaMailTagged] [PATCH 0/2] Add color output to `ovs-ofctl dump-flows` command

2016-02-02 19:14 GMT+01:00 Ben Pfaff : > On Tue, Feb 02, 2016 at 09:31:22AM +0100, Quentin Monnet wrote: > > 2016-02-01 18:14 GMT+01:00 Ben Pfaff : > > > > > On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote: > > > > Proposal: add an option to ovs-ofctl utility so as to obtain > color

[ovs-dev] Dev@openvswitch.org

The original message was received at Sun, 1 Jan 2006 02:05:48 +0530 from openvswitch.org [60.66.35.253] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org

Re: [ovs-dev] [PATCH v8 0/5] Convert DPDK configuration from command line to DB based

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Friday, February 5, 2016 2:22 AM > To: Flavio Leitner; Aaron Conole; Andy Zhou > Cc: > Subject: Re: [ovs-dev] [PATCH v8 0/5] Convert DPDK configuration from command > line to D

Re: [ovs-dev] [PATCH monitor_cond V3 09/10] python: move Python idl to work with monitor_cond

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > Python idl works now with "monitor_cond" method. Add test > for backward compatibility with old "monitor" method. > > Signed-off-by: Liran Schour > I glanced through the logic of most of the changes. They look find in general. I have the sa

[ovs-dev] [PATCH] Installation steps correction for DPDK 2.2.

Missing step added to INSTALL.DPDK.md which prevents installation error message. Signed-off-by: Michal Weglicki --- INSTALL.DPDK.md | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index c601358..0928e66 100644 --- a/INS

Re: [ovs-dev] [PATCH monitor_cond V3 08/10] lib: add monitor_cond_update API to C IDL lib

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > Add API that allows the user to create condition iteratively > and send condition_update to the server. > > Signed-off-by: Liran Schour > --- > v2->v3: > * Simplify API to allow iteratively adding clauses to condition > before send monito

[ovs-dev] [PATCH v1] Basic GTP-U tunnel implementation in ovs

GPRS Tunneling Protocol (GTP) is a group of IP-based communications protocols used to carry general packet radio service (GPRS) within GSM, UMTS and LTE networks. GTP-U is used for carrying user data within the GPRS core network and between the radio access network and the core network. In case of

Re: [ovs-dev] [PATCH monitor_cond V3 07/10] lib: add to ovsdb-idl monitor_id

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > IDL uses now a uuid to specify a monitoring session that is being > sent to the server on "monitor_cond" request. > This uuid will be used to issue ongoing "monitor_cond_change" requests > for this monitoring session. > > Signed-off-by: Liran

Re: [ovs-dev] [PATCH monitor_cond V3 06/10] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > ovsdb-server now accepts "monitor_cond_update" request. On conditions > update > we insert all rows of table in a new changes list - OVSDB_MONITOR_ALL that > are > being indexed by the transaction-id at the moment of insertion. > JSON cache is

Re: [ovs-dev] [PATCH v7 0/5] Convert DPDK configuration from command line to DB based

> "Wojciechowicz, RobertX" writes: > > Hi, > > > > one question to the "vhost-sock-dir" database entry. > > We received requirement to make sure that this entry will be available > > in the database > > even if there will be used the default vhost socket directory. > > In my patch "dpdk_set_config

[ovs-dev] Fwd: Query Regarding Packet aware pipeline processing (EXT-112)

Hi, Please help me to solve this query. Thanks Niti Rohilla -- Forwarded message -- From: niti Rohilla Date: Thu, Jan 14, 2016 at 7:29 PM Subject: Query Regarding Packet aware pipeline processing (EXT-112) To: dev@openvswitch.org Cc: partha.da...@tcs.com, deepankar.gu...@tcs.com

  1   2   >