On Wed, Feb 03, 2016 at 04:20:23PM -0600, RYAN D. MOATS wrote:
> Add incremental processing of lflows in ovn-controller by
> taking the simple approach of marking each lflow dirty when
> touched and have lflow_run only process dirty flows.
> 
> This needs unit test code before the RFC tag comes off.
> 
> Signed-off-by: RYAN D. MOATS <rmo...@us.ibm.com>

I was envisioning something that would incrementally determine on a
per-flow basis whether anything needed to be recalculated.  Starting
with a per-logical-datapath approach, as this patch does, is a nice
place to start because it is presumably easier, so I think it's a good
idea.

I don't understand how this particular patch is going to make a
difference, though, since ldp_run() appears to always dirty every
logical datapath.

I don't know why this deletes a comment that seems to be orthogonal to
the purpose of the patch.

Please use "bool", "true", and "false" for Boolean values, instead of
uint8_t, 1, and 0.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to