Sorry for not spotting this on review, I must have assumed that if the tests
pass it must be correct!
A reference to the commit this fixes would be nice.
Acked-by: Jarno Rajahalme <ja...@ovn.org>
> On Feb 5, 2016, at 3:30 PM, Ben Pfaff <b...@ovn.org> wrote:
>
> This definition just didn't work, and caused lots of tests to inadvertently
> be effectively skipped.
>
> Signed-off-by: Ben Pfaff <b...@ovn.org>
> ---
> tests/ofproto-macros.at | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
> index 354a384..c6c3321 100644
> --- a/tests/ofproto-macros.at
> +++ b/tests/ofproto-macros.at
> @@ -338,8 +338,8 @@ check_logs () {
> add_of_ports () {
> local args
> local br=$1; shift
> - for $pnum; do
> - AS_VAR_APPEND([args], [" -- $br p$pnum -- set Interface p$pnum
> type=dummy ofport_request=$pnum"])
> + for pnum; do
> + AS_VAR_APPEND([args], [" -- add-port $br p$pnum -- set Interface
> p$pnum type=dummy ofport_request=$pnum"])
> done
> ovs-vsctl $args
> }
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
