On Mon, Jan 25, 2016 at 03:15:23PM +0000, Mark Kavanagh wrote: > Current testing guidelines do not take account of two distinct > OVS builds: > a) 'standard' OVS > b) OVS with DPDK integration > > It is critical that all patches are tested against both builds; if not, > there is a strong possibility that code which adversely affects one > of the builds may be upstreamed, leading to issues such as broken build, > e.g. http://openvswitch.org/pipermail/dev/2016-January/064328.html > > Signed-off-by: Mark Kavanagh <mark.b.kavan...@intel.com> > --- > CONTRIBUTING.md | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > index 086b6e8..fe9400a 100644 > --- a/CONTRIBUTING.md > +++ b/CONTRIBUTING.md > @@ -35,6 +35,9 @@ Testing is also important: > - A patch that adds or deletes files should also be tested with > `make distcheck` before submission. > > + - The above tests should be performed with OVS compiled as 'normal', > + and also compiled with DPDK support.
It's something of a pain to do that when DPDK is so hardware dependent. I think the example that you show is actually a pretty good example of how quickly we catch problems. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
