[ovs-dev] Mail System Error - Returned Mail

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

hi Jesse, We are getting the Hyper-V solution to a state with the following goals: - Work “out of the box” ie. no need to make special settings such as disabling checksum offload, TSO, etc. - Reasonably stable Most of the patches we have checked in so far into 2.4 are geared towards these two go

Re: [ovs-dev] Integrate ovs+dpdk to openstack

Hi Przemek, Thanks your reply. I read the code and find some missing, for example: 1, in file common/config.py, a new parameter of_interface is added "cfg.StrOpt('of_interface', default='ovsdpdk-ofctl'", but it is not used in other place. 2, in file agent/openflow/ovsdpdk_ofctl/main.py, it impo

Re: [ovs-dev] communicatin failed with combination of ovs and linux native bonding

On 9/23/15 13:46, 渔舟 wrote: > On 9/23/15 10:35, Jesse Gross wrote: >> On Tue, Sep 22, 2015 at 7:28 PM, 渔舟 wrote: >>> On 9/23/15 09:35, Jesse Gross wrote: On Fri, Sep 18, 2015 at 7:30 PM, 渔舟 wrote: > Hi, all > Communication failed happened sometimes (about fifty-fifty) with > co

Re: [ovs-dev] communicatin failed with combination of ovs and linux native bonding

On 9/23/15 10:35, Jesse Gross wrote: > On Tue, Sep 22, 2015 at 7:28 PM, 渔舟 wrote: >> On 9/23/15 09:35, Jesse Gross wrote: >>> On Fri, Sep 18, 2015 at 7:30 PM, 渔舟 wrote: Hi, all Communication failed happened sometimes (about fifty-fifty) with combination of ovs and linux nati

[ovs-dev] Dev@openvswitch.org

Dear user dev@openvswitch.org, We have received reports that your account has been used to send a large amount of junk e-mail messages during this week. We suspect that your computer had been compromised and now runs a trojan proxy server. We recommend you to follow instruction in order to keep

Re: [ovs-dev] [PATCH 2/3] datapath: Add support for 4.2 kernel.

On Tue, Sep 22, 2015 at 7:21 PM, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 3:23 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/linux/net.h >> b/datapath/linux/compat/include/linux/net.h >> index 9c94745..2a6903d 100644 >> --- a/datapath/linux/compat/include/linux/net

Re: [ovs-dev] communicatin failed with combination of ovs and linux native bonding

On Tue, Sep 22, 2015 at 7:28 PM, 渔舟 wrote: > > On 9/23/15 09:35, Jesse Gross wrote: >> On Fri, Sep 18, 2015 at 7:30 PM, 渔舟 wrote: >>> Hi, all >>> Communication failed happened sometimes (about fifty-fifty) with >>> combination of ovs >>> and linux native bonding( 802.3ad mode), but if I use ovs

Re: [ovs-dev] communicatin failed with combination of ovs and linux native bonding

On 9/23/15 09:35, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 7:30 PM, 渔舟 wrote: >> Hi, all >> Communication failed happened sometimes (about fifty-fifty) with combination >> of ovs >> and linux native bonding( 802.3ad mode), but if I use ovs own >> bonding(lacp=active) instead, >> the failure

Re: [ovs-dev] [PATCH 2/3] datapath: Add support for 4.2 kernel.

On Fri, Sep 18, 2015 at 3:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/linux/net.h > b/datapath/linux/compat/include/linux/net.h > index 9c94745..2a6903d 100644 > --- a/datapath/linux/compat/include/linux/net.h > +++ b/datapath/linux/compat/include/linux/net.h [...]

[ovs-dev] dev@openvswitch.org

Dear user dev@openvswitch.org, We have received reports that your account was used to send a large amount of spam messages during this week. Probably, your computer was infected by a recent virus and now contains a trojaned proxy server. We recommend you to follow the instruction in order to ke

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

On Tue, Sep 22, 2015 at 9:18 AM, Nithin Raju wrote: > >> On Sep 22, 2015, at 9:07 AM, Ben Pfaff wrote: >> >> Thanks Sairam and Nithin, I applied this to master. > > Ben, > Can you pls. apply this to 2.4 as well? I'm somewhat concerned about the number and size of Windows patches that are targete

Re: [ovs-dev] [PATCH 1/8] configure: add configuration options for libcap-ng

Forgot to tag those as V4 of series that add --user option. On Tue, Sep 22, 2015 at 5:51 PM, Andy Zhou wrote: > Add configuration option for enabling or disabling linking with > libcap-ng. Since capabilities are a security feature, the libcapng > option is handled as follows: > > - no option

Re: [ovs-dev] How to debug openvswitch

On Fri, Sep 18, 2015 at 7:31 PM, liu_ch...@buaa.edu.cn wrote: > Well I've been thought about this too, but I used modprobe to install the > kernel module while right after make and make install and make > module_install, is that OK? > If I have to use insmode, shoulde I go to the openvswitch/datap

Re: [ovs-dev] communicatin failed with combination of ovs and linux native bonding

On Fri, Sep 18, 2015 at 7:30 PM, 渔舟 wrote: > Hi, all > Communication failed happened sometimes (about fifty-fifty) with combination > of ovs > and linux native bonding( 802.3ad mode), but if I use ovs own > bonding(lacp=active) instead, > the failure disappeared, any ideas? > > I read below post

[ovs-dev] Tax Payer's Bill of Rights - Oct 28

This email newsletter was sent to you in graphical HTML format. If you're seeing this version, your email program prefers plain text emails. You can read the original version online: http://ymlp172.com/zZCLfZ

[ovs-dev] [PATCH] datapath: Backport "openvswitch: Zero flows on allocation."

Upstream commit: openvswitch: Zero flows on allocation. When support for megaflows was introduced, OVS needed to start installing flows with a mask applied to them. Since masking is an expensive operation, OVS also had an optimization that would only take the parts of the flow

Re: [ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

On Fri, Sep 18, 2015 at 3:32 PM, Andy Zhou wrote: >> >> It seems reasonable at first glance, but I wonder whether you went >> through the history of this logic to make sure that we're not regressing >> on any of the improvements we've made over time? > > This algorithm did not change much. As far

[ovs-dev] [PATCH 5/8] ovs-dev.py: rename ROOT to VARDIR

VARDIR seems to be a better name. Signed-off-by: Andy Zhou --- utilities/ovs-dev.py | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py index 54989e6..82d946d 100755 --- a/utilities/ovs-dev.py +++ b/utilit

[ovs-dev] [PATCH 7/8] ovs-dev.py: add --user and -u option

ovs-dev.py "run" command now accepts the "--user" option for running all ovs daemons as "user". The argument can be specified in "user[:group]" format. '-u' is an short hand option that, if ovs-dev.py is launched as an non-root user, then current user and group will be used as if they are supplied

[ovs-dev] [PATCH 8/8] ovs-dev.py: add --monitor and -m option

Runs ovsdb-server and ovs-vswitch with --monitor option. This feature is useful for testing daemon monitoring together with --user option. Signed-off-by: Andy Zhou --- utilities/ovs-dev.py | 5 + 1 file changed, 5 insertions(+) diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py index

[ovs-dev] [PATCH 6/8] ovs-dev.py: run operational commands as root

Switch operational commands, run, kill, reset and modinst directly or indirectly read and writes files within the RUNDIR. Currently these commands run in the current user context, with some "sudo" commands thrown in to ensure daemons such as ovs-vswichd will be launched as root. This approach work

[ovs-dev] [PATCH 1/8] configure: add configuration options for libcap-ng

Add configuration option for enabling or disabling linking with libcap-ng. Since capabilities are a security feature, the libcapng option is handled as follows: - no option: use libcapng if it's present --disable-libcapng: do not use libcapng --enable-libcapng: do use libcapng and f

[ovs-dev] [PATCH 2/8] lib/daemon: support --user option for all OVS daemon

OVS daemons can now support --user option to run as a non-root user with less privileges. See the manpage patch for more descriptions. Signed-off-by: Andy Zhou v3->v4: calling daemon_become_new_user() from daemonize_start(), so the API works will for most daemons. In case a daemo

[ovs-dev] [PATCH 4/8] ovs-dev.py: allow current directory to be used as the working directory

Rather than forcing a single ovs source tree under ~/ovs, this change supports invoking the script from the root of any ovs source tree as the working source tree. If the script is invoked from a directory not recognized as OVS source tree, ~/ovs will then be used. Signed-off-by: Andy Zhou --- u

[ovs-dev] [PATCH 3/8] dpdk: reject --user option

dpdk datapath needs to run as root. Block the --user option for now. It is likely we will revisit this issue for possibly supporting --user option for dpdk datapath process as well. Signed-off-by: Andy Zhou --- lib/netdev-dpdk.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) di

[ovs-dev] [PATCH] datapath-windows: Update documentation

Commit ID:7845b70384d75bd7d753648cb547be5c6c75ddca changed the hardcoded names of 'internal' and 'external.1'. This patch updates the documentation to accomodate the patches. Signed-off-by: Alin Gabriel Serdean --- This patch is intended for branch-2.4 as well --- INSTALL.Windows.md | 71 ++

Re: [ovs-dev] [PATCHv2 4/6] Add connection tracking label support.

On 22 September 2015 at 17:34, Joe Stringer wrote: > On 18 September 2015 at 10:49, Ben Pfaff wrote: >> On Thu, Sep 17, 2015 at 04:04:26PM -0700, Joe Stringer wrote: >>> This patch adds a new 128-bit metadata field to the connection tracking >>> interface. When a label is specified as part of the

Re: [ovs-dev] [PATCHv2 4/6] Add connection tracking label support.

On 18 September 2015 at 10:49, Ben Pfaff wrote: > On Thu, Sep 17, 2015 at 04:04:26PM -0700, Joe Stringer wrote: >> This patch adds a new 128-bit metadata field to the connection tracking >> interface. When a label is specified as part of the ct action and the >> connection is committed, the value

[ovs-dev] [PATCH] datapath-windows: Support attribute OVS_KEY_ATTR_TCP_FLAGS

This patch adds OVS_KEY_ATTR_TCP_FLAGS to our flow mechanism. Also clean unecesarry parts of code. Signed-off-by: Alin Gabriel Serdean --- This patch is intended for branch-2.4 as well --- datapath-windows/ovsext/DpInternal.h | 9 +--- datapath-windows/ovsext/Flow.c | 40

Re: [ovs-dev] About the bandwith performance of vxlan tunnel

Thank you for your reply. I see the function skb_udp_tunnel_segment in file linux-3.14\net\ipv4\udp.c struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb, netdev_features_t features) (...skip...) /* segment inner packet. */ enc_features = skb->dev->hw_enc_features & netif_s

[ovs-dev] [PATCH] datapath-windows: Fix IP fragmentation

Currently in the case of IP fragmentation we send to the userspace that the flag for the last fragment is 3 when it actually should be a value between 0..2. This patch fixes the problem and also uses the values used in the common header of the datapath. Signed-off-by: Alin Gabriel Serdean --- Th

[ovs-dev] [PATCH] datapath-windows: add file to solution

This patch adds the file DpInternal.h to the ovsetx.sln. Signed-off-by: Alin Gabriel Serdean --- This patch is meant for branch-2.4 as well --- datapath-windows/ovsext/ovsext.vcxproj | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/ovsext.vcxproj b/datapath-windows/ov

[ovs-dev] [PATCH v2] datapath-windows: Compute checksums for VXLAN inner packets

Windows does not support VXLAN hardware offloading. Currently we do not compute IP/TCP/UDP checksums for the inner packet. This patch computes the checksums mentioned above in regards with the enabled settings. i.e. if IP checksum offloading is enabled for the inner packet we compute it. The same

[ovs-dev] Returned mail: see transcript for details

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [v3 09/10] ovs-dev.py: add --user and -u option

On Fri, Sep 18, 2015 at 1:09 PM, Ansis Atteka wrote: > On Mon, Sep 14, 2015 at 3:54 PM, Andy Zhou wrote: >> ovs-dev.py "run" command now accepts the "--user" option for runing >> all ovs daemons as "user". The argument can be speicfied in >> "user[:group]" format. >> >> '-u' is an short hand opti

Re: [ovs-dev] [v3 10/10] ovs-dev.py: add --monitor and -m option

On Fri, Sep 18, 2015 at 11:41 AM, Ansis Atteka wrote: > On Mon, Sep 14, 2015 at 3:54 PM, Andy Zhou wrote: >> Runs OVSDB server and OVS Vswichd with --monitor option. This features > How about: > s/OVSDB server/ovsbd-server > s/OVS Vswitchd/ovs-vswitchd > s/features/feature >> is useful for testin

Re: [ovs-dev] [PATCH 1/3] datapath: Fix compilation on kernel 3.18

On Fri, Sep 18, 2015 at 6:15 PM, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 3:23 PM, Pravin B Shelar wrote: >> Fixes following compilation error: >> In file included from ovs/datapath/linux/actions.c:30: >> ovs/datapath/linux/compat/include/linux/if_vlan.h:65: >> error: redefinition of ‘__vlan

[ovs-dev] [PATCH] dpdk: fix compiler warnings on 32bit build

Those changes prevent compiler warnings. Signed-off-by: Andy Zhou --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e4e3d2c..e7eb526 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1785,13 +1785,

Re: [ovs-dev] [PATCH 1/3] datapath: Add support for 4.1 kernel.

On Tue, Sep 22, 2015 at 1:11 PM, Thomas F Herbert wrote: > On 9/15/15 2:09 PM, Pravin B Shelar wrote: >> >> From: Joe Stringer >> >> Signed-off-by: Joe Stringer >> Signed-off-by: Pravin B Shelar >> --- >> .travis.yml |3 +- >> FAQ.md

Re: [ovs-dev] [PATCH] datapath-windows: Fix broken build on branch 2.4

Acked-by: Nithin Raju > On Sep 22, 2015, at 12:35 PM, Alin Serdean > wrote: > > Change variable name to fix compiling. > > Signed-off-by: Alin Gabriel Serdean > --- > This patch is intended only for the branch-2.4 > --- > datapath-windows/ovsext/Flow.c | 10 +- > 1 file changed, 5 ins

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

Hey Sorin, Can you update the Install.Windows.md to reflect these changes? Thanks, Sairam On 9/22/15, 8:31 AM, "Sorin Vinturis" wrote: >The internal/external vports will have the actual OS-based names, which >represent the NIC interface alias that is displayed by running >'Get-NetAdapter' Hyp

Re: [ovs-dev] [PATCH 1/3] datapath: Add support for 4.1 kernel.

On 9/15/15 2:09 PM, Pravin B Shelar wrote: From: Joe Stringer Signed-off-by: Joe Stringer Signed-off-by: Pravin B Shelar --- .travis.yml |3 +- FAQ.md|1 + acinclude.m4

[ovs-dev] [PATCH 5/7] Include headers where ovs_rundir is used

This patch includes dirs.h because ovs_rundir is used. Found while compiling with MSVC x64. Signed-off-by: Alin Gabriel Serdean --- lib/daemon-windows.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c index 04e1f1a..696ec1c 100644 --- a/lib/daemon

[ovs-dev] [PATCH 7/7] Add build system for compiling under MSVC x64

This patch adds the modifications needed to compile under x64 under Windows: - created a new macro for testing if we are compiling under x64. this will define the linker flag: "/MACHINE:X64" as per documentation (https://msdn.microsoft.com/en-us/library/9yb4317s.aspx). - added x64 pthread librarie

[ovs-dev] [PATCH 3/7] MSVC64 atomics

In case of MSVC 64 bit compiler use ovs-atomic-pthreads for now. Signed-off-by: Alin Gabriel Serdean --- lib/ovs-atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h index b38c9ef..f5459d6 100644 --- a/lib/ovs-atomic.h +++ b/lib/ovs-ato

[ovs-dev] [PATCH 6/7] Remove build assert

We will support x64 bit compiling making this build assert outdated. Signed-off-by: Alin Gabriel Serdean --- lib/netlink-socket.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c index 42eb232..6722a86 100644 --- a/lib/netlink-socket.c +++ b/lib/netl

[ovs-dev] [PATCH 2/7] MSVC 64 bit compile error

MSVC does not support zero-size array unless it is the last member of a defined structure. The error is hit only on MSVC 64 bit because the size of uint64_t is equal with sizeof(struct tun_table *). This patch ifdef's out the pad member of the structure tun_metadata in case we are on the MSVC 64

[ovs-dev] [PATCH 4/7] Include headers when using ovs_rundir

This patch adds an additional include file while compiling under MSVC. Found by compiling under MSVC x64 and hitting the following problem: http://stackoverflow.com/questions/23144151/64-bit-function-returns-32-bit-pointer Signed-off-by: Alin Gabriel Serdean --- lib/stream-tcp.c | 2 ++ 1 file

[ovs-dev] [PATCH 1/7] Add x64 bit configuration to windows installer

This patch defines the x64 in the configuration of the visual studio solution: ovs-windows-installer.sln Signed-off-by: Alin Gabriel Serdean --- windows/ovs-windows-installer.sln | 4 ++- .../ovs-windows-installer.wixproj | 41 +- 2 files ch

[ovs-dev] [PATCH 0/7] Add 64 bit support for MSVC

This patch series adds the build system, documentation and various fixes needed to compile under x64 MSVC. The patch series are intended for branch-2.4 minus the following patch: MSVC 64 bit compile error. Alin Gabriel Serdean (7): Add x64 bit configuration to windows installer MSVC 64 bit

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

> This looks useful, but the patch was corrupted in posting and I can't apply > it. If > you can, please use "git send-email" to send the email. > Otherwise, please use a github "pull request", which is certain to work out > properly. "pull request" done for this change (includes test cases). P

[ovs-dev] [PATCH] datapath-windows: Fix broken build on branch 2.4

Change variable name to fix compiling. Signed-off-by: Alin Gabriel Serdean --- This patch is intended only for the branch-2.4 --- datapath-windows/ovsext/Flow.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

It should. I forgot to mention. Thanks Ben! -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Tuesday, 22 September, 2015 19:01 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vpo

Re: [ovs-dev] [PATCHv2 2/6] Add connection tracking mark support.

On 18 September 2015 at 09:58, Ben Pfaff wrote: > On Thu, Sep 17, 2015 at 04:04:24PM -0700, Joe Stringer wrote: >> This patch adds a new 32-bit metadata field to the connection tracking >> interface. When a mark is specified as part of the ct action and the >> connection is committed, the value is

Re: [ovs-dev] Testing OpenStack security groups with OVN ACLs

On 09/21/2015 08:26 PM, Joe Stringer wrote: > > On 21 Sep 2015 2:36 pm, "Russell Bryant" > wrote: >> >> On 09/21/2015 02:50 PM, Joe Stringer wrote: >> > On 18 September 2015 at 08:27, Russell Bryant > wrote: >> >> I mentioned in yesterday's O

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

On Tue, Sep 22, 2015 at 04:18:24PM +, Nithin Raju wrote: > > > On Sep 22, 2015, at 9:00 AM, Ben Pfaff wrote: > > > > On Tue, Sep 22, 2015 at 09:00:29AM -0700, Ben Pfaff wrote: > >> On Tue, Sep 22, 2015 at 03:31:08PM +, Sorin Vinturis wrote: > >>> The internal/external vports will have th

Re: [ovs-dev] [PATCH 4/4] ovn-sbctl: Improve usage message.

Thanks for the acks. These patches were applied to master last week, on the strength of Alex's acks. On Fri, Sep 18, 2015 at 03:33:25PM -0700, Andy Zhou wrote: > Acked-by: Andy Zhou > > On Fri, Sep 11, 2015 at 8:46 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > ovn/utilities/o

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

> On Sep 22, 2015, at 9:07 AM, Ben Pfaff wrote: > > Thanks Sairam and Nithin, I applied this to master. Ben, Can you pls. apply this to 2.4 as well? thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

> On Sep 22, 2015, at 9:00 AM, Ben Pfaff wrote: > > On Tue, Sep 22, 2015 at 09:00:29AM -0700, Ben Pfaff wrote: >> On Tue, Sep 22, 2015 at 03:31:08PM +, Sorin Vinturis wrote: >>> The internal/external vports will have the actual OS-based names, which >>> represent the NIC interface alias that

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

Thanks Sairam and Nithin, I applied this to master. On Mon, Sep 21, 2015 at 10:06:33PM +, Sairam Venugopal wrote: > Hey Nithin, > > Thanks for reviewing the patch. > > Regards, > Sairam > > On 9/21/15, 3:02 PM, "Nithin Raju" wrote: > > >> On Sep 21, 2015, at 1:32 PM, Sairam Venugopal > >

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

On Tue, Sep 22, 2015 at 09:00:29AM -0700, Ben Pfaff wrote: > On Tue, Sep 22, 2015 at 03:31:08PM +, Sorin Vinturis wrote: > > The internal/external vports will have the actual OS-based names, which > > represent the NIC interface alias that is displayed by running > > 'Get-NetAdapter' Hyper-V PS

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

On Tue, Sep 22, 2015 at 04:18:03PM +, Nithin Raju wrote: > > > On Sep 22, 2015, at 9:07 AM, Ben Pfaff wrote: > > > > Thanks Sairam and Nithin, I applied this to master. > > Ben, > Can you pls. apply this to 2.4 as well? Done! Thanks, Ben. ___ d

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

Thanks, I understand now. I applied this to master, changing Nikita's Signed-off-by: to a Reported-by:. On Tue, Sep 22, 2015 at 07:30:47PM +0300, Ilya Maximets wrote: > Author is me, Nikita found and analyzed the problem. > You may change Signed-off-by to something more proper. > > Best regards,

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

Author is me, Nikita found and analyzed the problem. You may change Signed-off-by to something more proper. Best regards, Ilya Maximets. On 22.09.2015 18:49, Ben Pfaff wrote: > On Tue, Sep 22, 2015 at 12:27:15PM +0300, Ilya Maximets wrote: >> Zero is a valid value for a file descriptor. >> >> Sig

Re: [ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

On Tue, Sep 22, 2015 at 03:31:08PM +, Sorin Vinturis wrote: > The internal/external vports will have the actual OS-based names, which > represent the NIC interface alias that is displayed by running > 'Get-NetAdapter' Hyper-V PS command. > > Signed-off-by: Sorin Vinturis > Acked-by: Nithin Ra

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

On Tue, Sep 22, 2015 at 12:27:15PM +0300, Ilya Maximets wrote: > Zero is a valid value for a file descriptor. > > Signed-off-by: Ilya Maximets > Signed-off-by: Nikita Kalyazin Thanks for the patch! The sign-off chain is unclear. Who is the author? What did the other person do? Thanks, Ben.

[ovs-dev] [PATCH v4] datapath-windows: Removed hardcoded names for internal/external vports

The internal/external vports will have the actual OS-based names, which represent the NIC interface alias that is displayed by running 'Get-NetAdapter' Hyper-V PS command. Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- datapath-windows/ovsext/Vport.c | 107 ++---

Re: [ovs-dev] [PATCH v3] datapath-windows: Removed hardcoded names for internal/external vports

Sound good. Thanks for the explanation. If you don’t mind, can you pls. add a comment to this effect? The code in Vport.c is kind of complex, and comments would really help. Acked-by: Nithin Raju > On Sep 21, 2015, at 10:40 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Please see my answe

Re: [ovs-dev] [PATCH 1/2] rhel: Make python 2.7 a requirement of build.

On Mon, Sep 21, 2015 at 5:24 PM, Flavio Leitner wrote: > On Wed, Sep 16, 2015 at 09:30:30AM -0700, Gurucharan Shetty wrote: >> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in >> index dad3e04..642986b 100644 >> --- a/rhel/openvswitch.spec.in >> +++ b/rhel/openvswitch.spec.in >> @@

Re: [ovs-dev] When the attribute OVS_KEY_ATTR_ENCAP will be used?

On 9/17/15 3:50 AM, openvswitcher wrote: Hi, all Could you tell me when the attribute OVS_KEY_ATTR_ENCAP will be used? That is the encapsulation attribute used for the netlink serialization encoding. If the packet is 802.1q, then OVS_KEY_ATTR_VLAN will be used to store the vlan tci, so wh

Re: [ovs-dev] [PATCH] doc: document feature deprecation and removal process

On Sat, Sep 19, 2015 at 01:22:39PM -0700, Ansis Atteka wrote: > It seems that we haven't defined clear process on how features should > be removed from OVS. This patch attempts to document this process. > > Singed-off-by: Ansis Atteka > --- > CONTRIBUTING.md | 31 +++

[ovs-dev] Where is the skb->dev set in skb_udp_tunnel_segment function?

Hi, all I see the function skb_udp_tunnel_segment in file linux-3.14\net\ipv4\udp.c struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb, netdev_features_t features) (...skip...) /* segment inner packet. */ enc_features = skb->dev->hw_enc_features & netif_skb_features(skb);

Re: [ovs-dev] [PATCH 00/38] Fixes related to incorrect usage of unsigned types

On 09/22/2015 11:13 AM, Andrzej Hajda wrote: On 09/21/2015 03:42 PM, David Howells wrote: Andrzej Hajda wrote: Semantic patch finds comparisons of types: unsigned < 0 unsigned >= 0 The former is always false, the latter is always true. Such comparisons are useless, so theoretically

[ovs-dev] Message could not be delivered

The original message was received at Tue, 22 Sep 2015 16:37:57 +0700 from openvswitch.org [7.197.194.40] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.or

[ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

Zero is a valid value for a file descriptor. Signed-off-by: Ilya Maximets Signed-off-by: Nikita Kalyazin --- lib/poll-loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/poll-loop.c b/lib/poll-loop.c index 3c4b55c..36eb5ac 100644 --- a/lib/poll-loop.c +++ b/lib/po

Re: [ovs-dev] [PATCH 00/38] Fixes related to incorrect usage of unsigned types

On 09/21/2015 03:42 PM, David Howells wrote: > Andrzej Hajda wrote: > >> Semantic patch finds comparisons of types: >> unsigned < 0 >> unsigned >= 0 >> The former is always false, the latter is always true. >> Such comparisons are useless, so theoretically they could be >> safely removed,

[ovs-dev] ethernet Packet Header & payload related header file information

Hi,Can anyone help me. I want to know, which header / c file is responsible for the processing of Ethernet Packet header and the payload in Openvswitch. I want to log and check some information during VM to VM communication. Please response. Thanking you all RegardsKallol     __