Re: [ovs-dev] [PATCH 21/22] ofctrl: Negotiate OVN Geneve option.

2015-07-31 Thread Alex Wang
On Fri, Jul 31, 2015 at 10:15 PM, Ben Pfaff wrote: > On Fri, Jul 31, 2015 at 10:04:35PM -0700, Alex Wang wrote: > > Is there any documentation for the ovs side geneve negotiation? > > No. What kind of documentation would help? > Maybe, For ovs side, my understanding is that Geneve allows us to

Re: [ovs-dev] [PATCH 21/22] ofctrl: Negotiate OVN Geneve option.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 10:04:35PM -0700, Alex Wang wrote: > Is there any documentation for the ovs side geneve negotiation? No. What kind of documentation would help? > > +if (state != S_UPDATE_FLOWS > > +|| rconn_packet_counter_n_packets(tx_counter)) { > > +ovn_flow_table_c

Re: [ovs-dev] [PATCH 21/22] ofctrl: Negotiate OVN Geneve option.

2015-07-31 Thread Alex Wang
Is there any documentation for the ovs side geneve negotiation? Also one question below: Thanks, Alex Wang, On Sun, Jul 19, 2015 at 3:45 PM, Ben Pfaff wrote: > This won't really get used until the next commit. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/ofctrl.c | 470 > +

[ovs-dev] classifier versioning and rule_dpif_try_ref()

2015-07-31 Thread Ben Pfaff
Now that the classifier is versioned, is it still possible for rule_dpif_try_ref() to return false? Specifically, can we change the loop in rule_dpif_lookup_in_table() to do an ordinary ref instead of a try_ref? My motive is that, if we could change it, then we could drop the 'take_ref' parameter

Re: [ovs-dev] [PATCH v5 5/6] ovn: Add "localnet" logical port type.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 09:44:17PM -0700, Ben Pfaff wrote: > Sorry, I forgot that there was a detailed example earlier. I didn't > mean to make you go to a lot of work to repeat it. You know, it might be worthwhile to put either this example or the former one into the commit log. That way I won'

Re: [ovs-dev] [PATCH v5 5/6] ovn: Add "localnet" logical port type.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 10:19:32PM -0400, Russell Bryant wrote: > On 07/31/2015 07:26 PM, Ben Pfaff wrote: > > I'm not sure I correctly understand the model for using these. Maybe > > you can flesh out an example to help me. Suppose I have a pair of > > hypervisors A and B, and each HV has two VM

Re: [ovs-dev] MPLS support in OVS 2.3.2

2015-07-31 Thread Ben Pfaff
On Sat, Aug 01, 2015 at 09:42:06AM +0530, tech_kals Kals wrote: > Could you please let me know whether the said MPLS actions are supported in > OVS or not? To know what Open vSwitch supports, please read the documentation. ___ dev mailing list dev@openvs

Re: [ovs-dev] MPLS support in OVS 2.3.2

2015-07-31 Thread tech_kals Kals
Thanks Ben for your reply. Could you please let me know whether the said MPLS actions are supported in OVS or not? Thanks in adv, tech kals. On Fri, Jul 31, 2015 at 8:55 PM, Ben Pfaff wrote: > On Fri, Jul 31, 2015 at 06:30:15PM +0530, tech_kals Kals wrote: > > Also, is there any plan to suppo

Re: [ovs-dev] [PATCH v5 6/6] ovn: Automatically create br-int in ovn-controller.

2015-07-31 Thread Russell Bryant
On 07/31/2015 07:27 PM, Ben Pfaff wrote: > On Fri, Jul 31, 2015 at 01:14:45PM -0400, Russell Bryant wrote: >> ovn-controller previously required the integration bridge to be >> created before running ovn-controller. This patch makes >> ovn-controller automatically create it if it doesn't already e

Re: [ovs-dev] [PATCH v5 5/6] ovn: Add "localnet" logical port type.

2015-07-31 Thread Russell Bryant
On 07/31/2015 07:26 PM, Ben Pfaff wrote: > On Fri, Jul 31, 2015 at 01:14:44PM -0400, Russell Bryant wrote: >> Introduce a new logical port type called "localnet". A logical port >> with this type also has an option called "network_name". A "localnet" >> logical port represents a connection to a l

Re: [ovs-dev] [PATCH] datapath: Fix STT protocol field for sampling packet.

2015-07-31 Thread Pravin Shelar
On Fri, Jul 31, 2015 at 10:21 AM, Jesse Gross wrote: > On Thu, Jul 30, 2015 at 8:51 PM, Pravin B Shelar wrote: >> Fixes typo in STT sampling code. >> >> Signed-off-by: Pravin B Shelar >> --- >> datapath/vport-stt.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Acked-by: Jes

Re: [ovs-dev] [PATCH v5 2/6] ovn: Add bridge mappings to ovn-controller.

2015-07-31 Thread Russell Bryant
On 07/31/2015 07:07 PM, Ben Pfaff wrote: > On Fri, Jul 31, 2015 at 01:14:41PM -0400, Russell Bryant wrote: >> Add a new OVN configuration entry in the Open_vSwitch database called >> "ovn-bridge-mappings". This allows the configuration of mappings >> between a physical network name and an OVS brid

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-31 Thread Nithin Raju
hi Sorin, In OvsInitExternalNBLContext(), there’s the following check: 563 if (poolHandle == context->ovsPool.ndisHandle || 564 nbl->SourceHandle == context->ovsPool.ndisHandle) { 565 return (POVS_BUFFER_CONTEXT)NET_BUFFER_LIST_CONTEXT_

Re: [ovs-dev] [PATCH v5 6/6] ovn: Automatically create br-int in ovn-controller.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:45PM -0400, Russell Bryant wrote: > ovn-controller previously required the integration bridge to be > created before running ovn-controller. This patch makes > ovn-controller automatically create it if it doesn't already exist. > > Signed-off-by: Russell Bryant See

Re: [ovs-dev] [PATCH v5 5/6] ovn: Add "localnet" logical port type.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:44PM -0400, Russell Bryant wrote: > Introduce a new logical port type called "localnet". A logical port > with this type also has an option called "network_name". A "localnet" > logical port represents a connection to a locally accessible network. > ovn-controller wi

Re: [ovs-dev] [PATCH v5 4/6] ovn: Get/set lport type and options in ovn-nbctl.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:43PM -0400, Russell Bryant wrote: > A recent patch added "type" and "options" columns to the Logical_Port > table in OVN_Northbound. This patch allows you to get and set those > columns with ovn-nbctl. > > ovn-nbctl should eventually get converted to use the common d

Re: [ovs-dev] [PATCH v5 3/6] ovn: Add type and options to logical port.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:42PM -0400, Russell Bryant wrote: > We have started discussing the use of the logical port abstraction in > OVN to represent special types of connections into an OVN logical > switch. This patch proposes some schema updates to reflect these > special types of logical

Re: [ovs-dev] [PATCH v5 2/6] ovn: Add bridge mappings to ovn-controller.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:41PM -0400, Russell Bryant wrote: > Add a new OVN configuration entry in the Open_vSwitch database called > "ovn-bridge-mappings". This allows the configuration of mappings > between a physical network name and an OVS bridge that provides > connectivity to that networ

Re: [ovs-dev] [PATCH v2 17/21] ovn: Rename Pipeline table to Rule table.

2015-07-31 Thread Alex Wang
Just to mention that I also think Flow is a better name for this table. On Fri, Jul 31, 2015 at 11:19 AM, Ben Pfaff wrote: > I have a lot of misgivings about all of the possible names. > > Thanks. > > On Thu, Jul 30, 2015 at 04:33:23PM -0700, Justin Pettit wrote: > > I think Pipeline is more des

[ovs-dev] [RFC] dpdk: support multiple queues in vhost

2015-07-31 Thread Flavio Leitner
This RFC is based on the vhost multiple queues work on dpdk-dev: http://dpdk.org/ml/archives/dev/2015-June/019345.html Signed-off-by: Flavio Leitner --- lib/netdev-dpdk.c | 61 --- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a

Re: [ovs-dev] [PATCH v5 1/6] lib: Add smap_equal().

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:14:40PM -0400, Russell Bryant wrote: > Add a method to determine of two smaps are equal (have the exact same > set of key-value pairs). > > Suggested-by: Ben Pfaff > Signed-off-by: Russell Bryant Applied to master, thanks! _

Re: [ovs-dev] [PATCH 26/26] ofproto-dpif-xlate: Fix mirroring interaction with recirculation.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 03:10:47PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > Thanks for the clean-up, will be easier to maintain this code going forward. Thanks for all the reviews! I applied this series to master. > Appreciate the C lessons as well :-) :-) ___

Re: [ovs-dev] [PATCH v2 20/21] ofctrl: Negotiate OVN Geneve option.

2015-07-31 Thread Justin Pettit
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote: > > > +static void > +recv_S_GENEVE_TABLE_MOD_SENT(const struct ofp_header *oh, enum ofptype type) > +{ > +if (oh->xid != xid && oh->xid != xid2) { > +ofctrl_recv(oh, type); > +} else if (oh->xid == xid2 && type == OFPTYPE_BARRIER_

Re: [ovs-dev] [PATCH 26/26] ofproto-dpif-xlate: Fix mirroring interaction with recirculation.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme Thanks for the clean-up, will be easier to maintain this code going forward. Appreciate the C lessons as well :-) Jarno > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Before this commit, mirroring state was not preserved across recirculation, > which could r

Re: [ovs-dev] [PATCH 25/26] ofproto-dpif-xlate: Add recirculation information to "ofproto/trace".

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This makes it possible to understand what happens recirculation-wise in > translation. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 29 + > 1 file changed, 25 inser

Re: [ovs-dev] [PATCH 24/26] ofp-actions: Add action "debug_recirc" for testing recirculation.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > It isn't otherwise useful and in fact hurts performance so it's disabled > without --enable-dummy. > > An upcoming commit will make use of this. > > Signed-off-by: Ben Pfaff > --- > lib/dummy.c |

Re: [ovs-dev] [PATCH 23/26] ofproto-dpif-rid: Factor recirculation state out as new structure.

2015-07-31 Thread Jarno Rajahalme
It’s almost like having named function arguments in C! Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This greatly reduces the number of arguments to many of the functions > involved in recirculation, which to my eye makes the code clearer. It > will also make

Re: [ovs-dev] [PATCH 22/26] ofproto-dpif-xlate: Rewrite mirroring to better fit flow translation.

2015-07-31 Thread Jarno Rajahalme
Always learn something new when reviewing code ;-) Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Until now, mirroring has been implemented by accumulating, across the whole > translation process, a set of mirrors that should receive a mirrored > packet. After

Re: [ovs-dev] [PATCH 21/26] ofproto-dpif-xlate: Drop packets received from mirror output ports earlier.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Packets should never be received on mirror output ports. We drop them > when we do receive them. But by putting them through the processing that > we did until now, we made it possible for MAC learning, etc. to hap

Re: [ovs-dev] [PATCH 20/26] ofproto-dpif-xlate: Move initialization of 'in_port' closer to first use.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This seems to be a little clearer to me. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/ofproto/ofproto-dpif-xl

Re: [ovs-dev] [PATCH 15/26] ofproto-dpif-xlate: Clean up sFlow and IPFIX sampling code.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 02:25:22PM -0700, Jarno Rajahalme wrote: > I’m starting to dig the designated initializers, too :-) My favorite use of them is the following example C99 standard. I haven't actually used this style myself yet, though: EXAMPLE 3 Initializers with designations can be co

Re: [ovs-dev] [PATCH 19/26] ofproto-dpif-xlate: Move 'nf_output_iface' from xlate_out to xlate_ctx.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This member is used internally during translation but none of the callers > used as an output of translation. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 35 ++---

Re: [ovs-dev] [PATCH 12/26] ofproto-dpif-xlate: Simplify 'sample_actions_len' calculation.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 02:03:24PM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > > > It's always the size of 'odp_actions' following adding the sample actions. > > > > Is this a bug fix? No, there should be no visible change. I'll note that in the com

Re: [ovs-dev] [PATCH 18/26] ofproto-dpif-xlate: Remove multiple members from struct xlate_out.

2015-07-31 Thread Jarno Rajahalme
Must have been historical reasons :-) Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Nothing used them. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 7 --- > ofproto/ofproto-dpif-xlate.h | 3 --- > 2 files changed, 10 deletions(-) > >

Re: [ovs-dev] [PATCH 17/26] ofproto-dpif-xlate: Move 'mirrors' from xlate_out to xlate_ctx.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Nothing outside of ofproto-dpif-xlate.c referenced this member. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 21 +++-- > ofproto/ofproto-dpif-xlate.h | 1 - > 2 files changed,

Re: [ovs-dev] [PATCH 16/26] ofproto-dpif-xlate: Set up 'base_flow' when we initialize 'ctx'.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > The initialization of 'base_flow' was previously split into a few pieces, > and I think it's easier to understand if it's all in one place. > > This also moves and rewrites the comment describing 'base_flow'. I thi

Re: [ovs-dev] [PATCH 15/26] ofproto-dpif-xlate: Clean up sFlow and IPFIX sampling code.

2015-07-31 Thread Jarno Rajahalme
I’m starting to dig the designated initializers, too :-) Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This code was a twisty maze of tiny functions, but what it actually needed > to do was simple. This makes it look that simple. > > Among more stylistic chan

Re: [ovs-dev] [PATCH 14/26] ofproto-dpif-xlate: Factor wildcard processing out of xlate_actions().

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > I think that this makes xlate_actions() easier to read. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 102 --- > 1 file changed, 58 insertions(+), 44 del

Re: [ovs-dev] [PATCH 13/26] tunnel: Break tnl_xlate_init() into two separate functions.

2015-07-31 Thread Jarno Rajahalme
That was surprisingly difficult to read :-) Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > It seems to me that tnl_xlate_init() has two almost-separate tasks. First, > it marks most of the 'wc' bits for tunnels. Second, it checks and updates > ECN bits. This

Re: [ovs-dev] [PATCH 12/26] ofproto-dpif-xlate: Simplify 'sample_actions_len' calculation.

2015-07-31 Thread Jarno Rajahalme
> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > It's always the size of 'odp_actions' following adding the sample actions. > Is this a bug fix? Jarno Acked-by: Jarno Rajahalme > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 6 +- > 1 file changed, 1 insertion(+

Re: [ovs-dev] [PATCH 11/26] ofproto-dpif-xlate: Move declaration of 'orig_flow' near its first use.

2015-07-31 Thread Jarno Rajahalme
C99 liberties… Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > in

Re: [ovs-dev] [PATCH 10/26] ofproto-dpif-xlate: Eliminate 'is_icmp' from xlate_actions().

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This is only used in one place and action processing can't change the > result, so only calculate it where it's needed. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 4 +--- > 1 file changed, 1

Re: [ovs-dev] [PATCH 09/26] ofproto-dpif-xlate: Simplify invocation of process_special().

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This takes advantage of common properties of the invocation of this > function in both callers (both supply the same 'flow' and 'packet', > although they write it differently) and avoids the need for a local > variab

Re: [ovs-dev] [PATCH 08/26] ofproto-dpif-xlate: Eliminate 'rule' local variable.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This variable was only used as a temporary within a small scope, so it > worked just as well to just use ctx.rule there instead. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 18 +++---

Re: [ovs-dev] [PATCH 07/26] ofproto-dpif-xlate: Calculate 'ofpacts' in more restricted scope.

2015-07-31 Thread Ben Pfaff
Thanks. I applied the series up to this point to master. On Fri, Jul 31, 2015 at 01:46:58PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > > > This moves the calculation of 'ofpacts' closer to its actual use, which > > in my

Re: [ovs-dev] [PATCH 07/26] ofproto-dpif-xlate: Calculate 'ofpacts' in more restricted scope.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > This moves the calculation of 'ofpacts' closer to its actual use, which > in my opinion makes the code easier to read. > > This commit also expands the circumstances in which OVS omits sending > NetFlow records from

Re: [ovs-dev] [PATCH 06/26] ofproto-dpif-xlate: Make xlate_actions() caller supply action buffer.

2015-07-31 Thread Ben Pfaff
Thanks, I've fixed that now. On Fri, Jul 31, 2015 at 01:41:42PM -0700, Jarno Rajahalme wrote: > There was a missing dot in the commit message > > > On Jul 31, 2015, at 1:40 PM, Jarno Rajahalme wrote: > > > > Acked-by: Jarno Rajahalme > > > >> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: >

Re: [ovs-dev] [PATCH 05/26] ofproto-dpif-xlate: Make xlate_actions() caller supply flow_wildcards.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:28:43PM -0700, Jarno Rajahalme wrote: > > > On Jul 31, 2015, at 1:06 PM, Ben Pfaff wrote: > > > > On Fri, Jul 31, 2015 at 11:39:07AM -0700, Jarno Rajahalme wrote: > >>> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > >>> > >>> Until now, struct xlate_out has embedde

Re: [ovs-dev] [PATCH 06/26] ofproto-dpif-xlate: Make xlate_actions() caller supply action buffer.

2015-07-31 Thread Jarno Rajahalme
There was a missing dot in the commit message > On Jul 31, 2015, at 1:40 PM, Jarno Rajahalme wrote: > > Acked-by: Jarno Rajahalme > >> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: >> >> Until now, struct xlate_out has embedded an ofpbuf for actions and a large >> stub for it, which xlate_a

Re: [ovs-dev] [PATCH 06/26] ofproto-dpif-xlate: Make xlate_actions() caller supply action buffer.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Until now, struct xlate_out has embedded an ofpbuf for actions and a large > stub for it, which xlate_actions() filled in during the flow translation > process This commit removes the embedded ofpbuf and stub, instea

Re: [ovs-dev] [PATCH 02/26] list: New macro OVS_LIST_POISON for initializing a poisoned list.

2015-07-31 Thread Jarno Rajahalme
Thanks! Jarno > On Jul 31, 2015, at 1:14 PM, Ben Pfaff wrote: > > On Fri, Jul 31, 2015 at 01:03:24PM -0700, Jarno Rajahalme wrote: >>> On Jul 31, 2015, at 11:37 AM, Ben Pfaff wrote: >>> >>> On Fri, Jul 31, 2015 at 11:18:22AM -0700, Jarno Rajahalme wrote: One question below, >>> >>> On

Re: [ovs-dev] [PATCH 05/26] ofproto-dpif-xlate: Make xlate_actions() caller supply flow_wildcards.

2015-07-31 Thread Jarno Rajahalme
> On Jul 31, 2015, at 1:06 PM, Ben Pfaff wrote: > > On Fri, Jul 31, 2015 at 11:39:07AM -0700, Jarno Rajahalme wrote: >>> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: >>> >>> Until now, struct xlate_out has embedded a struct flow_wildcards, which >>> xlate_actions() filled in during the flow

Re: [ovs-dev] [PATCH 02/26] list: New macro OVS_LIST_POISON for initializing a poisoned list.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 01:03:24PM -0700, Jarno Rajahalme wrote: > > On Jul 31, 2015, at 11:37 AM, Ben Pfaff wrote: > > > > On Fri, Jul 31, 2015 at 11:18:22AM -0700, Jarno Rajahalme wrote: > >> One question below, > > > > One answer below ;-) > > > >> Acked-by: Jarno Rajahalme > > > > Thanks.

Re: [ovs-dev] [PATCH 05/26] ofproto-dpif-xlate: Make xlate_actions() caller supply flow_wildcards.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 11:39:07AM -0700, Jarno Rajahalme wrote: > > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > > > Until now, struct xlate_out has embedded a struct flow_wildcards, which > > xlate_actions() filled in during the flow translation process (unless this > > was disabled with

Re: [ovs-dev] [PATCH 02/26] list: New macro OVS_LIST_POISON for initializing a poisoned list.

2015-07-31 Thread Jarno Rajahalme
> On Jul 31, 2015, at 11:37 AM, Ben Pfaff wrote: > > On Fri, Jul 31, 2015 at 11:18:22AM -0700, Jarno Rajahalme wrote: >> One question below, > > One answer below ;-) > >> Acked-by: Jarno Rajahalme > > Thanks. > >>> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: >>> >>> To be used in an up

Re: [ovs-dev] [PATCH 05/26] ofproto-dpif-xlate: Make xlate_actions() caller supply flow_wildcards.

2015-07-31 Thread Jarno Rajahalme
> On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > Until now, struct xlate_out has embedded a struct flow_wildcards, which > xlate_actions() filled in during the flow translation process (unless this > was disabled with xin->skip_wildcards to in theory save time). This commit I have recently

Re: [ovs-dev] [PATCH 02/26] list: New macro OVS_LIST_POISON for initializing a poisoned list.

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 11:18:22AM -0700, Jarno Rajahalme wrote: > One question below, One answer below ;-) > Acked-by: Jarno Rajahalme Thanks. > > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > > > To be used in an upcoming commit. > > > > Signed-off-by: Ben Pfaff > > --- > > lib/list

Re: [ovs-dev] [PATCH v2 18/21] actions: Allow caller to specify output table.

2015-07-31 Thread Ben Pfaff
On Thu, Jul 30, 2015 at 04:55:13PM -0700, Justin Pettit wrote: > > > On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote: > > > > When an upcoming commit divides the pipeline up into ingress and egress > > pipeline, it will become necessary to resubmit to different tables from > > each of those pipelin

Re: [ovs-dev] [PATCH 04/26] ofproto-dpif-xlate: Initialize 'ctx' all in one place.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > As I see it, this has two benefits. First, by using an initializer > rather than a series of assignment statements, the reader can be > assured that everything in the structure is actually initialized. > Second, pre

Re: [ovs-dev] [PATCH 03/26] ofpbuf: New macro OFPBUF_STUB_INITIALIZER.

2015-07-31 Thread Jarno Rajahalme
Neat! Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > To be used in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > lib/ofpbuf.h | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h

Re: [ovs-dev] [PATCH v2 17/21] ovn: Rename Pipeline table to Rule table.

2015-07-31 Thread Ben Pfaff
I have a lot of misgivings about all of the possible names. Thanks. On Thu, Jul 30, 2015 at 04:33:23PM -0700, Justin Pettit wrote: > I think Pipeline is more descriptive about what it actually is. I also find > it confusing since we use the term "rule" in the classifier. I think Flow > (or Lo

Re: [ovs-dev] [PATCH 02/26] list: New macro OVS_LIST_POISON for initializing a poisoned list.

2015-07-31 Thread Jarno Rajahalme
One question below, Jarno Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > To be used in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > lib/list.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lib/list.h b/lib/list.h

Re: [ovs-dev] [PATCH 01/26] ofproto-dpif-xlate: Initialize '*xout' all together at beginning.

2015-07-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 29, 2015, at 11:42 PM, Ben Pfaff wrote: > > To my mind, this is a good way to ensure that '*xout' gets initialized > properly in every execution. By using an initializer rather than a > series of assignment statements, we can be assured that every member > ge

Re: [ovs-dev] [PATCH 3/3] tests: Add basic vxlan tunnel sanity test.

2015-07-31 Thread Daniele Di Proietto
On 31/07/2015 01:30, "Joe Stringer" wrote: >On 30 July 2015 at 11:37, Daniele Di Proietto >wrote: >> I get a warning in the OVS log that causes this test to fail. >> >> It appears that when br0 is removed (in OVS_KMOD_VSWITCHD_STOP) >> OVS gets a rtnetlink message (because br0 had an address i

[ovs-dev] [PATCH 2/2] bridge: reconfigure when system interfaces change

2015-07-31 Thread Thadeu Lima de Souza Cascardo
Whenever system interfaces are removed, added or change state, reconfigure bridge. This allows late interfaces to be added to the datapath when they are added to the system after ovs-vswitchd is started. Signed-off-by: Thadeu Lima de Souza Cascardo --- lib/automake.mk| 7 - lib/if-n

[ovs-dev] [PATCH 1/2] rtbsd: support RTM_IFANNOUNCE messages

2015-07-31 Thread Thadeu Lima de Souza Cascardo
When devices are created, they are announced using RTM_IFANNOUNCE messages using PF_ROUTE. Signed-off-by: Thadeu Lima de Souza Cascardo --- lib/rtbsd.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/rtbsd.c b/lib/rtbsd.c index 8fc88e4..33fb9fd 1

Re: [ovs-dev] [PATCH 6/6] datapath: Add support for 4.1 kernel.

2015-07-31 Thread Jesse Gross
On Thu, Jul 30, 2015 at 4:30 PM, Joe Stringer wrote: > On 30 July 2015 at 12:24, Jesse Gross wrote: >> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer >> wrote: >>> diff --git a/.travis.yml b/.travis.yml >>> index 70cc14b..f3236db 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -12,6 +

Re: [ovs-dev] [PATCH] datapath: Fix STT protocol field for sampling packet.

2015-07-31 Thread Jesse Gross
On Thu, Jul 30, 2015 at 8:51 PM, Pravin B Shelar wrote: > Fixes typo in STT sampling code. > > Signed-off-by: Pravin B Shelar > --- > datapath/vport-stt.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Jesse Gross ___ dev mai

[ovs-dev] [PATCH v5 6/6] ovn: Automatically create br-int in ovn-controller.

2015-07-31 Thread Russell Bryant
ovn-controller previously required the integration bridge to be created before running ovn-controller. This patch makes ovn-controller automatically create it if it doesn't already exist. Signed-off-by: Russell Bryant --- ovn/controller/ovn-controller.c | 65 ++--

[ovs-dev] [PATCH v5 3/6] ovn: Add type and options to logical port.

2015-07-31 Thread Russell Bryant
We have started discussing the use of the logical port abstraction in OVN to represent special types of connections into an OVN logical switch. This patch proposes some schema updates to reflect these special types of logical ports. A logical port can have a "type" and a set of options specific t

[ovs-dev] [PATCH v5 5/6] ovn: Add "localnet" logical port type.

2015-07-31 Thread Russell Bryant
Introduce a new logical port type called "localnet". A logical port with this type also has an option called "network_name". A "localnet" logical port represents a connection to a locally accessible network. ovn-controller will use the ovn-bridge-mappings configuration to figure out which patch p

[ovs-dev] [PATCH v5 2/6] ovn: Add bridge mappings to ovn-controller.

2015-07-31 Thread Russell Bryant
Add a new OVN configuration entry in the Open_vSwitch database called "ovn-bridge-mappings". This allows the configuration of mappings between a physical network name and an OVS bridge that provides connectivity to that network. For example, if you wanted to configure "physnet1" to map to "br-eth

[ovs-dev] [PATCH v5 4/6] ovn: Get/set lport type and options in ovn-nbctl.

2015-07-31 Thread Russell Bryant
A recent patch added "type" and "options" columns to the Logical_Port table in OVN_Northbound. This patch allows you to get and set those columns with ovn-nbctl. ovn-nbctl should eventually get converted to use the common db-ctl code that was recently added. When that happens, these commands can

[ovs-dev] [PATCH v5 0/6] OVN support for Neutron provider networks

2015-07-31 Thread Russell Bryant
v4->v5: - Fix some bugs where code assume br_int existed and that there was an active ovs_idl transaction that could be used. - Add patch for automatically creating br-int if it does not already exist. I added it to this series because it would conflict if I split it out. v3->v4: - Drop pa

[ovs-dev] [PATCH v5 1/6] lib: Add smap_equal().

2015-07-31 Thread Russell Bryant
Add a method to determine of two smaps are equal (have the exact same set of key-value pairs). Suggested-by: Ben Pfaff Signed-off-by: Russell Bryant --- lib/smap.c | 20 lib/smap.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/lib/smap.c b/lib/smap.c index 7fe3ce

Re: [ovs-dev] [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-31 Thread Thomas F Herbert
On 7/31/15 5:34 AM, ravulakollu.ku...@wipro.com wrote: Hi Thomas, I have applied your below mentioned 1ad patch to ovs-master code. Compiled successfully. I am running ovs in a centos machine. I have created bridge and configured ports using below commands. ovs-vsctl --no-wait add-br br0 ov

Re: [ovs-dev] MPLS support in OVS 2.3.2

2015-07-31 Thread Ben Pfaff
On Fri, Jul 31, 2015 at 06:30:15PM +0530, tech_kals Kals wrote: > Also, is there any plan to support TTP (Table Type Pattern) in the upcoming > OVS release ? No. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v4 5/5] ovn: Add "localnet" logical port type.

2015-07-31 Thread Russell Bryant
Introduce a new logical port type called "localnet". A logical port with this type also has an option called "network_name". A "localnet" logical port represents a connection to a locally accessible network. ovn-controller will use the ovn-bridge-mappings configuration to figure out which patch p

[ovs-dev] [PATCH v4 3/5] ovn: Add type and options to logical port.

2015-07-31 Thread Russell Bryant
We have started discussing the use of the logical port abstraction in OVN to represent special types of connections into an OVN logical switch. This patch proposes some schema updates to reflect these special types of logical ports. A logical port can have a "type" and a set of options specific t

[ovs-dev] [PATCH v4 2/5] ovn: Add bridge mappings to ovn-controller.

2015-07-31 Thread Russell Bryant
Add a new OVN configuration entry in the Open_vSwitch database called "ovn-bridge-mappings". This allows the configuration of mappings between a physical network name and an OVS bridge that provides connectivity to that network. For example, if you wanted to configure "physnet1" to map to "br-eth

[ovs-dev] [PATCH v4 1/5] lib: Add smap_equal().

2015-07-31 Thread Russell Bryant
Add a method to determine of two smaps are equal (have the exact same set of key-value pairs). Suggested-by: Ben Pfaff Signed-off-by: Russell Bryant --- lib/smap.c | 20 lib/smap.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/lib/smap.c b/lib/smap.c index 7fe3ce

[ovs-dev] [PATCH v4 4/5] ovn: Get/set lport type and options in ovn-nbctl.

2015-07-31 Thread Russell Bryant
A recent patch added "type" and "options" columns to the Logical_Port table in OVN_Northbound. This patch allows you to get and set those columns with ovn-nbctl. ovn-nbctl should eventually get converted to use the common db-ctl code that was recently added. When that happens, these commands can

[ovs-dev] [PATCH v4 0/6] OVN support for Neutron provider networks

2015-07-31 Thread Russell Bryant
v3->v4: - Drop patches that either merged or are no longer necessary. - Rework patches so that there are no longer any blocking transactions. Everything is now done in the transactions committed in the main loop. - Add patch for automatically creating br-int if it does not already exist. Rus

[ovs-dev] MPLS support in OVS 2.3.2

2015-07-31 Thread tech_kals Kals
Hi Experts, Could someone clarify me whether the following MPLS actions are supported in latest OVS. MPLS L3 VPN Label group entry bucket actions:  Push MPLS shim header (for VPN label; this sets the Ether type to 0x8847)  Set-Field MPLS Label  Set-Field BOS (bottom of stack)  Set-Field

Re: [ovs-dev] [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-31 Thread ravulakollu.kumar
Hi Thomas, I have applied your below mentioned 1ad patch to ovs-master code. Compiled successfully. I am running ovs in a centos machine. I have created bridge and configured ports using below commands. ovs-vsctl --no-wait add-br br0 ovs-vsctl --no-wait add-port br0 eth0 tag=100 vlan_mode=nativ

[ovs-dev] [PATCH v4 2/2] ofproto: Implement OF1.4 Group & Meter change notification messages

2015-07-31 Thread niti1489
From: Niti Rohilla This patch adds support for Openflow1.4 Group & meter change notification messages. In a multi controller environment, when a controller modifies the state of group and meter table, the request that successfully modifies this state is forwarded to other controllers. Other contr

Re: [ovs-dev] [PATCH v3 2/2] ofproto: Implement OF1.4 Group & Meter change notification messages

2015-07-31 Thread niti Rohilla
Hi Ben, Thanks for the review. All the comments have been incorporated in Version 3 of the patch. Thanks Niti Rohilla On Tue, Jul 28, 2015 at 8:59 PM, Ben Pfaff wrote: > On Tue, Jul 28, 2015 at 05:22:25PM +0530, niti1...@gmail.com wrote: > > From: Niti Rohilla > > > > This patch adds support

[ovs-dev] [PATCH 15/15] net: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread Viresh Kumar
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. Signed-off-by: Viresh Kumar --- net/openvswitch/datapath.c | 2 +- net/sctp/socket.c | 2 +- net/socket.c | 6 +++--- 3 files changed, 5 insertions

Re: [ovs-dev] [dpdk-dev] Fwd: OVS with DPDK ..Error packets

2015-07-31 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Srikanth Akula > Sent: Wednesday, July 29, 2015 10:32 PM > To: d...@dpdk.org; dev@openvswitch.org > Subject: [dpdk-dev] Fwd: OVS with DPDK ..Error packets > > (+DPDK dev team ) > > > Hello , > > I am trying to