On Fri, Jul 31, 2015 at 10:15 PM, Ben Pfaff <[email protected]> wrote:
> On Fri, Jul 31, 2015 at 10:04:35PM -0700, Alex Wang wrote:
> > Is there any documentation for the ovs side geneve negotiation?
>
> No. What kind of documentation would help?
>
Maybe,
For ovs side, my understanding is that Geneve allows us to define custom
matching field that is matchable in an OpenFlow flow? The ofctl manual
gives this example,
add-geneve-map br0 "{class=0xffff,type=0,len=4}->tun_metadata0"
But, could we have example about how to use it?
For ovn-side, why do we need to negotiate this particular option,
>
> > > + if (state != S_UPDATE_FLOWS
> > > + || rconn_packet_counter_n_packets(tx_counter)) {
> > > + ovn_flow_table_clear(flow_table);
> > > + return;
> > > }
> >
> > Should we use maybe a boolean to mark this case, so that ofctrl_wait
> > could register a wake up event for re-updating the flows? Wonder if
> there
> > could be a delayed flow update issue~
>
> Only rconn_run() could cause rconn_packet_counter_n_packets() to
> decrease to 0, and only ofctrl_run() calls rconn_run() on swconn, so it
> shouldn't happen currently. I guess it could happen if ofctrl_put()
> were called *before* ofctrl_run() instead of after; maybe there should
> be a note about that.
>
Thx for the explanation, makes sense, a note would be helpful~
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev