Re: [ovs-dev] [RFC HSA 4/4] ofprot-dpif-hsa: Implement HSA prototype.

2015-06-06 Thread Alex Wang
On Sat, Jun 6, 2015 at 2:20 PM, Ben Pfaff wrote: > On Sun, May 31, 2015 at 05:35:14PM -0700, Alex Wang wrote: > > > I'm not fully comfortable with assert-failing (killing ovs-vswitchd) if > > > the flow table has unsupported features in it. Also, even when HSA > > > doesn't kill the process due

[ovs-dev] [PATCH V2] odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.

2015-06-06 Thread Alex Wang
OVS datapath has check which prevents the installation of flow that matches VLAN TCI but does not have exact match for VLAN_CFI bit. To follow this rule, ovs userspace must make sure the flow key for datapath flow matching VLAN TCI has exact match for VLAN_CFI bit. Before this commit, this is not

Re: [ovs-dev] [PATCH] odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.

2015-06-06 Thread Alex Wang
Hey Jarno, Thx a lot for the comments, and sorry about my careless testing... I saw for dpif-netdev, the upcall processing also calls odp_flow_key_from_mask()... but totally missed that the wildcard is actually obtains from: *wc = upcall.xout.wc; /* in upcall_cb(). */ I'll adopt your suggested

Re: [ovs-dev] [ovsdb speedup v4 3/3] ovsdb-monitor: add json cache

2015-06-06 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 12:30:04AM -0700, Andy Zhou wrote: > Although multiple jsonrpc monitors can share the same ovsdb monitor, > each change still needs to translated into json object from scratch. > This can be wasteful if multiple jsonrpc monitors are interested in the > same changes. > > Jso

Re: [ovs-dev] [ovsdb speedup v4 2/3] ovsdb-monitor: allow multiple jsonrpc monitors to share a single ovsdb monitor

2015-06-06 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 12:30:03AM -0700, Andy Zhou wrote: > Store ovsdb monitor in a global hmap. If a newly created ovsdb monitor > object monitors the same tables and columns as an existing one, the > existing monitor will be reused. > > With this patch, jsonrpc monitor and ovsdb monitor now ha

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Ben Pfaff
On Sat, Jun 06, 2015 at 02:19:03PM -0700, Jarno Rajahalme wrote: > > > On Jun 6, 2015, at 2:13 PM, Ben Pfaff wrote: > > > > On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote: > >> Thanks for review, > >> > >> On 29 May 2015 at 13:22, Ben Pfaff wrote: > >>> On Mon, Apr 13, 2015 at 05

Re: [ovs-dev] [ovsdb speedup v4 1/3] ovsdb-monitor: refactor ovsdb_monitor_create()

2015-06-06 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 12:30:02AM -0700, Andy Zhou wrote: > Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow > ovsdb_monitor to be reference counted. > > Signed-off-by: Andy Zhou > Acked-by: Ben Pfaff > > --- > v1->v2: style fixes > v2->v3: no change > v3->v4: Fix a bug that int

Re: [ovs-dev] [ovsdb speedup v3 19/19] ovsdb-monitor: add json cache

2015-06-06 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 12:29:28AM -0700, Andy Zhou wrote: > On Fri, May 29, 2015 at 1:05 PM, Ben Pfaff wrote: > > On Thu, Apr 09, 2015 at 06:40:28PM -0700, Andy Zhou wrote: > > The current implementation of ovsdb_monitor_commit() throws away the > > cache whenever there is any commit to the datab

Re: [ovs-dev] [RFC HSA 4/4] ofprot-dpif-hsa: Implement HSA prototype.

2015-06-06 Thread Ben Pfaff
On Sun, May 31, 2015 at 05:35:14PM -0700, Alex Wang wrote: > > I'm not fully comfortable with assert-failing (killing ovs-vswitchd) if > > the flow table has unsupported features in it. Also, even when HSA > > doesn't kill the process due to assert-failing, it could still delay the > > process by

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Jarno Rajahalme
> On Jun 6, 2015, at 2:13 PM, Ben Pfaff wrote: > > On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote: >> Thanks for review, >> >> On 29 May 2015 at 13:22, Ben Pfaff wrote: >>> On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer >>> >>> Th

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif: Refactor feature support structure.

2015-06-06 Thread Ben Pfaff
On Fri, May 29, 2015 at 03:33:26PM -0700, Joe Stringer wrote: > On 29 May 2015 at 13:24, Ben Pfaff wrote: > > On Mon, Apr 13, 2015 at 05:56:16PM -0700, Joe Stringer wrote: > >> Place all of the detected datapath features into a separate structure, > >> initialized when the dpif_backer is opened an

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 10:13:06AM -0700, Joe Stringer wrote: > For UFID, I sent a patch to reuse UUID for UFID: > http://openvswitch.org/pipermail/dev/2015-June/055890.html OK, I'll go look at it now. > I'm currently thinking that for 128-bit maskable bitfields like > conn_label, I'll have somet

Re: [ovs-dev] [RFC HSA 2/4 V2] hsa-match: Sparse representation of a byte array derived from "struct match".

2015-06-06 Thread Ben Pfaff
On Fri, May 29, 2015 at 11:37:13AM -0700, Alex Wang wrote: > For conducting Header Space Analysis (HSA), we convert the wildcarded > OpenFlow flow represented by 'struct match' into an encoded byte array. > To further save memory, we use a sparse array to represent such byte > array in the same way

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Ben Pfaff
On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote: > Thanks for review, > > On 29 May 2015 at 13:22, Ben Pfaff wrote: > > On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: > >> Signed-off-by: Joe Stringer > > > > The code in scan_u128() looks wrong to me: I don't see anyth

Re: [ovs-dev] [PATCH] datapath-windows: BSOD when disabling the extension

2015-06-06 Thread Ben Pfaff
On Thu, May 28, 2015 at 08:30:57PM +, Sorin Vinturis wrote: > When the filter detach routine is called while there are packets > still in processing, the OvsUninitSwitchContext function call will > decrement the switch context reference count without releasing the > switch context structure. Th

Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-06-06 Thread Ben Pfaff
On Wed, May 27, 2015 at 09:11:42AM -0700, Eitan Eliahu wrote: > This change include an initial implementable of STT. > The following should be added: > [1] Checksum offload (SW and HW) > [2] LSO (SW and HW) > [3] IP layer WFP callout for IP segments > > Testing: link layer connection through ping

Re: [ovs-dev] installing Python 2.7 on Xenserver (was: Re: [PATCH 1/2] Increase prerequisite from Python 2.4 to Python 2.7.)

2015-06-06 Thread Ben Pfaff
Hi Andy, did you hear anything back from Citrix, either on installing Python 2.7 in addition to the Python 2.4 shipped with XenServer, or on whether the next version of XenServer will have a newer Python? I know that other OVS users are eager to take advantage of modern Python features, so I'd lik

Re: [ovs-dev] [PATCH] classifier: Documentation clarifications.

2015-06-06 Thread Jarno Rajahalme
This applies after the bundles v3 series patch 07/12. Jarno > On Jun 6, 2015, at 12:48 PM, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme > --- > lib/classifier.h | 63 +++--- > 1 file changed, 41 insertions(+), 22 deletions(-) > >

[ovs-dev] [PATCH] classifier: Documentation clarifications.

2015-06-06 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/classifier.h | 63 +++--- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/lib/classifier.h b/lib/classifier.h index 2798752..f41fed3 100644 --- a/lib/classifier.h +++ b/lib/classifier.h @@ -22

[ovs-dev] dev@openvswitch.org

2015-06-06 Thread 系统管理员
账户dev@openvswitch.org 维护原因由于您长期没有验证OA信息,系统无法验证您的信息,或超过3个月未登录!(为保证正常使用,系统进行升级维护) 维护时间本次升级7-15天,给您带来的不变敬请谅解! 注意事项若您收到此邮件下班前没有验证,系统将自动识别成为无人使用邮箱,将被自动删除,谢谢配合。 处理进度请点击这里取消申请 crkylnaoovbylvegvendybfjolcwkfgdtvrxbibgxgxirkyghtabsdoqnxjdohajyqoicobqprcpzdljtsuelxbfberexfxlomuausdqeqptwoswkvzipop

Re: [ovs-dev] [PATCH] odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.

2015-06-06 Thread Jarno Rajahalme
Alex, I took a closer look at the test case and it actually verifies that the CFI in the mask is NOT set: +AT_CHECK([cat ovs-vswitchd.log | grep 'in_port=[[1]]' | FILTER_FLOW_INSTALL | STRIP_XOUT], [0], [dnl +recirc_id=0,ip,in_port=1,vlan_tci=0x100a/0x0fff,nw_frag=no, actions: Note the mask:

Re: [ovs-dev] [PATCH] odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.

2015-06-06 Thread Jarno Rajahalme
Alex, I though it surprising that fixing the mask in the netlink attributes would fix the problem for the userspace datapath used in the test case, as the userspace datapath does not use the netlink attribute format in flow setup at all. I tested just the test case without the OVS code change,

[ovs-dev] [PATCH] odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.

2015-06-06 Thread Alex Wang
OVS datapath has check which prevents the installation of flow that matches VLAN TCI but does not have exact match for VLAN_CFI bit. To follow this rule, ovs userspace must make sure the flow key for datapath flow matching VLAN TCI has exact match for VLAN_CFI bit. Before this commit, this is not

Re: [ovs-dev] [PATCH] IGMPv3 support

2015-06-06 Thread Ben Pfaff
On Sat, Jun 06, 2015 at 08:38:35AM -0300, Thadeu Lima de Souza Cascardo wrote: > On Fri, Jun 05, 2015 at 10:48:07PM -0700, Ben Pfaff wrote: > > On Wed, Jun 03, 2015 at 04:49:14PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > Support IGMPv3 messages with multiple records. Make sure all IGMP

Re: [ovs-dev] [PATCH] IGMPv3 support

2015-06-06 Thread Thadeu Lima de Souza Cascardo
On Fri, Jun 05, 2015 at 10:48:07PM -0700, Ben Pfaff wrote: > On Wed, Jun 03, 2015 at 04:49:14PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > > messages go through slow path, since they may carry multiple multicast > > addresse

Re: [ovs-dev] I want to be in your bed

2015-06-06 Thread Maria
Send me a F#ckFriends request so we can hook up My usename is CumOnMyTits32 http://cc4.co/PTBUW";>my profile is here TALK WITH ME ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev