On Fri, Jun 05, 2015 at 10:48:07PM -0700, Ben Pfaff wrote:
> On Wed, Jun 03, 2015 at 04:49:14PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > Support IGMPv3 messages with multiple records. Make sure all IGMPv3
> > messages go through slow path, since they may carry multiple multicast
> > addresses, unlike IGMPv2.
> >
> > Tests done:
> >
> > * multiple addresses in IGMPv3 report are inserted in mdb;
> > * address is removed from IGMPv3 if record is INCLUDE_MODE;
> > * reports sent on a burst with same flow all go to userspace;
> > * IGMPv3 reports go to mrouters, i.e., ports that have issued a query.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com>
>
> Thanks for working on this!
>
> I get a ton of errors like this trying to compile with this applied:
>
> In file included from ../lib/hmap.h:22:0,
> from ../lib/cfm.h:21,
> from ../ofproto/ofproto-provider.h:36,
> from ../ofproto/bond.h:22,
> from ../ofproto/bond.c:19:
> ../lib/packets.h:555:37: error: expected expression before '==' token
> BUILD_ASSERT_DECL(IGMPV3_RECORD_LEN == sizeof(struct igmpv3_record));
> ^
> ../lib/util.h:48:61: note: in definition of macro 'BUILD_ASSERT__'
> sizeof(struct { unsigned int build_assert_failed : (EXPR) ? 1 : -1;
> })
> ^
> ../lib/packets.h:555:1: note: in expansion of macro 'BUILD_ASSERT_DECL'
> BUILD_ASSERT_DECL(IGMPV3_RECORD_LEN == sizeof(struct igmpv3_record));
> ^
> ../lib/packets.h:555:37: error: bit-field 'build_assert_failed' width not an
> integer constant
> BUILD_ASSERT_DECL(IGMPV3_RECORD_LEN == sizeof(struct igmpv3_record));
> ^
> ../lib/util.h:48:61: note: in definition of macro 'BUILD_ASSERT__'
> sizeof(struct { unsigned int build_assert_failed : (EXPR) ? 1 : -1;
> })
> ^
> ../lib/packets.h:555:1: note: in expansion of macro 'BUILD_ASSERT_DECL'
> BUILD_ASSERT_DECL(IGMPV3_RECORD_LEN == sizeof(struct igmpv3_record));
> ^
Sorry for that. These were some last minute changes. What was I thinking not
testing
those? It must have been all the excitement to get my first patch submitted to
OVS.
I will fix those, test they work just as well as the original, and resend.
Thanks.
Cascardo.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
