On Mon, Jun 01, 2015 at 12:30:03AM -0700, Andy Zhou wrote: > Store ovsdb monitor in a global hmap. If a newly created ovsdb monitor > object monitors the same tables and columns as an existing one, the > existing monitor will be reused. > > With this patch, jsonrpc monitor and ovsdb monitor now have N:1 mapping. > The goals are to: > 1) Reduce the cost of maintaining duplicated monitors. > 2) Allow for create Json cache for the same updates. Json cache will be > introduced in the following patch. > > Signed-off-by: Andy Zhou <az...@nicira.com>
In ovsdb_monitor_get_initial(), in the case where we find an existing changes object, do we still need to iterate over all the rows? I think that the changes have to already be composed properly, in that case. In the same function, I think that we could skip the second call to ovsdb_monitor_table_find_changes(), in the "if (!changes)" case, if ovsdb_monitor_table_add_changes() returned the new object. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
