Thanks Alin, I will remove the space and rebase.
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, September 10, 2014 1:41 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v1] Netlink_socket.c Join/Unjoin an MC group for
Hi Guru,
You can just suppress the warning by wrapping the code in a pragama warning
block:
#pragma warning( push )
#pragma warning( disable : 4707 )
// Some code
#pragma warning( pop )
You don't want to initialize to NULL just for suppressing the warning.
Thanks,
Eitan
-Original Message-
On Sep 10, 2014, at 4:15 PM, Samuel Ghinet
wrote:
> Hey Nithin,
>
> AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a
> callback called by NDIS when an IO is pending and the file must be closed.
> FreeUserDumpState is only for dump operations.
>
> Is it possible that an I
hi Sam/Alin,
This is a followup to the discussion we had over IRC this morning about adding
vports.
The question was about what should happen in the kernel if userspace tries to
add a VIF port that is not existent on the hyper-v switch. Should we support it?
In general, you cannot add a vport t
On Wed, Sep 10, 2014 at 07:38:08PM -0300, Flavio Leitner wrote:
>
> I've changed netdev_max_backlog to 110 as before and the "same"
> reproducer but using Linux bridge runs fine up to 1024 ports
> where it reaches the bridge port upper limit (BR_MAX_PORTS).
Actually, the Linux bridge sends the pa
Added an inline function to return used size in the buffer.
Signed-off-by: Ankur Sharma
Acked-by: Samuel Ghinet
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.
Added APIs for creating and parsing nested netlink attributes.
APIs are on similar lines as userspace netlink code.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.c | 92 ++-
datapath-windows/ovsext/Netlink/Netlink.h | 1
Hi,
Sorry i think Sam has not Acked it yet. I'll send a v4 with only nithin's name.
Thanks.
Regards,
Ankur
From: Ankur Sharma
Sent: Wednesday, September 10, 2014 5:30 PM
To: dev@openvswitch.org
Cc: Ankur Sharma
Subject: [PATCH v3 2/2] datapath-windows/Ne
Added APIs for creating and parsing nested netlink attributes.
APIs are on similar lines as userspace netlink code.
Signed-off-by: Ankur Sharma
Acked-by: Samuel Ghinet
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.c | 92 ++-
datapath-windows/ovs
Added an inline function to return used size in the buffer.
Signed-off-by: Ankur Sharma
Acked-by: Samuel Ghinet
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.
Hi Sam,
That is a good catch. My bad. I'll fix it and respin v3.
Thanks.
Regards,
Ankur
From: Samuel Ghinet
Sent: Wednesday, September 10, 2014 4:41 PM
To: dev@openvswitch.org; Ankur Sharma
Subject: RE: [ovs-dev] [PATCH v2 2/2] datapath-windows/Netlink:
Hi Ankur,
> +VOID
> +NlMsgPutNested(PNL_BUFFER buf, UINT16 type,
> + const PVOID data, UINT32 size)
> +{
> +UINT32 offset = NlMsgStartNested(buf, type);
> +
> +UNREFERENCED_PARAMETER(data);
> +UNREFERENCED_PARAMETER(size);
> +
> +ASSERT(offset);
> +
> +ASSERT(NlMs
Acked-by Samuel Ghinet
Date: Wed, 10 Sep 2014 16:20:16 -0700
From: Ankur Sharma
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 1/2] datapath-windows/NetlinkBuf.h: Added
NlBufSize
Message-ID: <1410391216-2019-1-git-send-email-ankursha...@vmwar
Added APIs for creating and parsing netlink attributes.
APIs are on similar lines as userspace netlink code.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.c | 94 ++-
datapath-windows/ovsext/Netlink/Netlink.h | 12
Added an inline function to return used size in the buffer.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.h
b/datapath-windows/ovs
Hey Nithin,
AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a callback
called by NDIS when an IO is pending and the file must be closed.
FreeUserDumpState is only for dump operations.
Is it possible that an IO to be pending (packet queueing) while at the same
time a dump op
Eitan,
A few notes:
o) regarding the call:
> error = nl_sock_send__(sock, &request, 0, true);
(parameter 3 is sequence)
I found doc comment in nl_sock_allocate_seq, saying:
> /* Make it impossible for the next request for sequence numbers to wrap
> * around to 0. Start over with 1 to avoid ever
> Added an inline function to return used size in the buffer.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi Ankur,
I had minor comments, but LG otherwise.
Acked-by: Nithin Raju
> +VOID
> +NlMsgPutNested(PNL_BUFFER buf, UINT16 type,
> + const PVOID data, UINT32 size)
> +{
> +UINT32 offset = NlMsgStartNested(buf, type);
> +
> +UNREFERENCED_PARAMETER(data);
> +UNREFERENCED_PA
Current autoconfig detection logic for HAVE_PER_CPU_PTR is not robust.
Depends on linux kernel version, the definition can be in either
linux/percpu.h or asm/percpu.h
Turns out it is simpler and safer to handle missing percpu.h
definitions in linux/percpu.h rather than asm/percpu.h. With this
chan
>
> You are right probably either use WaitForMultipleObjects or add wrapper
> functionality for it.
We use events and wait for it in lib/daemon-windows.c and
lib/fatal-signal.c with a combination of poll_wevent_wait(),
SetEvent() and ResetEvent(). What is the workflow that you are
interested in?
I've changed netdev_max_backlog to 110 as before and the "same"
reproducer but using Linux bridge runs fine up to 1024 ports
where it reaches the bridge port upper limit (BR_MAX_PORTS).
fbl
On Wed, Sep 10, 2014 at 09:39:42AM -0700, Ben Pfaff wrote:
> My kernel knowledge is rusty. I can research
Hi Guru,
You are right probably either use WaitForMultipleObjects or add wrapper
functionality for it.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 11:28 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-d
Just realized that I mistakenly sent this series (not ready) out. Please
ignore,
I have sent the new version (3 patches instead of 4) without adding a
version number... sorry,
On Wed, Sep 10, 2014 at 12:52 PM, Alex Wang wrote:
> Remove the include of vlog.h and all the related macros, since
>
Thanks for the review :-)
Pushed to master,
Jarno
On Sep 10, 2014, at 10:08 AM, Pravin Shelar wrote:
> On Tue, Sep 9, 2014 at 12:51 PM, Jarno Rajahalme
> wrote:
>> Should be the same as other IPv6 address fields.
>>
>> Forthcoming patches produce sparse warnings without this change.
>>
>
On Wed, Sep 10, 2014 at 2:10 PM, Andy Zhou wrote:
> The upstream modules uses this_cpu_xxx APIs. Add those functions for
> older kernel (<3.0.0) that does not provide them.
>
> VMware-BZ: #1319082
>
> Signed-off-by: Andy Zhou
> ---
> datapath/linux/Modules.mk| 1 +
> datapat
Added an inline function to return used size in the buffer.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.h
b/datapath-windows/ovsext/Netlink/NetlinkBuf.
Added APIs for creating and parsing nested netlink attributes.
APIs are on similar lines as userspace netlink code.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/Netlink.c | 94 ++-
datapath-windows/ovsext/Netlink/Netlink.h | 12
2 files changed
Thanks for fixing these warnings!
>Implementation of OBJECT_OFFSETOF() for non-GNUC compilers like MSVC
>causes "uninitialized variable" warnings. Since OBJECT_OFFSETOF() is
>indirectly used through all the *_FOR_EACH() (through ASSIGN_CONTAINER()
>and OBJECT_CONTAINING()) macros, the OVS build
>
Sorry I missed this one.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 10:39 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Gurucharan Shetty
Subiect: [PATCH] netlink-socket: Convert
On Wed, Sep 10, 2014 at 1:11 PM, Andy Zhou wrote:
> LGTM.
>
> Acked-by: Andy Zhou
I pushed to master, 2.1, 2.3.
Thanks.
>
> On Wed, Sep 10, 2014 at 10:36 AM, Pravin B Shelar wrote:
>> definition of __ip_select_ident() changed in newer kernel and
>> it is backported to stable kernel, Therefore
Signed-off-by: Alex Wang
---
utilities/ovs-appctl.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
index bb17ec2..f279f50 100644
--- a/utilities/ovs-appctl.c
+++ b/utilities/ovs-appctl.c
@@ -81,6 +81,19 @@ main(int argc,
Signed-off-by: Alex Wang
---
lib/dpif-netdev.c |4 ++--
lib/netdev-dummy.c |2 +-
lib/timeval.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 072ed5d..a4dabb6 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev
There is no use case of this option in ovsdb-server. Also,
it causes dpif-dummy and netdev-dummy module register unrelated
unixctl commands.
Signed-off-by: Alex Wang
---
ovsdb/ovsdb-server.c |7 ---
tests/ovsdb-server.at |2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff
The upstream modules uses this_cpu_xxx APIs. Add those functions for
older kernel (<3.0.0) that does not provide them.
VMware-BZ: #1319082
Signed-off-by: Andy Zhou
---
datapath/linux/Modules.mk| 1 +
datapath/linux/compat/include/linux/percpu.h | 18 ++
2 fi
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 1/3] ovs-ofctl: Workaround a compiler warni
Use the new OVS_FLOW_ATTR_SILENT flag when probing for datapath
feature support. Suppress also dpif error logging when requested, as
probe failures are already logged at ofproto-dpif.
Signed-off-by: Jarno Rajahalme
---
lib/dpif-linux.c | 11 +++
lib/dpif.c
Acked-by: Alin Gabriel Serdean
Thanks for removing a lot warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH
This new flag is useful for suppressing error logging when error
messages may be expected, as when probing for datapath features using
flow commands.
Signed-off-by: Jarno Rajahalme
---
datapath/datapath.c | 26 +--
datapath/datapath.h
When probing for variable length userdata before handler threads are
set, the pid included in the userspace action will be 0, which is
flagged as an error by the linux kernel datapath. As a result the
feature probe will produce an unnecessary log message. By probing for
variable length userdata l
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 2/3] hash.h: Avoid compiler warnings with M
MSVC complains about a void function returning a value if there is a
statement of the form - 'return foo()' even if foo() has a void return
type.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-ofctl.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/utilities/o
Implementation of OBJECT_OFFSETOF() for non-GNUC compilers like MSVC
causes "uninitialized variable" warnings. Since OBJECT_OFFSETOF() is
indirectly used through all the *_FOR_EACH() (through ASSIGN_CONTAINER()
and OBJECT_CONTAINING()) macros, the OVS build
on Windows gets littered with "uninitial
The lack of 'const' in function declaration causes MSVC to complain
because the function definition uses it.
Signed-off-by: Gurucharan Shetty
---
lib/hash.h |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/hash.h b/lib/hash.h
index f8bbada..6d3affc 100644
--- a/lib
On 09/10/14 at 10:33pm, Thomas Graf wrote:
> ./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlopen'
> ./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlerror'
Corresponding failing build:
https://travis-ci.org/tgraf/ovs/jobs/34953295
_
Hi Eitan,
Trailing whitespace:
+ OVS_CTRL_CMD_MC_SUBSCRIBE_REQ,
+static int __inline
And could not apply patch because
+/* NL Attributes for joining/unjoining an MC group */ enum
+ovs_nl_mcast_attr {
+OVS_NL_ATTR_MCAST_GRP, /* Join an MC group */
+OVS_NL_ATTR_
On 09/10/14 at 04:22pm, Daniele Di Proietto wrote:
> That’s great,
>
> I see that -Wl,--whole-archive -Wl,-ldl -Wl,--no-whole-archive is used
> when building ovs_client. That should not happen on master
> (-Wl,--whole-archive is used only when we need to link all the pmd
> drivers, i.e. when linki
A missing " prevented the DPDK build in the matrix from functioning.
Correctly build DPDK as a single, shared library and point the OVS
build to the corresponding build directory. Also removes the 'make
install' as it is not needed.
Due to incorrect casts in the DPDK headers, we have to disable
ba
configure cannot expect that the user will not pass additional CFLAGS
and LDFLAGS at make time. Use OVS_CFLAGS and OVS_LDFLAGS instead to
collect compiler and linker flags and substitute in Makefile.am.
This allows for:
./configure --with-dpdk=[...]
make CFLAGS=-Wno-error=foo
Signed-off-by: Thoma
WIP, this still results in an error:
/bin/bash ./libtool --tag=CC --mode=link env REAL_CC="gcc -std=gnu99"
CHECK="sparse -I ./include/sparse -m64 -I /usr/local/include -I
/usr/include/x86_64-linux-gnu " cgcc -target=x86_64 -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith
The upstream modules uses this_cpu_xxx APIs. Add those functions for
older kernel (<3.0.0) that does not provide them.
VMware-BZ: #1319082
Signed-off-by: Andy Zhou
---
datapath/linux/Modules.mk | 1 +
datapath/linux/compat/include/percpu.h | 18 ++
2 files changed,
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index c145d00..d1f4b9d 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath
Ah, this version does not work with redhat patched kernel. I will respin it.
On Wed, Sep 10, 2014 at 9:58 AM, Pravin Shelar wrote:
> I am still see compilation error on centos 6.5
>
> CC [M] /home/pravin/ovs/w8/datapath/linux/actions.o
>
> /home/pravin/ovs/w8/datapath/linux/actions.c: In funct
LGTM.
Acked-by: Andy Zhou
On Wed, Sep 10, 2014 at 10:36 AM, Pravin B Shelar wrote:
> definition of __ip_select_ident() changed in newer kernel and
> it is backported to stable kernel, Therefore adding configure
> check to detect the new function.
>
> Signed-off-by: Pravin B Shelar
> ---
> aci
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
---
v1 CodingStyle fix alignment
---
datapath-windows/include/OvsDpInterface
Remove the include of vlog.h and all the related macros, since
it is not really used.
Signed-off-by: Alex Wang
---
utilities/ovs-appctl.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
index 8249bf8..174d147 100644
--- a/utilities/ovs
There is no use case of this option in ovsdb-server. Also,
it causes dpif-dummy and netdev-dummy module register unrelated
unixctl commands.
Signed-off-by: Alex Wang
---
ovsdb/ovsdb-server.c |7 ---
tests/ovsdb-server.at |2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff
Signed-off-by: Alex Wang
---
lib/dpif-netdev.c |4 ++--
lib/netdev-dummy.c |2 +-
lib/timeval.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 072ed5d..a4dabb6 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev
Signed-off-by: Alex Wang
---
utilities/ovs-appctl.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
index bb17ec2..8249bf8 100644
--- a/utilities/ovs-appctl.c
+++ b/utilities/ovs-appctl.c
@@ -81,6 +81,19 @@ main(int argc,
Sure will do a)
Thanks
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 12:45 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for
event subscription
On Sep 10, 2014, at 12:40 PM, Eitan Eliahu
wrote:
> Nith
On Sep 10, 2014, at 12:40 PM, Eitan Eliahu
wrote:
> Nithin, I can't align it since if aligned this line will go over the 80
> character limit.
You could do one of these two options. Either way is fine:
a)
+nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0,
+
Nithin, I can't align it since if aligned this line will go over the 80
character limit.
Thank you.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 12:38 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for
e
Eitan,
Thanks for doing this.
I had some minor comments. LG otherwise.
Acked-by: Nithin Raju
> +OVS_NL_ATTR_MCAST_JOIN, /*1/0 - Join/Unjoin */
minor: need a space before '1/0'.
> +nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0,
> + OVS_CTRL_CMD_
definition of __ip_select_ident() changed in newer kernel and
it is backported to stable kernel, Therefore adding configure
check to detect the new function.
Signed-off-by: Pravin B Shelar
---
acinclude.m4| 2 ++
datapath/linux/compat/ip_tunnels_core.c | 5 +
2 fi
On Wed, Sep 10, 2014 at 10:02 AM, Mark Maglana wrote:
> That's a more elegant solution. Yes, that works for me. Thanks! :-)
>
Thanks. I applied the following version (copy-pasted).
[PATCH] ovs-vtep: Handle physical ports with '-' in its name.
As of now, if a physical port has a '-' in its name, o
On Tue, Sep 9, 2014 at 12:51 PM, Jarno Rajahalme wrote:
> Should be the same as other IPv6 address fields.
>
> Forthcoming patches produce sparse warnings without this change.
>
> Signed-off-by: Jarno Rajahalme
LGTM
Acked-by: Pravin B Shelar
> ---
> datapath/linux/compat/include/linux/openvsw
That's a more elegant solution. Yes, that works for me. Thanks! :-)
On Wed, Sep 10, 2014 at 8:51 AM, Gurucharan Shetty
wrote:
> On Tue, Sep 9, 2014 at 9:18 AM, Mark Maglana wrote:
> > On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty
> > wrote:
> >>
> >> I see that there is a bug. With your pa
I am still see compilation error on centos 6.5
CC [M] /home/pravin/ovs/w8/datapath/linux/actions.o
/home/pravin/ovs/w8/datapath/linux/actions.c: In function ‘ovs_execute_actions’:
/home/pravin/ovs/w8/datapath/linux/actions.c:1034: error: implicit
declaration of function ‘this_cpu_read’
/home
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
---
datapath-windows/include/OvsDpInterfaceExt.h | 7 +++
lib/netlink-socket.c | 81 +---
2 files c
Daniele,
See comments below.
Also, it would be preferable to send related changes, or multiple unrelated
changes to any given subsystem, as a series of patches instead of individual
ones. “git format-patch” does that automatically.
Jarno
On Sep 10, 2014, at 1:28 AM, Daniele Venturino wrote
I personally prefer starting the struct field names on the same column whenever
that is practical. However, this is better than the original inconsistency in
style, so:
Acked-by: Jarno Rajahalme
Pushed to master,
Jarno
On Sep 10, 2014, at 1:28 AM, Daniele Venturino wrote:
> Signed-off by
Did the same treatment to rstp_port_unref() and elaborated the commit message.
Acked-by: Jarno Rajahalme
Pushed to master,
Jarno
On Sep 10, 2014, at 1:28 AM, Daniele Venturino wrote:
> See commit 24f8381214966e90819bf4a9ecabf076cbfc1b08.
>
> Signed-off by: Daniele Venturino
> ---
> lib/r
Acked-by: Jarno Rajahalme
& pushed to master,
Jarno
On Sep 10, 2014, at 1:28 AM, Daniele Venturino wrote:
> Signed-off by: Daniele Venturino
> ---
> lib/rstp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/rstp.c b/lib/rstp.c
> index 5914a1d..b213b44 100644
My kernel knowledge is rusty. I can research it, but maybe Flavio or
someone else "just knows".
On Wed, Sep 10, 2014 at 08:48:01AM -0700, Justin Pettit wrote:
> Ben, we were assuming this same issue would happen with the
> bridge. Do we know if that's true? It seems like it would be a
> pretty se
On 9/10/14, 7:54 AM, "Thomas Graf" wrote:
>On 09/09/14 at 10:45pm, Daniele Di Proietto wrote:
>> I¹ll try to figure out what¹s wrong an post another patch.
>
>Daniele,
>
>I have a patchset to properly enable the DPDK build, fix CFLAGS
>and disable some errors to make -Werror work. The only thing
On Tue, Sep 9, 2014 at 9:18 AM, Mark Maglana wrote:
> On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty
> wrote:
>>
>> I see that there is a bug. With your patch, would we still hit the bug
>> if the port name has a "--" in it?
>
>
> Definitely. Although I'm guessing that the probability of "--"
Ben, we were assuming this same issue would happen with the bridge. Do we know
if that's true? It seems like it would be a pretty serious problem as the
number of containers/VMs grows on a host, so I'm wondering what the kernel
community may do about it.
--Justin
> On Sep 9, 2014, at 3:07 PM,
On Tue, Sep 09, 2014 at 09:02:36AM -0700, Nithin Raju wrote:
> During a review, it seemed that some of the conventions were not clear.
> Fixing them in this patch.
>
> Signed-off-by: Nithin Raju
> Reported-by: Samuel Ghinet
Applied, thanks!
___
dev ma
On Tue, Sep 9, 2014 at 5:54 PM, Eitan Eliahu wrote:
>
> Yes, I see, my bad. MAXIMUM_MONITORS instead of MAX_MONTIORS.
> Looks good.
Thanks! Applied.
> Thanks,
> Eitan
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tuesday, September 09, 2014 3:51 PM
> To: Eitan E
On Wed, Sep 10, 2014 at 11:46:55AM -0300, Flavio Leitner wrote:
> On Wed, Sep 10, 2014 at 07:39:17AM -0700, Ben Pfaff wrote:
> > On Wed, Sep 10, 2014 at 08:42:50AM -0300, Flavio Leitner wrote:
> > > On Tue, Sep 09, 2014 at 03:07:28PM -0700, Ben Pfaff wrote:
> > > > Linux has an internal queue that
On 09/09/14 at 10:45pm, Daniele Di Proietto wrote:
> I¹ll try to figure out what¹s wrong an post another patch.
Daniele,
I have a patchset to properly enable the DPDK build, fix CFLAGS
and disable some errors to make -Werror work. The only thing left
is resolving this linker error:
/bin/bash ./l
On Wed, Sep 10, 2014 at 07:39:17AM -0700, Ben Pfaff wrote:
> On Wed, Sep 10, 2014 at 08:42:50AM -0300, Flavio Leitner wrote:
> > On Tue, Sep 09, 2014 at 03:07:28PM -0700, Ben Pfaff wrote:
> > > Linux has an internal queue that temporarily holds packets transmitted to
> > > certain network devices.
On Wed, Sep 10, 2014 at 08:42:50AM -0300, Flavio Leitner wrote:
> On Tue, Sep 09, 2014 at 03:07:28PM -0700, Ben Pfaff wrote:
> > Linux has an internal queue that temporarily holds packets transmitted to
> > certain network devices. If too many packets are transmitted to such
> > network devices wi
Thanks Nithin. Will fix the parameter alignment in the first opportunity.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, September 10, 2014 6:25 AM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH v4] Windows NetLink Socket - Support for
asynchronous event notification
T
This is already committed, but LG to me as well. Will look forward to the
kernel implementation.
Only comment I had was w.r.t alignment in the following code:
> +int ovs_msg_size = sizeof (struct nlmsghdr) + sizeof (struct genlmsghdr)
> +
> + sizeof (struct ovs
On Wed, Sep 10, 2014 at 06:07:25PM +0530, Rishi Bamba wrote:
> I am facing a compilation issue on making a change in openflow-1.0.h
> struct "ofp10_flow_mod"(adding a new parameter) , though the ASSERT
> value has been correctly modified for the struct and build has passed
> the assert code block.
Hi All,
I am facing a compilation issue on making a change in openflow-1.0.h struct
"ofp10_flow_mod"(adding a new parameter) , though the ASSERT value has been
correctly modified for the struct and build has passed the assert code block.
The following error is faced currently :
"""
PYTHONP
On Tue, Sep 09, 2014 at 03:07:28PM -0700, Ben Pfaff wrote:
> Linux has an internal queue that temporarily holds packets transmitted to
> certain network devices. If too many packets are transmitted to such
> network devices within a single list of actions, then packets tend to get
> dropped. Broa
On 09/09/14 at 03:17pm, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> I didn't test the fix. If it works "netdev-dpdk.o" should appear in the travis
> output (on master it doesn't)
>
> Thanks,
>
> Daniele
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1
This function allows netlink attributes to be parsed more strictly,
to check for additional constraints beyond those that nla_parse() checks
for. Passing flags=0 to nla_parse_strict() implies the same behaviour as
nla_parse().
Signed-off-by: Joe Stringer
---
v2: Change nla_parse_strict() interfac
Reduce duplicate code by using nla_policy and nla_parse_strict().
Signed-off-by: Joe Stringer
---
v2: Remove attrs bitmasks from most functions.
Remove key/mask wrappers for parse_nlattrs().
Rebase against flag-based nla_parse_strict().
---
datapath/flow_netlink.c | 420
See commit bacdb85ad82f981697245eefb40a3b360cfe379b.
Signed-off by: Daniele Venturino
---
lib/rstp.h | 42 +++---
ofproto/ofproto-dpif-xlate.c | 6 +++---
2 files changed, 42 insertions(+), 6 deletions(-)
diff --git a/lib/rstp.h b/lib/rs
See commit 24f8381214966e90819bf4a9ecabf076cbfc1b08.
Signed-off by: Daniele Venturino
---
lib/rstp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index b213b44..f2f1dce 100644
--- a/lib/rstp.c
+++ b/lib/rstp.c
@@ -168,7 +168,7 @@ void
rstp_unref(st
Signed-off by: Daniele Venturino
---
lib/rstp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index 5914a1d..b213b44 100644
--- a/lib/rstp.c
+++ b/lib/rstp.c
@@ -951,7 +951,8 @@ rstp_initialize_port_defaults__(struct rstp_port *p)
{
rstp_port_
Signed-off by: Daniele Venturino
---
lib/rstp-common.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/rstp-common.h b/lib/rstp-common.h
index 4e0d398..587f88c 100644
--- a/lib/rstp-common.h
+++ b/lib/rstp-common.h
@@ -225,19 +225,19 @@ enum rstp_bpdu_f
95 matches
Mail list logo
