Sorry I missed this one. Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
-----Mesaj original----- De la: Gurucharan Shetty [mailto:shet...@nicira.com] Trimis: Tuesday, September 9, 2014 10:39 PM Către: dev@openvswitch.org Cc: Alin Serdean; Eitan Eliahu; Gurucharan Shetty Subiect: [PATCH] netlink-socket: Convert from error number to string correctly. As mentioned in the comment above the function ovs_strerror(), it should not be used to convert WINAPI error numbers to string. Use ovs_lasterror_to_string() instead. CC: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> CC: Eitan Eliahu <elia...@vmware.com> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> --- lib/netlink-socket.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c index f91b909..bdc1ade 100644 --- a/lib/netlink-socket.c +++ b/lib/netlink-socket.c @@ -147,16 +147,14 @@ nl_sock_create(int protocol, struct nl_sock **sockp) FILE_FLAG_OVERLAPPED, NULL); if (sock->handle == INVALID_HANDLE_VALUE) { - int last_error = GetLastError(); - VLOG_ERR("fcntl: %s", ovs_strerror(last_error)); + VLOG_ERR("fcntl: %s", ovs_lasterror_to_string()); goto error; } memset(&sock->overlapped, 0, sizeof sock->overlapped); sock->overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); if (sock->overlapped.hEvent == NULL) { - int last_error = GetLastError(); - VLOG_ERR("fcntl: %s", ovs_strerror(last_error)); + VLOG_ERR("fcntl: %s", ovs_lasterror_to_string()); goto error; } -- 1.7.9.5 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
