[ovs-dev] RFC: OVS on Hyper-V design and implementation

2014-06-13 Thread Nithin Raju
Hi, Below is a document that describes the design and implementation of OVS for Hyper-V that my team in VMware has been working on. The focus was to work on the implementation of the kernel components and leverage the userspace port. We have most of the pieces working, and the document describes

Re: [ovs-dev] [MASTER 3/3] bridge: Make ovs-vswitchd run again if status_txn commit fails.

2014-06-13 Thread Alex Wang
Applied all three patches to master, thx for the review, On Fri, Jun 13, 2014 at 5:41 PM, Alex Wang wrote: > TXN_UNCOMMITTED should not be possible here (because we just committed >> it). If you want to check for it (I probably wouldn't bother) then >> I'd use an assertion: >> > +/

Re: [ovs-dev] [MASTER 3/3] bridge: Make ovs-vswitchd run again if status_txn commit fails.

2014-06-13 Thread Alex Wang
> > TXN_UNCOMMITTED should not be possible here (because we just committed > it). If you want to check for it (I probably wouldn't bother) then > I'd use an assertion: > > +/* Sets the 'status_txn_try_again' if the transaction > fails. */ > > +if (status == TXN_SUCCESS || s

[ovs-dev] [PATCH v5 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-13 Thread Daniele Di Proietto
This commit introduces a new data structure used for receiving packets from netdevs and passing them to dpifs. The purpose of this change is to allow storing some private data for each packet. The subsequent commits make use of it. Signed-off-by: Daniele Di Proietto --- lib/automake.mk

[ovs-dev] [PATCH v5 2/3] netdev: netdev_send accepts multiple packets

2014-06-13 Thread Daniele Di Proietto
The netdev_send function has been modified to accept multiple packets, to allow netdev providers to amortize locking and queuing costs. This is especially true for netdev-dpdk. Later commits exploit the new API. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 4 +- lib/netdev-b

[ovs-dev] [PATCH v5 3/3] dpif-netdev: batch packet processing

2014-06-13 Thread Daniele Di Proietto
This change in dpif-netdev allows faster packet processing for devices which implement batching (netdev-dpdk currently). Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c| 354 +++ lib/dpif.c | 12 +- lib/odp-execute.c

[ovs-dev] [PATCH v5 0/3] DPDK batch packet processing

2014-06-13 Thread Daniele Di Proietto
Changes from v4: rebased simplified error handling in netdev_linux_send() moved dpif_packet functions into a separate .c file cosmetic changes Changes from v3: struct dpif_packet has its own header removed many dpif_packet functions (using ofpbuf directly instead) avoided copying in dpif_execute

Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-13 Thread Simon Horman
On Fri, Jun 13, 2014 at 10:46:07AM -0700, Ben Pfaff wrote: > On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote: > > dd51dae29bccca3 ("ofproto: Move logic for collecting read-only rules into > > rule_criteria.") modifies modify_flows__ such that the variable error, > > the return value, m

Re: [ovs-dev] [PATCH v2 05/47] ofproto: Add ofoperation_has_out_group

2014-06-13 Thread Simon Horman
On Fri, Jun 13, 2014 at 11:19:39AM -0700, Ben Pfaff wrote: > On Tue, Jun 10, 2014 at 07:27:09PM +0900, Simon Horman wrote: > > This is analogous to ofoperation_has_out_port, > > operating on a group rather than a port. > > > > This is in preparation for adding out_group support to flow monitors >

Re: [ovs-dev] [PATCH V2] ovs-thread: Implement OVS specific barrier.

2014-06-13 Thread Alex Wang
Thx for the review, applied to master. On Fri, Jun 13, 2014 at 10:48 AM, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 02:28:44PM -0700, Alex Wang wrote: > > Non-leader revalidator thread uses pthread_barrier_* functions in their > > main loop to synchronize with leader thread. However, since tho

[ovs-dev] [PATCH] ofproto: Honour out_port of flow monitors

2014-06-13 Thread Simon Horman
Previously the out_port of a flow monitor was checked in ofmonitor_report() using ofoperation_has_out_port(). When ofoperation_has_out_port() was removed so was the call to it in ofmonitor_report() thus flow monitor updates are longer filtered on the out_port. This restores filtering on the out_p

Re: [ovs-dev] [PATCH] netdev-vport: Use dpif_port as base for tunnel backing port.

2014-06-13 Thread Jesse Gross
On Fri, Jun 13, 2014 at 4:13 PM, Ben Pfaff wrote: > On Fri, Jun 13, 2014 at 12:08:40PM -0700, Jesse Gross wrote: >> In most cases, tunnel ports specify a dpif name to act as the backing >> port in the datapath. However, in the case of UDP tunnels the type is >> used with the port number appended.

Re: [ovs-dev] [PATCH] stream-ssl: Enable TLSv1.1 and TLSv1.2.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 03:49:13PM -0700, Gurucharan Shetty wrote: > On Thu, Jun 12, 2014 at 4:07 PM, Ben Pfaff wrote: > > The Open vSwitch SSL code was inadvertently enabling only TLSv1, not > > later versions. This commit should fix it. > > > > Signed-off-by: Ben Pfaff > > Reported-by: Abhinav

Re: [ovs-dev] [PATCH] odp-util: Make it harder to forget to update ODPUTIL_FLOW_KEY_BYTES.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 02:44:46PM -0700, Andy Zhou wrote: > On Fri, Jun 13, 2014 at 8:40 AM, Ben Pfaff wrote: > > We've forgotten more than once. Most updates coincide with adding > > new flow members, so a build assertion on FLOW_WC_SEQ seems appropriate. > > > > Signed-off-by: Ben Pfaff > >

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Honour NXFMF_OWN flag of flow monitors

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 11:40:24AM +0900, Simon Horman wrote: > If NXFMF_OWN is set then full updates should be sent. > Prior to this change an abbreviated update is always sent > to the controller to which a monitor belongs, that is, > the NXFMF_OWN flag is ignored. > > Also: > * Update existing

Re: [ovs-dev] [PATCH v2 1/2] ofproto: Break out perl code for sorting multiline messages

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 11:40:23AM +0900, Simon Horman wrote: > The flow monitoring tests includes a perl script to sort multiline > messages. This commit breaks it out of an individual test so that it can > be used elsewhere. > > Signed-off-by: Simon Horman > [b...@nicira.com changed approach f

Re: [ovs-dev] [PATCH] netdev-vport: Use dpif_port as base for tunnel backing port.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 04:13:15PM -0700, Ben Pfaff wrote: > On Fri, Jun 13, 2014 at 12:08:40PM -0700, Jesse Gross wrote: > > In most cases, tunnel ports specify a dpif name to act as the backing > > port in the datapath. However, in the case of UDP tunnels the type is > > used with the port number

Re: [ovs-dev] [PATCH] netdev-vport: Use dpif_port as base for tunnel backing port.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 12:08:40PM -0700, Jesse Gross wrote: > In most cases, tunnel ports specify a dpif name to act as the backing > port in the datapath. However, in the case of UDP tunnels the type is > used with the port number appended. This is potentially a problem for > IPsec tunnels becaus

Re: [ovs-dev] [PATCH] Move setsockopt TCP_NODELAY to when TCP is connected.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 02:21:36PM -0700, Linda Sun wrote: > On windows platform, TCP_NODELAY can only be set when TCP > is established. If the conection is not immediately returning > success, call it when state is changed from TCP_CONNECTING > to SSL_CONNECTING. > > Signed-off-by: Linda Sun A

Re: [ovs-dev] [PATCH 1/3] util: Move definition of HANDLE here.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 03:34:25PM -0700, Gurucharan Shetty wrote: > On Fri, Jun 13, 2014 at 3:28 PM, Ben Pfaff wrote: > > A few Open vSwitch source files use a type named HANDLE on Windows systems, > > in a way that makes it easier to avoid #ifdefs if we have a dummy > > definition on other platf

Re: [ovs-dev] [PATCH] stream-ssl: Enable TLSv1.1 and TLSv1.2.

2014-06-13 Thread Gurucharan Shetty
On Thu, Jun 12, 2014 at 4:07 PM, Ben Pfaff wrote: > The Open vSwitch SSL code was inadvertently enabling only TLSv1, not > later versions. This commit should fix it. > > Signed-off-by: Ben Pfaff > Reported-by: Abhinav Singhal Based on https://www.openssl.org/docs/ssl/SSL_CTX_new.html and http:/

Re: [ovs-dev] [PATCH 1/3] util: Move definition of HANDLE here.

2014-06-13 Thread Gurucharan Shetty
On Fri, Jun 13, 2014 at 3:28 PM, Ben Pfaff wrote: > A few Open vSwitch source files use a type named HANDLE on Windows systems, > in a way that makes it easier to avoid #ifdefs if we have a dummy > definition on other platforms. was a really weird place > for this dummy definition. This commit

[ovs-dev] [PATCH 2/3] Do not seemingly #include Linux-specific headers on other platforms.

2014-06-13 Thread Ben Pfaff
Until now, the OVS source tree has had a whole maze of header files that make "#include " work OK regardless of platform, but this confuses everyone new to the tree, at first glance, and is difficult to understand at second glance too. This commit moves the core of the Netlink definitions that wer

[ovs-dev] [PATCH 3/3] odp-netlink-internal.h: Use ovs_32aligned_u64.

2014-06-13 Thread Ben Pfaff
Open vSwitch userspace uses special types to indicate that a particular object may not be naturally aligned. Netlink is one source of such problems: in Netlink, 64-bit integers are often aligned only on 32-bit boundaries. Now that the header file for Open vSwitch datapath Netlink definitions has

[ovs-dev] [PATCH 1/3] util: Move definition of HANDLE here.

2014-06-13 Thread Ben Pfaff
A few Open vSwitch source files use a type named HANDLE on Windows systems, in a way that makes it easier to avoid #ifdefs if we have a dummy definition on other platforms. was a really weird place for this dummy definition. This commit moves it to util.h. Signed-off-by: Ben Pfaff --- include

Re: [ovs-dev] [PATCH v2] lib/classifier: Fix use of uninitialized memory.

2014-06-13 Thread Jarno Rajahalme
Thanks for the review! Pushed in two separate commits and the for statement restored and backported to branch-2.1 and branch-2.3. More comments below, Jarno On Jun 11, 2014, at 2:46 PM, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 03:06:22PM -0700, Jarno Rajahalme wrote: >> When reaching the

Re: [ovs-dev] [PATCH] odp-util: Make it harder to forget to update ODPUTIL_FLOW_KEY_BYTES.

2014-06-13 Thread Andy Zhou
On Fri, Jun 13, 2014 at 8:40 AM, Ben Pfaff wrote: > We've forgotten more than once. Most updates coincide with adding > new flow members, so a build assertion on FLOW_WC_SEQ seems appropriate. > > Signed-off-by: Ben Pfaff Good idea. Acked-by: Andy Zhou _

Re: [ovs-dev] [mask array v5 2/2] datapath: keep mask array compact when deleting mask

2014-06-13 Thread Pravin Shelar
Git am warning. git am dd2.patch Applying: datapath: keep mask array compact when deleting mask /home/pravin/ovs/cln/.git/rebase-apply/patch:119: trailing whitespace. if (i < ma->max) warning: 1 line adds whitespace errors. On Wed, Jun 11, 2014 at 2:24 PM, Andy Zhou wrote: > When deleting a

[ovs-dev] [PATCH] Move setsockopt TCP_NODELAY to when TCP is connected.

2014-06-13 Thread Linda Sun
On windows platform, TCP_NODELAY can only be set when TCP is established. If the conection is not immediately returning success, call it when state is changed from TCP_CONNECTING to SSL_CONNECTING. Signed-off-by: Linda Sun --- lib/stream-ssl.c | 36 1 file

[ovs-dev] Spam Quarantine Summary - (1)

2014-06-13 Thread CudaMail Spam & Virus Firewall
Dear dev@openvswitch.org, this is your quarantine summary from the CudaMail Spam & Virus Firewall. You have 1 messages in your spam quarantine inbox. To view the contents of your quarantine inbox or to manage your spam preferences, please open the following link in your browser: https://web.cu

Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Ben Pfaff
OK. Can you add the information about this only working on Windows after connection completion to the change log, and then factor out the new duplicated code into a function (probably in socket-util.[ch])? Then it makes sense to apply it. Thanks, Ben. On Fri, Jun 13, 2014 at 08:56:13PM +,

Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Linda Sun
I'm probably wrong, but my interpretation is that this ends up being an no-op on windows. But without moving it down, setsockopt() would fail, and I can't establish connections to NVP controller. Linda -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Friday, June 13,

Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Ben Pfaff
Is TCP_NODELAY actually the right way to disable Nagle on Windows? The Microsoft documentation at http://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx says that "This socket option is included for backward compatibility with Windows Sockets 1.1" which implies that there's

Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Linda Sun
On windows platform, setsockopt would return invalid argument if called before tcp is connected. Linda -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Friday, June 13, 2014 1:36 PM To: Linda Sun Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Only set TCP_NODELA

Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 01:35:18PM -0700, Linda Sun wrote: > Signed-off-by: Linda Sun Why? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL.

2014-06-13 Thread Linda Sun
Signed-off-by: Linda Sun --- lib/stream-ssl.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c index 3f753d1..aad7d8c 100644 --- a/lib/stream-ssl.c +++ b/lib/stream-ssl.c @@ -260,13 +260,15 @@ new_ssl_stream(cons

Re: [ovs-dev] [PATCH/RFC v2 3/4] ofproto: Support multipart flow monitor requests

2014-06-13 Thread Ben Pfaff
On Wed, Jun 11, 2014 at 01:34:43PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Looks good at first glance. Please rebase when you get a chance. Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo

Re: [ovs-dev] [PATCH/RFC v2 2/4] connmgr: Buffer multipart requests

2014-06-13 Thread Ben Pfaff
On Wed, Jun 11, 2014 at 01:34:42PM +0900, Simon Horman wrote: > Buffer a multi-part requests until all its parts are received. > > This is achieved by initialising the list_node field of messages > and passing them to ofmp_req_filter(). > > * If the message is not recognised as part of a multi-pa

Re: [ovs-dev] [PATCH/RFC v2 1/4] ofp-msg: Add helpers for allowing multipart requests

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 01:22:46PM -0700, Ben Pfaff wrote: > On Wed, Jun 11, 2014 at 01:34:41PM +0900, Simon Horman wrote: > > Add helpers for allowing requests and use them in handle_openflow__(). > > > > This is a in preparation for supporting multipart requests > > on a per message type basis.

Re: [ovs-dev] [PATCH/RFC v2 1/4] ofp-msg: Add helpers for allowing multipart requests

2014-06-13 Thread Ben Pfaff
On Wed, Jun 11, 2014 at 01:34:41PM +0900, Simon Horman wrote: > Add helpers for allowing requests and use them in handle_openflow__(). > > This is a in preparation for supporting multipart requests > on a per message type basis. > > Signed-off-by: Simon Horman As is, ofpmsg_is_mp_request() coul

Re: [ovs-dev] [MASTER 3/3] bridge: Make ovs-vswitchd run again if status_txn commit fails.

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 10:03:52AM -0700, Alex Wang wrote: > This commit adds logic that checks the return value of status_txn > transaction and runs the update again if the transaction fails > (transaction status is not 'TXN_SUCCESS', 'TXN_UNCHANGED', or > 'TXN_INCOMPLETE'). > > To keep the code

Re: [ovs-dev] [MASTER 2/3] ofproto: Add separate functions for checking bfd/cfm status change.

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 10:03:51AM -0700, Alex Wang wrote: > Currently, ofproto_port_get_bfd/cfm_status() is used to check the > bfd/cfm status change and query the status change. Users decide > what to do with the filled status struct based on the return value > of the funciton. Such design is c

Re: [ovs-dev] [MASTER 1/3] cfm: Extracts the cfm status in one function.

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 10:03:50AM -0700, Alex Wang wrote: > This commit adds a new function, cfm_get_status(), for extracting > all cfm status at once. This helps avoid the sequence of lock > acquire/release in current implementation of status query. > > Signed-off-by: Alex Wang Acked-by: Ben

Re: [ovs-dev] [PATCH 2/4] lib: Userspace library changes to support provider VLANs

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:03:44PM +0530, Avinash wrote: > This commit contains the following changes: > 1. New vlan variables (tpid and count) are added to flow structure to support >provider VLANs. > 2. miniflow_extract() initialises these new variables based on received >packet. > 3. Alt

Re: [ovs-dev] [PATCH 3/4] vswitchd: New parameter to support provider vlans

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:04:07PM +0530, Avinash wrote: > Introduced new parameter dvlan-tags in other-config to support > provider VLANs at access port. > > Help and usage of this new parameter is updated vswitch.xml > > Signed-off-by: Avinash Maybe the documentation in this patch is good eno

Re: [ovs-dev] [PATCH 4/4] ofproto: dpif changes to support provider VLANs

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 12:27:12PM -0700, Ben Pfaff wrote: > On Tue, Jun 10, 2014 at 07:04:28PM +0530, Avinash wrote: > > This commit includes: > > 1. Support for new config parameter in xbundle. > > 2. Changes in determining the vlan id and number of VLANs to be present > >in the output packet

Re: [ovs-dev] [PATCH 4/4] ofproto: dpif changes to support provider VLANs

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:04:28PM +0530, Avinash wrote: > This commit includes: > 1. Support for new config parameter in xbundle. > 2. Changes in determining the vlan id and number of VLANs to be present >in the output packet. > > For testing purpose, planned to make changes in normalize-acti

Re: [ovs-dev] [PATCH 1/7] lisp: Use IP addresses rather than flow on hash failure.

2014-06-13 Thread Jesse Gross
On Wed, Jun 11, 2014 at 1:50 AM, Thomas Graf wrote: > On 06/10/14 at 04:47pm, Jesse Gross wrote: >> When calculating the source port for the UDP header, LISP primarily >> uses skb_get_hash() but needs a backup in case this fails. The >> current backup is a hash of the entire flow key but this incl

[ovs-dev] [PATCH] netdev-vport: Use dpif_port as base for tunnel backing port.

2014-06-13 Thread Jesse Gross
In most cases, tunnel ports specify a dpif name to act as the backing port in the datapath. However, in the case of UDP tunnels the type is used with the port number appended. This is potentially a problem for IPsec tunnels because they have different types but should have the same backing port. Th

Re: [ovs-dev] [PATCH v2 00/47] OF1.4 Flow Monitor

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:04PM +0900, Simon Horman wrote: > this patch-set is a first-pass at adding support for OpenFlow1.4 flow > monitor. It leverages the existing NX flow monitor extension. There are, > however, enough differences between the two to make this a substantial > patch-set. > >

Re: [ovs-dev] [PATCH v2 32/47] extract-ofp-msg: Add ONF extension support

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:36PM +0900, Simon Horman wrote: > This is analogous to Nicira extension support. > > This is in preparation for supporting EXT-187: flow entry notification > extension (ONF flow monitor). > > Signed-off-by: Simon Horman Thanks, I'll apply this in a minute.

Re: [ovs-dev] [PATCH v2 04/47] ofp-msgs: Add OFPRAW_OFPST14_FLOW_MONITOR_*

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:08PM +0900, Simon Horman wrote: > Add OFPRAW_OFPST14_FLOW_MONITOR_REQUEST and > OFPRAW_OFPST14_FLOW_MONITOR_REPLY. > > This is a step towards supporting OpenFlow1.4 flow monitors. > > Signed-off-by: Simon Horman Applied, thanks!

Re: [ovs-dev] [PATCH v2 05/47] ofproto: Add ofoperation_has_out_group

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:09PM +0900, Simon Horman wrote: > This is analogous to ofoperation_has_out_port, > operating on a group rather than a port. > > This is in preparation for adding out_group support to flow monitors > which is in turn in preparation for supporting OpenFlow1.4 flow monit

Re: [ovs-dev] [PATCH v2 03/47] ofp-errors: Add OFPET_FLOW_MONITOR_FAILED

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:07PM +0900, Simon Horman wrote: > Add OFPET_FLOW_MONITOR_FAILED which is added in OpenFLow1.4. > Map the OFPERR_NXBRC_FM_* errors to the corresponding new OpenFlow errors. > > This is a step towards supporting OpenFlow1.4 flow monitors. > > Signed-off-by: Simon Horma

Re: [ovs-dev] [PATCH] timeval: Provide a variation for time/warp command.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 11:08:37AM -0700, Gurucharan Shetty wrote: > On Thu, Jun 12, 2014 at 3:35 PM, Ben Pfaff wrote: > > On Fri, Jun 06, 2014 at 10:04:31AM -0700, Gurucharan Shetty wrote: > >> The new command is of the form 'time/warp LARGE_MSECS MSECS'. > >> It advances the current monotonic ti

[ovs-dev] [PATCH v2] timeval: Provide a variation for time/warp command.

2014-06-13 Thread Gurucharan Shetty
The new command is of the form 'time/warp LARGE_MSECS MSECS'. It advances the current monotonic time by LARGE_MSECS. This is done MSECS at a time in each run of the main thread. This gives other threads time to run after the clock has been advanced by MSECS. The old command would continue to work.

Re: [ovs-dev] [PATCH] timeval: Provide a variation for time/warp command.

2014-06-13 Thread Gurucharan Shetty
On Thu, Jun 12, 2014 at 3:35 PM, Ben Pfaff wrote: > On Fri, Jun 06, 2014 at 10:04:31AM -0700, Gurucharan Shetty wrote: >> The new command is of the form 'time/warp LARGE_MSECS MSECS'. >> It advances the current monotonic time by LARGE_MSECS. This is done MSECS >> at a time in each run of the main

Re: [ovs-dev] [PATCH v2 02/47] ofproto: Use ofp14_flow_monitor_flags internally

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:06PM +0900, Simon Horman wrote: > Use enum ofp14_flow_monitor_flags in place of enum nx_flow_monitor_flags in > struct ofputil_flow_monitor_request and struct rule, translating between > the two enumerations as necessary. > > The motivation for this patch is to move t

Re: [ovs-dev] [PATCH v2 01/47] ofproto: Add ofp14_flow_monitor_{request, command, flags}

2014-06-13 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 07:27:05PM +0900, Simon Horman wrote: > This is in preparation for supporting OpenFlow1.4 > flow monitor requests. > > Signed-off-by: Simon Horman Thanks, I'll apply this soon with a few typos fixed (one of them is in the OF1.4 spec): diff --git a/include/openflow/openfl

Re: [ovs-dev] [PATCH V2] ovs-thread: Implement OVS specific barrier.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 02:28:44PM -0700, Alex Wang wrote: > Non-leader revalidator thread uses pthread_barrier_* functions in their > main loop to synchronize with leader thread. However, since those threads > only call poll_block() intermittently, the poll interval check in > poll_block() can wr

Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote: > dd51dae29bccca3 ("ofproto: Move logic for collecting read-only rules into > rule_criteria.") modifies modify_flows__ such that the variable error, > the return value, may be uninitialised if either of the following is true: > > 1. ofp

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:55AM -0700, Jarno Rajahalme wrote: > Use cmap instead of hmap & hindex in classifier. Performance impact > with current locking strategy is not yet tested. Later patches will > introduce RCU into the classifer. into the "classifier". > Signed-off-by: Jarno Rajahalm

Re: [ovs-dev] [PATCH 7/8] lib/classifier: Clarify find_match_wc().

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:54AM -0700, Jarno Rajahalme wrote: > Reduce the number of goto statements by returning via a new helper > fill_range_wc() when no match is found. > > Signed-off-by: Jarno Rajahalme I slightly lean toward making fill_range_wc() a void function, but this is OK too. A

Re: [ovs-dev] [PATCH 6/8] lib/classifier: Add miniflow_and_mask_matches_flow_wc.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:53AM -0700, Jarno Rajahalme wrote: > miniflow_and_mask_matches_flow_wc() fills in the masks in flow > wildcards, so a separate step to that effect is no longer needed. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > When, during a classifier lookup, we narrow down to a single potential > rule, it is enough to match on ("unwildcard") one bit that differs > between the packet and the rule. > > This is a special case of the more general algorithm

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 10:21:36AM -0700, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > > When, during a classifier lookup, we narrow down to a single potential > > rule, it is enough to match on ("unwildcard") one bit that differs > > between the packet and

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > When, during a classifier lookup, we narrow down to a single potential > rule, it is enough to match on ("unwildcard") one bit that differs > between the packet and the rule. > > This is a special case of the more general algorithm

Re: [ovs-dev] [PATCH 4/8] lib/pvector: Non-intrusive RCU priority vector.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:51AM -0700, Jarno Rajahalme wrote: > Factor out the priority vector code from the classifier. > > Making the classifier use RCU instead of locking requires parallel > access to the priority vector, pointing to subtables in descending > priority order. When a new subt

Re: [ovs-dev] [PATCH v3 2/3] netdev: netdev_send accepts multiple packets

2014-06-13 Thread Ben Pfaff
OK, thanks! I didn't realize that I was reviewing an old version; I'm glad that I didn't look deeper, then. On Fri, Jun 13, 2014 at 09:14:50AM -0700, Daniele Di Proietto wrote: > I posted a v4 few days later, but since I need to apply this change > I?ll post a v5 as soon as possible. > > Daniele

Re: [ovs-dev] [PATCH v3 2/3] netdev: netdev_send accepts multiple packets

2014-06-13 Thread Daniele Di Proietto
Thanks for the suggestions Ben. I posted a v4 few days later, but since I need to apply this change I’ll post a v5 as soon as possible. Daniele On Jun 13, 2014, at 9:10 AM, Ben Pfaff wrote: > On Fri, Jun 06, 2014 at 05:13:14PM -0700, Daniele Di Proietto wrote: >> The netdev_send function has

Re: [ovs-dev] [PATCH v3 2/3] netdev: netdev_send accepts multiple packets

2014-06-13 Thread Ben Pfaff
On Fri, Jun 06, 2014 at 05:13:14PM -0700, Daniele Di Proietto wrote: > The netdev_send function has been modified to accept multiple packets, to > allow netdev providers to amortize locking and queuing costs. > This is especially true for netdev-dpdk. > > Later commits exploit the new API. > > Si

Re: [ovs-dev] [wait for connection v2 2/3] test: add WAIT_FOR_DUMMY_PORTS helper macro for writing tests

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 10:23:54PM -0700, Andy Zhou wrote: > Yes indeed. ovs_wait() internally sleeps. The first sleep is with > 0.1 seconds. So fractional seconds are portable after all. I don't know whether they are portable in practice, but ovs_wait works even if they are not portable. The c

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-13 Thread Ben Pfaff
On Fri, Jun 06, 2014 at 05:13:13PM -0700, Daniele Di Proietto wrote: > This commit introduces a new data structure used for receiving packets from > netdevs and passing them to dpifs. > The purpose of this change is to allow storing some private data for each > packet. The subsequent commits make u

Re: [ovs-dev] [PATCH] dpif-netdev: enumerate dpif belonging to the right class

2014-06-13 Thread Daniele Di Proietto
On Jun 12, 2014, at 4:54 PM, Ben Pfaff wrote: > On Thu, Jun 12, 2014 at 04:37:33PM -0700, Daniele Di Proietto wrote: >> Since dpif_netdev_enumerate() is used for "netdev" and "dummy" class, it >> incorrectly lists dpif-netdevs as "dummy" and vice versa. >> This patches address the issue by chang

[ovs-dev] [PATCH] odp-util: Make it harder to forget to update ODPUTIL_FLOW_KEY_BYTES.

2014-06-13 Thread Ben Pfaff
We've forgotten more than once. Most updates coincide with adding new flow members, so a build assertion on FLOW_WC_SEQ seems appropriate. Signed-off-by: Ben Pfaff --- lib/odp-util.h |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/odp-util.h b/lib/odp-util.h in

Re: [ovs-dev] [PATCH] odp-util: update comments on ODPUTIL_FLOW_KEY_BYTES estimation

2014-06-13 Thread Ben Pfaff
On Thu, Jun 12, 2014 at 10:41:30PM -0700, Andy Zhou wrote: > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2 1/7] util: Make WSAStartup available outside stream.c.

2014-06-13 Thread Gurucharan Shetty
WSAStartup() needs to be called before using winsock2 related functions. We need this for almost all the utilities. So call it through OVS_CONSTRUCTOR. Signed-off-by: Gurucharan Shetty --- lib/stream.c | 29 - lib/util.c | 11 +++ 2 files changed, 11 ins

[ovs-dev] [PATCH v2 6/7] lockfile: Modify tests for Windows.

2014-06-13 Thread Gurucharan Shetty
As of now, when a process tries to reacquire a lockfile, we return EEXIST on Windows and print a different error message. This means that the unit tests need to look for different error messages too. Linux uses EDEADLK for the same. EDEADLK feels like a good error description for Windows too and th

[ovs-dev] [PATCH v2 5/7] util: Don't compile couple of unused function for Windows.

2014-06-13 Thread Gurucharan Shetty
basename() and dir_name() are not used for Windows and won't work well if used. So put a '#ifndef _WIN32' around them to prevent future calls. test-file_name.c tests the above 2 functions. It makes sense to merge this single function file with test-util.c and then not compile it for Windows. Sig

[ovs-dev] [PATCH v2 7/7] atlocal: Disable Python related tests on Windows.

2014-06-13 Thread Gurucharan Shetty
Most of the Python code in Open vSwitch repo does not work on Windows. Till that porting is done, simply skip all Python tests. Signed-off-by: Gurucharan Shetty --- v1-v2: * Abandoned commits in v1 that selectively disabled Python tests and instead added this single commit. --- tests/atlocal

[ovs-dev] [PATCH v2 3/7] test-util: Changes for 'assert' test on Windows.

2014-06-13 Thread Gurucharan Shetty
There is no 'kill -l' type functionality available on Windows. So instead of looking for the string 'ABRT', check for the exit code in both platforms. On msys (unit test environment), it is 9 and on Linux, it is 134 (SIGABRT + 128). On Windows, stderr is fully buffered if connected to a pipe. Make

[ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-13 Thread Gurucharan Shetty
After the change, both of them compile. test-netflow related unit tests pass. test-sflow related tests do not pass because of LOOPBACK_INTERFACE constraints for 'agent'. (It should be revisited later.) Signed-off-by: Gurucharan Shetty --- v1-v2: Remove the call to winsock_start() as WSAStartup

[ovs-dev] [PATCH v2 4/7] daemon-windows: unlink pidfile before stopping the service.

2014-06-13 Thread Gurucharan Shetty
When a OVS daemon is configured to run as a Windows service, when the service is stopped by calling service_stop(), the windows services manager does not give enough time to do everything in the atexit handler. So call the exit handler directly from service_stop(). Also add a test case for Windows

Re: [ovs-dev] CPU usage increasing while adding port

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:44:58PM +0530, Rahul Arora wrote: > I am working on openvswitch version 2.1.2. But i am facing one issue in > this. > > When i am adding port in a bridge,Then my CPU usage is increasing to 100%. > > When i am commenting the following line in the file (* vim > openvswitc

[ovs-dev] CPU usage increasing while adding port

2014-06-13 Thread Rahul Arora
Hi All, I am working on openvswitch version 2.1.2. But i am facing one issue in this. When i am adding port in a bridge,Then my CPU usage is increasing to 100%. When i am commenting the following line in the file (* vim openvswitch-2.1.2/lib/seq.c*) *poll_immediate_wake(); //line number 17

[ovs-dev] openvswitch_2.1.0+git20140411-3_i386.changes ACCEPTED into unstable

2014-06-13 Thread Debian FTP Masters
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Fri, 13 Jun 2014 06:07:31 -0700 Source: openvswitch Binary: openvswitch-datapath-source openvswitch-datapath-dkms openvswitch-common openvswitch-switch openvswitch-ipsec openvswitch-pki openvswitch-dbg python-openvswi

[ovs-dev] Processing of openvswitch_2.1.0+git20140411-3_i386.changes

2014-06-13 Thread Debian FTP Masters
openvswitch_2.1.0+git20140411-3_i386.changes uploaded successfully to localhost along with the files: openvswitch-common_2.1.0+git20140411-3_i386.deb openvswitch-switch_2.1.0+git20140411-3_i386.deb openvswitch-ipsec_2.1.0+git20140411-3_i386.deb openvswitch-dbg_2.1.0+git20140411-3_i386.deb

[ovs-dev] Follow Up

2014-06-13 Thread June White
Hi, A quick follow up to know if you would be interested to acquire a list of MS HyperV-End Users & Partners. Let me know if you are focused on any particular application/technology users or titles so that I can get back to you with all the relevant details. Your questions and queries w

Re: [ovs-dev] [ovs-discuss] Blocking flow rules to be installed in an openvswitch via controller

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 12:00 AM, Arpit Kumar wrote: > Hi all, > I am working with ovs-switch where the ovs-switch say O1 has a controller > say C. Now O1 has some pre-installed rule inside it which I manually install > using ovs-ofctl. > I want the controller C to be connected to it but I want O1

[ovs-dev] Blocking flow rules to be installed in an openvswitch via controller

2014-06-13 Thread Arpit Kumar
Hi all, I am working with ovs-switch where the ovs-switch say O1 has a controller say C. Now O1 has some pre-installed rule inside it which I manually install using ovs-ofctl. I want the controller C to be connected to it but I want O1 to ignore all flow-rules that is tried to be install by my cont